Strategy11 / formidable-forms

classes/controllers/FrmFormActionsController.php

Spacing +17 added lines, -17 removed lines

@@ -113,19 +113,19 @@ 
 		}
 
 		foreach ( $action_controls as $action ) {
-			if ( isset( $groups[ $action->id_base ] ) || in_array( $action->id_base, $grouped ) ) {
+			if ( isset( $groups[$action->id_base] ) || in_array( $action->id_base, $grouped ) ) {
 				continue;
 			}
 
 			$this_group = $action->action_options['group'];
-			if ( ! isset( $groups[ $this_group ] ) ) {
+			if ( ! isset( $groups[$this_group] ) ) {
 				$this_group = 'misc';
 			}
 
-			if ( ! isset( $groups[ $this_group ]['actions'] ) ) {
-				$groups[ $this_group ]['actions'] = array();
+			if ( ! isset( $groups[$this_group]['actions'] ) ) {
+				$groups[$this_group]['actions'] = array();
 			}
-			$groups[ $this_group ]['actions'][] = $action->id_base;
+			$groups[$this_group]['actions'][] = $action->id_base;
 
 			unset( $action );
 		}
@@ -279,7 +279,7 @@ 
 				return $a;
 			}
 
-			$actions[ $a->id_base ] = $a;
+			$actions[$a->id_base] = $a;
 		}
 
 		return $actions;
@@ -313,18 +313,18 @@ 
 		$action_map = array();
 
 		foreach ( $action_controls as $key => $control ) {
-			$action_map[ $control->id_base ] = $key;
+			$action_map[$control->id_base] = $key;
 		}
 
 		self::maybe_show_limit_warning( $form->id, $form_actions );
 
 		foreach ( $form_actions as $action ) {
-			if ( ! isset( $action_map[ $action->post_excerpt ] ) ) {
+			if ( ! isset( $action_map[$action->post_excerpt] ) ) {
 				// don't try and show settings if action no longer exists
 				continue;
 			}
 
-			self::action_control( $action, $form, $action->ID, $action_controls[ $action_map[ $action->post_excerpt ] ], $values );
+			self::action_control( $action, $form, $action->ID, $action_controls[$action_map[$action->post_excerpt]], $values );
 		}
 	}
 
@@ -592,8 +592,8 @@ 
 			}
 
 			// Store actions so they can be triggered with the correct priority.
-			$stored_actions[ $action->ID ]  = $action;
-			$action_priority[ $action->ID ] = $link_settings[ $action->post_excerpt ]->action_options['priority'];
+			$stored_actions[$action->ID]  = $action;
+			$action_priority[$action->ID] = $link_settings[$action->post_excerpt]->action_options['priority'];
 
 			unset( $action );
 		}//end foreach
@@ -605,7 +605,7 @@ 
 			new FrmNotification();
 
 			foreach ( $action_priority as $action_id => $priority ) {
-				$action = $stored_actions[ $action_id ];
+				$action = $stored_actions[$action_id];
 
 				/**
 				 * Allows custom form action trigger.
@@ -669,12 +669,12 @@ 
 	}
 
 	public function register( $action_class ) {
-		$this->actions[ $action_class ] = new $action_class();
+		$this->actions[$action_class] = new $action_class();
 	}
 
 	public function unregister( $action_class ) {
-		if ( isset( $this->actions[ $action_class ] ) ) {
-			unset( $this->actions[ $action_class ] );
+		if ( isset( $this->actions[$action_class] ) ) {
+			unset( $this->actions[$action_class] );
 		}
 	}
 
@@ -683,8 +683,8 @@ 
 
 		foreach ( $keys as $key ) {
 			// don't register new action if old action with the same id is already registered
-			if ( ! isset( $this->actions[ $key ] ) ) {
-				$this->actions[ $key ]->_register();
+			if ( ! isset( $this->actions[$key] ) ) {
+				$this->actions[$key]->_register();
 			}
 		}
 	}

classes/models/fields/FrmFieldEmail.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 		}
 		$errors = array();
 		if ( false !== strpos( $args['value'], '.@' ) || ! is_email( $args['value'] ) ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
 		}
 		return $errors;
 	}

stripe/controllers/FrmTransLiteHooksController.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
 	public static function load_admin_hooks() {
 		add_action(
 			'admin_init',
-			function () {
+			function() {
 				self::fix_addon_hooks();
 			}
 		);

classes/helpers/FrmApiHelper.php

Spacing +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
 	 * @return bool
 	 */
 	private static function check_free_segments( $who ) {
-		$segments          = array(
+		$segments = array(
 			'free_first_1',
 			'free_first_2_3',
 			'free_first_4_7',

classes/models/fields/FrmFieldNumber.php

Spacing +5 added lines, -5 removed lines

@@ -62,7 +62,7 @@ 
 
 		// Validate the number format.
 		if ( ! is_numeric( $args['value'] ) && '' !== $args['value'] ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
 		}
 
 		if ( $args['value'] === '' ) {
@@ -74,9 +74,9 @@ 
 		$maxnum = FrmField::get_option( $this->field, 'maxnum' );
 
 		if ( $minnum !== '' && $value < $minnum ) {
-			$errors[ 'field' . $args['id'] ] = __( 'Please select a higher number', 'formidable' );
+			$errors['field' . $args['id']] = __( 'Please select a higher number', 'formidable' );
 		} elseif ( $maxnum !== '' && $value > $maxnum ) {
-			$errors[ 'field' . $args['id'] ] = __( 'Please select a lower number', 'formidable' );
+			$errors['field' . $args['id']] = __( 'Please select a lower number', 'formidable' );
 		}
 
 		$this->validate_step( $errors, $args );
@@ -95,7 +95,7 @@ 
 	 * @return void
 	 */
 	protected function validate_step( &$errors, $args ) {
-		if ( isset( $errors[ 'field' . $args['id'] ] ) ) {
+		if ( isset( $errors['field' . $args['id']] ) ) {
 			// Don't need to check if value is invalid before.
 			return;
 		}
@@ -110,7 +110,7 @@ 
 			return;
 		}
 
-		$errors[ 'field' . $args['id'] ] = sprintf(
+		$errors['field' . $args['id']] = sprintf(
 			// Translators: %1$s: the first nearest value; %2$s: the second nearest value.
 			__( 'Please enter a valid value. Two nearest valid values are %1$s and %2$s', 'formidable' ),
 			is_numeric( $result[0] ) ? floatval( $result[0] ) : $result[0],

classes/helpers/FrmFormsListHelper.php

Spacing +6 added lines, -6 removed lines

@@ -28,7 +28,7 @@ 
 		$page     = $this->get_pagenum();
 		$per_page = $this->get_items_per_page( 'formidable_page_formidable_per_page' );
 
-		$mode    = self::get_param(
+		$mode = self::get_param(
 			array(
 				'param'   => 'mode',
 				'default' => 'list',
@@ -40,7 +40,7 @@ 
 				'default' => 'name',
 			)
 		);
-		$order   = self::get_param(
+		$order = self::get_param(
 			array(
 				'param'   => 'order',
 				'default' => 'ASC',
@@ -49,7 +49,7 @@ 
 
 		FrmAppController::apply_saved_sort_preference( $orderby, $order );
 
-		$start   = self::get_param(
+		$start = self::get_param(
 			array(
 				'param'   => 'start',
 				'default' => ( $page - 1 ) * $per_page,
@@ -181,7 +181,7 @@ 
 		$counts    = FrmForm::get_count();
 		$form_type = FrmAppHelper::simple_get( 'form_type', 'sanitize_title', 'published' );
 
-		if ( isset( $statuses[ $form_type ] ) ) {
+		if ( isset( $statuses[$form_type] ) ) {
 			$counts->$form_type = $this->total_items;
 		}
 
@@ -202,7 +202,7 @@ 
 
 			if ( $counts->{$status} || 'draft' !== $status ) {
 				/* translators: %1$s: Status, %2$s: Number of items */
-				$links[ $status ] = '<a href="' . esc_url( '?page=formidable&form_type=' . $status ) . '" ' . $class . '>' . sprintf( __( '%1$s <span class="count">(%2$s)</span>', 'formidable' ), $name, number_format_i18n( $counts->{$status} ) ) . '</a>';
+				$links[$status] = '<a href="' . esc_url( '?page=formidable&form_type=' . $status ) . '" ' . $class . '>' . sprintf( __( '%1$s <span class="count">(%2$s)</span>', 'formidable' ), $name, number_format_i18n( $counts->{$status} ) ) . '</a>';
 			}
 
 			unset( $status, $name );
@@ -404,7 +404,7 @@ 
 	private function get_actions( &$actions, $item, $edit_link ) {
 		$new_actions = FrmFormsHelper::get_action_links( $item->id, $item );
 		foreach ( $new_actions as $link => $action ) {
-			$new_actions[ $link ] = FrmFormsHelper::format_link_html( $action, 'short' );
+			$new_actions[$link] = FrmFormsHelper::format_link_html( $action, 'short' );
 		}
 
 		if ( 'trash' === $this->status ) {

classes/controllers/FrmFormsController.php

Braces +4 added lines, -2 removed lines

@@ -1889,7 +1889,8 @@ 
 		$action = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action';
 		$vars   = array();
 		FrmAppHelper::include_svg();
-		if ( isset( $_POST['frm_compact_fields'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $_POST['frm_compact_fields'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			FrmAppHelper::permission_check( 'frm_edit_forms' );
 
 			// Javascript needs to be allowed in some field settings.
@@ -2314,7 +2315,8 @@ 
 	private static function get_saved_errors( $form, $params ) {
 		global $frm_vars;
 
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
 		} else {
 			$errors = array();

Spacing +32 added lines, -32 removed lines

@@ -739,7 +739,7 @@ 
 			 * @param string|null $src
 			 * @return string
 			 */
-			function ( $src ) {
+			function( $src ) {
 				if ( is_null( $src ) ) {
 					$src = '';
 				}
@@ -804,11 +804,11 @@ 
 			),
 		);
 
-		if ( ! isset( $available_status[ $status ] ) ) {
+		if ( ! isset( $available_status[$status] ) ) {
 			return;
 		}
 
-		FrmAppHelper::permission_check( $available_status[ $status ]['permission'] );
+		FrmAppHelper::permission_check( $available_status[$status]['permission'] );
 
 		$params = FrmForm::list_page_params();
 
@@ -816,8 +816,8 @@ 
 		check_admin_referer( $status . '_form_' . $params['id'] );
 
 		$count = 0;
-		if ( FrmForm::set_status( $params['id'], $available_status[ $status ]['new_status'] ) ) {
-			++$count;
+		if ( FrmForm::set_status( $params['id'], $available_status[$status]['new_status'] ) ) {
+			++ $count;
 		}
 
 		$form_type = FrmAppHelper::get_simple_request(
@@ -833,7 +833,7 @@ 
 		/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
 		$available_status['trash']['message'] = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' );
 
-		$message = $available_status[ $status ]['message'];
+		$message = $available_status[$status]['message'];
 
 		self::display_forms_list( $params, $message );
 	}
@@ -848,7 +848,7 @@ 
 		$count = 0;
 		foreach ( $ids as $id ) {
 			if ( FrmForm::trash( $id ) ) {
-				++$count;
+				++ $count;
 			}
 		}
 
@@ -862,7 +862,7 @@ 
 				'type'  => 'request',
 			)
 		);
-		$message      = sprintf(
+		$message = sprintf(
 			/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
 			_n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ),
 			$count,
@@ -883,7 +883,7 @@ 
 
 		$count = 0;
 		if ( FrmForm::destroy( $params['id'] ) ) {
-			++$count;
+			++ $count;
 		}
 
 		/* translators: %1$s: Number of forms */
@@ -903,7 +903,7 @@ 
 		foreach ( $ids as $id ) {
 			$d = FrmForm::destroy( $id );
 			if ( $d ) {
-				++$count;
+				++ $count;
 			}
 		}
 
@@ -1404,7 +1404,7 @@ 
 
 		add_action(
 			'wp_enqueue_editor',
-			function () {
+			function() {
 				wp_print_media_templates();
 			}
 		);
@@ -1535,7 +1535,7 @@ 
 				$section['id'] = $section['anchor'];
 			}
 
-			$sections[ $key ] = $section;
+			$sections[$key] = $section;
 		}//end foreach
 
 		return $sections;
@@ -1658,7 +1658,7 @@ 
 		if ( $user_fields ) {
 			$user_helpers = array();
 			foreach ( $user_fields as $uk => $uf ) {
-				$user_helpers[ '|user_id| show="' . $uk . '"' ] = $uf;
+				$user_helpers['|user_id| show="' . $uk . '"'] = $uf;
 				unset( $uk, $uf );
 			}
 
@@ -1792,7 +1792,7 @@ 
 		if ( ! isset( $frm_vars['js_validate_forms'] ) ) {
 			$frm_vars['js_validate_forms'] = array();
 		}
-		$frm_vars['js_validate_forms'][ $form->id ] = $form;
+		$frm_vars['js_validate_forms'][$form->id] = $form;
 	}
 
 	public static function get_email_html() {
@@ -1976,7 +1976,7 @@ 
 				add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
 			} else {
 				$vars   = FrmAppHelper::json_to_array( $json_vars );
-				$action = $vars[ $action ];
+				$action = $vars[$action];
 				unset( $_REQUEST['frm_compact_fields'], $_POST['frm_compact_fields'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$_REQUEST = array_merge( $_REQUEST, $vars ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$_POST    = array_merge( $_POST, $_REQUEST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -2159,7 +2159,7 @@ 
 		$actions = array();
 		foreach ( $frm_vars['forms_loaded'] as $form ) {
 			if ( is_object( $form ) ) {
-				$actions[ $form->id ] = $form->name;
+				$actions[$form->id] = $form->name;
 			}
 			unset( $form );
 		}
@@ -2404,8 +2404,8 @@ 
 	private static function get_saved_errors( $form, $params ) {
 		global $frm_vars;
 
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
-			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][$form->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			$errors = $frm_vars['created_entries'][$form->id]['errors'];
 		} else {
 			$errors = array();
 		}
@@ -2427,7 +2427,7 @@ 
 	public static function just_created_entry( $form_id ) {
 		global $frm_vars;
 
-		return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0;
+		return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][$form_id] ) && isset( $frm_vars['created_entries'][$form_id]['entry_id'] ) ? $frm_vars['created_entries'][$form_id]['entry_id'] : 0;
 	}
 
 	/**
@@ -2447,7 +2447,7 @@ 
 	private static function get_confirmation_method( $atts ) {
 		$action = FrmOnSubmitHelper::current_event( $atts );
 		$opt    = 'update' === $action ? 'edit_action' : 'success_action';
-		$method = ! empty( $atts['form']->options[ $opt ] ) ? $atts['form']->options[ $opt ] : 'message';
+		$method = ! empty( $atts['form']->options[$opt] ) ? $atts['form']->options[$opt] : 'message';
 
 		if ( ! empty( $atts['entry_id'] ) ) {
 			$met_actions = self::get_met_on_submit_actions( $atts, $action );
@@ -2468,7 +2468,7 @@ 
 	public static function maybe_trigger_redirect( $form, $params, $args ) {
 		if ( ! isset( $params['id'] ) ) {
 			global $frm_vars;
-			$params['id'] = $frm_vars['created_entries'][ $form->id ]['entry_id'];
+			$params['id'] = $frm_vars['created_entries'][$form->id]['entry_id'];
 		}
 
 		$conf_method = self::get_confirmation_method(
@@ -2550,7 +2550,7 @@ 
 		$args['success_opt'] = $opt;
 		$args['ajax']        = ! empty( $frm_vars['ajax'] );
 
-		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[ $opt . '_page_id' ] ) ) {
+		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[$opt . '_page_id'] ) ) {
 			self::load_page_after_submit( $args );
 		} elseif ( $args['conf_method'] === 'redirect' ) {
 			self::redirect_after_submit( $args );
@@ -2574,7 +2574,7 @@ 
 		}
 
 		// If a redirect action has already opened the URL in a new tab, we show the default message in the current tab.
-		if ( ! empty( self::$redirected_in_new_tab[ $args['form']->id ] ) ) {
+		if ( ! empty( self::$redirected_in_new_tab[$args['form']->id] ) ) {
 			return array( FrmOnSubmitHelper::get_fallback_action_after_open_in_new_tab( $event ) );
 		}
 
@@ -2762,7 +2762,7 @@ 
 
 		$opt = 'update' === $args['action'] ? 'edit_' : 'success_';
 
-		$new_args['conf_method'] = $new_args['form']->options[ $opt . 'action' ];
+		$new_args['conf_method'] = $new_args['form']->options[$opt . 'action'];
 
 		/**
 		 * Filters the run success action args.
@@ -2782,8 +2782,8 @@ 
 	private static function load_page_after_submit( $args ) {
 		global $post;
 		$opt = $args['success_opt'];
-		if ( ! $post || $args['form']->options[ $opt . '_page_id' ] != $post->ID ) {
-			$page     = get_post( $args['form']->options[ $opt . '_page_id' ] );
+		if ( ! $post || $args['form']->options[$opt . '_page_id'] != $post->ID ) {
+			$page     = get_post( $args['form']->options[$opt . '_page_id'] );
 			$old_post = $post;
 			$post     = $page;
 			$content  = apply_filters( 'frm_content', $page->post_content, $args['form'], $args['entry_id'] );
@@ -2813,7 +2813,7 @@ 
 		add_filter( 'frm_use_wpautop', '__return_false' );
 
 		$opt         = $args['success_opt'];
-		$success_url = trim( $args['form']->options[ $opt . '_url' ] );
+		$success_url = trim( $args['form']->options[$opt . '_url'] );
 		$success_url = apply_filters( 'frm_content', $success_url, $args['form'], $args['entry_id'] );
 		$success_url = do_shortcode( $success_url );
 
@@ -2835,7 +2835,7 @@ 
 			// Not AJAX submit, no headers sent, and there is just one Redirect action runs.
 			if ( ! empty( $args['form']->options['open_in_new_tab'] ) ) {
 				self::print_open_in_new_tab_js_with_fallback_handler( $success_url, $args );
-				self::$redirected_in_new_tab[ $args['form']->id ] = 1;
+				self::$redirected_in_new_tab[$args['form']->id] = 1;
 				return;
 			}
 
@@ -3115,7 +3115,7 @@ 
 			'description' => false,
 			'reset'       => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 	}
 
 	/**
@@ -3153,7 +3153,7 @@ 
 		$opt          = $args['success_opt'] ?? 'success';
 
 		if ( $entry_id && is_numeric( $entry_id ) ) {
-			$message = $form->options[ $opt . '_msg' ] ?? $frm_settings->success_msg;
+			$message = $form->options[$opt . '_msg'] ?? $frm_settings->success_msg;
 			$class   = 'frm_message';
 		} else {
 			$message = $frm_settings->failed_msg;
@@ -3378,8 +3378,8 @@ 
 
 		check_ajax_referer( 'frm_ajax', 'nonce' );
 
-		$html             = FrmAppHelper::clip(
-			function () {
+		$html = FrmAppHelper::clip(
+			function() {
 				FrmAppHelper::maybe_autocomplete_pages_options(
 					array(
 						'field_name'  => 'frm_page_dropdown',

classes/helpers/FrmFieldGdprHelper.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
 	 * @return array
 	 */
 	public static function add_gdpr_field( $fields ) {
-		$fields[ self::FIELD_TYPE ] = array(
+		$fields[self::FIELD_TYPE] = array(
 			'name' => __( 'GDPR', 'formidable' ),
 			'icon' => 'frm_icon_font frm-gdpr-icon',
 		);

classes/views/frm-forms/add_field_links.php

Spacing +3 added lines, -3 removed lines

@@ -76,10 +76,10 @@
 								foreach ( $pro_fields as $field_key => $field_type ) {
 
 									if ( isset( $field_type['section'] ) ) {
-										if ( ! isset( $field_sections[ $field_type['section'] ] ) ) {
-											$field_sections[ $field_type['section'] ] = array();
+										if ( ! isset( $field_sections[$field_type['section']] ) ) {
+											$field_sections[$field_type['section']] = array();
 										}
-										$field_sections[ $field_type['section'] ][ $field_key ] = $field_type;
+										$field_sections[$field_type['section']][$field_key] = $field_type;
 										continue;
 									}