@@ -71,12 +71,12 @@ discard block |
||
| 71 | 71 | $show_intervals = array( 50, 200, 500 ); |
| 72 | 72 | $asked = $this->review_status['asked']; |
| 73 | 73 | |
| 74 | - if ( ! isset( $show_intervals[ $asked ] ) ) { |
|
| 74 | + if ( ! isset( $show_intervals[$asked] ) ) { |
|
| 75 | 75 | return; |
| 76 | 76 | } |
| 77 | 77 | |
| 78 | 78 | $entries = FrmEntry::getRecordCount(); |
| 79 | - $count = $show_intervals[ $asked ]; |
|
| 79 | + $count = $show_intervals[$asked]; |
|
| 80 | 80 | $user = wp_get_current_user(); |
| 81 | 81 | |
| 82 | 82 | // Only show review request if the site has collected enough entries |
@@ -118,7 +118,7 @@ discard block |
||
| 118 | 118 | $requests = $message->get_messages(); |
| 119 | 119 | $key = $this->inbox_key . ( $asked ? $asked : '' ); |
| 120 | 120 | |
| 121 | - if ( isset( $requests[ $key ] ) ) { |
|
| 121 | + if ( isset( $requests[$key] ) ) { |
|
| 122 | 122 | return; |
| 123 | 123 | } |
| 124 | 124 | |
@@ -154,7 +154,7 @@ discard block |
||
| 154 | 154 | * @since 4.05.02 |
| 155 | 155 | */ |
| 156 | 156 | private function has_later_request( $requests, $asked ) { |
| 157 | - return isset( $requests[ $this->inbox_key . ( $asked + 1 ) ] ) || isset( $requests[ $this->inbox_key . ( $asked + 2 ) ] ); |
|
| 157 | + return isset( $requests[$this->inbox_key . ( $asked + 1 )] ) || isset( $requests[$this->inbox_key . ( $asked + 2 )] ); |
|
| 158 | 158 | } |
| 159 | 159 | |
| 160 | 160 | /** |
@@ -125,7 +125,8 @@ |
||
| 125 | 125 | } |
| 126 | 126 | |
| 127 | 127 | // Only do this for single site installs. |
| 128 | - if ( isset( $_GET['activate-multi'] ) || is_network_admin() ) { // WPCS: CSRF ok. |
|
| 128 | + if ( isset( $_GET['activate-multi'] ) || is_network_admin() ) { |
|
| 129 | +// WPCS: CSRF ok. |
|
| 129 | 130 | return; |
| 130 | 131 | } |
| 131 | 132 | |
@@ -546,6 +546,9 @@ |
||
| 546 | 546 | $this->show_import_options( $this->view_options(), 'view' ); |
| 547 | 547 | } |
| 548 | 548 | |
| 549 | + /** |
|
| 550 | + * @param string $importing |
|
| 551 | + */ |
|
| 549 | 552 | protected function show_import_options( $options, $importing, $xml = '' ) { |
| 550 | 553 | if ( empty( $options ) ) { |
| 551 | 554 | return; |
@@ -159,7 +159,7 @@ discard block |
||
| 159 | 159 | */ |
| 160 | 160 | public function add_settings( $sections ) { |
| 161 | 161 | wp_enqueue_style( 'formidable-pro-fields' ); |
| 162 | - $sections[ $this->plugin_slug ] = array( |
|
| 162 | + $sections[$this->plugin_slug] = array( |
|
| 163 | 163 | 'class' => $this, |
| 164 | 164 | 'function' => 'settings_page', |
| 165 | 165 | 'name' => $this->plugin_name(), |
@@ -316,9 +316,9 @@ discard block |
||
| 316 | 316 | // Set the current step. |
| 317 | 317 | if ( ! isset( $step['current'] ) ) { |
| 318 | 318 | if ( $step['complete'] ) { |
| 319 | - $steps[ $k ]['current'] = false; |
|
| 319 | + $steps[$k]['current'] = false; |
|
| 320 | 320 | } else { |
| 321 | - $steps[ $k ]['current'] = ! $has_current; |
|
| 321 | + $steps[$k]['current'] = ! $has_current; |
|
| 322 | 322 | $has_current = true; |
| 323 | 323 | } |
| 324 | 324 | } elseif ( $step['current'] ) { |
@@ -328,10 +328,10 @@ discard block |
||
| 328 | 328 | // Set disabled buttons. |
| 329 | 329 | $class = isset( $step['button_class'] ) ? $step['button_class'] : ''; |
| 330 | 330 | $class .= ' button-primary frm-button-primary'; |
| 331 | - if ( ! $steps[ $k ]['current'] ) { |
|
| 331 | + if ( ! $steps[$k]['current'] ) { |
|
| 332 | 332 | $class .= ' frm_grey disabled'; |
| 333 | 333 | } |
| 334 | - $steps[ $k ]['button_class'] = $class; |
|
| 334 | + $steps[$k]['button_class'] = $class; |
|
| 335 | 335 | } |
| 336 | 336 | |
| 337 | 337 | return $steps; |
@@ -353,7 +353,7 @@ discard block |
||
| 353 | 353 | if ( $plugin['status'] === 'active' ) { |
| 354 | 354 | continue; |
| 355 | 355 | } |
| 356 | - $links[ $plugin_key ] = $plugin; |
|
| 356 | + $links[$plugin_key] = $plugin; |
|
| 357 | 357 | if ( isset( $plugin['url'] ) ) { |
| 358 | 358 | $rel[] = $plugin['url']; |
| 359 | 359 | } else { |
@@ -468,7 +468,7 @@ discard block |
||
| 468 | 468 | $addons = $api->get_api_info(); |
| 469 | 469 | |
| 470 | 470 | $id = $this->download_id(); |
| 471 | - $has_file = isset( $addons[ $id ] ) && isset( $addons[ $id ]['beta'] ); |
|
| 471 | + $has_file = isset( $addons[$id] ) && isset( $addons[$id]['beta'] ); |
|
| 472 | 472 | |
| 473 | 473 | if ( ! $step['current'] ) { |
| 474 | 474 | ?> |
@@ -483,10 +483,10 @@ discard block |
||
| 483 | 483 | |
| 484 | 484 | if ( ! $has_file ) { |
| 485 | 485 | echo '<p class="frm_error_style">' . esc_html__( 'We didn\'t find anything to import. Please contact our team.', 'formidable' ) . '</p>'; |
| 486 | - } elseif ( ! isset( $addons[ $id ]['beta']['package'] ) ) { |
|
| 486 | + } elseif ( ! isset( $addons[$id]['beta']['package'] ) ) { |
|
| 487 | 487 | echo '<p class="frm_error_style">' . esc_html__( 'Looks like you may not have a current subscription for this solution. Please check your account.', 'formidable' ) . '</p>'; |
| 488 | 488 | } else { |
| 489 | - $xml = $addons[ $id ]['beta']['package']; |
|
| 489 | + $xml = $addons[$id]['beta']['package']; |
|
| 490 | 490 | if ( is_array( $xml ) ) { |
| 491 | 491 | $xml = reset( $xml ); |
| 492 | 492 | } |
@@ -624,7 +624,7 @@ discard block |
||
| 624 | 624 | foreach ( $forms as $form ) { |
| 625 | 625 | $was_imported = isset( $form['form'] ) ? FrmForm::get_id_by_key( $form['form'] ) : false; |
| 626 | 626 | if ( $was_imported ) { |
| 627 | - $imported[ $form['form'] ] = $was_imported; |
|
| 627 | + $imported[$form['form']] = $was_imported; |
|
| 628 | 628 | } |
| 629 | 629 | } |
| 630 | 630 | |
@@ -29,7 +29,7 @@ |
||
| 29 | 29 | </h3> |
| 30 | 30 | <span class="frm_inbox_date"> |
| 31 | 31 | <?php |
| 32 | - if ( ! isset( $message['read'] ) || ! isset( $message['read'][ $user->ID ] ) ) { |
|
| 32 | + if ( ! isset( $message['read'] ) || ! isset( $message['read'][$user->ID] ) ) { |
|
| 33 | 33 | $inbox->mark_read( $key ); |
| 34 | 34 | ?> |
| 35 | 35 | <span class="frm_inbox_unread"></span> |
@@ -132,6 +132,9 @@ discard block |
||
| 132 | 132 | } |
| 133 | 133 | } |
| 134 | 134 | |
| 135 | + /** |
|
| 136 | + * @param boolean $messages |
|
| 137 | + */ |
|
| 135 | 138 | private function filter_messages( &$messages ) { |
| 136 | 139 | $user_id = get_current_user_id(); |
| 137 | 140 | foreach ( $messages as $k => $message ) { |
@@ -256,6 +259,7 @@ discard block |
||
| 256 | 259 | |
| 257 | 260 | /** |
| 258 | 261 | * @since 4.05.02 |
| 262 | + * @param string $key |
|
| 259 | 263 | */ |
| 260 | 264 | public function remove( $key ) { |
| 261 | 265 | if ( isset( $this->messages[ $key ] ) ) { |
@@ -75,18 +75,18 @@ discard block |
||
| 75 | 75 | * @param array $message |
| 76 | 76 | */ |
| 77 | 77 | public function add_message( $message ) { |
| 78 | - if ( isset( $this->messages[ $message['key'] ] ) && ! isset( $message['force'] ) ) { |
|
| 78 | + if ( isset( $this->messages[$message['key']] ) && ! isset( $message['force'] ) ) { |
|
| 79 | 79 | // Don't replace messages unless required. |
| 80 | 80 | return; |
| 81 | 81 | } |
| 82 | 82 | |
| 83 | - if ( isset( $this->messages[ $message['key'] ] ) ) { |
|
| 83 | + if ( isset( $this->messages[$message['key']] ) ) { |
|
| 84 | 84 | // Move up and mark as new. |
| 85 | - unset( $this->messages[ $message['key'] ] ); |
|
| 85 | + unset( $this->messages[$message['key']] ); |
|
| 86 | 86 | } |
| 87 | 87 | |
| 88 | 88 | $this->fill_message( $message ); |
| 89 | - $this->messages[ $message['key'] ] = $message; |
|
| 89 | + $this->messages[$message['key']] = $message; |
|
| 90 | 90 | |
| 91 | 91 | $this->update_list(); |
| 92 | 92 | |
@@ -114,11 +114,11 @@ discard block |
||
| 114 | 114 | private function clean_messages() { |
| 115 | 115 | $removed = false; |
| 116 | 116 | foreach ( $this->messages as $t => $message ) { |
| 117 | - $read = isset( $message['read'] ) && ! empty( $message['read'] ) && isset( $message['read'][ get_current_user_id() ] ) && $message['read'][ get_current_user_id() ] < strtotime( '-1 month' ); |
|
| 118 | - $dismissed = isset( $message['dismissed'] ) && ! empty( $message['dismissed'] ) && isset( $message['dismissed'][ get_current_user_id() ] ) && $message['dismissed'][ get_current_user_id() ] < strtotime( '-1 week' ); |
|
| 117 | + $read = isset( $message['read'] ) && ! empty( $message['read'] ) && isset( $message['read'][get_current_user_id()] ) && $message['read'][get_current_user_id()] < strtotime( '-1 month' ); |
|
| 118 | + $dismissed = isset( $message['dismissed'] ) && ! empty( $message['dismissed'] ) && isset( $message['dismissed'][get_current_user_id()] ) && $message['dismissed'][get_current_user_id()] < strtotime( '-1 week' ); |
|
| 119 | 119 | $expired = $this->is_expired( $message ); |
| 120 | 120 | if ( $read || $expired || $dismissed ) { |
| 121 | - unset( $this->messages[ $t ] ); |
|
| 121 | + unset( $this->messages[$t] ); |
|
| 122 | 122 | $removed = true; |
| 123 | 123 | } |
| 124 | 124 | } |
@@ -131,11 +131,11 @@ discard block |
||
| 131 | 131 | private function filter_messages( &$messages ) { |
| 132 | 132 | $user_id = get_current_user_id(); |
| 133 | 133 | foreach ( $messages as $k => $message ) { |
| 134 | - $dismissed = isset( $message['dismissed'] ) && isset( $message['dismissed'][ $user_id ] ); |
|
| 134 | + $dismissed = isset( $message['dismissed'] ) && isset( $message['dismissed'][$user_id] ); |
|
| 135 | 135 | if ( $this->is_expired( $message ) || $dismissed ) { |
| 136 | - unset( $messages[ $k ] ); |
|
| 136 | + unset( $messages[$k] ); |
|
| 137 | 137 | } elseif ( ! $this->is_for_user( $message ) ) { |
| 138 | - unset( $messages[ $k ] ); |
|
| 138 | + unset( $messages[$k] ); |
|
| 139 | 139 | } |
| 140 | 140 | } |
| 141 | 141 | $messages = apply_filters( 'frm_filter_inbox', $messages ); |
@@ -168,14 +168,14 @@ discard block |
||
| 168 | 168 | * @param string $key |
| 169 | 169 | */ |
| 170 | 170 | public function mark_read( $key ) { |
| 171 | - if ( ! isset( $this->messages[ $key ] ) ) { |
|
| 171 | + if ( ! isset( $this->messages[$key] ) ) { |
|
| 172 | 172 | return; |
| 173 | 173 | } |
| 174 | 174 | |
| 175 | - if ( ! isset( $this->messages[ $key ]['read'] ) ) { |
|
| 176 | - $this->messages[ $key ]['read'] = array(); |
|
| 175 | + if ( ! isset( $this->messages[$key]['read'] ) ) { |
|
| 176 | + $this->messages[$key]['read'] = array(); |
|
| 177 | 177 | } |
| 178 | - $this->messages[ $key ]['read'][ get_current_user_id() ] = time(); |
|
| 178 | + $this->messages[$key]['read'][get_current_user_id()] = time(); |
|
| 179 | 179 | |
| 180 | 180 | $this->update_list(); |
| 181 | 181 | } |
@@ -186,9 +186,9 @@ discard block |
||
| 186 | 186 | * @since 4.05.02 |
| 187 | 187 | */ |
| 188 | 188 | public function mark_unread( $key ) { |
| 189 | - $is_read = isset( $this->messages[ $key ] ) && isset( $this->messages[ $key ]['read'] ) && isset( $this->messages[ $key ]['read'][ get_current_user_id() ] ); |
|
| 189 | + $is_read = isset( $this->messages[$key] ) && isset( $this->messages[$key]['read'] ) && isset( $this->messages[$key]['read'][get_current_user_id()] ); |
|
| 190 | 190 | if ( $is_read ) { |
| 191 | - unset( $this->messages[ $key ]['read'][ get_current_user_id() ] ); |
|
| 191 | + unset( $this->messages[$key]['read'][get_current_user_id()] ); |
|
| 192 | 192 | $this->update_list(); |
| 193 | 193 | } |
| 194 | 194 | } |
@@ -202,14 +202,14 @@ discard block |
||
| 202 | 202 | return; |
| 203 | 203 | } |
| 204 | 204 | |
| 205 | - if ( ! isset( $this->messages[ $key ] ) ) { |
|
| 205 | + if ( ! isset( $this->messages[$key] ) ) { |
|
| 206 | 206 | return; |
| 207 | 207 | } |
| 208 | 208 | |
| 209 | - if ( ! isset( $this->messages[ $key ]['dismissed'] ) ) { |
|
| 210 | - $this->messages[ $key ]['dismissed'] = array(); |
|
| 209 | + if ( ! isset( $this->messages[$key]['dismissed'] ) ) { |
|
| 210 | + $this->messages[$key]['dismissed'] = array(); |
|
| 211 | 211 | } |
| 212 | - $this->messages[ $key ]['dismissed'][ get_current_user_id() ] = time(); |
|
| 212 | + $this->messages[$key]['dismissed'][get_current_user_id()] = time(); |
|
| 213 | 213 | |
| 214 | 214 | $this->update_list(); |
| 215 | 215 | } |
@@ -221,11 +221,11 @@ discard block |
||
| 221 | 221 | $user_id = get_current_user_id(); |
| 222 | 222 | foreach ( $this->messages as $key => $message ) { |
| 223 | 223 | if ( ! isset( $message['dismissed'] ) ) { |
| 224 | - $this->messages[ $key ]['dismissed'] = array(); |
|
| 224 | + $this->messages[$key]['dismissed'] = array(); |
|
| 225 | 225 | } |
| 226 | 226 | |
| 227 | - if ( ! isset( $message['dismissed'][ $user_id ] ) ) { |
|
| 228 | - $this->messages[ $key ]['dismissed'][ $user_id ] = time(); |
|
| 227 | + if ( ! isset( $message['dismissed'][$user_id] ) ) { |
|
| 228 | + $this->messages[$key]['dismissed'][$user_id] = time(); |
|
| 229 | 229 | } |
| 230 | 230 | } |
| 231 | 231 | $this->update_list(); |
@@ -235,8 +235,8 @@ discard block |
||
| 235 | 235 | $messages = $this->get_messages( 'filter' ); |
| 236 | 236 | $user_id = get_current_user_id(); |
| 237 | 237 | foreach ( $messages as $t => $message ) { |
| 238 | - if ( isset( $message['read'] ) && isset( $message['read'][ $user_id ] ) ) { |
|
| 239 | - unset( $messages[ $t ] ); |
|
| 238 | + if ( isset( $message['read'] ) && isset( $message['read'][$user_id] ) ) { |
|
| 239 | + unset( $messages[$t] ); |
|
| 240 | 240 | } |
| 241 | 241 | } |
| 242 | 242 | return $messages; |
@@ -260,8 +260,8 @@ discard block |
||
| 260 | 260 | * @since 4.05.02 |
| 261 | 261 | */ |
| 262 | 262 | public function remove( $key ) { |
| 263 | - if ( isset( $this->messages[ $key ] ) ) { |
|
| 264 | - unset( $this->messages[ $key ] ); |
|
| 263 | + if ( isset( $this->messages[$key] ) ) { |
|
| 264 | + unset( $this->messages[$key] ); |
|
| 265 | 265 | $this->update_list(); |
| 266 | 266 | } |
| 267 | 267 | } |
@@ -140,7 +140,7 @@ discard block |
||
| 140 | 140 | |
| 141 | 141 | foreach ( $values as $value_key => $value ) { |
| 142 | 142 | if ( $value_key && in_array( $value_key, $form_fields ) ) { |
| 143 | - $new_values[ $value_key ] = $value; |
|
| 143 | + $new_values[$value_key] = $value; |
|
| 144 | 144 | } |
| 145 | 145 | } |
| 146 | 146 | |
@@ -210,15 +210,15 @@ discard block |
||
| 210 | 210 | $existing_keys = array_keys( $values['item_meta'] ); |
| 211 | 211 | foreach ( $all_fields as $fid ) { |
| 212 | 212 | if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) { |
| 213 | - $values['item_meta'][ $fid->id ] = ''; |
|
| 213 | + $values['item_meta'][$fid->id] = ''; |
|
| 214 | 214 | } |
| 215 | - $field_array[ $fid->id ] = $fid; |
|
| 215 | + $field_array[$fid->id] = $fid; |
|
| 216 | 216 | } |
| 217 | 217 | unset( $all_fields ); |
| 218 | 218 | |
| 219 | 219 | foreach ( $values['item_meta'] as $field_id => $default_value ) { |
| 220 | - if ( isset( $field_array[ $field_id ] ) ) { |
|
| 221 | - $field = $field_array[ $field_id ]; |
|
| 220 | + if ( isset( $field_array[$field_id] ) ) { |
|
| 221 | + $field = $field_array[$field_id]; |
|
| 222 | 222 | } else { |
| 223 | 223 | $field = FrmField::getOne( $field_id ); |
| 224 | 224 | } |
@@ -227,7 +227,7 @@ discard block |
||
| 227 | 227 | continue; |
| 228 | 228 | } |
| 229 | 229 | |
| 230 | - $is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) ); |
|
| 230 | + $is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options']['custom_html_' . $field_id] ) ); |
|
| 231 | 231 | if ( $is_settings_page ) { |
| 232 | 232 | self::get_settings_page_html( $values, $field ); |
| 233 | 233 | |
@@ -242,15 +242,15 @@ discard block |
||
| 242 | 242 | $update_options = apply_filters( 'frm_field_options_to_update', $update_options ); |
| 243 | 243 | |
| 244 | 244 | foreach ( $update_options as $opt => $default ) { |
| 245 | - $field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default; |
|
| 246 | - self::sanitize_field_opt( $opt, $field->field_options[ $opt ] ); |
|
| 245 | + $field->field_options[$opt] = isset( $values['field_options'][$opt . '_' . $field_id] ) ? $values['field_options'][$opt . '_' . $field_id] : $default; |
|
| 246 | + self::sanitize_field_opt( $opt, $field->field_options[$opt] ); |
|
| 247 | 247 | } |
| 248 | 248 | |
| 249 | 249 | $field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values ); |
| 250 | 250 | |
| 251 | 251 | $new_field = array( |
| 252 | 252 | 'field_options' => $field->field_options, |
| 253 | - 'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '', |
|
| 253 | + 'default_value' => isset( $values['default_value_' . $field_id] ) ? FrmAppHelper::maybe_json_encode( $values['default_value_' . $field_id] ) : '', |
|
| 254 | 254 | ); |
| 255 | 255 | |
| 256 | 256 | self::prepare_field_update_values( $field, $values, $new_field ); |
@@ -283,11 +283,11 @@ discard block |
||
| 283 | 283 | * Updating the settings page |
| 284 | 284 | */ |
| 285 | 285 | private static function get_settings_page_html( $values, &$field ) { |
| 286 | - if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) { |
|
| 286 | + if ( isset( $values['field_options']['custom_html_' . $field->id] ) ) { |
|
| 287 | 287 | $prev_opts = array(); |
| 288 | 288 | $fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type ); |
| 289 | 289 | |
| 290 | - $field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html; |
|
| 290 | + $field->field_options['custom_html'] = isset( $values['field_options']['custom_html_' . $field->id] ) ? $values['field_options']['custom_html_' . $field->id] : $fallback_html; |
|
| 291 | 291 | } elseif ( $field->type == 'hidden' || $field->type == 'user_id' ) { |
| 292 | 292 | $prev_opts = $field->field_options; |
| 293 | 293 | } |
@@ -313,7 +313,7 @@ discard block |
||
| 313 | 313 | foreach ( $field_cols as $col => $default ) { |
| 314 | 314 | $default = ( $default === '' ) ? $field->{$col} : $default; |
| 315 | 315 | |
| 316 | - $new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default; |
|
| 316 | + $new_field[$col] = isset( $values['field_options'][$col . '_' . $field->id] ) ? $values['field_options'][$col . '_' . $field->id] : $default; |
|
| 317 | 317 | } |
| 318 | 318 | |
| 319 | 319 | // Don't save the template option. |
@@ -727,8 +727,8 @@ discard block |
||
| 727 | 727 | self::maybe_get_form( $form ); |
| 728 | 728 | } |
| 729 | 729 | |
| 730 | - if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) { |
|
| 731 | - return $frm_vars['form_params'][ $form->id ]; |
|
| 730 | + if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][$form->id] ) ) { |
|
| 731 | + return $frm_vars['form_params'][$form->id]; |
|
| 732 | 732 | } |
| 733 | 733 | |
| 734 | 734 | $action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // WPCS: CSRF ok. |
@@ -757,15 +757,15 @@ discard block |
||
| 757 | 757 | //if there are two forms on the same page, make sure not to submit both |
| 758 | 758 | foreach ( $default_values as $var => $default ) { |
| 759 | 759 | if ( $var == 'action' ) { |
| 760 | - $values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' ); |
|
| 760 | + $values[$var] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' ); |
|
| 761 | 761 | } else { |
| 762 | - $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' ); |
|
| 762 | + $values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' ); |
|
| 763 | 763 | } |
| 764 | 764 | unset( $var, $default ); |
| 765 | 765 | } |
| 766 | 766 | } else { |
| 767 | 767 | foreach ( $default_values as $var => $default ) { |
| 768 | - $values[ $var ] = $default; |
|
| 768 | + $values[$var] = $default; |
|
| 769 | 769 | unset( $var, $default ); |
| 770 | 770 | } |
| 771 | 771 | } |
@@ -791,7 +791,7 @@ discard block |
||
| 791 | 791 | 'sdir' => '', |
| 792 | 792 | ); |
| 793 | 793 | foreach ( $defaults as $var => $default ) { |
| 794 | - $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' ); |
|
| 794 | + $values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' ); |
|
| 795 | 795 | } |
| 796 | 796 | |
| 797 | 797 | return $values; |
@@ -819,7 +819,7 @@ discard block |
||
| 819 | 819 | 'keep_post' => '', |
| 820 | 820 | ); |
| 821 | 821 | foreach ( $defaults as $var => $default ) { |
| 822 | - $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' ); |
|
| 822 | + $values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' ); |
|
| 823 | 823 | } |
| 824 | 824 | |
| 825 | 825 | return $values; |
@@ -905,7 +905,7 @@ discard block |
||
| 905 | 905 | $form = $atts['form']; |
| 906 | 906 | $default = isset( $atts['default'] ) ? $atts['default'] : ''; |
| 907 | 907 | |
| 908 | - return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default; |
|
| 908 | + return isset( $form->options[$atts['option']] ) ? $form->options[$atts['option']] : $default; |
|
| 909 | 909 | } |
| 910 | 910 | |
| 911 | 911 | /** |
@@ -78,7 +78,8 @@ |
||
| 78 | 78 | |
| 79 | 79 | if ( ! isset( $imported['form_status'] ) || empty( $imported['form_status'] ) ) { |
| 80 | 80 | // Check for an error message in the XML. |
| 81 | - if ( isset( $xml->Code ) && isset( $xml->Message ) ) { // phpcs:ignore WordPress.NamingConventions |
|
| 81 | + if ( isset( $xml->Code ) && isset( $xml->Message ) ) { |
|
| 82 | +// phpcs:ignore WordPress.NamingConventions |
|
| 82 | 83 | $imported['error'] = reset( $xml->Message ); // phpcs:ignore WordPress.NamingConventions |
| 83 | 84 | } |
| 84 | 85 | } |
@@ -562,6 +562,7 @@ discard block |
||
| 562 | 562 | * Also called during database migration in FrmMigrate. |
| 563 | 563 | * |
| 564 | 564 | * @since 4.0 |
| 565 | + * @param string $type |
|
| 565 | 566 | * @return array |
| 566 | 567 | */ |
| 567 | 568 | public static function migrate_field_placeholder( $field, $type ) { |
@@ -1217,6 +1218,7 @@ discard block |
||
| 1217 | 1218 | * The line endings may prevent html from being equal when it should |
| 1218 | 1219 | * |
| 1219 | 1220 | * @since 3.06 |
| 1221 | + * @param string $html_name |
|
| 1220 | 1222 | */ |
| 1221 | 1223 | private static function remove_default_html( $html_name, $defaults, &$options ) { |
| 1222 | 1224 | if ( ! isset( $options[ $html_name ] ) || ! isset( $defaults[ $html_name ] ) ) { |
@@ -1290,6 +1292,7 @@ discard block |
||
| 1290 | 1292 | * Migrate post settings to form action |
| 1291 | 1293 | * |
| 1292 | 1294 | * @param string $post_type |
| 1295 | + * @param boolean $switch |
|
| 1293 | 1296 | */ |
| 1294 | 1297 | private static function migrate_post_settings_to_action( $form_options, $form_id, $post_type, &$imported, $switch ) { |
| 1295 | 1298 | if ( ! isset( $form_options['create_post'] ) || ! $form_options['create_post'] ) { |
@@ -1368,8 +1371,8 @@ discard block |
||
| 1368 | 1371 | * @since 2.0 |
| 1369 | 1372 | * |
| 1370 | 1373 | * @param array $post_content - check for old field IDs |
| 1371 | - * @param array $basic_fields - fields with string or int saved |
|
| 1372 | - * @param array $array_fields - fields with arrays saved |
|
| 1374 | + * @param string[] $basic_fields - fields with string or int saved |
|
| 1375 | + * @param string[] $array_fields - fields with arrays saved |
|
| 1373 | 1376 | * |
| 1374 | 1377 | * @return string $post_content - new field IDs |
| 1375 | 1378 | */ |
@@ -1404,6 +1407,10 @@ discard block |
||
| 1404 | 1407 | return $post_content; |
| 1405 | 1408 | } |
| 1406 | 1409 | |
| 1410 | + /** |
|
| 1411 | + * @param string $post_type |
|
| 1412 | + * @param boolean $switch |
|
| 1413 | + */ |
|
| 1407 | 1414 | private static function migrate_email_settings_to_action( $form_options, $form_id, $post_type, &$imported, $switch ) { |
| 1408 | 1415 | // No old notifications or autoresponders to carry over |
| 1409 | 1416 | if ( ! isset( $form_options['auto_responder'] ) && ! isset( $form_options['notification'] ) && ! isset( $form_options['email_to'] ) ) { |
@@ -129,7 +129,7 @@ discard block |
||
| 129 | 129 | |
| 130 | 130 | if ( $term && is_array( $term ) ) { |
| 131 | 131 | $imported['imported']['terms'] ++; |
| 132 | - $imported['terms'][ (int) $t->term_id ] = $term['term_id']; |
|
| 132 | + $imported['terms'][(int) $t->term_id] = $term['term_id']; |
|
| 133 | 133 | } |
| 134 | 134 | |
| 135 | 135 | unset( $term, $t ); |
@@ -185,7 +185,7 @@ discard block |
||
| 185 | 185 | } |
| 186 | 186 | |
| 187 | 187 | // Keep track of whether this specific form was updated or not. |
| 188 | - $imported['form_status'][ $form_id ] = 'imported'; |
|
| 188 | + $imported['form_status'][$form_id] = 'imported'; |
|
| 189 | 189 | } |
| 190 | 190 | } |
| 191 | 191 | |
@@ -200,7 +200,7 @@ discard block |
||
| 200 | 200 | // Update field ids/keys to new ones. |
| 201 | 201 | do_action( 'frm_after_duplicate_form', $form_id, $form, array( 'old_id' => $old_id ) ); |
| 202 | 202 | |
| 203 | - $imported['forms'][ (int) $item->id ] = $form_id; |
|
| 203 | + $imported['forms'][(int) $item->id] = $form_id; |
|
| 204 | 204 | |
| 205 | 205 | // Send pre 2.0 form options through function that creates actions. |
| 206 | 206 | self::migrate_form_settings_to_actions( $form['options'], $form_id, $imported, true ); |
@@ -263,15 +263,15 @@ discard block |
||
| 263 | 263 | } |
| 264 | 264 | |
| 265 | 265 | // Keep track of whether this specific form was updated or not |
| 266 | - $imported['form_status'][ $form_id ] = 'updated'; |
|
| 266 | + $imported['form_status'][$form_id] = 'updated'; |
|
| 267 | 267 | } |
| 268 | 268 | |
| 269 | 269 | private static function get_form_fields( $form_id ) { |
| 270 | 270 | $form_fields = FrmField::get_all_for_form( $form_id, '', 'exclude', 'exclude' ); |
| 271 | 271 | $old_fields = array(); |
| 272 | 272 | foreach ( $form_fields as $f ) { |
| 273 | - $old_fields[ $f->id ] = $f; |
|
| 274 | - $old_fields[ $f->field_key ] = $f->id; |
|
| 273 | + $old_fields[$f->id] = $f; |
|
| 274 | + $old_fields[$f->field_key] = $f->id; |
|
| 275 | 275 | unset( $f ); |
| 276 | 276 | } |
| 277 | 277 | $form_fields = $old_fields; |
@@ -328,7 +328,7 @@ discard block |
||
| 328 | 328 | */ |
| 329 | 329 | private static function track_imported_child_forms( $form_id, $parent_form_id, &$child_forms ) { |
| 330 | 330 | if ( $parent_form_id ) { |
| 331 | - $child_forms[ $form_id ] = $parent_form_id; |
|
| 331 | + $child_forms[$form_id] = $parent_form_id; |
|
| 332 | 332 | } |
| 333 | 333 | } |
| 334 | 334 | |
@@ -343,9 +343,9 @@ discard block |
||
| 343 | 343 | */ |
| 344 | 344 | private static function maybe_update_child_form_parent_id( $imported_forms, $child_forms ) { |
| 345 | 345 | foreach ( $child_forms as $child_form_id => $old_parent_form_id ) { |
| 346 | - if ( isset( $imported_forms[ $old_parent_form_id ] ) && (int) $imported_forms[ $old_parent_form_id ] !== (int) $old_parent_form_id ) { |
|
| 346 | + if ( isset( $imported_forms[$old_parent_form_id] ) && (int) $imported_forms[$old_parent_form_id] !== (int) $old_parent_form_id ) { |
|
| 347 | 347 | // Update all children with this old parent_form_id |
| 348 | - $new_parent_form_id = (int) $imported_forms[ $old_parent_form_id ]; |
|
| 348 | + $new_parent_form_id = (int) $imported_forms[$old_parent_form_id]; |
|
| 349 | 349 | FrmForm::update( $child_form_id, array( 'parent_form_id' => $new_parent_form_id ) ); |
| 350 | 350 | do_action( 'frm_update_child_form_parent_id', $child_form_id, $new_parent_form_id ); |
| 351 | 351 | } |
@@ -375,27 +375,27 @@ discard block |
||
| 375 | 375 | |
| 376 | 376 | if ( ! empty( $this_form ) ) { |
| 377 | 377 | // check for field to edit by field id |
| 378 | - if ( isset( $form_fields[ $f['id'] ] ) ) { |
|
| 378 | + if ( isset( $form_fields[$f['id']] ) ) { |
|
| 379 | 379 | FrmField::update( $f['id'], $f ); |
| 380 | 380 | $imported['updated']['fields'] ++; |
| 381 | 381 | |
| 382 | - unset( $form_fields[ $f['id'] ] ); |
|
| 382 | + unset( $form_fields[$f['id']] ); |
|
| 383 | 383 | |
| 384 | 384 | //unset old field key |
| 385 | - if ( isset( $form_fields[ $f['field_key'] ] ) ) { |
|
| 386 | - unset( $form_fields[ $f['field_key'] ] ); |
|
| 385 | + if ( isset( $form_fields[$f['field_key']] ) ) { |
|
| 386 | + unset( $form_fields[$f['field_key']] ); |
|
| 387 | 387 | } |
| 388 | - } elseif ( isset( $form_fields[ $f['field_key'] ] ) ) { |
|
| 389 | - $keys_by_original_field_id[ $f['id'] ] = $f['field_key']; |
|
| 388 | + } elseif ( isset( $form_fields[$f['field_key']] ) ) { |
|
| 389 | + $keys_by_original_field_id[$f['id']] = $f['field_key']; |
|
| 390 | 390 | |
| 391 | 391 | // check for field to edit by field key |
| 392 | 392 | unset( $f['id'] ); |
| 393 | 393 | |
| 394 | - FrmField::update( $form_fields[ $f['field_key'] ], $f ); |
|
| 394 | + FrmField::update( $form_fields[$f['field_key']], $f ); |
|
| 395 | 395 | $imported['updated']['fields'] ++; |
| 396 | 396 | |
| 397 | - unset( $form_fields[ $form_fields[ $f['field_key'] ] ] ); //unset old field id |
|
| 398 | - unset( $form_fields[ $f['field_key'] ] ); //unset old field key |
|
| 397 | + unset( $form_fields[$form_fields[$f['field_key']]] ); //unset old field id |
|
| 398 | + unset( $form_fields[$f['field_key']] ); //unset old field key |
|
| 399 | 399 | } else { |
| 400 | 400 | // if no matching field id or key in this form, create the field |
| 401 | 401 | self::create_imported_field( $f, $imported ); |
@@ -504,8 +504,8 @@ discard block |
||
| 504 | 504 | if ( $f['type'] == 'form' || ( $f['type'] == 'divider' && FrmField::is_option_true( $f['field_options'], 'repeat' ) ) ) { |
| 505 | 505 | if ( FrmField::is_option_true( $f['field_options'], 'form_select' ) ) { |
| 506 | 506 | $form_select = (int) $f['field_options']['form_select']; |
| 507 | - if ( isset( $imported['forms'][ $form_select ] ) ) { |
|
| 508 | - $f['field_options']['form_select'] = $imported['forms'][ $form_select ]; |
|
| 507 | + if ( isset( $imported['forms'][$form_select] ) ) { |
|
| 508 | + $f['field_options']['form_select'] = $imported['forms'][$form_select]; |
|
| 509 | 509 | } |
| 510 | 510 | } |
| 511 | 511 | } |
@@ -526,8 +526,8 @@ discard block |
||
| 526 | 526 | |
| 527 | 527 | if ( FrmField::is_option_true_in_array( $f['field_options'], 'get_values_form' ) ) { |
| 528 | 528 | $old_form = $f['field_options']['get_values_form']; |
| 529 | - if ( isset( $imported['forms'][ $old_form ] ) ) { |
|
| 530 | - $f['field_options']['get_values_form'] = $imported['forms'][ $old_form ]; |
|
| 529 | + if ( isset( $imported['forms'][$old_form] ) ) { |
|
| 530 | + $f['field_options']['get_values_form'] = $imported['forms'][$old_form]; |
|
| 531 | 531 | } |
| 532 | 532 | } |
| 533 | 533 | } |
@@ -548,12 +548,12 @@ discard block |
||
| 548 | 548 | private static function migrate_placeholders( &$f ) { |
| 549 | 549 | $update_values = self::migrate_field_placeholder( $f, 'clear_on_focus' ); |
| 550 | 550 | foreach ( $update_values as $k => $v ) { |
| 551 | - $f[ $k ] = $v; |
|
| 551 | + $f[$k] = $v; |
|
| 552 | 552 | } |
| 553 | 553 | |
| 554 | 554 | $update_values = self::migrate_field_placeholder( $f, 'default_blank' ); |
| 555 | 555 | foreach ( $update_values as $k => $v ) { |
| 556 | - $f[ $k ] = $v; |
|
| 556 | + $f[$k] = $v; |
|
| 557 | 557 | } |
| 558 | 558 | } |
| 559 | 559 | |
@@ -567,7 +567,7 @@ discard block |
||
| 567 | 567 | public static function migrate_field_placeholder( $field, $type ) { |
| 568 | 568 | $field = (array) $field; |
| 569 | 569 | $field_options = $field['field_options']; |
| 570 | - if ( empty( $field_options[ $type ] ) || empty( $field['default_value'] ) ) { |
|
| 570 | + if ( empty( $field_options[$type] ) || empty( $field['default_value'] ) ) { |
|
| 571 | 571 | return array(); |
| 572 | 572 | } |
| 573 | 573 | |
@@ -593,7 +593,7 @@ discard block |
||
| 593 | 593 | } |
| 594 | 594 | |
| 595 | 595 | if ( $opt == $default_value ) { |
| 596 | - unset( $options[ $opt_key ] ); |
|
| 596 | + unset( $options[$opt_key] ); |
|
| 597 | 597 | break; |
| 598 | 598 | } |
| 599 | 599 | } |
@@ -788,17 +788,17 @@ discard block |
||
| 788 | 788 | self::update_postmeta( $post, $post_id ); |
| 789 | 789 | |
| 790 | 790 | $this_type = 'posts'; |
| 791 | - if ( isset( $post_types[ $post['post_type'] ] ) ) { |
|
| 792 | - $this_type = $post_types[ $post['post_type'] ]; |
|
| 791 | + if ( isset( $post_types[$post['post_type']] ) ) { |
|
| 792 | + $this_type = $post_types[$post['post_type']]; |
|
| 793 | 793 | } |
| 794 | 794 | |
| 795 | 795 | if ( isset( $post['ID'] ) && $post_id == $post['ID'] ) { |
| 796 | - $imported['updated'][ $this_type ] ++; |
|
| 796 | + $imported['updated'][$this_type] ++; |
|
| 797 | 797 | } else { |
| 798 | - $imported['imported'][ $this_type ] ++; |
|
| 798 | + $imported['imported'][$this_type] ++; |
|
| 799 | 799 | } |
| 800 | 800 | |
| 801 | - $imported['posts'][ (int) $old_id ] = $post_id; |
|
| 801 | + $imported['posts'][(int) $old_id] = $post_id; |
|
| 802 | 802 | |
| 803 | 803 | do_action( 'frm_after_import_view', $post_id, $post ); |
| 804 | 804 | |
@@ -815,9 +815,9 @@ discard block |
||
| 815 | 815 | $post['attachment_url'] = (string) $item->attachment_url; |
| 816 | 816 | } |
| 817 | 817 | |
| 818 | - if ( $post['post_type'] == FrmFormActionsController::$action_post_type && isset( $imported['forms'][ (int) $post['menu_order'] ] ) ) { |
|
| 818 | + if ( $post['post_type'] == FrmFormActionsController::$action_post_type && isset( $imported['forms'][(int) $post['menu_order']] ) ) { |
|
| 819 | 819 | // update to new form id |
| 820 | - $post['menu_order'] = $imported['forms'][ (int) $post['menu_order'] ]; |
|
| 820 | + $post['menu_order'] = $imported['forms'][(int) $post['menu_order']]; |
|
| 821 | 821 | } |
| 822 | 822 | |
| 823 | 823 | // Don't allow default styles to take over a site's default style |
@@ -844,8 +844,8 @@ discard block |
||
| 844 | 844 | ); |
| 845 | 845 | |
| 846 | 846 | //switch old form and field ids to new ones |
| 847 | - if ( $m['key'] == 'frm_form_id' && isset( $imported['forms'][ (int) $m['value'] ] ) ) { |
|
| 848 | - $m['value'] = $imported['forms'][ (int) $m['value'] ]; |
|
| 847 | + if ( $m['key'] == 'frm_form_id' && isset( $imported['forms'][(int) $m['value']] ) ) { |
|
| 848 | + $m['value'] = $imported['forms'][(int) $m['value']]; |
|
| 849 | 849 | } else { |
| 850 | 850 | $m['value'] = FrmAppHelper::maybe_json_decode( $m['value'] ); |
| 851 | 851 | |
@@ -856,15 +856,15 @@ discard block |
||
| 856 | 856 | } elseif ( $m['key'] == 'frm_options' ) { |
| 857 | 857 | |
| 858 | 858 | foreach ( array( 'date_field_id', 'edate_field_id' ) as $setting_name ) { |
| 859 | - if ( isset( $m['value'][ $setting_name ] ) && is_numeric( $m['value'][ $setting_name ] ) && isset( $frm_duplicate_ids[ $m['value'][ $setting_name ] ] ) ) { |
|
| 860 | - $m['value'][ $setting_name ] = $frm_duplicate_ids[ $m['value'][ $setting_name ] ]; |
|
| 859 | + if ( isset( $m['value'][$setting_name] ) && is_numeric( $m['value'][$setting_name] ) && isset( $frm_duplicate_ids[$m['value'][$setting_name]] ) ) { |
|
| 860 | + $m['value'][$setting_name] = $frm_duplicate_ids[$m['value'][$setting_name]]; |
|
| 861 | 861 | } |
| 862 | 862 | } |
| 863 | 863 | |
| 864 | 864 | $check_dup_array = array(); |
| 865 | 865 | if ( isset( $m['value']['order_by'] ) && ! empty( $m['value']['order_by'] ) ) { |
| 866 | - if ( is_numeric( $m['value']['order_by'] ) && isset( $frm_duplicate_ids[ $m['value']['order_by'] ] ) ) { |
|
| 867 | - $m['value']['order_by'] = $frm_duplicate_ids[ $m['value']['order_by'] ]; |
|
| 866 | + if ( is_numeric( $m['value']['order_by'] ) && isset( $frm_duplicate_ids[$m['value']['order_by']] ) ) { |
|
| 867 | + $m['value']['order_by'] = $frm_duplicate_ids[$m['value']['order_by']]; |
|
| 868 | 868 | } elseif ( is_array( $m['value']['order_by'] ) ) { |
| 869 | 869 | $check_dup_array[] = 'order_by'; |
| 870 | 870 | } |
@@ -875,9 +875,9 @@ discard block |
||
| 875 | 875 | } |
| 876 | 876 | |
| 877 | 877 | foreach ( $check_dup_array as $check_k ) { |
| 878 | - foreach ( (array) $m['value'][ $check_k ] as $mk => $mv ) { |
|
| 879 | - if ( isset( $frm_duplicate_ids[ $mv ] ) ) { |
|
| 880 | - $m['value'][ $check_k ][ $mk ] = $frm_duplicate_ids[ $mv ]; |
|
| 878 | + foreach ( (array) $m['value'][$check_k] as $mk => $mv ) { |
|
| 879 | + if ( isset( $frm_duplicate_ids[$mv] ) ) { |
|
| 880 | + $m['value'][$check_k][$mk] = $frm_duplicate_ids[$mv]; |
|
| 881 | 881 | } |
| 882 | 882 | unset( $mk, $mv ); |
| 883 | 883 | } |
@@ -890,7 +890,7 @@ discard block |
||
| 890 | 890 | $m['value'] = FrmAppHelper::maybe_json_decode( $m['value'] ); |
| 891 | 891 | } |
| 892 | 892 | |
| 893 | - $post['postmeta'][ (string) $meta->meta_key ] = $m['value']; |
|
| 893 | + $post['postmeta'][(string) $meta->meta_key] = $m['value']; |
|
| 894 | 894 | } |
| 895 | 895 | |
| 896 | 896 | /** |
@@ -918,11 +918,11 @@ discard block |
||
| 918 | 918 | $name = (string) $c; |
| 919 | 919 | } |
| 920 | 920 | |
| 921 | - if ( ! isset( $post['tax_input'][ $taxonomy ] ) ) { |
|
| 922 | - $post['tax_input'][ $taxonomy ] = array(); |
|
| 921 | + if ( ! isset( $post['tax_input'][$taxonomy] ) ) { |
|
| 922 | + $post['tax_input'][$taxonomy] = array(); |
|
| 923 | 923 | } |
| 924 | 924 | |
| 925 | - $post['tax_input'][ $taxonomy ][] = $name; |
|
| 925 | + $post['tax_input'][$taxonomy][] = $name; |
|
| 926 | 926 | unset( $name ); |
| 927 | 927 | } |
| 928 | 928 | } |
@@ -1021,7 +1021,7 @@ discard block |
||
| 1021 | 1021 | |
| 1022 | 1022 | $message = '<ul>'; |
| 1023 | 1023 | foreach ( $result as $type => $results ) { |
| 1024 | - if ( ! isset( $t_strings[ $type ] ) ) { |
|
| 1024 | + if ( ! isset( $t_strings[$type] ) ) { |
|
| 1025 | 1025 | // only print imported and updated |
| 1026 | 1026 | continue; |
| 1027 | 1027 | } |
@@ -1033,7 +1033,7 @@ discard block |
||
| 1033 | 1033 | } |
| 1034 | 1034 | |
| 1035 | 1035 | if ( ! empty( $s_message ) ) { |
| 1036 | - $message .= '<li><strong>' . $t_strings[ $type ] . ':</strong> '; |
|
| 1036 | + $message .= '<li><strong>' . $t_strings[$type] . ':</strong> '; |
|
| 1037 | 1037 | $message .= implode( ', ', $s_message ); |
| 1038 | 1038 | $message .= '</li>'; |
| 1039 | 1039 | } |
@@ -1073,7 +1073,7 @@ discard block |
||
| 1073 | 1073 | 'actions' => sprintf( _n( '%1$s Form Action', '%1$s Form Actions', $m, 'formidable' ), $m ), |
| 1074 | 1074 | ); |
| 1075 | 1075 | |
| 1076 | - $s_message[] = isset( $strings[ $type ] ) ? $strings[ $type ] : ' ' . $m . ' ' . ucfirst( $type ); |
|
| 1076 | + $s_message[] = isset( $strings[$type] ) ? $strings[$type] : ' ' . $m . ' ' . ucfirst( $type ); |
|
| 1077 | 1077 | } |
| 1078 | 1078 | |
| 1079 | 1079 | /** |
@@ -1205,10 +1205,10 @@ discard block |
||
| 1205 | 1205 | $array_defaults = array_filter( $defaults, 'is_array' ); |
| 1206 | 1206 | foreach ( $array_defaults as $d => $default ) { |
| 1207 | 1207 | // compare array defaults |
| 1208 | - if ( $default == $saved[ $d ] ) { |
|
| 1209 | - unset( $saved[ $d ] ); |
|
| 1208 | + if ( $default == $saved[$d] ) { |
|
| 1209 | + unset( $saved[$d] ); |
|
| 1210 | 1210 | } |
| 1211 | - unset( $defaults[ $d ] ); |
|
| 1211 | + unset( $defaults[$d] ); |
|
| 1212 | 1212 | } |
| 1213 | 1213 | $saved = array_diff_assoc( (array) $saved, $defaults ); |
| 1214 | 1214 | } |
@@ -1219,14 +1219,14 @@ discard block |
||
| 1219 | 1219 | * @since 3.06 |
| 1220 | 1220 | */ |
| 1221 | 1221 | private static function remove_default_html( $html_name, $defaults, &$options ) { |
| 1222 | - if ( ! isset( $options[ $html_name ] ) || ! isset( $defaults[ $html_name ] ) ) { |
|
| 1222 | + if ( ! isset( $options[$html_name] ) || ! isset( $defaults[$html_name] ) ) { |
|
| 1223 | 1223 | return; |
| 1224 | 1224 | } |
| 1225 | 1225 | |
| 1226 | - $old_html = str_replace( "\r\n", "\n", $options[ $html_name ] ); |
|
| 1227 | - $default_html = $defaults[ $html_name ]; |
|
| 1226 | + $old_html = str_replace( "\r\n", "\n", $options[$html_name] ); |
|
| 1227 | + $default_html = $defaults[$html_name]; |
|
| 1228 | 1228 | if ( $old_html == $default_html ) { |
| 1229 | - unset( $options[ $html_name ] ); |
|
| 1229 | + unset( $options[$html_name] ); |
|
| 1230 | 1230 | |
| 1231 | 1231 | return; |
| 1232 | 1232 | } |
@@ -1234,7 +1234,7 @@ discard block |
||
| 1234 | 1234 | // Account for some of the older field default HTML. |
| 1235 | 1235 | $default_html = str_replace( ' id="frm_desc_field_[key]"', '', $default_html ); |
| 1236 | 1236 | if ( $old_html == $default_html ) { |
| 1237 | - unset( $options[ $html_name ] ); |
|
| 1237 | + unset( $options[$html_name] ); |
|
| 1238 | 1238 | } |
| 1239 | 1239 | } |
| 1240 | 1240 | |
@@ -1320,8 +1320,8 @@ discard block |
||
| 1320 | 1320 | ); |
| 1321 | 1321 | |
| 1322 | 1322 | foreach ( $post_settings as $post_setting ) { |
| 1323 | - if ( isset( $form_options[ $post_setting ] ) ) { |
|
| 1324 | - $new_action['post_content'][ $post_setting ] = $form_options[ $post_setting ]; |
|
| 1323 | + if ( isset( $form_options[$post_setting] ) ) { |
|
| 1324 | + $new_action['post_content'][$post_setting] = $form_options[$post_setting]; |
|
| 1325 | 1325 | } |
| 1326 | 1326 | unset( $post_setting ); |
| 1327 | 1327 | } |
@@ -1391,11 +1391,11 @@ discard block |
||
| 1391 | 1391 | foreach ( $post_content as $key => $setting ) { |
| 1392 | 1392 | if ( ! is_array( $setting ) && in_array( $key, $basic_fields ) ) { |
| 1393 | 1393 | // Replace old IDs with new IDs |
| 1394 | - $post_content[ $key ] = str_replace( $old, $new, $setting ); |
|
| 1394 | + $post_content[$key] = str_replace( $old, $new, $setting ); |
|
| 1395 | 1395 | } elseif ( is_array( $setting ) && in_array( $key, $array_fields ) ) { |
| 1396 | 1396 | foreach ( $setting as $k => $val ) { |
| 1397 | 1397 | // Replace old IDs with new IDs |
| 1398 | - $post_content[ $key ][ $k ] = str_replace( $old, $new, $val ); |
|
| 1398 | + $post_content[$key][$k] = str_replace( $old, $new, $val ); |
|
| 1399 | 1399 | } |
| 1400 | 1400 | } |
| 1401 | 1401 | unset( $key, $setting ); |
@@ -1471,8 +1471,8 @@ discard block |
||
| 1471 | 1471 | private static function remove_deprecated_notification_settings( $form_id, $form_options ) { |
| 1472 | 1472 | $delete_settings = array( 'notification', 'autoresponder', 'email_to' ); |
| 1473 | 1473 | foreach ( $delete_settings as $index ) { |
| 1474 | - if ( isset( $form_options[ $index ] ) ) { |
|
| 1475 | - unset( $form_options[ $index ] ); |
|
| 1474 | + if ( isset( $form_options[$index] ) ) { |
|
| 1475 | + unset( $form_options[$index] ); |
|
| 1476 | 1476 | } |
| 1477 | 1477 | } |
| 1478 | 1478 | FrmForm::update( $form_id, array( 'options' => $form_options ) ); |
@@ -1525,12 +1525,12 @@ discard block |
||
| 1525 | 1525 | 'reply_to_name' => '', |
| 1526 | 1526 | ); |
| 1527 | 1527 | foreach ( $reply_fields as $f => $val ) { |
| 1528 | - if ( isset( $notification[ $f ] ) ) { |
|
| 1529 | - $atts[ $f ] = $notification[ $f ]; |
|
| 1530 | - if ( 'custom' == $notification[ $f ] ) { |
|
| 1531 | - $atts[ $f ] = $notification[ 'cust_' . $f ]; |
|
| 1532 | - } elseif ( is_numeric( $atts[ $f ] ) && ! empty( $atts[ $f ] ) ) { |
|
| 1533 | - $atts[ $f ] = '[' . $atts[ $f ] . ']'; |
|
| 1528 | + if ( isset( $notification[$f] ) ) { |
|
| 1529 | + $atts[$f] = $notification[$f]; |
|
| 1530 | + if ( 'custom' == $notification[$f] ) { |
|
| 1531 | + $atts[$f] = $notification['cust_' . $f]; |
|
| 1532 | + } elseif ( is_numeric( $atts[$f] ) && ! empty( $atts[$f] ) ) { |
|
| 1533 | + $atts[$f] = '[' . $atts[$f] . ']'; |
|
| 1534 | 1534 | } |
| 1535 | 1535 | } |
| 1536 | 1536 | unset( $f, $val ); |
@@ -1561,13 +1561,13 @@ discard block |
||
| 1561 | 1561 | foreach ( $atts['email_to'] as $key => $email_field ) { |
| 1562 | 1562 | |
| 1563 | 1563 | if ( is_numeric( $email_field ) ) { |
| 1564 | - $atts['email_to'][ $key ] = '[' . $email_field . ']'; |
|
| 1564 | + $atts['email_to'][$key] = '[' . $email_field . ']'; |
|
| 1565 | 1565 | } |
| 1566 | 1566 | |
| 1567 | 1567 | if ( strpos( $email_field, '|' ) ) { |
| 1568 | 1568 | $email_opt = explode( '|', $email_field ); |
| 1569 | 1569 | if ( isset( $email_opt[0] ) ) { |
| 1570 | - $atts['email_to'][ $key ] = '[' . $email_opt[0] . ' show=' . $email_opt[1] . ']'; |
|
| 1570 | + $atts['email_to'][$key] = '[' . $email_opt[0] . ' show=' . $email_opt[1] . ']'; |
|
| 1571 | 1571 | } |
| 1572 | 1572 | unset( $email_opt ); |
| 1573 | 1573 | } |
@@ -1588,12 +1588,12 @@ discard block |
||
| 1588 | 1588 | // Add more fields to the new notification |
| 1589 | 1589 | $add_fields = array( 'email_message', 'email_subject', 'plain_text', 'inc_user_info', 'conditions' ); |
| 1590 | 1590 | foreach ( $add_fields as $add_field ) { |
| 1591 | - if ( isset( $notification[ $add_field ] ) ) { |
|
| 1592 | - $new_notification['post_content'][ $add_field ] = $notification[ $add_field ]; |
|
| 1591 | + if ( isset( $notification[$add_field] ) ) { |
|
| 1592 | + $new_notification['post_content'][$add_field] = $notification[$add_field]; |
|
| 1593 | 1593 | } elseif ( in_array( $add_field, array( 'plain_text', 'inc_user_info' ) ) ) { |
| 1594 | - $new_notification['post_content'][ $add_field ] = 0; |
|
| 1594 | + $new_notification['post_content'][$add_field] = 0; |
|
| 1595 | 1595 | } else { |
| 1596 | - $new_notification['post_content'][ $add_field ] = ''; |
|
| 1596 | + $new_notification['post_content'][$add_field] = ''; |
|
| 1597 | 1597 | } |
| 1598 | 1598 | unset( $add_field ); |
| 1599 | 1599 | } |
@@ -1617,7 +1617,7 @@ discard block |
||
| 1617 | 1617 | if ( isset( $post_content['conditions'] ) && is_array( $post_content['conditions'] ) ) { |
| 1618 | 1618 | foreach ( $post_content['conditions'] as $email_key => $val ) { |
| 1619 | 1619 | if ( is_numeric( $email_key ) ) { |
| 1620 | - $post_content['conditions'][ $email_key ] = self::switch_action_field_ids( $val, array( 'hide_field' ) ); |
|
| 1620 | + $post_content['conditions'][$email_key] = self::switch_action_field_ids( $val, array( 'hide_field' ) ); |
|
| 1621 | 1621 | } |
| 1622 | 1622 | unset( $email_key, $val ); |
| 1623 | 1623 | } |
@@ -6,7 +6,7 @@ discard block |
||
| 6 | 6 | $info['url'] = $xml; |
| 7 | 7 | } |
| 8 | 8 | |
| 9 | - $disabled = isset( $imported[ $info['form'] ] ) ? ' disabled' : ''; |
|
| 9 | + $disabled = isset( $imported[$info['form']] ) ? ' disabled' : ''; |
|
| 10 | 10 | $url = isset( $info['url'] ) ? $info['url'] : ''; |
| 11 | 11 | $value = $importing === 'form' ? $info['form'] : $info['key']; |
| 12 | 12 | if ( ! isset( $info['img'] ) ) { |
@@ -16,7 +16,7 @@ discard block |
||
| 16 | 16 | continue; |
| 17 | 17 | } |
| 18 | 18 | |
| 19 | - $hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[ $info['form'] ] ) ); |
|
| 19 | + $hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[$info['form']] ) ); |
|
| 20 | 20 | ?> |
| 21 | 21 | <div class="frm_radio radio-inline radio frm_image_option<?php echo esc_attr( $importing === 'view' ? ' show_sub_opt show_' . $info['form'] : '' ); ?>" style="<?php echo esc_attr( $hide_views ? 'display:none' : '' ); ?>"> |
| 22 | 22 | <?php if ( $importing === 'form' ) { ?> |
@@ -36,7 +36,7 @@ discard block |
||
| 36 | 36 | <?php } ?> |
| 37 | 37 | /> |
| 38 | 38 | <div class="frm_image_option_container frm_label_with_image"> |
| 39 | - <?php echo FrmAppHelper::kses( $info['img'], array( 'svg', 'rect', 'path' ) ); // WPCS: XSS ok. ?> |
|
| 39 | + <?php echo FrmAppHelper::kses( $info['img'], array( 'svg', 'rect', 'path' ) ); // WPCS: XSS ok. ?> |
|
| 40 | 40 | <span class="frm_text_label_for_image"> |
| 41 | 41 | <?php |
| 42 | 42 | if ( ! empty( $disabled ) ) { |
@@ -49,7 +49,7 @@ discard block |
||
| 49 | 49 | } |
| 50 | 50 | |
| 51 | 51 | if ( $importing === 'form' && $disabled ) { |
| 52 | - echo FrmFormsHelper::edit_form_link( $imported[ $info['form'] ] ); // WPCS: XSS ok. |
|
| 52 | + echo FrmFormsHelper::edit_form_link( $imported[$info['form']] ); // WPCS: XSS ok. |
|
| 53 | 53 | } else { |
| 54 | 54 | echo esc_html( $info['name'] ); |
| 55 | 55 | } |
@@ -144,11 +144,11 @@ |
||
| 144 | 144 | if ( isset( $response['success'] ) && ! $response['success'] ) { |
| 145 | 145 | // What happens when the CAPTCHA was entered incorrectly |
| 146 | 146 | $invalid_message = FrmField::get_option( $this->field, 'invalid' ); |
| 147 | - $errors[ 'field' . $args['id'] ] = ( $invalid_message == '' ? $frm_settings->re_msg : $invalid_message ); |
|
| 147 | + $errors['field' . $args['id']] = ( $invalid_message == '' ? $frm_settings->re_msg : $invalid_message ); |
|
| 148 | 148 | } elseif ( is_wp_error( $resp ) ) { |
| 149 | 149 | $error_string = $resp->get_error_message(); |
| 150 | - $errors[ 'field' . $args['id'] ] = __( 'There was a problem verifying your recaptcha', 'formidable' ); |
|
| 151 | - $errors[ 'field' . $args['id'] ] .= ' ' . $error_string; |
|
| 150 | + $errors['field' . $args['id']] = __( 'There was a problem verifying your recaptcha', 'formidable' ); |
|
| 151 | + $errors['field' . $args['id']] .= ' ' . $error_string; |
|
| 152 | 152 | } |
| 153 | 153 | |
| 154 | 154 | return $errors; |
@@ -41,8 +41,8 @@ discard block |
||
| 41 | 41 | * @param array $atts |
| 42 | 42 | */ |
| 43 | 43 | private function _set( $param, $atts ) { |
| 44 | - if ( isset( $atts[ $param ] ) ) { |
|
| 45 | - $this->{$param} = $atts[ $param ]; |
|
| 44 | + if ( isset( $atts[$param] ) ) { |
|
| 45 | + $this->{$param} = $atts[$param]; |
|
| 46 | 46 | } |
| 47 | 47 | } |
| 48 | 48 | |
@@ -86,8 +86,8 @@ discard block |
||
| 86 | 86 | |
| 87 | 87 | $exclude = array( 'field_obj', 'html' ); |
| 88 | 88 | foreach ( $exclude as $ex ) { |
| 89 | - if ( isset( $atts[ $ex ] ) ) { |
|
| 90 | - unset( $this->pass_args[ $ex ] ); |
|
| 89 | + if ( isset( $atts[$ex] ) ) { |
|
| 90 | + unset( $this->pass_args[$ex] ); |
|
| 91 | 91 | } |
| 92 | 92 | } |
| 93 | 93 | } |
@@ -99,8 +99,8 @@ discard block |
||
| 99 | 99 | * @param array $set |
| 100 | 100 | */ |
| 101 | 101 | private function set_from_field( $atts, $set ) { |
| 102 | - if ( isset( $atts[ $set['param'] ] ) ) { |
|
| 103 | - $this->{$set['param']} = $atts[ $set['param'] ]; |
|
| 102 | + if ( isset( $atts[$set['param']] ) ) { |
|
| 103 | + $this->{$set['param']} = $atts[$set['param']]; |
|
| 104 | 104 | } else { |
| 105 | 105 | $this->{$set['param']} = $this->field_obj->get_field_column( $set['default'] ); |
| 106 | 106 | } |
@@ -225,7 +225,7 @@ discard block |
||
| 225 | 225 | */ |
| 226 | 226 | private function replace_error_shortcode() { |
| 227 | 227 | $this->maybe_add_error_id(); |
| 228 | - $error = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? $this->pass_args['errors'][ 'field' . $this->field_id ] : false; |
|
| 228 | + $error = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? $this->pass_args['errors']['field' . $this->field_id] : false; |
|
| 229 | 229 | FrmShortcodeHelper::remove_inline_conditions( ! empty( $error ), 'error', $error, $this->html ); |
| 230 | 230 | } |
| 231 | 231 | |
@@ -236,7 +236,7 @@ discard block |
||
| 236 | 236 | * @since 3.06.02 |
| 237 | 237 | */ |
| 238 | 238 | private function maybe_add_error_id() { |
| 239 | - if ( ! isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ) { |
|
| 239 | + if ( ! isset( $this->pass_args['errors']['field' . $this->field_id] ) ) { |
|
| 240 | 240 | return; |
| 241 | 241 | } |
| 242 | 242 | |
@@ -316,7 +316,7 @@ discard block |
||
| 316 | 316 | preg_match_all( "/\[(input|deletelink)\b(.*?)(?:(\/))?\]/s", $this->html, $shortcodes, PREG_PATTERN_ORDER ); |
| 317 | 317 | |
| 318 | 318 | foreach ( $shortcodes[0] as $short_key => $tag ) { |
| 319 | - $shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] ); |
|
| 319 | + $shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] ); |
|
| 320 | 320 | $tag = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key ); |
| 321 | 321 | |
| 322 | 322 | $replace_with = ''; |
@@ -327,7 +327,7 @@ discard block |
||
| 327 | 327 | $replace_with = $this->replace_input_shortcode( $shortcode_atts ); |
| 328 | 328 | } |
| 329 | 329 | |
| 330 | - $this->html = str_replace( $shortcodes[0][ $short_key ], $replace_with, $this->html ); |
|
| 330 | + $this->html = str_replace( $shortcodes[0][$short_key], $replace_with, $this->html ); |
|
| 331 | 331 | } |
| 332 | 332 | } |
| 333 | 333 | |
@@ -359,7 +359,7 @@ discard block |
||
| 359 | 359 | unset( $shortcode_atts['class'] ); |
| 360 | 360 | } |
| 361 | 361 | |
| 362 | - $shortcode_atts['aria-invalid'] = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? 'true' : 'false'; |
|
| 362 | + $shortcode_atts['aria-invalid'] = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? 'true' : 'false'; |
|
| 363 | 363 | |
| 364 | 364 | $this->field_obj->set_field_column( 'shortcodes', $shortcode_atts ); |
| 365 | 365 | |
@@ -414,7 +414,7 @@ discard block |
||
| 414 | 414 | */ |
| 415 | 415 | private function get_field_div_classes() { |
| 416 | 416 | // Add error class |
| 417 | - $classes = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? ' frm_blank_field' : ''; |
|
| 417 | + $classes = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? ' frm_blank_field' : ''; |
|
| 418 | 418 | |
| 419 | 419 | // Add label position class |
| 420 | 420 | $settings = $this->field_obj->display_field_settings(); |