Strategy11 / formidable-forms

classes/helpers/FrmTipsHelper.php

Spacing +3 added lines, -3 removed lines

@@ -296,7 +296,7 @@ 
 	}
 
 	public static function get_banner_tip() {
-		$tips       = array(
+		$tips = array(
 			array(
 				'link' => array(
 					'medium'  => 'banner',
@@ -323,7 +323,7 @@ 
 			),
 		);
 		$random     = rand( 0, count( $tips ) - 1 );
-		$tip        = $tips[ $random ];
+		$tip        = $tips[$random];
 		$tip['num'] = $random;
 
 		return $tip;
@@ -332,6 +332,6 @@ 
 	public static function get_random_tip( $tips ) {
 		$random = rand( 0, count( $tips ) - 1 );
 
-		return $tips[ $random ];
+		return $tips[$random];
 	}
 }

classes/helpers/FrmFormsListHelper.php

Spacing +5 added lines, -5 removed lines

@@ -18,7 +18,7 @@ 
 		$page     = $this->get_pagenum();
 		$per_page = $this->get_items_per_page( 'formidable_page_formidable_per_page' );
 
-		$mode    = self::get_param(
+		$mode = self::get_param(
 			array(
 				'param'   => 'mode',
 				'default' => 'list',
@@ -30,13 +30,13 @@ 
 				'default' => 'name',
 			)
 		);
-		$order   = self::get_param(
+		$order = self::get_param(
 			array(
 				'param'   => 'order',
 				'default' => 'ASC',
 			)
 		);
-		$start   = self::get_param(
+		$start = self::get_param(
 			array(
 				'param'   => 'start',
 				'default' => ( $page - 1 ) * $per_page,
@@ -177,7 +177,7 @@ 
 
 			if ( $counts->{$status} || 'draft' !== $status ) {
 				/* translators: %1$s: Status, %2$s: Number of items */
-				$links[ $status ] = '<a href="' . esc_url( '?page=formidable&form_type=' . $status ) . '" ' . $class . '>' . sprintf( __( '%1$s <span class="count">(%2$s)</span>', 'formidable' ), $name, number_format_i18n( $counts->{$status} ) ) . '</a>';
+				$links[$status] = '<a href="' . esc_url( '?page=formidable&form_type=' . $status ) . '" ' . $class . '>' . sprintf( __( '%1$s <span class="count">(%2$s)</span>', 'formidable' ), $name, number_format_i18n( $counts->{$status} ) ) . '</a>';
 			}
 
 			unset( $status, $name );
@@ -282,7 +282,7 @@ 
 	private function get_actions( &$actions, $item, $edit_link ) {
 		$new_actions = FrmFormsHelper::get_action_links( $item->id, $item );
 		foreach ( $new_actions as $link => $action ) {
-			$new_actions[ $link ] = FrmFormsHelper::format_link_html( $action, 'short' );
+			$new_actions[$link] = FrmFormsHelper::format_link_html( $action, 'short' );
 		}
 
 		if ( 'trash' == $this->status ) {

classes/helpers/FrmShortcodeHelper.php

Spacing +3 added lines, -3 removed lines

@@ -61,8 +61,8 @@ 
 		}
 
 		$with_tags = $args['conditional_check'] ? 3 : 2;
-		if ( ! empty( $shortcodes[ $with_tags ][ $short_key ] ) ) {
-			$tag  = str_replace( '[' . $prefix, '', $shortcodes[0][ $short_key ] );
+		if ( ! empty( $shortcodes[$with_tags][$short_key] ) ) {
+			$tag  = str_replace( '[' . $prefix, '', $shortcodes[0][$short_key] );
 			$tag  = str_replace( ']', '', $tag );
 			$tag  = str_replace( chr( 194 ) . chr( 160 ), ' ', $tag );
 			$tags = preg_split( '/\s+/', $tag, 2 );
@@ -70,7 +70,7 @@ 
 				$tag = $tags[0];
 			}
 		} else {
-			$tag = $shortcodes[ $with_tags - 1 ][ $short_key ];
+			$tag = $shortcodes[$with_tags - 1][$short_key];
 		}
 
 		return $tag;

classes/controllers/FrmSettingsController.php

Spacing +3 added lines, -3 removed lines

@@ -115,7 +115,7 @@ 
 				$section['function'] = $original;
 			}
 
-			$sections[ $key ] = $section;
+			$sections[$key] = $section;
 		}
 
 		return $sections;
@@ -127,11 +127,11 @@ 
 
 		$section  = FrmAppHelper::get_post_param( 'tab', '', 'sanitize_text_field' );
 		$sections = self::get_settings_tabs();
-		if ( ! isset( $sections[ $section ] ) ) {
+		if ( ! isset( $sections[$section] ) ) {
 			wp_die();
 		}
 
-		$section = $sections[ $section ];
+		$section = $sections[$section];
 
 		if ( isset( $section['class'] ) ) {
 			call_user_func( array( $section['class'], $section['function'] ) );

classes/controllers/FrmFormActionsController.php

Spacing +17 added lines, -17 removed lines

@@ -98,19 +98,19 @@ 
 		}
 
 		foreach ( $action_controls as $action ) {
-			if ( isset( $groups[ $action->id_base ] ) || in_array( $action->id_base, $grouped ) ) {
+			if ( isset( $groups[$action->id_base] ) || in_array( $action->id_base, $grouped ) ) {
 				continue;
 			}
 
 			$this_group = $action->action_options['group'];
-			if ( ! isset( $groups[ $this_group ] ) ) {
+			if ( ! isset( $groups[$this_group] ) ) {
 				$this_group = 'misc';
 			}
 
-			if ( ! isset( $groups[ $this_group ]['actions'] ) ) {
-				$groups[ $this_group ]['actions'] = array();
+			if ( ! isset( $groups[$this_group]['actions'] ) ) {
+				$groups[$this_group]['actions'] = array();
 			}
-			$groups[ $this_group ]['actions'][] = $action->id_base;
+			$groups[$this_group]['actions'][] = $action->id_base;
 
 			unset( $action );
 		}
@@ -241,7 +241,7 @@ 
 				return $a;
 			}
 
-			$actions[ $a->id_base ] = $a;
+			$actions[$a->id_base] = $a;
 		}
 
 		return $actions;
@@ -272,16 +272,16 @@ 
 		$action_map = array();
 
 		foreach ( $action_controls as $key => $control ) {
-			$action_map[ $control->id_base ] = $key;
+			$action_map[$control->id_base] = $key;
 		}
 
 		foreach ( $form_actions as $action ) {
-			if ( ! isset( $action_map[ $action->post_excerpt ] ) ) {
+			if ( ! isset( $action_map[$action->post_excerpt] ) ) {
 				// don't try and show settings if action no longer exists
 				continue;
 			}
 
-			self::action_control( $action, $form, $action->ID, $action_controls[ $action_map[ $action->post_excerpt ] ], $values );
+			self::action_control( $action, $form, $action->ID, $action_controls[$action_map[$action->post_excerpt]], $values );
 		}
 	}
 
@@ -489,8 +489,8 @@ 
 			}
 
 			// Store actions so they can be triggered with the correct priority.
-			$stored_actions[ $action->ID ]  = $action;
-			$action_priority[ $action->ID ] = $link_settings[ $action->post_excerpt ]->action_options['priority'];
+			$stored_actions[$action->ID]  = $action;
+			$action_priority[$action->ID] = $link_settings[$action->post_excerpt]->action_options['priority'];
 
 			unset( $action );
 		}
@@ -502,7 +502,7 @@ 
 			new FrmNotification();
 
 			foreach ( $action_priority as $action_id => $priority ) {
-				$action = $stored_actions[ $action_id ];
+				$action = $stored_actions[$action_id];
 				do_action( 'frm_trigger_' . $action->post_excerpt . '_action', $action, $entry, $form, $event );
 				do_action( 'frm_trigger_' . $action->post_excerpt . '_' . $event . '_action', $action, $entry, $form );
 
@@ -549,12 +549,12 @@ 
 	}
 
 	public function register( $action_class ) {
-		$this->actions[ $action_class ] = new $action_class();
+		$this->actions[$action_class] = new $action_class();
 	}
 
 	public function unregister( $action_class ) {
-		if ( isset( $this->actions[ $action_class ] ) ) {
-			unset( $this->actions[ $action_class ] );
+		if ( isset( $this->actions[$action_class] ) ) {
+			unset( $this->actions[$action_class] );
 		}
 	}
 
@@ -563,8 +563,8 @@ 
 
 		foreach ( $keys as $key ) {
 			// don't register new action if old action with the same id is already registered
-			if ( ! isset( $this->actions[ $key ] ) ) {
-				$this->actions[ $key ]->_register();
+			if ( ! isset( $this->actions[$key] ) ) {
+				$this->actions[$key]->_register();
 			}
 		}
 	}

classes/views/frm-forms/list-templates.php

Spacing +4 added lines, -4 removed lines

@@ -30,11 +30,11 @@ 
 			</li>
 			<?php
 			foreach ( array( 20872734, 20874748, 20882522, 20874739 ) as $template ) {
-				if ( ! isset( $templates[ $template ] ) ) {
+				if ( ! isset( $templates[$template] ) ) {
 					continue;
 				}
 
-				$template      = $templates[ $template ];
+				$template      = $templates[$template];
 				$plan_required = FrmFormsHelper::get_plan_required( $template );
 				$link          = FrmFormsHelper::get_template_install_link( $template, compact( 'pricing', 'license_type', 'plan_required' ) );
 				?>
@@ -138,7 +138,7 @@ 
 					</div>
 				</td>
 				</tr>
-				<?php unset( $template, $templates[ $k ] ); ?>
+				<?php unset( $template, $templates[$k] ); ?>
 			<?php } ?>
 		</tbody>
 </table>
@@ -238,7 +238,7 @@ 
 							</div>
 						</td>
 					</tr>
-					<?php unset( $template, $templates[ $k ] ); ?>
+					<?php unset( $template, $templates[$k] ); ?>
 				<?php } ?>
 				</tbody>
 			</table>

classes/models/FrmMigrate.php

Spacing +3 added lines, -3 removed lines

@@ -329,7 +329,7 @@ 
 
 		foreach ( (array) $fields as $f ) {
 			FrmAppHelper::unserialize_or_decode( $f->field_options );
-			$size             = $f->field_options['size'];
+			$size = $f->field_options['size'];
 			$this->maybe_convert_migrated_size( $size );
 
 			if ( $size === $f->field_options['size'] ) {
@@ -392,7 +392,7 @@ 
 				continue;
 			}
 
-			$this->maybe_convert_migrated_size( $widgets[ $k ]['size'] );
+			$this->maybe_convert_migrated_size( $widgets[$k]['size'] );
 		}
 		update_option( 'widget_frm_show_form', $widgets );
 	}
@@ -491,7 +491,7 @@ 
 			if ( ! is_array( $widget ) || ! isset( $widget['size'] ) ) {
 				continue;
 			}
-			$this->convert_character_to_px( $widgets[ $k ]['size'] );
+			$this->convert_character_to_px( $widgets[$k]['size'] );
 		}
 		update_option( 'widget_frm_show_form', $widgets );
 	}

classes/helpers/FrmEntriesHelper.php

Doc Comments +3 added lines

@@ -136,6 +136,9 @@
 		return apply_filters( 'frm_setup_edit_entry_vars', $values, $record );
 	}
 
+	/**
+	 * @param string $message
+	 */
 	public static function replace_default_message( $message, $atts ) {
 		if ( strpos( $message, '[default-message' ) === false &&
 			strpos( $message, '[default_message' ) === false &&

Spacing +29 added lines, -29 removed lines

@@ -117,10 +117,10 @@ 
 		if ( $_POST ) {
 			$repeating = isset( $args['repeating'] ) && $args['repeating'];
 			if ( $repeating ) {
-				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) {
+				if ( isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field->id] ) ) {
 					$value_is_posted = true;
 				}
-			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) {
+			} elseif ( isset( $_POST['item_meta'][$field->id] ) ) {
 				$value_is_posted = true;
 			}
 		}
@@ -150,7 +150,7 @@ 
 		preg_match_all( "/\[(default-message|default_message)\b(.*?)(?:(\/))?\]/s", $message, $shortcodes, PREG_PATTERN_ORDER );
 
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
-			$add_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
+			$add_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
 			if ( ! empty( $add_atts ) ) {
 				$this_atts = array_merge( $atts, $add_atts );
 			} else {
@@ -160,14 +160,14 @@ 
 			$default = FrmEntriesController::show_entry_shortcode( $this_atts );
 
 			// Add the default message.
-			$message = str_replace( $shortcodes[0][ $short_key ], $default, $message );
+			$message = str_replace( $shortcodes[0][$short_key], $default, $message );
 		}
 
 		return $message;
 	}
 
 	public static function prepare_display_value( $entry, $field, $atts ) {
-		$field_value = isset( $entry->metas[ $field->id ] ) ? $entry->metas[ $field->id ] : false;
+		$field_value = isset( $entry->metas[$field->id] ) ? $entry->metas[$field->id] : false;
 
 		if ( FrmAppHelper::pro_is_installed() ) {
 			$empty = empty( $field_value );
@@ -190,7 +190,7 @@ 
 			$child_entries = FrmEntry::getAll( array( 'it.parent_item_id' => $entry->id ) );
 		} else {
 			// Get all values for this field.
-			$child_values = isset( $entry->metas[ $atts['embedded_field_id'] ] ) ? $entry->metas[ $atts['embedded_field_id'] ] : false;
+			$child_values = isset( $entry->metas[$atts['embedded_field_id']] ) ? $entry->metas[$atts['embedded_field_id']] : false;
 
 			if ( $child_values ) {
 				$child_entries = FrmEntry::getAll( array( 'it.id' => (array) $child_values ) );
@@ -308,7 +308,7 @@ 
 			$value = $args['temp_value'];
 		}
 		if ( empty( $args['parent_field_id'] ) ) {
-			$_POST['item_meta'][ $field->id ] = $value;
+			$_POST['item_meta'][$field->id] = $value;
 		} else {
 			self::set_parent_field_posted_value( $field, $value, $args );
 		}
@@ -320,20 +320,20 @@ 
 	 * @since 4.01
 	 */
 	private static function set_parent_field_posted_value( $field, $value, $args ) {
-		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) &&
-			 is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) {
+		if ( isset( $_POST['item_meta'][$args['parent_field_id']] ) &&
+			 is_array( $_POST['item_meta'][$args['parent_field_id']] ) ) {
 
-			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ||
-				 ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) {
-				$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array();
+			if ( ! isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] ) ||
+				 ! is_array( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] ) ) {
+				$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] = array();
 			}
 		} else {
 			// All of the section was probably removed.
-			$_POST['item_meta'][ $args['parent_field_id'] ] = array();
-			$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array();
+			$_POST['item_meta'][$args['parent_field_id']] = array();
+			$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] = array();
 		}
 
-		$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] = $value;
+		$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field->id] = $value;
 	}
 
 	public static function get_posted_value( $field, &$value, $args ) {
@@ -364,10 +364,10 @@ 
 		if ( empty( $args['parent_field_id'] ) ) {
 			// Sanitizing is done next.
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-			$value = isset( $_POST['item_meta'][ $field_id ] ) ? wp_unslash( $_POST['item_meta'][ $field_id ] ) : '';
+			$value = isset( $_POST['item_meta'][$field_id] ) ? wp_unslash( $_POST['item_meta'][$field_id] ) : '';
 		} else {
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-			$value = isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field_id ] ) ? wp_unslash( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field_id ] ) : '';
+			$value = isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field_id] ) ? wp_unslash( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field_id] ) : '';
 		}
 		return $value;
 	}
@@ -398,7 +398,7 @@ 
 		self::set_other_repeating_vals( $field, $value, $args );
 
 		// Check if there are any posted "Other" values.
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) {
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][$field->id] ) ) {
 
 			// Save original value.
 			$args['temp_value'] = $value;
@@ -406,7 +406,7 @@ 
 
 			// Sanitizing is done next.
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-			$other_vals = wp_unslash( $_POST['item_meta']['other'][ $field->id ] );
+			$other_vals = wp_unslash( $_POST['item_meta']['other'][$field->id] );
 			FrmAppHelper::sanitize_value( 'sanitize_text_field', $other_vals );
 
 			// Set the validation value now
@@ -429,13 +429,13 @@ 
 		}
 
 		// Check if there are any other posted "other" values for this field.
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) {
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']]['other'][$field->id] ) ) {
 			// Save original value
 			$args['temp_value'] = $value;
 			$args['other']      = true;
 
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-			$other_vals = wp_unslash( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] );
+			$other_vals = wp_unslash( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']]['other'][$field->id] );
 			FrmAppHelper::sanitize_value( 'sanitize_text_field', $other_vals );
 
 			// Set the validation value now.
@@ -462,7 +462,7 @@ 
 		if ( is_array( $value ) && $field->type === 'checkbox' ) {
 			// Combine "Other" values with checked values. "Other" values will override checked box values.
 			foreach ( $other_vals as $k => $v ) {
-				if ( isset( $value[ $k ] ) && trim( $v ) === '' ) {
+				if ( isset( $value[$k] ) && trim( $v ) === '' ) {
 					// If the other box is checked, but doesn't have a value.
 					$value = '';
 					break;
@@ -479,25 +479,25 @@ 
 
 			// Multi-select dropdown.
 			if ( is_array( $value ) ) {
-				$o_key = array_search( $field->options[ $other_key ], $value );
+				$o_key = array_search( $field->options[$other_key], $value );
 
 				if ( $o_key !== false ) {
 					// Modify the original value so other key will be preserved.
-					$value[ $other_key ] = $value[ $o_key ];
+					$value[$other_key] = $value[$o_key];
 
 					// By default, the array keys will be numeric for multi-select dropdowns.
 					// If going backwards and forwards between pages, the array key will match the other key.
 					if ( $o_key !== $other_key ) {
-						unset( $value[ $o_key ] );
+						unset( $value[$o_key] );
 					}
 
 					$args['temp_value']  = $value;
-					$value[ $other_key ] = reset( $other_vals );
-					if ( FrmAppHelper::is_empty_value( $value[ $other_key ] ) ) {
-						unset( $value[ $other_key ] );
+					$value[$other_key] = reset( $other_vals );
+					if ( FrmAppHelper::is_empty_value( $value[$other_key] ) ) {
+						unset( $value[$other_key] );
 					}
 				}
-			} elseif ( $field->options[ $other_key ] == $value ) {
+			} elseif ( $field->options[$other_key] == $value ) {
 				$value = $other_vals;
 			}
 		}

classes/models/FrmEmail.php

Spacing +6 added lines, -6 removed lines

@@ -85,7 +85,7 @@ 
 		$to = $this->prepare_email_setting( $this->settings['email_to'], $user_id_args );
 		$to = $this->explode_emails( $to );
 
-		$where  = array(
+		$where = array(
 			'it.field_id !' => 0,
 			'it.item_id'    => $this->entry->id,
 		);
@@ -95,7 +95,7 @@ 
 			'entry'     => $this->entry,
 			'form'      => $this->form,
 		);
-		$to     = apply_filters( 'frm_to_email', $to, $values, $this->form->id, $args );
+		$to = apply_filters( 'frm_to_email', $to, $values, $this->form->id, $args );
 
 		$this->to = array_unique( (array) $to );
 
@@ -298,7 +298,7 @@ 
 
 		// Add the user info if it isn't already included
 		if ( $this->include_user_info && $prev_mail_body === $mail_body ) {
-			$data      = $this->entry->description;
+			$data = $this->entry->description;
 			$mail_body .= "\r\n\r\n" . __( 'User Information', 'formidable' ) . "\r\n";
 			$this->maybe_add_ip( $mail_body );
 			$mail_body .= __( 'User-Agent (Browser/OS)', 'formidable' ) . ': ' . FrmEntriesHelper::get_browser( $data['browser'] ) . "\r\n";
@@ -563,12 +563,12 @@ 
 					$name = trim( str_replace( $email, '', $val ) );
 				} else {
 					// If user enters a name without an email
-					unset( $recipients[ $key ] );
+					unset( $recipients[$key] );
 					continue;
 				}
 			}
 
-			$recipients[ $key ] = $this->format_from_email( $name, $email );
+			$recipients[$key] = $this->format_from_email( $name, $email );
 		}
 
 		return $recipients;
@@ -709,7 +709,7 @@ 
 				);
 
 				// Remove phone number from to addresses
-				unset( $this->to[ $key ] );
+				unset( $this->to[$key] );
 			}
 		}
 	}