Strategy11 / formidable-forms

classes/models/fields/FrmFieldUrl.php

Spacing +3 added lines, -3 removed lines

@@ -39,7 +39,7 @@ 
 			'sep'  => ', ',
 			'html' => false,
 		);
-		$atts     = wp_parse_args( $atts, $defaults );
+		$atts = wp_parse_args( $atts, $defaults );
 
 		if ( $atts['html'] ) {
 			$atts['sep'] = ' ';
@@ -61,9 +61,9 @@ 
 
 		// validate the url format
 		if ( ! empty( $value ) && ! preg_match( '/^http(s)?:\/\/(?:localhost|(?:[\da-z\.-]+\.[\da-z\.-]+))/i', $value ) ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
 		} elseif ( $this->field->required == '1' && empty( $value ) ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'blank' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'blank' );
 		}
 
 		return $errors;

classes/models/FrmSettings.php

Braces +4 added lines, -2 removed lines

@@ -56,7 +56,8 @@ 
 	}
 
 	private function translate_settings( $settings ) {
-		if ( $settings ) { //workaround for W3 total cache conflict
+		if ( $settings ) {
+//workaround for W3 total cache conflict
 			return unserialize( serialize( $settings ) );
 		}
 
@@ -68,7 +69,8 @@ 
 		}
 
 		// If unserializing didn't work
-		if ( $settings ) { //workaround for W3 total cache conflict
+		if ( $settings ) {
+//workaround for W3 total cache conflict
 			$settings = unserialize( serialize( $settings ) );
 		} else {
 			$settings = $this;

Spacing +4 added lines, -4 removed lines

@@ -145,8 +145,8 @@ 
 		$settings = $this->default_options();
 
 		foreach ( $settings as $setting => $default ) {
-			if ( isset( $params[ 'frm_' . $setting ] ) ) {
-				$this->{$setting} = $params[ 'frm_' . $setting ];
+			if ( isset( $params['frm_' . $setting] ) ) {
+				$this->{$setting} = $params['frm_' . $setting];
 			} elseif ( ! isset( $this->{$setting} ) ) {
 				$this->{$setting} = $default;
 			}
@@ -251,7 +251,7 @@ 
 
 		$checkboxes = array( 'mu_menu', 're_multi', 'use_html', 'jquery_css', 'accordion_js', 'fade_form', 'old_css', 'no_ips', 'tracking', 'admin_bar' );
 		foreach ( $checkboxes as $set ) {
-			$this->$set = isset( $params[ 'frm_' . $set ] ) ? $params[ 'frm_' . $set ] : 0;
+			$this->$set = isset( $params['frm_' . $set] ) ? $params['frm_' . $set] : 0;
 		}
 	}
 
@@ -261,7 +261,7 @@ 
 		$frm_roles = FrmAppHelper::frm_capabilities();
 		$roles     = get_editable_roles();
 		foreach ( $frm_roles as $frm_role => $frm_role_description ) {
-			$this->$frm_role = (array) ( isset( $params[ $frm_role ] ) ? $params[ $frm_role ] : 'administrator' );
+			$this->$frm_role = (array) ( isset( $params[$frm_role] ) ? $params[$frm_role] : 'administrator' );
 
 			// Make sure administrators always have permissions
 			if ( ! in_array( 'administrator', $this->$frm_role ) ) {

classes/models/FrmCreateFile.php

Spacing +1 added lines, -1 removed lines

@@ -146,7 +146,7 @@
 
 		$next_dir = '';
 		foreach ( $dir_names as $dir ) {
-			$next_dir      .= '/' . $dir;
+			$next_dir .= '/' . $dir;
 			$needed_dirs[] = $this->uploads['basedir'] . $next_dir;
 		}
 

classes/models/FrmTableHTMLGenerator.php

Spacing +4 added lines, -4 removed lines

@@ -71,7 +71,7 @@ 
 	 * @param array $atts
 	 */
 	private function init_style_settings( $atts ) {
-		$style_settings       = array(
+		$style_settings = array(
 			'border_color' => 'dddddd',
 			'bg_color'     => 'f7f7f7',
 			'text_color'   => '444444',
@@ -82,12 +82,12 @@ 
 		$this->style_settings = apply_filters( 'frm_show_entry_styles', $style_settings );
 
 		foreach ( $this->style_settings as $key => $setting ) {
-			if ( isset( $atts[ $key ] ) && $atts[ $key ] !== '' ) {
-				$this->style_settings[ $key ] = $atts[ $key ];
+			if ( isset( $atts[$key] ) && $atts[$key] !== '' ) {
+				$this->style_settings[$key] = $atts[$key];
 			}
 
 			if ( $this->is_color_setting( $key ) ) {
-				$this->style_settings[ $key ] = $this->get_color_markup( $this->style_settings[ $key ] );
+				$this->style_settings[$key] = $this->get_color_markup( $this->style_settings[$key] );
 			}
 		}
 

classes/models/FrmEntryValidate.php

Spacing +6 added lines, -6 removed lines

@@ -11,7 +11,7 @@ 
 			return $errors;
 		}
 
-		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values[ 'frm_submit_entry_' . $values['form_id'] ] ) || ! wp_verify_nonce( $values[ 'frm_submit_entry_' . $values['form_id'] ], 'frm_submit_entry_nonce' ) ) ) {
+		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values['frm_submit_entry_' . $values['form_id']] ) || ! wp_verify_nonce( $values['frm_submit_entry_' . $values['form_id']], 'frm_submit_entry_nonce' ) ) ) {
 			$errors['form'] = __( 'You do not have permission to do that', 'formidable' );
 		}
 
@@ -65,10 +65,10 @@ 
 			'key_pointer'     => '', // the pointer in the posted array
 			'exclude'         => array(), // exclude these field types from validation
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		if ( empty( $args['parent_field_id'] ) ) {
-			$value = isset( $values['item_meta'][ $args['id'] ] ) ? $values['item_meta'][ $args['id'] ] : '';
+			$value = isset( $values['item_meta'][$args['id']] ) ? $values['item_meta'][$args['id']] : '';
 		} else {
 			// value is from a nested form
 			$value = $values;
@@ -89,7 +89,7 @@ 
 		}
 
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
 		} elseif ( $posted_field->type == 'text' && ! isset( $_POST['item_name'] ) ) { // WPCS: CSRF ok.
 			$_POST['item_name'] = $value;
 		}
@@ -142,7 +142,7 @@ 
 			$pattern = self::phone_format( $field );
 
 			if ( ! preg_match( $pattern, $value ) ) {
-				$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
+				$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
 			}
 		}
 	}
@@ -378,7 +378,7 @@ 
 
 			// Send any potentially useful $_SERVER vars, but avoid sending junk we don't need.
 			if ( $include_value ) {
-				$datas[ $key ] = $value;
+				$datas[$key] = $value;
 			}
 			unset( $key, $value );
 		}

Braces +2 added lines, -1 removed lines

@@ -90,7 +90,8 @@
 
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
 			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
-		} elseif ( $posted_field->type == 'text' && ! isset( $_POST['item_name'] ) ) { // WPCS: CSRF ok.
+		} elseif ( $posted_field->type == 'text' && ! isset( $_POST['item_name'] ) ) {
+// WPCS: CSRF ok.
 			$_POST['item_name'] = $value;
 		}
 

Doc Comments +7 added lines

@@ -44,6 +44,9 @@ 
 		}
 	}
 
+	/**
+	 * @param boolean $exclude
+	 */
 	private static function get_fields_to_validate( $values, $exclude ) {
 		$where = apply_filters( 'frm_posted_field_ids', array( 'fi.form_id' => $values['form_id'] ) );
 
@@ -293,6 +296,9 @@ 
 	 * For WP 5.5 compatibility.
 	 *
 	 * @since 4.06.02
+	 * @param string $content
+	 * @param string $ip
+	 * @param string $user_agent
 	 */
 	private static function check_disallowed_words( $author, $email, $url, $content, $ip, $user_agent ) {
 		if ( function_exists( 'wp_check_comment_disallowed_list' ) ) {
@@ -306,6 +312,7 @@ 
 	 * For WP 5.5 compatibility.
 	 *
 	 * @since 4.06.02
+	 * @return string
 	 */
 	private static function get_disallowed_words() {
 		$keys = get_option( 'disallowed_keys' );

classes/models/FrmFieldValue.php

Spacing +2 added lines, -2 removed lines

@@ -59,8 +59,8 @@
 	protected function init_saved_value( $entry ) {
 		if ( $this->field->type === 'html' ) {
 			$this->saved_value = $this->field->description;
-		} elseif ( isset( $entry->metas[ $this->field->id ] ) ) {
-			$this->saved_value = $entry->metas[ $this->field->id ];
+		} elseif ( isset( $entry->metas[$this->field->id] ) ) {
+			$this->saved_value = $entry->metas[$this->field->id];
 		} else {
 			$this->saved_value = '';
 		}

classes/views/frm-forms/form.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
 		if ( isset( $values['fields'] ) && ! empty( $values['fields'] ) ) {
 			$values['count'] = 0;
 			foreach ( $values['fields'] as $field ) {
-				$values['count']++;
+				$values['count'] ++;
 				FrmFieldsController::load_single_field( $field, $values );
 				unset( $field );
 			}

classes/views/frm-form-actions/_action_inside.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
 	$event_labels = FrmFormAction::trigger_labels();
 	foreach ( $action_control->action_options['event'] as $event ) {
 		?>
-		<option value="<?php echo esc_attr( $event ); ?>" <?php echo in_array( $event, (array) $form_action->post_content['event'] ) ? ' selected="selected"' : ''; ?> ><?php echo esc_html( isset( $event_labels[ $event ] ) ? $event_labels[ $event ] : $event ); ?></option>
+		<option value="<?php echo esc_attr( $event ); ?>" <?php echo in_array( $event, (array) $form_action->post_content['event'] ) ? ' selected="selected"' : ''; ?> ><?php echo esc_html( isset( $event_labels[$event] ) ? $event_labels[$event] : $event ); ?></option>
 <?php } ?>
 		</select>
 	</p>

classes/views/frm-form-actions/default_actions.php

Spacing +2 added lines, -2 removed lines

@@ -3,7 +3,7 @@ 
 class FrmDefPostAction extends FrmFormAction {
 	public function __construct() {
 		$action_ops = FrmFormAction::default_action_opts( 'frm_wordpress_icon frm-inverse frm_show_upgrade' );
-		$action_ops['color']   = 'rgb(0,160,210)';
+		$action_ops['color'] = 'rgb(0,160,210)';
 
 		parent::__construct( 'wppost', __( 'Create Post', 'formidable' ), $action_ops );
 	}
@@ -42,7 +42,7 @@ 
 class FrmDefMlcmpAction extends FrmFormAction {
 	public function __construct() {
 		$action_ops = FrmFormAction::default_action_opts( 'frm_mailchimp_icon frm_show_upgrade frm-inverse' );
-		$action_ops['color']   = 'var(--dark-grey)';
+		$action_ops['color'] = 'var(--dark-grey)';
 
 		parent::__construct( 'mailchimp', 'MailChimp', $action_ops );
 	}