Strategy11 / formidable-forms

classes/models/FrmFormState.php

Spacing +3 added lines, -3 removed lines

@@ -59,7 +59,7 @@ 
 	 * @return void
 	 */
 	public function set( $key, $value ) {
-		$this->state[ $key ] = $value;
+		$this->state[$key] = $value;
 	}
 
 	/**
@@ -81,7 +81,7 @@ 
 	 * @return mixed
 	 */
 	public function get( $key, $default ) {
-		return $this->state[ $key ] ?? $default;
+		return $this->state[$key] ?? $default;
 	}
 
 	/**
@@ -192,7 +192,7 @@ 
 	private function compressed_state() {
 		$compressed = array();
 		foreach ( $this->state as $key => $value ) {
-			$compressed[ self::compressed_key( $key ) ] = $value;
+			$compressed[self::compressed_key( $key )] = $value;
 		}
 		return $compressed;
 	}

classes/controllers/FrmXMLController.php

Spacing +11 added lines, -11 removed lines

@@ -169,7 +169,7 @@ 
 			return;
 		}
 
-		$selected_xml = isset( $form['xml'] ) && isset( $form['xml'][ $selected_form ] ) ? $form['xml'][ $selected_form ] : '';
+		$selected_xml = isset( $form['xml'] ) && isset( $form['xml'][$selected_form] ) ? $form['xml'][$selected_form] : '';
 		if ( empty( $selected_xml ) || strpos( $selected_xml, 'http' ) !== 0 ) {
 			return;
 		}
@@ -186,8 +186,8 @@ 
 	 * @return string
 	 */
 	private static function get_selected_in_form( $form, $value = 'form' ) {
-		if ( ! empty( $form ) && ! empty( $form[ $value ] ) ) {
-			return $form[ $value ];
+		if ( ! empty( $form ) && ! empty( $form[$value] ) ) {
+			return $form[$value];
 		}
 
 		return '';
@@ -215,7 +215,7 @@ 
 			}
 
 			if ( $for === 'view' ) {
-				$item_key  = is_array( $view_keys ) ? $view_keys[ $form_key ] : $view_keys;
+				$item_key  = is_array( $view_keys ) ? $view_keys[$form_key] : $view_keys;
 				$shortcode = '[display-frm-data id=%1$s filter=limited]';
 			} elseif ( $for === 'form' ) {
 				$item_key  = $form_key;
@@ -230,7 +230,7 @@ 
 				continue;
 			}
 
-			$page_ids[ $for ] = wp_insert_post(
+			$page_ids[$for] = wp_insert_post(
 				array(
 					'post_title'   => $name,
 					'post_type'    => 'page',
@@ -383,7 +383,7 @@ 
 		// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
 		$file_type = sanitize_option( 'upload_path', $_FILES['frm_import_file']['name'] );
 		$file_type = strtolower( pathinfo( $file_type, PATHINFO_EXTENSION ) );
-		if ( 'xml' !== $file_type && isset( $export_format[ $file_type ] ) ) {
+		if ( 'xml' !== $file_type && isset( $export_format[$file_type] ) ) {
 			// allow other file types to be imported
 			do_action( 'frm_before_import_' . $file_type );
 
@@ -477,7 +477,7 @@ 
 		foreach ( $type as $tb_type ) {
 			$where = array();
 			$join  = '';
-			$table = $tables[ $tb_type ];
+			$table = $tables[$tb_type];
 
 			$select     = $table . '.id';
 			$query_vars = array();
@@ -492,7 +492,7 @@ 
 							$table . '.parent_form_id' => $args['ids'],
 						);
 					} else {
-						$where[ $table . '.status !' ] = 'draft';
+						$where[$table . '.status !'] = 'draft';
 					}
 					break;
 				case 'actions':
@@ -505,7 +505,7 @@ 
 				case 'items':
 					// $join = "INNER JOIN {$wpdb->prefix}frm_item_metas im ON ($table.id = im.item_id)";
 					if ( $args['ids'] ) {
-						$where[ $table . '.form_id' ] = $args['ids'];
+						$where[$table . '.form_id'] = $args['ids'];
 					}
 					break;
 				case 'styles':
@@ -546,7 +546,7 @@ 
 					}
 			}//end switch
 
-			$records[ $tb_type ] = FrmDb::get_col( $table . $join, $where, $select );
+			$records[$tb_type] = FrmDb::get_col( $table . $join, $where, $select );
 			unset( $tb_type );
 		}//end foreach
 
@@ -745,7 +745,7 @@ 
 		$no_export_fields = FrmField::no_save_fields();
 		foreach ( $csv_fields as $k => $f ) {
 			if ( in_array( $f->type, $no_export_fields, true ) ) {
-				unset( $csv_fields[ $k ] );
+				unset( $csv_fields[$k] );
 			}
 		}
 

classes/helpers/FrmCSVExportHelper.php

Spacing +57 added lines, -57 removed lines

@@ -154,7 +154,7 @@ 
 
 		unset( $filename );
 
-		$comment_count       = FrmDb::get_count(
+		$comment_count = FrmDb::get_count(
 			'frm_item_metas',
 			array(
 				'item_id'         => $atts['entry_ids'],
@@ -316,7 +316,7 @@ 
 	private static function prepare_csv_headings() {
 		$headings = array();
 		self::csv_headings( $headings );
-		$headings       = apply_filters(
+		$headings = apply_filters(
 			'frm_csv_columns',
 			$headings,
 			self::$form_id,
@@ -345,15 +345,15 @@ 
 		$field_headings  = array();
 		$separate_values = array( 'user_id', 'file', 'data', 'date' );
 		if ( ! empty( $col->field_options['separate_value'] ) && ! in_array( $col->type, $separate_values, true ) ) {
-			$field_headings[ $col->id . '_label' ] = strip_tags( $col->name . ' ' . __( '(label)', 'formidable' ) );
+			$field_headings[$col->id . '_label'] = strip_tags( $col->name . ' ' . __( '(label)', 'formidable' ) );
 		}
 
-		if ( ! empty( $field_headings[ $col->id . '_label' ] ) ) {
-			$field_headings[ $col->id ] = strip_tags( $col->name . ' ' . __( '(value)', 'formidable' ) );
+		if ( ! empty( $field_headings[$col->id . '_label'] ) ) {
+			$field_headings[$col->id] = strip_tags( $col->name . ' ' . __( '(value)', 'formidable' ) );
 		} else {
-			$field_headings[ $col->id ] = strip_tags( $col->name );
+			$field_headings[$col->id] = strip_tags( $col->name );
 		}
-		$field_headings             = apply_filters(
+		$field_headings = apply_filters(
 			'frm_csv_field_columns',
 			$field_headings,
 			array_merge(
@@ -378,14 +378,14 @@ 
 			if ( self::is_the_child_of_a_repeater( $col ) ) {
 				$repeater_id = $col->field_options['in_section'];
 				// Set a placeholder to maintain order for repeater fields.
-				$headings[ 'repeater' . $repeater_id ] = array();
+				$headings['repeater' . $repeater_id] = array();
 
-				if ( ! isset( $fields_by_repeater_id[ $repeater_id ] ) ) {
-					$fields_by_repeater_id[ $repeater_id ] = array();
+				if ( ! isset( $fields_by_repeater_id[$repeater_id] ) ) {
+					$fields_by_repeater_id[$repeater_id] = array();
 					$repeater_ids[]                        = $repeater_id;
 				}
 
-				$fields_by_repeater_id[ $repeater_id ][] = $col;
+				$fields_by_repeater_id[$repeater_id][] = $col;
 
 				continue;
 			}
@@ -404,8 +404,8 @@ 
 				$end    = strpos( $row->meta_value, ':{' );
 				$length = substr( $row->meta_value, $start, $end - $start );
 
-				if ( $length > $max[ $row->field_id ] ) {
-					$max[ $row->field_id ] = $length;
+				if ( $length > $max[$row->field_id] ) {
+					$max[$row->field_id] = $length;
 				}
 			}
 			unset( $start, $end, $length, $row, $repeater_meta, $where );
@@ -416,17 +416,17 @@ 
 					$repeater_id = str_replace( 'repeater', '', $key );
 
 					$repeater_headings = array();
-					foreach ( $fields_by_repeater_id[ $repeater_id ] as $col ) {
+					foreach ( $fields_by_repeater_id[$repeater_id] as $col ) {
 						$repeater_headings += self::field_headings( $col );
 					}
 
-					for ( $i = 0; $i < $max[ $repeater_id ]; $i++ ) {
+					for ( $i = 0; $i < $max[$repeater_id]; $i ++ ) {
 						foreach ( $repeater_headings as $repeater_key => $repeater_name ) {
-							$flat[ $repeater_key . '[' . $i . ']' ] = $repeater_name;
+							$flat[$repeater_key . '[' . $i . ']'] = $repeater_name;
 						}
 					}
 				} else {
-					$flat[ $key ] = $heading;
+					$flat[$key] = $heading;
 				}
 			}
 
@@ -439,10 +439,10 @@ 
 		}//end if
 
 		if ( self::$comment_count ) {
-			for ( $i = 0; $i < self::$comment_count; $i++ ) {
-				$headings[ 'comment' . $i ]            = __( 'Comment', 'formidable' );
-				$headings[ 'comment_user_id' . $i ]    = __( 'Comment User', 'formidable' );
-				$headings[ 'comment_created_at' . $i ] = __( 'Comment Date', 'formidable' );
+			for ( $i = 0; $i < self::$comment_count; $i ++ ) {
+				$headings['comment' . $i]            = __( 'Comment', 'formidable' );
+				$headings['comment_user_id' . $i]    = __( 'Comment User', 'formidable' );
+				$headings['comment_created_at' . $i] = __( 'Comment Date', 'formidable' );
 			}
 			unset( $i );
 		}
@@ -495,7 +495,7 @@ 
 	 */
 	private static function prepare_next_csv_rows( $next_set ) {
 		if ( FrmAppHelper::pro_is_installed() ) {
-			$where    = array(
+			$where = array(
 				'or'             => 1,
 				'id'             => $next_set,
 				'parent_item_id' => $next_set,
@@ -560,32 +560,32 @@ 
 					continue;
 				}
 
-				if ( ! isset( $entries[ self::$entry->parent_item_id ] ) ) {
-					$entries[ self::$entry->parent_item_id ]        = new stdClass();
-					$entries[ self::$entry->parent_item_id ]->metas = array();
+				if ( ! isset( $entries[self::$entry->parent_item_id] ) ) {
+					$entries[self::$entry->parent_item_id]        = new stdClass();
+					$entries[self::$entry->parent_item_id]->metas = array();
 				}
 
-				if ( ! isset( $entries[ self::$entry->parent_item_id ]->metas[ $meta_id ] ) ) {
-					$entries[ self::$entry->parent_item_id ]->metas[ $meta_id ] = array();
-				} elseif ( ! is_array( $entries[ self::$entry->parent_item_id ]->metas[ $meta_id ] ) ) {
+				if ( ! isset( $entries[self::$entry->parent_item_id]->metas[$meta_id] ) ) {
+					$entries[self::$entry->parent_item_id]->metas[$meta_id] = array();
+				} elseif ( ! is_array( $entries[self::$entry->parent_item_id]->metas[$meta_id] ) ) {
 					// if the data is here, it should be an array but if this field has collected data
 					// both while inside and outside of the repeating section, it's possible this is a string.
-					$entries[ self::$entry->parent_item_id ]->metas[ $meta_id ] = (array) $entries[ self::$entry->parent_item_id ]->metas[ $meta_id ];
+					$entries[self::$entry->parent_item_id]->metas[$meta_id] = (array) $entries[self::$entry->parent_item_id]->metas[$meta_id];
 				}
 
 				// Add the repeated values.
-				$entries[ self::$entry->parent_item_id ]->metas[ $meta_id ][] = $meta_value;
+				$entries[self::$entry->parent_item_id]->metas[$meta_id][] = $meta_value;
 			}//end foreach
 
 			self::$entry->metas                              = self::fill_missing_repeater_metas( self::$entry->metas, $entries );
-			$entries[ self::$entry->parent_item_id ]->metas += self::$entry->metas;
+			$entries[self::$entry->parent_item_id]->metas += self::$entry->metas;
 		}//end if
 
 		// add the embedded form id
-		if ( ! isset( $entries[ self::$entry->parent_item_id ]->embedded_fields ) ) {
-			$entries[ self::$entry->parent_item_id ]->embedded_fields = array();
+		if ( ! isset( $entries[self::$entry->parent_item_id]->embedded_fields ) ) {
+			$entries[self::$entry->parent_item_id]->embedded_fields = array();
 		}
-		$entries[ self::$entry->parent_item_id ]->embedded_fields[ self::$entry->id ] = self::$entry->form_id;
+		$entries[self::$entry->parent_item_id]->embedded_fields[self::$entry->id] = self::$entry->form_id;
 	}
 
 	/**
@@ -606,19 +606,19 @@ 
 		}
 
 		$repeater_id = $field->field_options['in_section'];
-		if ( ! isset( self::$fields_by_repeater_id[ $repeater_id ] ) ) {
+		if ( ! isset( self::$fields_by_repeater_id[$repeater_id] ) ) {
 			return $metas;
 		}
 
-		foreach ( self::$fields_by_repeater_id[ $repeater_id ] as $repeater_child ) {
-			if ( ! isset( $metas[ $repeater_child->id ] ) ) {
-				$metas[ $repeater_child->id ] = '';
+		foreach ( self::$fields_by_repeater_id[$repeater_id] as $repeater_child ) {
+			if ( ! isset( $metas[$repeater_child->id] ) ) {
+				$metas[$repeater_child->id] = '';
 
-				if ( ! isset( $entries[ self::$entry->parent_item_id ]->metas[ $repeater_child->id ] ) || ! is_array( $entries[ self::$entry->parent_item_id ]->metas[ $repeater_child->id ] ) ) {
-					$entries[ self::$entry->parent_item_id ]->metas[ $repeater_child->id ] = array();
+				if ( ! isset( $entries[self::$entry->parent_item_id]->metas[$repeater_child->id] ) || ! is_array( $entries[self::$entry->parent_item_id]->metas[$repeater_child->id] ) ) {
+					$entries[self::$entry->parent_item_id]->metas[$repeater_child->id] = array();
 				}
 
-				$entries[ self::$entry->parent_item_id ]->metas[ $repeater_child->id ][] = '';
+				$entries[self::$entry->parent_item_id]->metas[$repeater_child->id][] = '';
 			}
 		}
 
@@ -647,7 +647,7 @@ 
 	 */
 	private static function add_field_values_to_csv( &$row ) {
 		foreach ( self::$fields as $col ) {
-			$field_value = self::$entry->metas[ $col->id ] ?? false;
+			$field_value = self::$entry->metas[$col->id] ?? false;
 
 			FrmFieldsHelper::prepare_field_value( $field_value, $col->type );
 			self::add_array_values_to_columns( $row, compact( 'col', 'field_value' ) );
@@ -666,20 +666,20 @@ 
 			if ( ! empty( $col->field_options['separate_value'] ) ) {
 				$label_key = $col->id . '_label';
 				if ( self::is_the_child_of_a_repeater( $col ) ) {
-					$row[ $label_key ] = array();
+					$row[$label_key] = array();
 
 					if ( is_array( $field_value ) ) {
 						foreach ( $field_value as $value ) {
-							$row[ $label_key ][] = self::get_separate_value_label( $value, $col );
+							$row[$label_key][] = self::get_separate_value_label( $value, $col );
 						}
 					}
 				} else {
-					$row[ $label_key ] = self::get_separate_value_label( $field_value, $col );
+					$row[$label_key] = self::get_separate_value_label( $field_value, $col );
 				}
 				unset( $label_key );
 			}
 
-			$row[ $col->id ] = $field_value;
+			$row[$col->id] = $field_value;
 
 			unset( $col, $field_value );
 		}//end foreach
@@ -702,7 +702,7 @@ 
 				'show_icon'         => false,
 				'entry_id'          => self::$entry->id,
 				'sep'               => self::$separator,
-				'embedded_field_id' => isset( self::$entry->embedded_fields ) && isset( self::$entry->embedded_fields[ self::$entry->id ] ) ? 'form' . self::$entry->embedded_fields[ self::$entry->id ] : 0,
+				'embedded_field_id' => isset( self::$entry->embedded_fields ) && isset( self::$entry->embedded_fields[self::$entry->id] ) ? 'form' . self::$entry->embedded_fields[self::$entry->id] : 0,
 			)
 		);
 	}
@@ -721,8 +721,8 @@ 
 					// This is combo field inside repeater. The heading key has this format: [86_first[0]].
 					foreach ( $sub_value as $sub_key => $sub_sub_value ) {
 						$column_key = $atts['col']->id . '_' . $sub_key . '[' . $key . ']';
-						if ( ! is_numeric( $sub_key ) && isset( self::$headings[ $column_key ] ) ) {
-							$row[ $column_key ] = $sub_sub_value;
+						if ( ! is_numeric( $sub_key ) && isset( self::$headings[$column_key] ) ) {
+							$row[$column_key] = $sub_sub_value;
 						}
 					}
 
@@ -730,8 +730,8 @@ 
 				}
 
 				$column_key = $atts['col']->id . '_' . $key;
-				if ( ! is_numeric( $key ) && isset( self::$headings[ $column_key ] ) ) {
-					$row[ $column_key ] = $sub_value;
+				if ( ! is_numeric( $key ) && isset( self::$headings[$column_key] ) ) {
+					$row[$column_key] = $sub_value;
 				}
 			}
 		}
@@ -766,18 +766,18 @@ 
 		$echo = 'echo' === self::$mode;
 
 		foreach ( self::$headings as $k => $heading ) {
-			if ( isset( $rows[ $k ] ) ) {
-				$row = $rows[ $k ];
+			if ( isset( $rows[$k] ) ) {
+				$row = $rows[$k];
 			} else {
 				$row = '';
 				// array indexed data is not at $rows[ $k ]
-				if ( $k[ strlen( $k ) - 1 ] === ']' ) {
+				if ( $k[strlen( $k ) - 1] === ']' ) {
 					$start = strrpos( $k, '[' );
-					$key   = substr( $k, 0, $start++ );
+					$key   = substr( $k, 0, $start ++ );
 					$index = substr( $k, $start, strlen( $k ) - 1 - $start );
 
-					if ( isset( $rows[ $key ] ) && isset( $rows[ $key ][ $index ] ) ) {
-						$row = $rows[ $key ][ $index ];
+					if ( isset( $rows[$key] ) && isset( $rows[$key][$index] ) ) {
+						$row = $rows[$key][$index];
 					}
 
 					unset( $start, $key, $index );

classes/models/FrmEntry.php

Spacing +23 added lines, -23 removed lines

@@ -56,8 +56,8 @@ 
 	 * @return void
 	 */
 	private static function flag_new_unique_key( $unique_id ) {
-		if ( ! isset( self::$unique_id_match_checks[ $unique_id ] ) ) {
-			self::$unique_id_match_checks[ $unique_id ] = false;
+		if ( ! isset( self::$unique_id_match_checks[$unique_id] ) ) {
+			self::$unique_id_match_checks[$unique_id] = false;
 		}
 	}
 
@@ -112,7 +112,7 @@ 
 				if ( 0 === (int) $meta->field_id ) {
 					continue;
 				}
-				$field_metas[ $meta->field_id ] = $meta->meta_value;
+				$field_metas[$meta->field_id] = $meta->meta_value;
 			}
 
 			$filtered_vals = array_filter( $values['item_meta'] );
@@ -177,8 +177,8 @@ 
 			return false;
 		}
 
-		if ( isset( self::$unique_id_match_checks[ $unique_id ] ) ) {
-			return self::$unique_id_match_checks[ $unique_id ];
+		if ( isset( self::$unique_id_match_checks[$unique_id] ) ) {
+			return self::$unique_id_match_checks[$unique_id];
 		}
 
 		$timestamp = strtotime( $created_at );
@@ -186,7 +186,7 @@ 
 			$timestamp = time();
 		}
 
-		self::$unique_id_match_checks[ $unique_id ] = (bool) FrmDb::get_var(
+		self::$unique_id_match_checks[$unique_id] = (bool) FrmDb::get_var(
 			'frm_item_metas',
 			array(
 				'field_id'     => 0,
@@ -196,7 +196,7 @@ 
 			'id'
 		);
 
-		return self::$unique_id_match_checks[ $unique_id ];
+		return self::$unique_id_match_checks[$unique_id];
 	}
 
 	/**
@@ -226,10 +226,10 @@ 
 		$reduced = array();
 		foreach ( $filter_vals as $field_id => $value ) {
 			$field                = FrmFieldFactory::get_field_object( $field_id );
-			$reduced[ $field_id ] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
-			$reduced[ $field_id ] = $field->set_value_before_save( $reduced[ $field_id ] );
-			if ( '' === $reduced[ $field_id ] || ( is_array( $reduced[ $field_id ] ) && 0 === count( $reduced[ $field_id ] ) ) ) {
-				unset( $reduced[ $field_id ] );
+			$reduced[$field_id] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
+			$reduced[$field_id] = $field->set_value_before_save( $reduced[$field_id] );
+			if ( '' === $reduced[$field_id] || ( is_array( $reduced[$field_id] ) && 0 === count( $reduced[$field_id] ) ) ) {
+				unset( $reduced[$field_id] );
 			}
 		}
 		return $reduced;
@@ -515,7 +515,7 @@ 
 	private static function prepare_entries( &$entries ) {
 		foreach ( $entries as $k => $entry ) {
 			self::prepare_entry( $entry );
-			$entries[ $k ] = $entry;
+			$entries[$k] = $entry;
 		}
 	}
 
@@ -546,19 +546,19 @@ 
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
 
 			if ( $meta_val->item_id == $entry->id ) {
-				$entry->metas[ $meta_val->field_id ] = $meta_val->meta_value;
+				$entry->metas[$meta_val->field_id] = $meta_val->meta_value;
 				if ( $include_key ) {
-					$entry->metas[ $meta_val->field_key ] = $entry->metas[ $meta_val->field_id ];
+					$entry->metas[$meta_val->field_key] = $entry->metas[$meta_val->field_id];
 				}
 				continue;
 			}
 
 			// include sub entries in an array
-			if ( ! isset( $entry->metas[ $meta_val->field_id ] ) ) {
-				$entry->metas[ $meta_val->field_id ] = array();
+			if ( ! isset( $entry->metas[$meta_val->field_id] ) ) {
+				$entry->metas[$meta_val->field_id] = array();
 			}
 
-			$entry->metas[ $meta_val->field_id ][] = $meta_val->meta_value;
+			$entry->metas[$meta_val->field_id][] = $meta_val->meta_value;
 
 			unset( $meta_val );
 		}
@@ -662,16 +662,16 @@ 
 		}
 
 		foreach ( $metas as $m_key => $meta_val ) {
-			if ( ! isset( $entries[ $meta_val->item_id ] ) ) {
+			if ( ! isset( $entries[$meta_val->item_id] ) ) {
 				continue;
 			}
 
-			if ( ! isset( $entries[ $meta_val->item_id ]->metas ) ) {
-				$entries[ $meta_val->item_id ]->metas = array();
+			if ( ! isset( $entries[$meta_val->item_id]->metas ) ) {
+				$entries[$meta_val->item_id]->metas = array();
 			}
 
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
-			$entries[ $meta_val->item_id ]->metas[ $meta_val->field_id ] = $meta_val->meta_value;
+			$entries[$meta_val->item_id]->metas[$meta_val->field_id] = $meta_val->meta_value;
 			unset( $m_key, $meta_val );
 		}
 
@@ -863,7 +863,7 @@ 
 	 * @return mixed
 	 */
 	private static function get_entry_value( $values, $name, $default ) {
-		return $values[ $name ] ?? $default;
+		return $values[$name] ?? $default;
 	}
 
 	/**
@@ -1070,7 +1070,7 @@ 
 	private static function maybe_add_captcha_meta( $form_id, $entry_id ) {
 		global $frm_vars;
 		if ( array_key_exists( 'captcha_scores', $frm_vars ) && array_key_exists( $form_id, $frm_vars['captcha_scores'] ) ) {
-			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][ $form_id ] );
+			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][$form_id] );
 			FrmEntryMeta::add_entry_meta( $entry_id, 0, '', maybe_serialize( $captcha_score_meta ) );
 		}
 	}

classes/controllers/FrmFormActionsController.php

Spacing +17 added lines, -17 removed lines

@@ -133,19 +133,19 @@ 
 		}
 
 		foreach ( $action_controls as $action ) {
-			if ( isset( $groups[ $action->id_base ] ) || in_array( $action->id_base, $grouped ) ) {
+			if ( isset( $groups[$action->id_base] ) || in_array( $action->id_base, $grouped ) ) {
 				continue;
 			}
 
 			$this_group = $action->action_options['group'];
-			if ( ! isset( $groups[ $this_group ] ) ) {
+			if ( ! isset( $groups[$this_group] ) ) {
 				$this_group = 'misc';
 			}
 
-			if ( ! isset( $groups[ $this_group ]['actions'] ) ) {
-				$groups[ $this_group ]['actions'] = array();
+			if ( ! isset( $groups[$this_group]['actions'] ) ) {
+				$groups[$this_group]['actions'] = array();
 			}
-			$groups[ $this_group ]['actions'][] = $action->id_base;
+			$groups[$this_group]['actions'][] = $action->id_base;
 
 			unset( $action );
 		}
@@ -319,7 +319,7 @@ 
 				return $a;
 			}
 
-			$actions[ $a->id_base ] = $a;
+			$actions[$a->id_base] = $a;
 		}
 
 		return $actions;
@@ -358,18 +358,18 @@ 
 		$action_map = array();
 
 		foreach ( $action_controls as $key => $control ) {
-			$action_map[ $control->id_base ] = $key;
+			$action_map[$control->id_base] = $key;
 		}
 
 		self::maybe_show_limit_warning( $form->id, $form_actions );
 
 		foreach ( $form_actions as $action ) {
-			if ( ! isset( $action_map[ $action->post_excerpt ] ) ) {
+			if ( ! isset( $action_map[$action->post_excerpt] ) ) {
 				// don't try and show settings if action no longer exists
 				continue;
 			}
 
-			self::action_control( $action, $form, $action->ID, $action_controls[ $action_map[ $action->post_excerpt ] ], $values );
+			self::action_control( $action, $form, $action->ID, $action_controls[$action_map[$action->post_excerpt]], $values );
 		}
 	}
 
@@ -681,8 +681,8 @@ 
 			}
 
 			// Store actions so they can be triggered with the correct priority.
-			$stored_actions[ $action->ID ]  = $action;
-			$action_priority[ $action->ID ] = $link_settings[ $action->post_excerpt ]->action_options['priority'];
+			$stored_actions[$action->ID]  = $action;
+			$action_priority[$action->ID] = $link_settings[$action->post_excerpt]->action_options['priority'];
 
 			unset( $action );
 		}//end foreach
@@ -694,7 +694,7 @@ 
 			new FrmNotification();
 
 			foreach ( $action_priority as $action_id => $priority ) {
-				$action = $stored_actions[ $action_id ];
+				$action = $stored_actions[$action_id];
 
 				/**
 				 * Allows custom form action trigger.
@@ -791,7 +791,7 @@ 
 	 * @return void
 	 */
 	public function register( $action_class ) {
-		$this->actions[ $action_class ] = new $action_class();
+		$this->actions[$action_class] = new $action_class();
 	}
 
 	/**
@@ -800,8 +800,8 @@ 
 	 * @return void
 	 */
 	public function unregister( $action_class ) {
-		if ( isset( $this->actions[ $action_class ] ) ) {
-			unset( $this->actions[ $action_class ] );
+		if ( isset( $this->actions[$action_class] ) ) {
+			unset( $this->actions[$action_class] );
 		}
 	}
 
@@ -810,8 +810,8 @@ 
 
 		foreach ( $keys as $key ) {
 			// don't register new action if old action with the same id is already registered
-			if ( ! isset( $this->actions[ $key ] ) ) {
-				$this->actions[ $key ]->_register();
+			if ( ! isset( $this->actions[$key] ) ) {
+				$this->actions[$key]->_register();
 			}
 		}
 	}

classes/models/FrmAddon.php

Spacing +15 added lines, -15 removed lines

@@ -75,7 +75,7 @@ 
 	 * @return array
 	 */
 	public function insert_installed_addon( $plugins ) {
-		$plugins[ $this->plugin_slug ] = $this;
+		$plugins[$this->plugin_slug] = $this;
 
 		return $plugins;
 	}
@@ -88,8 +88,8 @@ 
 	public static function get_addon( $plugin_slug ) {
 		$plugins = apply_filters( 'frm_installed_addons', array() );
 		$plugin  = false;
-		if ( isset( $plugins[ $plugin_slug ] ) ) {
-			$plugin = $plugins[ $plugin_slug ];
+		if ( isset( $plugins[$plugin_slug] ) ) {
+			$plugin = $plugins[$plugin_slug];
 		}
 
 		return $plugin;
@@ -149,7 +149,7 @@ 
 		} else {
 			$api     = new FrmFormApi( $this->license );
 			$plugins = $api->get_api_info();
-			$_data   = $plugins[ $item_id ];
+			$_data   = $plugins[$item_id];
 		}
 
 		$_data['sections'] = array(
@@ -417,19 +417,19 @@ 
 
 		if ( $this->is_current_version( $transient ) ) {
 			// Make sure it doesn't show there is an update if plugin is up-to-date.
-			if ( isset( $transient->response[ $this->plugin_folder ] ) ) {
-				unset( $transient->response[ $this->plugin_folder ] );
+			if ( isset( $transient->response[$this->plugin_folder] ) ) {
+				unset( $transient->response[$this->plugin_folder] );
 			}
-		} elseif ( isset( $transient->response ) && isset( $transient->response[ $this->plugin_folder ] ) ) {
-			$this->prepare_update_details( $transient->response[ $this->plugin_folder ] );
+		} elseif ( isset( $transient->response ) && isset( $transient->response[$this->plugin_folder] ) ) {
+			$this->prepare_update_details( $transient->response[$this->plugin_folder] );
 
 			// if the transient has expired, clear the update and trigger it again
-			if ( $transient->response[ $this->plugin_folder ] === false ) {
+			if ( $transient->response[$this->plugin_folder] === false ) {
 				if ( ! $this->has_been_cleared() ) {
 					$this->cleared_plugins();
 					$this->manually_queue_update();
 				}
-				unset( $transient->response[ $this->plugin_folder ] );
+				unset( $transient->response[$this->plugin_folder] );
 			}
 		}
 
@@ -533,7 +533,7 @@ 
 	 * @return bool
 	 */
 	private function is_current_version( $transient ) {
-		if ( empty( $transient->checked ) || ! isset( $transient->checked[ $this->plugin_folder ] ) ) {
+		if ( empty( $transient->checked ) || ! isset( $transient->checked[$this->plugin_folder] ) ) {
 			return false;
 		}
 
@@ -542,7 +542,7 @@ 
 			return true;
 		}
 
-		return isset( $transient->response ) && isset( $transient->response[ $this->plugin_folder ] ) && $transient->checked[ $this->plugin_folder ] === $transient->response[ $this->plugin_folder ]->new_version;
+		return isset( $transient->response ) && isset( $transient->response[$this->plugin_folder] ) && $transient->checked[$this->plugin_folder] === $transient->response[$this->plugin_folder]->new_version;
 	}
 
 	/**
@@ -694,8 +694,8 @@ 
 			$response['message'] = $response['status'];
 		} else {
 			$messages = $this->get_messages();
-			if ( is_string( $response['status'] ) && isset( $messages[ $response['status'] ] ) ) {
-				$response['message'] = $messages[ $response['status'] ];
+			if ( is_string( $response['status'] ) && isset( $messages[$response['status']] ) ) {
+				$response['message'] = $messages[$response['status']];
 			} else {
 				$response['message'] = FrmAppHelper::kses( $response['status'], array( 'a' ) );
 			}
@@ -859,7 +859,7 @@ 
 			'user-agent' => $this->plugin_slug . '/' . $this->version . '; ' . get_bloginfo( 'url' ),
 		);
 
-		$resp              = wp_remote_post(
+		$resp = wp_remote_post(
 			$this->store_url . '?l=' . urlencode( base64_encode( $this->license ) ),
 			$arg_array
 		);

Braces +2 added lines, -1 removed lines

@@ -593,7 +593,8 @@
 	 * @return void
 	 */
 	private function is_license_revoked() {
-		if ( empty( $this->license ) || empty( $this->plugin_slug ) || isset( $_POST['license'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( empty( $this->license ) || empty( $this->plugin_slug ) || isset( $_POST['license'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return;
 		}
 

classes/helpers/FrmListHelper.php

Spacing +15 added lines, -15 removed lines

@@ -230,8 +230,8 @@ 
 			return $this->get_pagenum();
 		}
 
-		if ( isset( $this->_pagination_args[ $key ] ) ) {
-			return $this->_pagination_args[ $key ];
+		if ( isset( $this->_pagination_args[$key] ) ) {
+			return $this->_pagination_args[$key];
 		}
 	}
 
@@ -281,8 +281,8 @@ 
 	 * @return void
 	 */
 	private function hidden_search_inputs( $param_name ) {
-		if ( ! empty( $_REQUEST[ $param_name ] ) ) {
-			$value = sanitize_text_field( wp_unslash( $_REQUEST[ $param_name ] ) );
+		if ( ! empty( $_REQUEST[$param_name] ) ) {
+			$value = sanitize_text_field( wp_unslash( $_REQUEST[$param_name] ) );
 			echo '<input type="hidden" name="' . esc_attr( $param_name ) . '" value="' . esc_attr( $value ) . '" />';
 		}
 	}
@@ -324,7 +324,7 @@ 
 
 		echo "<ul class='subsubsub'>\n";
 		foreach ( $views as $class => $view ) {
-			$views[ $class ] = "\t" . '<li class="' . esc_attr( $class ) . '">' . $view;
+			$views[$class] = "\t" . '<li class="' . esc_attr( $class ) . '">' . $view;
 		}
 		echo implode( " |</li>\n", $views ) . "</li>\n"; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 		echo '</ul>';
@@ -490,7 +490,7 @@ 
 
 		$out = '<div class="' . ( $always_visible ? 'row-actions visible' : 'row-actions' ) . '">';
 		foreach ( $actions as $action => $link ) {
-			++$i;
+			++ $i;
 			$sep  = $i === $action_count ? '' : ' | ';
 			$out .= "<span class='$action'>$link$sep</span>";
 		}
@@ -723,7 +723,7 @@ 
 			'next'  => __( 'Next page', 'formidable' ),
 		);
 
-		return $labels[ $link ];
+		return $labels[$link];
 	}
 
 	private function current_url() {
@@ -828,7 +828,7 @@ 
 
 		// If the primary column doesn't exist fall back to the
 		// first non-checkbox column.
-		if ( ! isset( $columns[ $default ] ) ) {
+		if ( ! isset( $columns[$default] ) ) {
 			$default = self::get_default_primary_column_name();
 		}
 
@@ -842,7 +842,7 @@ 
 		 */
 		$column = apply_filters( 'list_table_primary_column', $default, $this->screen->id );
 
-		if ( empty( $column ) || ! isset( $columns[ $column ] ) ) {
+		if ( empty( $column ) || ! isset( $columns[$column] ) ) {
 			$column = $default;
 		}
 
@@ -863,7 +863,7 @@ 
 			// In 4.3, we added a fourth argument for primary column.
 			$column_headers = array( array(), array(), array(), $this->get_primary_column_name() );
 			foreach ( $this->_column_headers as $key => $value ) {
-				$column_headers[ $key ] = $value;
+				$column_headers[$key] = $value;
 			}
 
 			return $column_headers;
@@ -896,7 +896,7 @@ 
 				$data[1] = false;
 			}
 
-			$sortable[ $id ] = $data;
+			$sortable[$id] = $data;
 		}
 
 		$primary = $this->get_primary_column_name();
@@ -954,7 +954,7 @@ 
 			static $cb_counter = 1;
 			$columns['cb']     = '<label class="screen-reader-text" for="cb-select-all-' . $cb_counter . '">' . __( 'Select All', 'formidable' ) . '</label>';
 			$columns['cb']    .= '<input id="cb-select-all-' . esc_attr( $cb_counter ) . '" type="checkbox" />';
-			++$cb_counter;
+			++ $cb_counter;
 		}
 
 		foreach ( $columns as $column_key => $column_display_name ) {
@@ -976,8 +976,8 @@ 
 				$class[] = 'column-primary';
 			}
 
-			if ( isset( $sortable[ $column_key ] ) ) {
-				list( $orderby, $desc_first ) = $sortable[ $column_key ];
+			if ( isset( $sortable[$column_key] ) ) {
+				list( $orderby, $desc_first ) = $sortable[$column_key];
 
 				if ( $current_orderby == $orderby ) {
 					// The sorted column. The `aria-sort` attribute must be set only on the sorted column.
@@ -1094,7 +1094,7 @@ 
 	 * @return bool Returns true if the setting is not set or if it is not false; otherwise, returns false.
 	 */
 	protected function should_display( $args, $settings ) {
-		return ! isset( $args[ $settings ] ) || false !== $args[ $settings ];
+		return ! isset( $args[$settings] ) || false !== $args[$settings];
 	}
 
 	/**

classes/helpers/FrmFieldsHelper.php

Spacing +50 added lines, -50 removed lines

@@ -44,7 +44,7 @@ 
 			if ( in_array( $type, array( 'data', 'lookup' ), true ) ) {
 				$values['field_options']['data_type'] = $setting;
 			} else {
-				$values['field_options'][ $setting ] = 1;
+				$values['field_options'][$setting] = 1;
 			}
 		}
 
@@ -206,10 +206,10 @@ 
 		}
 
 		foreach ( $defaults as $opt => $default ) {
-			$values[ $opt ] = $field->field_options[ $opt ] ?? $default;
+			$values[$opt] = $field->field_options[$opt] ?? $default;
 
 			if ( $check_post ) {
-				self::get_posted_field_setting( $opt . '_' . $field->id, $values[ $opt ] );
+				self::get_posted_field_setting( $opt . '_' . $field->id, $values[$opt] );
 			}
 		}
 	}
@@ -226,7 +226,7 @@ 
 			return self::$context_is_safe_to_load_field_options_from_request_data;
 		}
 
-		$function = function () {
+		$function = function() {
 			if ( ! FrmAppHelper::is_admin_page() ) {
 				return false;
 			}
@@ -338,12 +338,12 @@ 
 	 * @return void
 	 */
 	private static function get_posted_field_setting( $setting, &$value ) {
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( ! isset( $_POST['field_options'][$setting] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return;
 		}
 
 		if ( strpos( $setting, 'html' ) !== false ) {
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 
 			// Conditionally strip script tags if the user sending $_POST data is not allowed to use unfiltered HTML.
 			if ( ! FrmAppHelper::allow_unfiltered_html() ) {
@@ -351,9 +351,9 @@ 
 			}
 		} elseif ( strpos( $setting, 'format_' ) === 0 ) {
 			// TODO: Remove stripslashes on output, and use on input only.
-			$value = sanitize_text_field( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
+			$value = sanitize_text_field( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
 		} else {
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 			FrmAppHelper::sanitize_value( 'wp_kses_post', $value );
 		}
 	}
@@ -436,7 +436,7 @@ 
 		$values['default_value'] = FrmAppHelper::maybe_json_encode( $field->default_value );
 
 		foreach ( array( 'name', 'description', 'type', 'field_order', 'field_options', 'required' ) as $col ) {
-			$values[ $col ] = $field->{$col};
+			$values[$col] = $field->{$col};
 		}
 	}
 
@@ -474,7 +474,7 @@ 
 		);
 
 		$msg = FrmField::get_option( $field, $error );
-		$msg = empty( $msg ) ? $defaults[ $error ]['part'] : $msg;
+		$msg = empty( $msg ) ? $defaults[$error]['part'] : $msg;
 		$msg = do_shortcode( $msg );
 
 		$msg = self::maybe_replace_substrings_with_field_name( $msg, $error, $field );
@@ -798,7 +798,7 @@ 
 			'inside_class' => 'inside',
 			'dismiss-icon' => true,
 		);
-		$args     = array_merge( $defaults, $args );
+		$args = array_merge( $defaults, $args );
 
 		include FrmAppHelper::plugin_path() . '/classes/views/frm-fields/back-end/inline-modal.php';
 	}
@@ -1082,7 +1082,7 @@ 
 				continue;
 			}
 
-			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][ $short_key ] );
+			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][$short_key] );
 			$tag  = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
 
 			$atts['entry'] = $entry;
@@ -1092,7 +1092,7 @@ 
 			if ( $replace_with !== null ) {
 				$replace_with = self::trigger_shortcode_atts( $replace_with, $atts );
 				self::sanitize_embedded_shortcodes( compact( 'entry' ), $replace_with );
-				$content = str_replace( $shortcodes[0][ $short_key ], $replace_with, $content );
+				$content = str_replace( $shortcodes[0][$short_key], $replace_with, $content );
 			}
 
 			unset( $atts, $replace_with );
@@ -1110,7 +1110,7 @@ 
 		$supported_atts = array( 'remove_accents', 'sanitize', 'sanitize_url' );
 		$included_atts  = array_intersect( $supported_atts, array_keys( $atts ) );
 		foreach ( $included_atts as $included_att ) {
-			if ( '0' === $atts[ $included_att ] ) {
+			if ( '0' === $atts[$included_att] ) {
 				// Skip any option that uses 0 so sanitize_url=0 does not encode.
 				continue;
 			}
@@ -1188,8 +1188,8 @@ 
 
 		$dynamic_default = array( 'admin_email', 'siteurl', 'frmurl', 'sitename', 'get', 'default-email', 'default-from-email' );
 
-		if ( isset( $shortcode_values[ $atts['tag'] ] ) ) {
-			$replace_with = $shortcode_values[ $atts['tag'] ];
+		if ( isset( $shortcode_values[$atts['tag']] ) ) {
+			$replace_with = $shortcode_values[$atts['tag']];
 		} elseif ( in_array( $atts['tag'], $dynamic_default, true ) ) {
 			$replace_with = self::dynamic_default_values( $atts['tag'], $atts );
 		} elseif ( $clean_tag === 'user_agent' ) {
@@ -1435,8 +1435,8 @@ 
 			self::field_types_for_input( $single_input, $field_selection, $field_types );
 		} elseif ( in_array( $type, $multiple_input, true ) ) {
 			self::field_types_for_input( $multiple_input, $field_selection, $field_types );
-		} elseif ( isset( $field_selection[ $type ] ) ) {
-			$field_types[ $type ] = $field_selection[ $type ];
+		} elseif ( isset( $field_selection[$type] ) ) {
+			$field_types[$type] = $field_selection[$type];
 		}
 
 		$field_types = apply_filters( 'frm_switch_field_types', $field_types, compact( 'type', 'field_selection' ) );
@@ -1480,7 +1480,7 @@ 
 		foreach ( $inputs as $input ) {
 			// This may not be set if a field type was removed using the frm_available_fields or frm_pro_available_fields filters.
 			if ( array_key_exists( $input, $fields ) ) {
-				$field_types[ $input ] = $fields[ $input ];
+				$field_types[$input] = $fields[$input];
 			}
 			unset( $input );
 		}
@@ -1515,7 +1515,7 @@ 
 			'parent'  => false,
 			'pointer' => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		$opt_key   = $args['opt_key'];
 		$field     = $args['field'];
@@ -1531,25 +1531,25 @@ 
 
 		// Check posted vals before checking saved values
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( $parent && isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
-				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
+				$other_val = isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ) : '';
 			} else {
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			}
 
 			return $other_val;
 		}
 
-		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			// For normal fields
 
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
-				$other_val = isset( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ) : '';
+				$other_val = isset( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ) : '';
 			} else {
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			}
 
 			return $other_val;
@@ -1559,8 +1559,8 @@ 
 		if ( $field['type'] === 'checkbox' && is_array( $field['value'] ) ) {
 			// Check if there is an "other" val in saved value and make sure the
 			// "other" val is not equal to the Other checkbox option
-			if ( isset( $field['value'][ $opt_key ] ) && $field['options'][ $opt_key ] != $field['value'][ $opt_key ] ) {
-				$other_val = $field['value'][ $opt_key ];
+			if ( isset( $field['value'][$opt_key] ) && $field['options'][$opt_key] != $field['value'][$opt_key] ) {
+				$other_val = $field['value'][$opt_key];
 			}
 		} else {
 			/**
@@ -1572,8 +1572,8 @@ 
 				// Multi-select dropdowns - key is not preserved
 				if ( is_array( $field['value'] ) ) {
 					$o_key = array_search( $temp_val, $field['value'] );
-					if ( isset( $field['value'][ $o_key ] ) ) {
-						unset( $field['value'][ $o_key ], $o_key );
+					if ( isset( $field['value'][$o_key] ) ) {
+						unset( $field['value'][$o_key], $o_key );
 					}
 				} elseif ( $temp_val == $field['value'] ) {
 					// For radio and regular dropdowns
@@ -1798,11 +1798,11 @@ 
 			foreach ( $val as $k => $v ) {
 				if ( is_string( $v ) ) {
 					if ( 'custom_html' === $k ) {
-						$val[ $k ] = self::switch_ids_except_strings( $replace, $replace_with, array( '[if description]', '[description]', '[/if description]' ), $v );
+						$val[$k] = self::switch_ids_except_strings( $replace, $replace_with, array( '[if description]', '[description]', '[/if description]' ), $v );
 						unset( $k, $v );
 						continue;
 					}
-					$val[ $k ] = str_replace( $replace, $replace_with, $v );
+					$val[$k] = str_replace( $replace, $replace_with, $v );
 					unset( $k, $v );
 				}
 			}
@@ -1831,8 +1831,8 @@ 
 			if ( false === $index ) {
 				continue;
 			}
-			unset( $replace[ $index ] );
-			unset( $replace_with[ $index ] );
+			unset( $replace[$index] );
+			unset( $replace_with[$index] );
 		}
 		$value = str_replace( $replace, $replace_with, $value );
 		return $value;
@@ -2190,7 +2190,7 @@ 
 			$countries['class'] = 'frm-countries-opts';
 		}
 
-		$prepop[ __( 'Countries', 'formidable' ) ] = $countries;
+		$prepop[__( 'Countries', 'formidable' )] = $countries;
 
 		// State abv.
 		$states    = self::get_us_states();
@@ -2200,7 +2200,7 @@ 
 			$state_abv['class'] = 'frm-state-abv-opts';
 		}
 
-		$prepop[ __( 'U.S. State Abbreviations', 'formidable' ) ] = $state_abv;
+		$prepop[__( 'U.S. State Abbreviations', 'formidable' )] = $state_abv;
 
 		// States.
 		$states = array_values( $states );
@@ -2209,7 +2209,7 @@ 
 			$states['class'] = 'frm-states-opts';
 		}
 
-		$prepop[ __( 'U.S. States', 'formidable' ) ] = $states;
+		$prepop[__( 'U.S. States', 'formidable' )] = $states;
 		unset( $state_abv, $states );
 
 		// Age.
@@ -2227,7 +2227,7 @@ 
 			$ages['class'] = 'frm-age-opts';
 		}
 
-		$prepop[ __( 'Age', 'formidable' ) ] = $ages;
+		$prepop[__( 'Age', 'formidable' )] = $ages;
 
 		// Satisfaction.
 		$satisfaction = array(
@@ -2242,7 +2242,7 @@ 
 			$satisfaction['class'] = 'frm-satisfaction-opts';
 		}
 
-		$prepop[ __( 'Satisfaction', 'formidable' ) ] = $satisfaction;
+		$prepop[__( 'Satisfaction', 'formidable' )] = $satisfaction;
 
 		// Importance.
 		$importance = array(
@@ -2257,7 +2257,7 @@ 
 			$importance['class'] = 'frm-importance-opts';
 		}
 
-		$prepop[ __( 'Importance', 'formidable' ) ] = $importance;
+		$prepop[__( 'Importance', 'formidable' )] = $importance;
 
 		// Agreement.
 		$agreement = array(
@@ -2272,7 +2272,7 @@ 
 			$agreement['class'] = 'frm-agreement-opts';
 		}
 
-		$prepop[ __( 'Agreement', 'formidable' ) ] = $agreement;
+		$prepop[__( 'Agreement', 'formidable' )] = $agreement;
 
 		// Likely.
 		$likely = array(
@@ -2287,7 +2287,7 @@ 
 			$likely['class'] = 'frm-likely-opts';
 		}
 
-		$prepop[ __( 'Likely', 'formidable' ) ] = $likely;
+		$prepop[__( 'Likely', 'formidable' )] = $likely;
 
 		$prepop = apply_filters( 'frm_bulk_field_choices', $prepop );
 	}
@@ -2516,16 +2516,16 @@ 
 	 */
 	private static function fill_image_setting_options( $options, &$args ) {
 		foreach ( $options as $key => $option ) {
-			$args['options'][ $key ] = $option;
+			$args['options'][$key] = $option;
 
 			if ( ! empty( $option['addon'] ) ) {
-				$args['options'][ $key ]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
+				$args['options'][$key]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
 			}
 
-			unset( $args['options'][ $key ]['addon'] );
+			unset( $args['options'][$key]['addon'] );
 			$fill = array( 'upgrade', 'message', 'content' );
 			foreach ( $fill as $f ) {
-				unset( $args['options'][ $key ][ $f ], $f );
+				unset( $args['options'][$key][$f], $f );
 			}
 		}
 	}
@@ -2548,8 +2548,8 @@ 
 
 		$fill = array( 'upgrade', 'message', 'content' );
 		foreach ( $fill as $f ) {
-			if ( isset( $option[ $f ] ) ) {
-				$custom_attrs[ 'data-' . $f ] = $option[ $f ];
+			if ( isset( $option[$f] ) ) {
+				$custom_attrs['data-' . $f] = $option[$f];
 			}
 		}
 
@@ -2615,7 +2615,7 @@ 
 
 		return array_filter(
 			$rows,
-			function ( $row ) {
+			function( $row ) {
 				FrmAppHelper::unserialize_or_decode( $row->field_options );
 				return is_array( $row->field_options ) && ! empty( $row->field_options['draft'] );
 			}
@@ -2680,7 +2680,7 @@ 
 		if ( empty( $attributes['data-fid'] ) ) {
 			unset( $data['plugin-status'] );
 			foreach ( $data as $key => $value ) {
-				$attributes[ 'data-' . $key ] = $value;
+				$attributes['data-' . $key] = $value;
 			}
 		}
 

Braces +8 added lines, -4 removed lines

@@ -231,7 +231,8 @@ 
 				return false;
 			}
 
-			if ( ! $_POST || ! isset( $_POST['field_options'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			if ( ! $_POST || ! isset( $_POST['field_options'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 				return false;
 			}
 
@@ -338,7 +339,8 @@ 
 	 * @return void
 	 */
 	private static function get_posted_field_setting( $setting, &$value ) {
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( ! isset( $_POST['field_options'][ $setting ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return;
 		}
 
@@ -1531,7 +1533,8 @@ 
 
 		// Check posted vals before checking saved values
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
@@ -1542,7 +1545,8 @@ 
 			return $other_val;
 		}
 
-		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			// For normal fields
 
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {

classes/models/FrmFieldFormHtml.php

Spacing +13 added lines, -13 removed lines

@@ -46,8 +46,8 @@ 
 	 * @return void
 	 */
 	private function _set( $param, $atts ) {
-		if ( isset( $atts[ $param ] ) ) {
-			$this->{$param} = $atts[ $param ];
+		if ( isset( $atts[$param] ) ) {
+			$this->{$param} = $atts[$param];
 		}
 	}
 
@@ -97,8 +97,8 @@ 
 
 		$exclude = array( 'field_obj', 'html' );
 		foreach ( $exclude as $ex ) {
-			if ( isset( $atts[ $ex ] ) ) {
-				unset( $this->pass_args[ $ex ] );
+			if ( isset( $atts[$ex] ) ) {
+				unset( $this->pass_args[$ex] );
 			}
 		}
 	}
@@ -112,8 +112,8 @@ 
 	 * @return void
 	 */
 	private function set_from_field( $atts, $set ) {
-		if ( isset( $atts[ $set['param'] ] ) ) {
-			$this->{$set['param']} = $atts[ $set['param'] ];
+		if ( isset( $atts[$set['param']] ) ) {
+			$this->{$set['param']} = $atts[$set['param']];
 		} else {
 			$this->{$set['param']} = $this->field_obj->get_field_column( $set['default'] );
 		}
@@ -264,7 +264,7 @@ 
 	 */
 	private function replace_error_shortcode() {
 		$this->maybe_add_error_id();
-		$error = $this->pass_args['errors'][ 'field' . $this->field_id ] ?? false;
+		$error = $this->pass_args['errors']['field' . $this->field_id] ?? false;
 
 		if ( ! empty( $error ) && false === strpos( $this->html, 'role="alert"' ) && FrmAppHelper::should_include_alert_role_on_field_errors() ) {
 			$error_body = self::get_error_body( $this->html );
@@ -307,7 +307,7 @@ 
 	 * @return void
 	 */
 	private function maybe_add_error_id() {
-		if ( ! isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ) {
+		if ( ! isset( $this->pass_args['errors']['field' . $this->field_id] ) ) {
 			return;
 		}
 
@@ -399,7 +399,7 @@ 
 		preg_match_all( "/\[(input|deletelink)\b(.*?)(?:(\/))?\]/s", $this->html, $shortcodes, PREG_PATTERN_ORDER );
 
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
-			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
+			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
 			$tag            = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
 
 			$replace_with = '';
@@ -410,7 +410,7 @@ 
 				$replace_with = $this->replace_input_shortcode( $shortcode_atts );
 			}
 
-			$this->html = str_replace( $shortcodes[0][ $short_key ], $replace_with, $this->html );
+			$this->html = str_replace( $shortcodes[0][$short_key], $replace_with, $this->html );
 		}
 	}
 
@@ -432,7 +432,7 @@ 
 	 */
 	private function prepare_input_shortcode_atts( $shortcode_atts ) {
 		if ( isset( $shortcode_atts['opt'] ) ) {
-			--$shortcode_atts['opt'];
+			-- $shortcode_atts['opt'];
 		}
 
 		$field_class = $shortcode_atts['class'] ?? '';
@@ -502,7 +502,7 @@ 
 	 */
 	private function get_field_div_classes() {
 		// Add error class
-		$classes = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? ' frm_blank_field' : '';
+		$classes = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? ' frm_blank_field' : '';
 
 		// Add label position class
 		$settings = $this->field_obj->display_field_settings();
@@ -583,7 +583,7 @@ 
 		}
 
 		// Add 'aria-invalid' attribute to the group if there are errors.
-		if ( isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ) {
+		if ( isset( $this->pass_args['errors']['field' . $this->field_id] ) ) {
 			$attributes['aria-invalid'] = 'true';
 		}