Strategy11 / formidable-forms

classes/helpers/FrmSubmitHelper.php

Spacing +3 added lines, -3 removed lines

@@ -85,7 +85,7 @@ 
 	public static function get_current_action_from_global_var( $form_id ) {
 		global $frm_vars;
 
-		return $frm_vars['form_params'][ $form_id ]['action'] ?? 'create';
+		return $frm_vars['form_params'][$form_id]['action'] ?? 'create';
 	}
 
 	/**
@@ -177,7 +177,7 @@ 
 	public static function remove_submit_field_from_list( &$fields ) {
 		foreach ( $fields as $key => $field ) {
 			if ( self::FIELD_TYPE === FrmField::get_field_type( $field ) ) {
-				unset( $fields[ $key ] );
+				unset( $fields[$key] );
 				return;
 			}
 		}
@@ -224,7 +224,7 @@ 
 				array( 'field_order' => $new_order )
 			);
 			if ( false !== $updated ) {
-				self::$last_row_fields_order[ $last_row_field_id ] = $new_order;
+				self::$last_row_fields_order[$last_row_field_id] = $new_order;
 			}
 		}
 	}

classes/models/FrmSalesApi.php

Spacing +9 added lines, -9 removed lines

@@ -112,8 +112,8 @@ 
 		$cross_sell_links = $data['cross_sell_link'];
 		$index            = self::determine_cross_sell_index( $cross_sell_text );
 
-		self::$cross_sell_text = sanitize_text_field( $cross_sell_text[ $index ] );
-		self::$cross_sell_link = esc_url_raw( $cross_sell_links[ $index ] );
+		self::$cross_sell_text = sanitize_text_field( $cross_sell_text[$index] );
+		self::$cross_sell_link = esc_url_raw( $cross_sell_links[$index] );
 	}
 
 	/**
@@ -158,13 +158,13 @@ 
 		}
 
 		foreach ( $cross_sell_text as $index => $current_text ) {
-			if ( ! isset( $cross_sell_settings[ $current_text ] ) ) {
-				$cross_sell_settings[ $current_text ] = time();
+			if ( ! isset( $cross_sell_settings[$current_text] ) ) {
+				$cross_sell_settings[$current_text] = time();
 				update_option( $option_name, $cross_sell_settings );
 				return $index;
 			}
 
-			$time_elapsed = time() - $cross_sell_settings[ $current_text ];
+			$time_elapsed = time() - $cross_sell_settings[$current_text];
 			if ( $time_elapsed < DAY_IN_SECONDS * 30 ) {
 				return $index;
 			}
@@ -197,7 +197,7 @@ 
 			return;
 		}
 
-		self::$sales[ $sale['key'] ] = $this->fill_sale( $sale );
+		self::$sales[$sale['key']] = $this->fill_sale( $sale );
 	}
 
 	/**
@@ -304,7 +304,7 @@ 
 
 		$sale = self::$instance->get_best_sale();
 
-		return is_array( $sale ) && ! empty( $sale[ $key ] ) ? $sale[ $key ] : false;
+		return is_array( $sale ) && ! empty( $sale[$key] ) ? $sale[$key] : false;
 	}
 
 	/**
@@ -501,14 +501,14 @@ 
 			esc_html( self::$cross_sell_text ),
 			'activate_plugins',
 			'frm-sales-api-cross-sell',
-			function () {
+			function() {
 				// There is no page. The redirect logic is handled below, before this callback is triggered.
 			}
 		);
 
 		add_action(
 			'admin_init',
-			function () {
+			function() {
 				if ( ! current_user_can( 'activate_plugins' ) ) {
 					return;
 				}

classes/controllers/FrmAddonsController.php

Spacing +26 added lines, -28 removed lines

@@ -116,7 +116,7 @@ 
 				'<span class="frm-upgrade-submenu">' . esc_html( $cta_text ) . '</span>',
 				'frm_view_forms',
 				'formidable-pro-upgrade',
-				function () {
+				function() {
 					// This function doesn't need to do anything.
 					// The redirect is handled earlier to avoid issues with the headers being sent.
 				}
@@ -147,7 +147,7 @@ 
 			unset( $addons['error'] );
 		}
 
-		$pro    = array(
+		$pro = array(
 			'pro' => array(
 				'title'      => 'Formidable Forms Pro',
 				'slug'       => 'formidable-pro',
@@ -189,9 +189,9 @@ 
 
 		// Extract the elements to move
 		foreach ( $plans as $plan ) {
-			if ( isset( self::$categories[ $plan ] ) ) {
-				$bottom_categories[ $plan ] = self::$categories[ $plan ];
-				unset( self::$categories[ $plan ] );
+			if ( isset( self::$categories[$plan] ) ) {
+				$bottom_categories[$plan] = self::$categories[$plan];
+				unset( self::$categories[$plan] );
 			}
 		}
 
@@ -245,14 +245,12 @@ 
 			// Add the slug to the new array.
 			$addon['category-slugs'][] = $category_slug;
 
-			if ( ! isset( self::$categories[ $category_slug ] ) ) {
-				self::$categories[ $category_slug ] = array(
+			if ( ! isset( self::$categories[$category_slug] ) ) {
+				self::$categories[$category_slug] = array(
 					'name'  => $category,
 					'count' => 0,
 				);
-			}
-
-			++self::$categories[ $category_slug ]['count'];
+			} ++self::$categories[$category_slug]['count'];
 		}
 	}
 
@@ -284,7 +282,7 @@ 
 		} else {
 			foreach ( $addons as $k => $addon ) {
 				if ( empty( $addon['excerpt'] ) && $k !== 'error' ) {
-					unset( $addons[ $k ] );
+					unset( $addons[$k] );
 				}
 			}
 		}
@@ -398,7 +396,7 @@ 
 
 		foreach ( $list as $k => $info ) {
 			$info['slug'] = $k;
-			$list[ $k ]   = array_merge( $defaults, $info );
+			$list[$k]   = array_merge( $defaults, $info );
 		}
 		return $list;
 	}
@@ -549,17 +547,17 @@ 
 				continue;
 			}
 
-			$wp_plugin    = $wp_plugins[ $folder ] ?? array();
+			$wp_plugin    = $wp_plugins[$folder] ?? array();
 			$wp_version   = $wp_plugin['Version'] ?? '1.0';
 			$plugin->slug = explode( '/', $folder )[0];
 
 			if ( version_compare( $wp_version, $plugin->new_version, '<' ) ) {
-				$transient->response[ $folder ] = $plugin;
+				$transient->response[$folder] = $plugin;
 			} else {
-				$transient->no_update[ $folder ] = $plugin;
+				$transient->no_update[$folder] = $plugin;
 			}
 
-			$transient->checked[ $folder ] = $wp_version;
+			$transient->checked[$folder] = $wp_version;
 
 		}//end foreach
 
@@ -592,7 +590,7 @@ 
 	 */
 	protected static function is_installed( $plugin ) {
 		$all_plugins = self::get_plugins();
-		return isset( $all_plugins[ $plugin ] );
+		return isset( $all_plugins[$plugin] );
 	}
 
 	/**
@@ -631,13 +629,13 @@ 
 			}
 
 			$download_id = $plugin['id'] ?? 0;
-			if ( ! empty( $download_id ) && ! isset( $version_info[ $download_id ]['package'] ) ) {
+			if ( ! empty( $download_id ) && ! isset( $version_info[$download_id]['package'] ) ) {
 				// if this addon is using its own license, get the update url
 				$addon_info = $api->get_api_info();
 
-				$version_info[ $download_id ] = $addon_info[ $download_id ];
+				$version_info[$download_id] = $addon_info[$download_id];
 				if ( isset( $addon_info['error'] ) ) {
-					$version_info[ $download_id ]['error'] = array(
+					$version_info[$download_id]['error'] = array(
 						'message' => $addon_info['error']['message'],
 						'code'    => $addon_info['error']['code'],
 					);
@@ -736,8 +734,8 @@ 
 					return $addon;
 				}
 			}
-		} elseif ( isset( $addons[ $download_id ] ) ) {
-			$plugin = $addons[ $download_id ];
+		} elseif ( isset( $addons[$download_id] ) ) {
+			$plugin = $addons[$download_id];
 		}
 
 		return $plugin;
@@ -803,7 +801,7 @@ 
 			self::set_addon_status( $addon );
 			self::set_categories( $addon );
 
-			$addons[ $id ] = $addon;
+			$addons[$id] = $addon;
 		}//end foreach
 	}
 
@@ -838,7 +836,7 @@ 
 		if ( strpos( $link, 'http' ) !== 0 ) {
 			$link = $site_url . $link;
 		}
-		$link       = FrmAppHelper::make_affiliate_url( $link );
+		$link = FrmAppHelper::make_affiliate_url( $link );
 
 		$utm  = array(
 			'campaign' => 'addons',
@@ -1061,7 +1059,7 @@ 
 	 */
 	public static function ajax_activate_addon() {
 		self::process_addon_action(
-			function ( $plugin ) {
+			function( $plugin ) {
 				return self::handle_addon_action( $plugin, 'activate' );
 			},
 			array( 'FrmAddonsController', 'get_addon_activation_response' )
@@ -1086,7 +1084,7 @@ 
 	 */
 	public static function ajax_deactivate_addon() {
 		self::process_addon_action(
-			function ( $plugin ) {
+			function( $plugin ) {
 				return self::handle_addon_action( $plugin, 'deactivate' );
 			}
 		);
@@ -1101,7 +1099,7 @@ 
 	 */
 	public static function ajax_uninstall_addon() {
 		self::process_addon_action(
-			function ( $plugin ) {
+			function( $plugin ) {
 				return self::handle_addon_action( $plugin, 'uninstall' );
 			}
 		);
@@ -1499,7 +1497,7 @@ 
 		$addons = $api->get_api_info();
 
 		if ( is_array( $addons ) && array_key_exists( $addon_id, $addons ) ) {
-			$dates    = $addons[ $addon_id ];
+			$dates    = $addons[$addon_id];
 			$requires = FrmFormsHelper::get_plan_required( $dates );
 		}
 

classes/controllers/FrmAppController.php

Spacing +10 added lines, -10 removed lines

@@ -1334,11 +1334,11 @@ 
 			wp_set_script_translations( 's11-floating-links-config', 's11-' );
 		}
 
-		$upgrade_utm         = array(
+		$upgrade_utm = array(
 			'campaign' => 'floating-links',
 			'content'  => 'floating-links-upgrade',
 		);
-		$docs_utm            = array(
+		$docs_utm = array(
 			'campaign' => 'floating-links',
 			'content'  => 'floating-links-docs',
 		);
@@ -1412,15 +1412,15 @@ 
 		global $wp_filter;
 
 		foreach ( $actions as $action ) {
-			if ( empty( $wp_filter[ $action ]->callbacks ) ) {
+			if ( empty( $wp_filter[$action]->callbacks ) ) {
 				continue;
 			}
-			foreach ( $wp_filter[ $action ]->callbacks as $priority => $callbacks ) {
+			foreach ( $wp_filter[$action]->callbacks as $priority => $callbacks ) {
 				foreach ( $callbacks as $callback_name => $callback ) {
 					if ( self::is_our_callback_string( $callback_name ) || self::is_our_callback_array( $callback ) ) {
 						continue;
 					}
-					unset( $wp_filter[ $action ]->callbacks[ $priority ][ $callback_name ] );
+					unset( $wp_filter[$action]->callbacks[$priority][$callback_name] );
 				}
 			}
 		}
@@ -1458,8 +1458,8 @@ 
 		$current_sort  = $previous_meta;
 		$form_id       = $is_entry_list ? FrmAppHelper::simple_get( 'form', 'absint' ) : 0;
 
-		if ( is_array( $current_sort ) && $form_id && is_int( $form_id ) && isset( $current_sort[ $form_id ] ) ) {
-			$current_sort = $current_sort[ $form_id ];
+		if ( is_array( $current_sort ) && $form_id && is_int( $form_id ) && isset( $current_sort[$form_id] ) ) {
+			$current_sort = $current_sort[$form_id];
 		}
 
 		if ( $new_sort !== $current_sort ) {
@@ -1468,7 +1468,7 @@ 
 			if ( $is_entry_list && $form_id && is_int( $form_id ) ) {
 				// Index meta by form ID.
 				$temp_meta             = is_array( $previous_meta ) ? $previous_meta : array();
-				$temp_meta[ $form_id ] = $new_meta;
+				$temp_meta[$form_id] = $new_meta;
 				$new_meta              = $temp_meta;
 				unset( $temp_meta );
 			}
@@ -1496,8 +1496,8 @@ 
 		$preferred_list_sort = get_user_meta( $user_id, $meta_key, true );
 		$form_id             = FrmAppHelper::simple_get( 'form', 'absint' );
 
-		if ( is_array( $preferred_list_sort ) && $form_id && is_int( $form_id ) && isset( $preferred_list_sort[ $form_id ] ) ) {
-			$preferred_list_sort = $preferred_list_sort[ $form_id ];
+		if ( is_array( $preferred_list_sort ) && $form_id && is_int( $form_id ) && isset( $preferred_list_sort[$form_id] ) ) {
+			$preferred_list_sort = $preferred_list_sort[$form_id];
 		}
 
 		if ( is_array( $preferred_list_sort ) && ! empty( $preferred_list_sort['orderby'] ) ) {

classes/views/addons/min-version-notice.php

Braces +5 added lines, -2 removed lines

@@ -14,7 +14,10 @@
 		);
 		?>
 		Please <a href="<?php echo esc_url( FrmAppHelper::admin_upgrade_link( $utm, 'account/downloads/' ) ); ?>">renew now</a> to get the latest version.
-	<?php else : ?>
-		Please <a href="<?php echo esc_url( admin_url( 'plugins.php?s=formidable%20forms%20pro' ) ); ?>">update now</a>.
+	<?php else {
+	: ?>
+		Please <a href="<?php echo esc_url( admin_url( 'plugins.php?s=formidable%20forms%20pro' ) );
+}
+?>">update now</a>.
 	<?php endif; ?>
 </div>

classes/controllers/FrmWelcomeTourController.php

Spacing +11 added lines, -11 removed lines

@@ -118,7 +118,7 @@ 
 		$active_step = 0;
 
 		foreach ( $step_keys as $index => $step_key ) {
-			$completed_step = isset( self::$checklist['completed_steps'][ $step_key ] );
+			$completed_step = isset( self::$checklist['completed_steps'][$step_key] );
 
 			if ( false === $completed_step ) {
 				switch ( $step_key ) {
@@ -132,15 +132,15 @@ 
 			}
 
 			if ( $completed_step ) {
-				self::$checklist['completed_steps'][ $step_key ] = true;
+				self::$checklist['completed_steps'][$step_key] = true;
 			}
 
 			// Count completed steps from start until gap found.
 			if ( $completed_step && $index === $active_step ) {
-				$active_step++;
+				$active_step ++;
 			}
 
-			self::$steps['steps'][ $index ]['completed'] = $completed_step;
+			self::$steps['steps'][$index]['completed'] = $completed_step;
 		}//end foreach
 
 		self::$checklist['active_step'] = $active_step;
@@ -149,7 +149,7 @@ 
 			self::$checklist['done']            = true;
 			self::$checklist['active_step_key'] = 'completed';
 		} else {
-			self::$checklist['active_step_key'] = $step_keys[ $active_step ];
+			self::$checklist['active_step_key'] = $step_keys[$active_step];
 		}
 
 		self::save_checklist();
@@ -199,8 +199,8 @@ 
 	 */
 	private static function fill_step_completed_data( $steps, $steps_keys ) {
 		return array_map(
-			function ( $step, $step_key ) {
-				$step['completed'] = isset( self::$checklist['completed_steps'][ $step_key ] );
+			function( $step, $step_key ) {
+				$step['completed'] = isset( self::$checklist['completed_steps'][$step_key] );
 				return $step;
 			},
 			$steps,
@@ -234,7 +234,7 @@ 
 					'target'        => '#frm_style_sidebar .frm-style-card > div',
 					'left-position' => 'end',
 					'offset'        => array(
-						'top'  => -22,
+						'top'  => - 22,
 						'left' => 16,
 					),
 				);
@@ -250,7 +250,7 @@ 
 				break;
 		}//end switch
 
-		return array_merge( self::$steps['steps'][ self::$checklist['active_step'] ], $spotlight_data );
+		return array_merge( self::$steps['steps'][self::$checklist['active_step']], $spotlight_data );
 	}
 
 	/**
@@ -377,7 +377,7 @@ 
 		}
 
 		self::$checklist                                 = self::get_checklist();
-		self::$checklist['completed_steps'][ $step_key ] = true;
+		self::$checklist['completed_steps'][$step_key] = true;
 		self::save_checklist();
 
 		wp_send_json_success();
@@ -591,7 +591,7 @@ 
 		$steps      = self::get_steps();
 
 		foreach ( $steps as $key => $step ) {
-			$usage_data[ 'completed_step_' . $key ] = empty( $option['completed_steps'][ $key ] ) ? 0 : 1;
+			$usage_data['completed_step_' . $key] = empty( $option['completed_steps'][$key] ) ? 0 : 1;
 		}
 
 		$usage_data['done'] = empty( $option['done'] ) ? 0 : 1;

classes/models/FrmEntryMeta.php

Spacing +11 added lines, -11 removed lines

@@ -58,7 +58,7 @@ 
 
 		global $wpdb;
 
-		$values               = array(
+		$values = array(
 			'item_id'  => $entry_id,
 			'field_id' => $field_id,
 		);
@@ -138,7 +138,7 @@ 
 				}
 			}
 
-			$values_indexed_by_field_id[ $field_id ] = $meta_value;
+			$values_indexed_by_field_id[$field_id] = $meta_value;
 
 			self::get_value_to_save( compact( 'field', 'field_id', 'entry_id' ), $meta_value );
 
@@ -146,7 +146,7 @@ 
 
 				if ( ( is_array( $meta_value ) && empty( $meta_value ) ) || ( ! is_array( $meta_value ) && trim( $meta_value ) === '' ) ) {
 					// Remove blank fields.
-					unset( $values_indexed_by_field_id[ $field_id ] );
+					unset( $values_indexed_by_field_id[$field_id] );
 				} else {
 					// if value exists, then update it
 					self::update_entry_meta( $entry_id, $field_id, '', $meta_value );
@@ -224,7 +224,7 @@ 
 	 */
 	public static function get_meta_value( $entry, $field_id ) {
 		if ( isset( $entry->metas ) ) {
-			return $entry->metas[ $field_id ] ?? false;
+			return $entry->metas[$field_id] ?? false;
 		}
 		return self::get_entry_meta_by_field( $entry->id, $field_id );
 	}
@@ -246,8 +246,8 @@ 
 			$cached   = FrmDb::check_cache( $entry_id, 'frm_entry' );
 		}
 
-		if ( $cached && isset( $cached->metas ) && isset( $cached->metas[ $field_id ] ) ) {
-			$result = $cached->metas[ $field_id ];
+		if ( $cached && isset( $cached->metas ) && isset( $cached->metas[$field_id] ) ) {
+			$result = $cached->metas[$field_id];
 
 			return wp_unslash( $result );
 		}
@@ -280,7 +280,7 @@ 
 			'stripslashes' => true,
 			'is_draft'     => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		$query = array();
 		self::meta_field_query( $field_id, $order, $limit, $args, $query );
@@ -295,7 +295,7 @@ 
 
 		foreach ( $values as $k => $v ) {
 			FrmAppHelper::unserialize_or_decode( $v );
-			$values[ $k ] = $v;
+			$values[$k] = $v;
 			unset( $k, $v );
 		}
 
@@ -362,7 +362,7 @@ 
 
 		foreach ( $results as $k => $result ) {
 			FrmAppHelper::unserialize_or_decode( $result->meta_value );
-			$results[ $k ]->meta_value = wp_unslash( $result->meta_value );
+			$results[$k]->meta_value = wp_unslash( $result->meta_value );
 			unset( $k, $result );
 		}
 
@@ -375,7 +375,7 @@ 
 			'user_id'  => '',
 			'group_by' => '',
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		$query = array();
 		self::get_ids_query( $where, $order_by, $limit, $unique, $args, $query );
@@ -478,7 +478,7 @@ 
 			} elseif ( false !== strpos( $args['is_draft'], ',' ) ) {
 				$is_draft = array_reduce(
 					explode( ',', $args['is_draft'] ),
-					function ( $total, $current ) {
+					function( $total, $current ) {
 						if ( is_numeric( $current ) ) {
 							$total[] = absint( $current );
 						}

classes/models/FrmForm.php

Spacing +32 added lines, -32 removed lines

@@ -216,7 +216,7 @@ 
 			}
 
 			if ( $new_val !== $value ) {
-				$new_values[ $key ] = $new_val;
+				$new_values[$key] = $new_val;
 			}
 		}//end foreach
 
@@ -253,7 +253,7 @@ 
 
 		foreach ( $values as $value_key => $value ) {
 			if ( $value_key && in_array( $value_key, $form_fields ) ) {
-				$new_values[ $value_key ] = $value;
+				$new_values[$value_key] = $value;
 			}
 		}
 
@@ -338,15 +338,15 @@ 
 		$existing_keys = array_keys( $values['item_meta'] );
 		foreach ( $all_fields as $fid ) {
 			if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
-				$values['item_meta'][ $fid->id ] = '';
+				$values['item_meta'][$fid->id] = '';
 			}
-			$field_array[ $fid->id ] = $fid;
+			$field_array[$fid->id] = $fid;
 		}
 		unset( $all_fields );
 
 		foreach ( $values['item_meta'] as $field_id => $default_value ) {
-			if ( isset( $field_array[ $field_id ] ) ) {
-				$field = $field_array[ $field_id ];
+			if ( isset( $field_array[$field_id] ) ) {
+				$field = $field_array[$field_id];
 			} else {
 				$field = FrmField::getOne( $field_id );
 			}
@@ -355,7 +355,7 @@ 
 				continue;
 			}
 
-			$is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
+			$is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options']['custom_html_' . $field_id] ) );
 			if ( $is_settings_page ) {
 				self::get_settings_page_html( $values, $field );
 
@@ -375,22 +375,22 @@ 
 			}
 
 			foreach ( $update_options as $opt => $default ) {
-				$field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default;
-				self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
+				$field->field_options[$opt] = $values['field_options'][$opt . '_' . $field_id] ?? $default;
+				self::sanitize_field_opt( $opt, $field->field_options[$opt] );
 			}
 
 			$field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
 
 			$new_field = array(
 				'field_options' => $field->field_options,
-				'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
+				'default_value' => isset( $values['default_value_' . $field_id] ) ? FrmAppHelper::maybe_json_encode( $values['default_value_' . $field_id] ) : '',
 			);
 
-			if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) {
-				foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
+			if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options']['options_' . $field_id] ) && is_array( $values['field_options']['options_' . $field_id] ) ) {
+				foreach ( $values['field_options']['options_' . $field_id] as $option_key => $option ) {
 					if ( is_array( $option ) ) {
 						foreach ( $option as $key => $item ) {
-							$values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
+							$values['field_options']['options_' . $field_id][$option_key][$key] = FrmAppHelper::kses( $item, 'all' );
 						}
 					}
 				}
@@ -420,8 +420,8 @@ 
 	 */
 	private static function maybe_update_max_option( $field, $values, &$new_field ) {
 		if ( $field->type === 'textarea' &&
-			! empty( $values['field_options'][ 'type_' . $field->id ] ) &&
-			in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
+			! empty( $values['field_options']['type_' . $field->id] ) &&
+			in_array( $values['field_options']['type_' . $field->id], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
 
 			$new_field['field_options']['max'] = '';
 
@@ -429,7 +429,7 @@ 
 			 * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
 			 * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
 			 */
-			$_POST['field_options'][ 'max_' . $field->id ] = '';
+			$_POST['field_options']['max_' . $field->id] = '';
 		}
 	}
 
@@ -511,11 +511,11 @@ 
 	 * @return void
 	 */
 	private static function get_settings_page_html( $values, &$field ) {
-		if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
+		if ( isset( $values['field_options']['custom_html_' . $field->id] ) ) {
 			$prev_opts     = array();
 			$fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type );
 
-			$field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html;
+			$field->field_options['custom_html'] = $values['field_options']['custom_html_' . $field->id] ?? $fallback_html;
 		} elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
 			$prev_opts = $field->field_options;
 		}
@@ -540,7 +540,7 @@ 
 		);
 		foreach ( $field_cols as $col => $default ) {
 			$default           = $default === '' ? $field->{$col} : $default;
-			$new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default;
+			$new_field[$col] = $values['field_options'][$col . '_' . $field->id] ?? $default;
 		}
 
 		if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
@@ -734,7 +734,7 @@ 
 			if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) {
 				self::destroy( $form->id );
 				if ( empty( $form->parent_form_id ) ) {
-					++$count;
+					++ $count;
 				}
 			}
 
@@ -961,16 +961,16 @@ 
 		foreach ( $results as $row ) {
 			if ( 'trash' != $row->status ) {
 				if ( $row->is_template ) {
-					++$counts['template'];
+					++ $counts['template'];
 				} else {
-					++$counts['published'];
+					++ $counts['published'];
 				}
 			} else {
-				++$counts['trash'];
+				++ $counts['trash'];
 			}
 
 			if ( 'draft' == $row->status ) {
-				++$counts['draft'];
+				++ $counts['draft'];
 			}
 
 			unset( $row );
@@ -1011,8 +1011,8 @@ 
 			self::maybe_get_form( $form );
 		}
 
-		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
-			return $frm_vars['form_params'][ $form->id ];
+		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][$form->id] ) ) {
+			return $frm_vars['form_params'][$form->id];
 		}
 
 		$action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -1041,15 +1041,15 @@ 
 			// If there are two forms on the same page, make sure not to submit both.
 			foreach ( $default_values as $var => $default ) {
 				if ( $var === 'action' ) {
-					$values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
+					$values[$var] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
 				} else {
-					$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+					$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 				}
 				unset( $var, $default );
 			}
 		} else {
 			foreach ( $default_values as $var => $default ) {
-				$values[ $var ] = $default;
+				$values[$var] = $default;
 				unset( $var, $default );
 			}
 		}
@@ -1075,7 +1075,7 @@ 
 			'sdir'     => '',
 		);
 		foreach ( $defaults as $var => $default ) {
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 		}
 
 		return $values;
@@ -1103,7 +1103,7 @@ 
 			'keep_post' => '',
 		);
 		foreach ( $defaults as $var => $default ) {
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 		}
 
 		return $values;
@@ -1217,7 +1217,7 @@ 
 		$form    = $atts['form'];
 		$default = $atts['default'] ?? '';
 
-		return $form->options[ $atts['option'] ] ?? $default;
+		return $form->options[$atts['option']] ?? $default;
 	}
 
 	/**

classes/helpers/FrmEntriesHelper.php

Braces +14 added lines, -7 removed lines

@@ -134,13 +134,16 @@ 
 	 */
 	public static function value_is_posted( $field, $args ) {
 		$value_is_posted = false;
-		if ( $_POST ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( $_POST ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			$repeating = isset( $args['repeating'] ) && $args['repeating'];
 			if ( $repeating ) {
-				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 					$value_is_posted = true;
 				}
-			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$value_is_posted = true;
 			}
 		}
@@ -363,8 +366,10 @@ 
 	 * @return void
 	 */
 	private static function set_parent_field_posted_value( $field, $value, $args ) {
-		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) && is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
-			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) || ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) && is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
+			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) || ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			}
 		} else {
@@ -446,7 +451,8 @@ 
 		self::set_other_repeating_vals( $field, $value, $args );
 
 		// Check if there are any posted "Other" values.
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 
 			// Save original value.
 			$args['temp_value'] = $value;
@@ -476,7 +482,8 @@ 
 		}
 
 		// Check if there are any other posted "other" values for this field.
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			// Save original value
 			$args['temp_value'] = $value;
 			$args['other']      = true;

Spacing +29 added lines, -29 removed lines

@@ -145,10 +145,10 @@ 
 		if ( $_POST ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			$repeating = isset( $args['repeating'] ) && $args['repeating'];
 			if ( $repeating ) {
-				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+				if ( isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 					$value_is_posted = true;
 				}
-			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			} elseif ( isset( $_POST['item_meta'][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$value_is_posted = true;
 			}
 		}
@@ -192,7 +192,7 @@ 
 		preg_match_all( "/\[(default-message|default_message)\b(.*?)(?:(\/))?\]/s", $message, $shortcodes, PREG_PATTERN_ORDER );
 
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
-			$add_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
+			$add_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
 			if ( ! empty( $add_atts ) ) {
 				$this_atts = array_merge( $atts, $add_atts );
 			} else {
@@ -202,7 +202,7 @@ 
 			$default = FrmEntriesController::show_entry_shortcode( $this_atts );
 
 			// Add the default message.
-			$message = str_replace( $shortcodes[0][ $short_key ], $default, $message );
+			$message = str_replace( $shortcodes[0][$short_key], $default, $message );
 		}
 
 		return $message;
@@ -215,7 +215,7 @@ 
 	 * @return string
 	 */
 	public static function prepare_display_value( $entry, $field, $atts ) {
-		$field_value = $entry->metas[ $field->id ] ?? false;
+		$field_value = $entry->metas[$field->id] ?? false;
 
 		if ( FrmAppHelper::pro_is_installed() ) {
 			$empty = empty( $field_value );
@@ -243,7 +243,7 @@ 
 			$child_entries = FrmEntry::getAll( array( 'it.parent_item_id' => $entry->id ), '', '', true );
 		} else {
 			// Get all values for this field.
-			$child_values = $entry->metas[ $atts['embedded_field_id'] ] ?? false;
+			$child_values = $entry->metas[$atts['embedded_field_id']] ?? false;
 
 			if ( $child_values ) {
 				$child_entries = FrmEntry::getAll( array( 'it.id' => (array) $child_values ) );
@@ -372,7 +372,7 @@ 
 			$value = $args['temp_value'];
 		}
 		if ( empty( $args['parent_field_id'] ) ) {
-			$_POST['item_meta'][ $field->id ] = $value;
+			$_POST['item_meta'][$field->id] = $value;
 		} else {
 			self::set_parent_field_posted_value( $field, $value, $args );
 		}
@@ -390,17 +390,17 @@ 
 	 * @return void
 	 */
 	private static function set_parent_field_posted_value( $field, $value, $args ) {
-		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) && is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
-			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) || ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
-				$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $_POST['item_meta'][$args['parent_field_id']] ) && is_array( $_POST['item_meta'][$args['parent_field_id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			if ( ! isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] ) || ! is_array( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+				$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			}
 		} else {
 			// All of the section was probably removed.
-			$_POST['item_meta'][ $args['parent_field_id'] ]                         = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
-			$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			$_POST['item_meta'][$args['parent_field_id']]                         = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 		}
 
-		$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] = $value; // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field->id] = $value; // phpcs:ignore WordPress.Security.NonceVerification.Missing
 	}
 
 	/**
@@ -447,9 +447,9 @@ 
 	private static function get_posted_meta( $field_id, $args ) {
 		if ( empty( $args['parent_field_id'] ) ) {
 			// Sanitizing is done next.
-			$value = isset( $_POST['item_meta'][ $field_id ] ) ? wp_unslash( $_POST['item_meta'][ $field_id ] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$value = isset( $_POST['item_meta'][$field_id] ) ? wp_unslash( $_POST['item_meta'][$field_id] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 		} else {
-			$value = isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field_id ] ) ? wp_unslash( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field_id ] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$value = isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field_id] ) ? wp_unslash( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field_id] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 		}
 		return $value;
 	}
@@ -480,14 +480,14 @@ 
 		self::set_other_repeating_vals( $field, $value, $args );
 
 		// Check if there are any posted "Other" values.
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 
 			// Save original value.
 			$args['temp_value'] = $value;
 			$args['other']      = true;
 
 			// Sanitizing is done next.
-			$other_vals = wp_unslash( $_POST['item_meta']['other'][ $field->id ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$other_vals = wp_unslash( $_POST['item_meta']['other'][$field->id] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 			FrmAppHelper::sanitize_value( 'sanitize_text_field', $other_vals );
 
 			// Set the validation value now
@@ -510,12 +510,12 @@ 
 		}
 
 		// Check if there are any other posted "other" values for this field.
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']]['other'][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			// Save original value
 			$args['temp_value'] = $value;
 			$args['other']      = true;
 
-			$other_vals = wp_unslash( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$other_vals = wp_unslash( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']]['other'][$field->id] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 			FrmAppHelper::sanitize_value( 'sanitize_text_field', $other_vals );
 
 			// Set the validation value now.
@@ -542,7 +542,7 @@ 
 		if ( is_array( $value ) && $field->type === 'checkbox' ) {
 			// Combine "Other" values with checked values. "Other" values will override checked box values.
 			foreach ( $other_vals as $k => $v ) {
-				if ( isset( $value[ $k ] ) && trim( $v ) === '' ) {
+				if ( isset( $value[$k] ) && trim( $v ) === '' ) {
 					// If the other box is checked, but doesn't have a value.
 					$value = '';
 					break;
@@ -559,25 +559,25 @@ 
 
 			// Multi-select dropdown.
 			if ( is_array( $value ) ) {
-				$o_key = array_search( $field->options[ $other_key ], $value );
+				$o_key = array_search( $field->options[$other_key], $value );
 
 				if ( $o_key !== false ) {
 					// Modify the original value so other key will be preserved.
-					$value[ $other_key ] = $value[ $o_key ];
+					$value[$other_key] = $value[$o_key];
 
 					// By default, the array keys will be numeric for multi-select dropdowns.
 					// If going backwards and forwards between pages, the array key will match the other key.
 					if ( $o_key !== $other_key ) {
-						unset( $value[ $o_key ] );
+						unset( $value[$o_key] );
 					}
 
 					$args['temp_value']  = $value;
-					$value[ $other_key ] = reset( $other_vals );
-					if ( FrmAppHelper::is_empty_value( $value[ $other_key ] ) ) {
-						unset( $value[ $other_key ] );
+					$value[$other_key] = reset( $other_vals );
+					if ( FrmAppHelper::is_empty_value( $value[$other_key] ) ) {
+						unset( $value[$other_key] );
 					}
 				}
-			} elseif ( $field->options[ $other_key ] == $value ) {
+			} elseif ( $field->options[$other_key] == $value ) {
 				$value = $other_vals;
 			}//end if
 		}//end if
@@ -831,7 +831,7 @@ 
 	 * @return void
 	 */
 	public static function maybe_render_captcha_score( $entry_id ) {
-		$query                 = array(
+		$query = array(
 			'item_id'  => (int) $entry_id,
 			'field_id' => 0,
 		);
@@ -885,7 +885,7 @@ 
 	public static function get_entry_status_label( $status ) {
 		$statuses = self::get_entry_statuses();
 
-		return $statuses[ self::get_entry_status( $status ) ];
+		return $statuses[self::get_entry_status( $status )];
 	}
 
 	/**