Completed
Pull Request — master (#1580)
by Stephanie
52s
created
classes/controllers/FrmSettingsController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 				$section['function'] = $original;
159 159
 			}
160 160
 
161
-			$sections[ $key ] = $section;
161
+			$sections[$key] = $section;
162 162
 		}//end foreach
163 163
 
164 164
 		return $sections;
@@ -170,11 +170,11 @@  discard block
 block discarded – undo
170 170
 
171 171
 		$section  = FrmAppHelper::get_post_param( 'tab', '', 'sanitize_text_field' );
172 172
 		$sections = self::get_settings_tabs();
173
-		if ( ! isset( $sections[ $section ] ) ) {
173
+		if ( ! isset( $sections[$section] ) ) {
174 174
 			wp_die();
175 175
 		}
176 176
 
177
-		$section = $sections[ $section ];
177
+		$section = $sections[$section];
178 178
 
179 179
 		if ( isset( $section['class'] ) ) {
180 180
 			call_user_func( array( $section['class'], $section['function'] ) );
Please login to merge, or discard this patch.
classes/controllers/FrmFormsController.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1616,7 +1616,8 @@  discard block
 block discarded – undo
1616 1616
 		$vars   = array();
1617 1617
 		FrmAppHelper::include_svg();
1618 1618
 
1619
-		if ( isset( $_POST['frm_compact_fields'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1619
+		if ( isset( $_POST['frm_compact_fields'] ) ) {
1620
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1620 1621
 			FrmAppHelper::permission_check( 'frm_edit_forms' );
1621 1622
 
1622 1623
 			// Javascript needs to be allowed in some field settings.
@@ -2046,7 +2047,8 @@  discard block
 block discarded – undo
2046 2047
 	private static function get_saved_errors( $form, $params ) {
2047 2048
 		global $frm_vars;
2048 2049
 
2049
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2050
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) {
2051
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
2050 2052
 			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
2051 2053
 		} else {
2052 2054
 			$errors = array();
Please login to merge, or discard this patch.
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -675,11 +675,11 @@  discard block
 block discarded – undo
675 675
 			),
676 676
 		);
677 677
 
678
-		if ( ! isset( $available_status[ $status ] ) ) {
678
+		if ( ! isset( $available_status[$status] ) ) {
679 679
 			return;
680 680
 		}
681 681
 
682
-		FrmAppHelper::permission_check( $available_status[ $status ]['permission'] );
682
+		FrmAppHelper::permission_check( $available_status[$status]['permission'] );
683 683
 
684 684
 		$params = FrmForm::list_page_params();
685 685
 
@@ -687,8 +687,8 @@  discard block
 block discarded – undo
687 687
 		check_admin_referer( $status . '_form_' . $params['id'] );
688 688
 
689 689
 		$count = 0;
690
-		if ( FrmForm::set_status( $params['id'], $available_status[ $status ]['new_status'] ) ) {
691
-			++$count;
690
+		if ( FrmForm::set_status( $params['id'], $available_status[$status]['new_status'] ) ) {
691
+			++ $count;
692 692
 		}
693 693
 
694 694
 		$form_type = FrmAppHelper::get_simple_request(
@@ -704,7 +704,7 @@  discard block
 block discarded – undo
704 704
 		/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
705 705
 		$available_status['trash']['message'] = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' );
706 706
 
707
-		$message = $available_status[ $status ]['message'];
707
+		$message = $available_status[$status]['message'];
708 708
 
709 709
 		self::display_forms_list( $params, $message );
710 710
 	}
@@ -715,7 +715,7 @@  discard block
 block discarded – undo
715 715
 		$count = 0;
716 716
 		foreach ( $ids as $id ) {
717 717
 			if ( FrmForm::trash( $id ) ) {
718
-				++$count;
718
+				++ $count;
719 719
 			}
720 720
 		}
721 721
 
@@ -725,7 +725,7 @@  discard block
 block discarded – undo
725 725
 				'type'  => 'request',
726 726
 			)
727 727
 		);
728
-		$message      = sprintf(
728
+		$message = sprintf(
729 729
 			/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
730 730
 			_n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ),
731 731
 			$count,
@@ -746,7 +746,7 @@  discard block
 block discarded – undo
746 746
 
747 747
 		$count = 0;
748 748
 		if ( FrmForm::destroy( $params['id'] ) ) {
749
-			++$count;
749
+			++ $count;
750 750
 		}
751 751
 
752 752
 		/* translators: %1$s: Number of forms */
@@ -762,7 +762,7 @@  discard block
 block discarded – undo
762 762
 		foreach ( $ids as $id ) {
763 763
 			$d = FrmForm::destroy( $id );
764 764
 			if ( $d ) {
765
-				++$count;
765
+				++ $count;
766 766
 			}
767 767
 		}
768 768
 
@@ -1309,7 +1309,7 @@  discard block
 block discarded – undo
1309 1309
 
1310 1310
 		foreach ( array( 'landing', 'chat', 'abandonment' ) as $feature ) {
1311 1311
 			if ( ! FrmAppHelper::show_new_feature( $feature ) ) {
1312
-				unset( $sections[ $feature ] );
1312
+				unset( $sections[$feature] );
1313 1313
 			}
1314 1314
 		}
1315 1315
 
@@ -1342,7 +1342,7 @@  discard block
 block discarded – undo
1342 1342
 				$section['id'] = $section['anchor'];
1343 1343
 			}
1344 1344
 
1345
-			$sections[ $key ] = $section;
1345
+			$sections[$key] = $section;
1346 1346
 		}//end foreach
1347 1347
 
1348 1348
 		return $sections;
@@ -1465,7 +1465,7 @@  discard block
 block discarded – undo
1465 1465
 		if ( ! empty( $user_fields ) ) {
1466 1466
 			$user_helpers = array();
1467 1467
 			foreach ( $user_fields as $uk => $uf ) {
1468
-				$user_helpers[ '|user_id| show="' . $uk . '"' ] = $uf;
1468
+				$user_helpers['|user_id| show="' . $uk . '"'] = $uf;
1469 1469
 				unset( $uk, $uf );
1470 1470
 			}
1471 1471
 
@@ -1604,7 +1604,7 @@  discard block
 block discarded – undo
1604 1604
 		if ( ! isset( $frm_vars['js_validate_forms'] ) ) {
1605 1605
 			$frm_vars['js_validate_forms'] = array();
1606 1606
 		}
1607
-		$frm_vars['js_validate_forms'][ $form->id ] = $form;
1607
+		$frm_vars['js_validate_forms'][$form->id] = $form;
1608 1608
 	}
1609 1609
 
1610 1610
 	public static function get_email_html() {
@@ -1763,7 +1763,7 @@  discard block
 block discarded – undo
1763 1763
 				add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
1764 1764
 			} else {
1765 1765
 				$vars   = FrmAppHelper::json_to_array( $json_vars );
1766
-				$action = $vars[ $action ];
1766
+				$action = $vars[$action];
1767 1767
 				unset( $_REQUEST['frm_compact_fields'], $_POST['frm_compact_fields'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1768 1768
 				$_REQUEST = array_merge( $_REQUEST, $vars ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1769 1769
 				$_POST    = array_merge( $_POST, $_REQUEST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -1931,7 +1931,7 @@  discard block
 block discarded – undo
1931 1931
 		$actions = array();
1932 1932
 		foreach ( $frm_vars['forms_loaded'] as $form ) {
1933 1933
 			if ( is_object( $form ) ) {
1934
-				$actions[ $form->id ] = $form->name;
1934
+				$actions[$form->id] = $form->name;
1935 1935
 			}
1936 1936
 			unset( $form );
1937 1937
 		}
@@ -2176,8 +2176,8 @@  discard block
 block discarded – undo
2176 2176
 	private static function get_saved_errors( $form, $params ) {
2177 2177
 		global $frm_vars;
2178 2178
 
2179
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2180
-			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
2179
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][$form->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2180
+			$errors = $frm_vars['created_entries'][$form->id]['errors'];
2181 2181
 		} else {
2182 2182
 			$errors = array();
2183 2183
 		}
@@ -2199,7 +2199,7 @@  discard block
 block discarded – undo
2199 2199
 	public static function just_created_entry( $form_id ) {
2200 2200
 		global $frm_vars;
2201 2201
 
2202
-		return ( isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0;
2202
+		return ( isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][$form_id] ) && isset( $frm_vars['created_entries'][$form_id]['entry_id'] ) ) ? $frm_vars['created_entries'][$form_id]['entry_id'] : 0;
2203 2203
 	}
2204 2204
 
2205 2205
 	/**
@@ -2219,7 +2219,7 @@  discard block
 block discarded – undo
2219 2219
 	private static function get_confirmation_method( $atts ) {
2220 2220
 		$action = FrmOnSubmitHelper::current_event( $atts );
2221 2221
 		$opt    = 'update' === $action ? 'edit_action' : 'success_action';
2222
-		$method = ( isset( $atts['form']->options[ $opt ] ) && ! empty( $atts['form']->options[ $opt ] ) ) ? $atts['form']->options[ $opt ] : 'message';
2222
+		$method = ( isset( $atts['form']->options[$opt] ) && ! empty( $atts['form']->options[$opt] ) ) ? $atts['form']->options[$opt] : 'message';
2223 2223
 
2224 2224
 		if ( ! empty( $atts['entry_id'] ) ) {
2225 2225
 			$met_actions = self::get_met_on_submit_actions( $atts, $action );
@@ -2240,7 +2240,7 @@  discard block
 block discarded – undo
2240 2240
 	public static function maybe_trigger_redirect( $form, $params, $args ) {
2241 2241
 		if ( ! isset( $params['id'] ) ) {
2242 2242
 			global $frm_vars;
2243
-			$params['id'] = $frm_vars['created_entries'][ $form->id ]['entry_id'];
2243
+			$params['id'] = $frm_vars['created_entries'][$form->id]['entry_id'];
2244 2244
 		}
2245 2245
 
2246 2246
 		$conf_method = self::get_confirmation_method(
@@ -2322,7 +2322,7 @@  discard block
 block discarded – undo
2322 2322
 		$args['success_opt'] = $opt;
2323 2323
 		$args['ajax']        = ! empty( $frm_vars['ajax'] );
2324 2324
 
2325
-		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[ $opt . '_page_id' ] ) ) {
2325
+		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[$opt . '_page_id'] ) ) {
2326 2326
 			self::load_page_after_submit( $args );
2327 2327
 		} elseif ( $args['conf_method'] === 'redirect' ) {
2328 2328
 			self::redirect_after_submit( $args );
@@ -2346,7 +2346,7 @@  discard block
 block discarded – undo
2346 2346
 		}
2347 2347
 
2348 2348
 		// If a redirect action has already opened the URL in a new tab, we show the default message in the currect tab.
2349
-		if ( ! empty( self::$redirected_in_new_tab[ $args['form']->id ] ) ) {
2349
+		if ( ! empty( self::$redirected_in_new_tab[$args['form']->id] ) ) {
2350 2350
 			return array( FrmOnSubmitHelper::get_fallback_action_after_open_in_new_tab( $event ) );
2351 2351
 		}
2352 2352
 
@@ -2534,7 +2534,7 @@  discard block
 block discarded – undo
2534 2534
 
2535 2535
 		$opt = 'update' === $args['action'] ? 'edit_' : 'success_';
2536 2536
 
2537
-		$new_args['conf_method'] = $new_args['form']->options[ $opt . 'action' ];
2537
+		$new_args['conf_method'] = $new_args['form']->options[$opt . 'action'];
2538 2538
 
2539 2539
 		/**
2540 2540
 		 * Filters the run success action args.
@@ -2554,8 +2554,8 @@  discard block
 block discarded – undo
2554 2554
 	private static function load_page_after_submit( $args ) {
2555 2555
 		global $post;
2556 2556
 		$opt = $args['success_opt'];
2557
-		if ( ! $post || $args['form']->options[ $opt . '_page_id' ] != $post->ID ) {
2558
-			$page     = get_post( $args['form']->options[ $opt . '_page_id' ] );
2557
+		if ( ! $post || $args['form']->options[$opt . '_page_id'] != $post->ID ) {
2558
+			$page     = get_post( $args['form']->options[$opt . '_page_id'] );
2559 2559
 			$old_post = $post;
2560 2560
 			$post     = $page;
2561 2561
 			$content  = apply_filters( 'frm_content', $page->post_content, $args['form'], $args['entry_id'] );
@@ -2585,7 +2585,7 @@  discard block
 block discarded – undo
2585 2585
 		add_filter( 'frm_use_wpautop', '__return_false' );
2586 2586
 
2587 2587
 		$opt         = $args['success_opt'];
2588
-		$success_url = trim( $args['form']->options[ $opt . '_url' ] );
2588
+		$success_url = trim( $args['form']->options[$opt . '_url'] );
2589 2589
 		$success_url = apply_filters( 'frm_content', $success_url, $args['form'], $args['entry_id'] );
2590 2590
 		$success_url = do_shortcode( $success_url );
2591 2591
 
@@ -2607,7 +2607,7 @@  discard block
 block discarded – undo
2607 2607
 			// Not AJAX submit, no headers sent, and there is just one Redirect action runs.
2608 2608
 			if ( ! empty( $args['form']->options['open_in_new_tab'] ) ) {
2609 2609
 				self::print_open_in_new_tab_js_with_fallback_handler( $success_url, $args );
2610
-				self::$redirected_in_new_tab[ $args['form']->id ] = 1;
2610
+				self::$redirected_in_new_tab[$args['form']->id] = 1;
2611 2611
 				return;
2612 2612
 			}
2613 2613
 
@@ -2869,7 +2869,7 @@  discard block
 block discarded – undo
2869 2869
 			'description' => false,
2870 2870
 			'reset'       => false,
2871 2871
 		);
2872
-		$args     = wp_parse_args( $args, $defaults );
2872
+		$args = wp_parse_args( $args, $defaults );
2873 2873
 	}
2874 2874
 
2875 2875
 	/**
@@ -2907,7 +2907,7 @@  discard block
 block discarded – undo
2907 2907
 		$opt          = isset( $args['success_opt'] ) ? $args['success_opt'] : 'success';
2908 2908
 
2909 2909
 		if ( $entry_id && is_numeric( $entry_id ) ) {
2910
-			$message = isset( $form->options[ $opt . '_msg' ] ) ? $form->options[ $opt . '_msg' ] : $frm_settings->success_msg;
2910
+			$message = isset( $form->options[$opt . '_msg'] ) ? $form->options[$opt . '_msg'] : $frm_settings->success_msg;
2911 2911
 			$class   = 'frm_message';
2912 2912
 		} else {
2913 2913
 			$message = $frm_settings->failed_msg;
@@ -3130,8 +3130,8 @@  discard block
 block discarded – undo
3130 3130
 
3131 3131
 		check_ajax_referer( 'frm_ajax', 'nonce' );
3132 3132
 
3133
-		$html             = FrmAppHelper::clip(
3134
-			function () {
3133
+		$html = FrmAppHelper::clip(
3134
+			function() {
3135 3135
 				FrmAppHelper::maybe_autocomplete_pages_options(
3136 3136
 					array(
3137 3137
 						'field_name'  => 'frm_page_dropdown',
Please login to merge, or discard this patch.
classes/helpers/FrmFieldsHelper.php 2 patches
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -185,7 +185,8 @@  discard block
 block discarded – undo
185 185
 	 * @param mixed  $value
186 186
 	 */
187 187
 	private static function get_posted_field_setting( $setting, &$value ) {
188
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
188
+		if ( ! isset( $_POST['field_options'][ $setting ] ) ) {
189
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
189 190
 			return;
190 191
 		}
191 192
 
@@ -1144,7 +1145,8 @@  discard block
 block discarded – undo
1144 1145
 
1145 1146
 		// Check posted vals before checking saved values
1146 1147
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
1147
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1148
+		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) {
1149
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1148 1150
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1149 1151
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1150 1152
 				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
@@ -1154,7 +1156,8 @@  discard block
 block discarded – undo
1154 1156
 
1155 1157
 			return $other_val;
1156 1158
 
1157
-		} elseif ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1159
+		} elseif ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) {
1160
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1158 1161
 			// For normal fields
1159 1162
 
1160 1163
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
Please login to merge, or discard this patch.
Spacing   +45 added lines, -45 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 			if ( in_array( $type, array( 'data', 'lookup' ), true ) ) {
32 32
 				$values['field_options']['data_type'] = $setting;
33 33
 			} else {
34
-				$values['field_options'][ $setting ] = 1;
34
+				$values['field_options'][$setting] = 1;
35 35
 			}
36 36
 		}
37 37
 
@@ -149,10 +149,10 @@  discard block
 block discarded – undo
149 149
 		}
150 150
 
151 151
 		foreach ( $defaults as $opt => $default ) {
152
-			$values[ $opt ] = isset( $field->field_options[ $opt ] ) ? $field->field_options[ $opt ] : $default;
152
+			$values[$opt] = isset( $field->field_options[$opt] ) ? $field->field_options[$opt] : $default;
153 153
 
154 154
 			if ( $check_post ) {
155
-				self::get_posted_field_setting( $opt . '_' . $field->id, $values[ $opt ] );
155
+				self::get_posted_field_setting( $opt . '_' . $field->id, $values[$opt] );
156 156
 			}
157 157
 
158 158
 			unset( $opt, $default );
@@ -228,18 +228,18 @@  discard block
 block discarded – undo
228 228
 	 * @param mixed  $value
229 229
 	 */
230 230
 	private static function get_posted_field_setting( $setting, &$value ) {
231
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
231
+		if ( ! isset( $_POST['field_options'][$setting] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
232 232
 			return;
233 233
 		}
234 234
 
235 235
 		if ( strpos( $setting, 'html' ) !== false ) {
236 236
 			// Strip slashes from HTML but not regex or script tags.
237
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
237
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
238 238
 		} elseif ( strpos( $setting, 'format_' ) === 0 ) {
239 239
 			// TODO: Remove stripslashes on output, and use on input only.
240
-			$value = sanitize_text_field( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
240
+			$value = sanitize_text_field( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
241 241
 		} else {
242
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
242
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
243 243
 			FrmAppHelper::sanitize_value( 'wp_kses_post', $value );
244 244
 		}
245 245
 	}
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
 		$values['default_value'] = FrmAppHelper::maybe_json_encode( $field->default_value );
313 313
 
314 314
 		foreach ( array( 'name', 'description', 'type', 'field_order', 'field_options', 'required' ) as $col ) {
315
-			$values[ $col ] = $field->{$col};
315
+			$values[$col] = $field->{$col};
316 316
 		}
317 317
 	}
318 318
 
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 		);
352 352
 
353 353
 		$msg = FrmField::get_option( $field, $error );
354
-		$msg = empty( $msg ) ? $defaults[ $error ]['part'] : $msg;
354
+		$msg = empty( $msg ) ? $defaults[$error]['part'] : $msg;
355 355
 		$msg = do_shortcode( $msg );
356 356
 
357 357
 		$msg = self::maybe_replace_substrings_with_field_name( $msg, $error, $field );
@@ -619,7 +619,7 @@  discard block
 block discarded – undo
619 619
 			'title'        => '',
620 620
 			'inside_class' => 'inside',
621 621
 		);
622
-		$args     = array_merge( $defaults, $args );
622
+		$args = array_merge( $defaults, $args );
623 623
 
624 624
 		include FrmAppHelper::plugin_path() . '/classes/views/frm-fields/back-end/inline-modal.php';
625 625
 	}
@@ -854,7 +854,7 @@  discard block
 block discarded – undo
854 854
 				continue;
855 855
 			}
856 856
 
857
-			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][ $short_key ] );
857
+			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][$short_key] );
858 858
 			$tag  = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
859 859
 
860 860
 			$atts['entry'] = $entry;
@@ -864,7 +864,7 @@  discard block
 block discarded – undo
864 864
 			if ( $replace_with !== null ) {
865 865
 				$replace_with = self::trigger_shortcode_atts( $replace_with, $atts );
866 866
 				self::sanitize_embedded_shortcodes( compact( 'entry' ), $replace_with );
867
-				$content = str_replace( $shortcodes[0][ $short_key ], $replace_with, $content );
867
+				$content = str_replace( $shortcodes[0][$short_key], $replace_with, $content );
868 868
 			}
869 869
 
870 870
 			unset( $atts, $replace_with );
@@ -882,7 +882,7 @@  discard block
 block discarded – undo
882 882
 		$supported_atts = array( 'remove_accents', 'sanitize', 'sanitize_url' );
883 883
 		$included_atts  = array_intersect( $supported_atts, array_keys( $atts ) );
884 884
 		foreach ( $included_atts as $included_att ) {
885
-			if ( '0' === $atts[ $included_att ] ) {
885
+			if ( '0' === $atts[$included_att] ) {
886 886
 				// Skip any option that uses 0 so sanitize_url=0 does not encode.
887 887
 				continue;
888 888
 			}
@@ -955,8 +955,8 @@  discard block
 block discarded – undo
955 955
 
956 956
 		$dynamic_default = array( 'admin_email', 'siteurl', 'frmurl', 'sitename', 'get' );
957 957
 
958
-		if ( isset( $shortcode_values[ $atts['tag'] ] ) ) {
959
-			$replace_with = $shortcode_values[ $atts['tag'] ];
958
+		if ( isset( $shortcode_values[$atts['tag']] ) ) {
959
+			$replace_with = $shortcode_values[$atts['tag']];
960 960
 		} elseif ( in_array( $atts['tag'], $dynamic_default ) ) {
961 961
 			$replace_with = self::dynamic_default_values( $atts['tag'], $atts );
962 962
 		} elseif ( $clean_tag === 'user_agent' ) {
@@ -1167,8 +1167,8 @@  discard block
 block discarded – undo
1167 1167
 			self::field_types_for_input( $single_input, $field_selection, $field_types );
1168 1168
 		} elseif ( in_array( $type, $multiple_input ) ) {
1169 1169
 			self::field_types_for_input( $multiple_input, $field_selection, $field_types );
1170
-		} elseif ( isset( $field_selection[ $type ] ) ) {
1171
-			$field_types[ $type ] = $field_selection[ $type ];
1170
+		} elseif ( isset( $field_selection[$type] ) ) {
1171
+			$field_types[$type] = $field_selection[$type];
1172 1172
 		}
1173 1173
 
1174 1174
 		$field_types = apply_filters( 'frm_switch_field_types', $field_types, compact( 'type', 'field_selection' ) );
@@ -1201,7 +1201,7 @@  discard block
 block discarded – undo
1201 1201
 
1202 1202
 	private static function field_types_for_input( $inputs, $fields, &$field_types ) {
1203 1203
 		foreach ( $inputs as $input ) {
1204
-			$field_types[ $input ] = $fields[ $input ];
1204
+			$field_types[$input] = $fields[$input];
1205 1205
 			unset( $input );
1206 1206
 		}
1207 1207
 	}
@@ -1233,7 +1233,7 @@  discard block
 block discarded – undo
1233 1233
 			'parent'  => false,
1234 1234
 			'pointer' => false,
1235 1235
 		);
1236
-		$args     = wp_parse_args( $args, $defaults );
1236
+		$args = wp_parse_args( $args, $defaults );
1237 1237
 
1238 1238
 		$opt_key   = $args['opt_key'];
1239 1239
 		$field     = $args['field'];
@@ -1249,24 +1249,24 @@  discard block
 block discarded – undo
1249 1249
 
1250 1250
 		// Check posted vals before checking saved values
1251 1251
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
1252
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1252
+		if ( $parent && isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1253 1253
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1254 1254
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1255
-				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
1255
+				$other_val = isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ) : '';
1256 1256
 			} else {
1257
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1257
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1258 1258
 			}
1259 1259
 
1260 1260
 			return $other_val;
1261 1261
 
1262
-		} elseif ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1262
+		} elseif ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1263 1263
 			// For normal fields
1264 1264
 
1265 1265
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1266 1266
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1267
-				$other_val = isset( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ) : '';
1267
+				$other_val = isset( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ) : '';
1268 1268
 			} else {
1269
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1269
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1270 1270
 			}
1271 1271
 
1272 1272
 			return $other_val;
@@ -1276,8 +1276,8 @@  discard block
 block discarded – undo
1276 1276
 		if ( $field['type'] === 'checkbox' && is_array( $field['value'] ) ) {
1277 1277
 			// Check if there is an "other" val in saved value and make sure the
1278 1278
 			// "other" val is not equal to the Other checkbox option
1279
-			if ( isset( $field['value'][ $opt_key ] ) && $field['options'][ $opt_key ] != $field['value'][ $opt_key ] ) {
1280
-				$other_val = $field['value'][ $opt_key ];
1279
+			if ( isset( $field['value'][$opt_key] ) && $field['options'][$opt_key] != $field['value'][$opt_key] ) {
1280
+				$other_val = $field['value'][$opt_key];
1281 1281
 			}
1282 1282
 		} else {
1283 1283
 			/**
@@ -1289,8 +1289,8 @@  discard block
 block discarded – undo
1289 1289
 				// Multi-select dropdowns - key is not preserved
1290 1290
 				if ( is_array( $field['value'] ) ) {
1291 1291
 					$o_key = array_search( $temp_val, $field['value'] );
1292
-					if ( isset( $field['value'][ $o_key ] ) ) {
1293
-						unset( $field['value'][ $o_key ], $o_key );
1292
+					if ( isset( $field['value'][$o_key] ) ) {
1293
+						unset( $field['value'][$o_key], $o_key );
1294 1294
 					}
1295 1295
 				} elseif ( $temp_val == $field['value'] ) {
1296 1296
 					// For radio and regular dropdowns
@@ -1500,7 +1500,7 @@  discard block
 block discarded – undo
1500 1500
 		if ( is_array( $val ) ) {
1501 1501
 			foreach ( $val as $k => $v ) {
1502 1502
 				if ( is_string( $v ) ) {
1503
-					$val[ $k ] = str_replace( $replace, $replace_with, $v );
1503
+					$val[$k] = str_replace( $replace, $replace_with, $v );
1504 1504
 					unset( $k, $v );
1505 1505
 				}
1506 1506
 			}
@@ -1853,7 +1853,7 @@  discard block
 block discarded – undo
1853 1853
 			$countries['class'] = 'frm-countries-opts';
1854 1854
 		}
1855 1855
 
1856
-		$prepop[ __( 'Countries', 'formidable' ) ] = $countries;
1856
+		$prepop[__( 'Countries', 'formidable' )] = $countries;
1857 1857
 
1858 1858
 		// State abv.
1859 1859
 		$states    = self::get_us_states();
@@ -1863,7 +1863,7 @@  discard block
 block discarded – undo
1863 1863
 			$state_abv['class'] = 'frm-state-abv-opts';
1864 1864
 		}
1865 1865
 
1866
-		$prepop[ __( 'U.S. State Abbreviations', 'formidable' ) ] = $state_abv;
1866
+		$prepop[__( 'U.S. State Abbreviations', 'formidable' )] = $state_abv;
1867 1867
 
1868 1868
 		// States.
1869 1869
 		$states = array_values( $states );
@@ -1872,7 +1872,7 @@  discard block
 block discarded – undo
1872 1872
 			$states['class'] = 'frm-states-opts';
1873 1873
 		}
1874 1874
 
1875
-		$prepop[ __( 'U.S. States', 'formidable' ) ] = $states;
1875
+		$prepop[__( 'U.S. States', 'formidable' )] = $states;
1876 1876
 		unset( $state_abv, $states );
1877 1877
 
1878 1878
 		// Age.
@@ -1890,7 +1890,7 @@  discard block
 block discarded – undo
1890 1890
 			$ages['class'] = 'frm-age-opts';
1891 1891
 		}
1892 1892
 
1893
-		$prepop[ __( 'Age', 'formidable' ) ] = $ages;
1893
+		$prepop[__( 'Age', 'formidable' )] = $ages;
1894 1894
 
1895 1895
 		// Satisfaction.
1896 1896
 		$satisfaction = array(
@@ -1905,7 +1905,7 @@  discard block
 block discarded – undo
1905 1905
 			$satisfaction['class'] = 'frm-satisfaction-opts';
1906 1906
 		}
1907 1907
 
1908
-		$prepop[ __( 'Satisfaction', 'formidable' ) ] = $satisfaction;
1908
+		$prepop[__( 'Satisfaction', 'formidable' )] = $satisfaction;
1909 1909
 
1910 1910
 		// Importance.
1911 1911
 		$importance = array(
@@ -1920,7 +1920,7 @@  discard block
 block discarded – undo
1920 1920
 			$importance['class'] = 'frm-importance-opts';
1921 1921
 		}
1922 1922
 
1923
-		$prepop[ __( 'Importance', 'formidable' ) ] = $importance;
1923
+		$prepop[__( 'Importance', 'formidable' )] = $importance;
1924 1924
 
1925 1925
 		// Agreement.
1926 1926
 		$agreement = array(
@@ -1935,7 +1935,7 @@  discard block
 block discarded – undo
1935 1935
 			$agreement['class'] = 'frm-agreement-opts';
1936 1936
 		}
1937 1937
 
1938
-		$prepop[ __( 'Agreement', 'formidable' ) ] = $agreement;
1938
+		$prepop[__( 'Agreement', 'formidable' )] = $agreement;
1939 1939
 
1940 1940
 		// Likely.
1941 1941
 		$likely = array(
@@ -1950,7 +1950,7 @@  discard block
 block discarded – undo
1950 1950
 			$likely['class'] = 'frm-likely-opts';
1951 1951
 		}
1952 1952
 
1953
-		$prepop[ __( 'Likely', 'formidable' ) ] = $likely;
1953
+		$prepop[__( 'Likely', 'formidable' )] = $likely;
1954 1954
 
1955 1955
 		$prepop = apply_filters( 'frm_bulk_field_choices', $prepop );
1956 1956
 	}
@@ -2171,16 +2171,16 @@  discard block
 block discarded – undo
2171 2171
 	 */
2172 2172
 	private static function fill_image_setting_options( $options, &$args ) {
2173 2173
 		foreach ( $options as $key => $option ) {
2174
-			$args['options'][ $key ] = $option;
2174
+			$args['options'][$key] = $option;
2175 2175
 
2176 2176
 			if ( ! empty( $option['addon'] ) ) {
2177
-				$args['options'][ $key ]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
2177
+				$args['options'][$key]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
2178 2178
 			}
2179 2179
 
2180
-			unset( $args['options'][ $key ]['addon'] );
2180
+			unset( $args['options'][$key]['addon'] );
2181 2181
 			$fill = array( 'upgrade', 'message', 'content' );
2182 2182
 			foreach ( $fill as $f ) {
2183
-				unset( $args['options'][ $key ][ $f ], $f );
2183
+				unset( $args['options'][$key][$f], $f );
2184 2184
 			}
2185 2185
 		}
2186 2186
 	}
@@ -2201,8 +2201,8 @@  discard block
 block discarded – undo
2201 2201
 
2202 2202
 		$fill = array( 'upgrade', 'message', 'content' );
2203 2203
 		foreach ( $fill as $f ) {
2204
-			if ( isset( $option[ $f ] ) ) {
2205
-				$custom_attrs[ 'data-' . $f ] = $option[ $f ];
2204
+			if ( isset( $option[$f] ) ) {
2205
+				$custom_attrs['data-' . $f] = $option[$f];
2206 2206
 			}
2207 2207
 		}
2208 2208
 
@@ -2267,7 +2267,7 @@  discard block
 block discarded – undo
2267 2267
 
2268 2268
 		return array_filter(
2269 2269
 			$rows,
2270
-			function ( $row ) {
2270
+			function( $row ) {
2271 2271
 				FrmAppHelper::unserialize_or_decode( $row->field_options );
2272 2272
 				return is_array( $row->field_options ) && ! empty( $row->field_options['draft'] );
2273 2273
 			}
Please login to merge, or discard this patch.
classes/models/FrmEntryValidate.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -145,7 +145,8 @@
 block discarded – undo
145 145
 
146 146
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
147 147
 			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
148
-		} elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
148
+		} elseif ( ! isset( $_POST['item_name'] ) ) {
149
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
149 150
 			self::maybe_add_item_name( $value, $posted_field );
150 151
 		}
151 152
 
Please login to merge, or discard this patch.
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 			return $errors;
21 21
 		}
22 22
 
23
-		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values[ 'frm_submit_entry_' . $values['form_id'] ] ) || ! wp_verify_nonce( $values[ 'frm_submit_entry_' . $values['form_id'] ], 'frm_submit_entry_nonce' ) ) ) {
23
+		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values['frm_submit_entry_' . $values['form_id']] ) || ! wp_verify_nonce( $values['frm_submit_entry_' . $values['form_id']], 'frm_submit_entry_nonce' ) ) ) {
24 24
 			$frm_settings   = FrmAppHelper::get_settings();
25 25
 			$errors['form'] = $frm_settings->admin_permission;
26 26
 		}
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 		$args = wp_parse_args( $args, $defaults );
124 124
 
125 125
 		if ( empty( $args['parent_field_id'] ) ) {
126
-			$value = isset( $values['item_meta'][ $args['id'] ] ) ? $values['item_meta'][ $args['id'] ] : '';
126
+			$value = isset( $values['item_meta'][$args['id']] ) ? $values['item_meta'][$args['id']] : '';
127 127
 		} else {
128 128
 			// value is from a nested form
129 129
 			$value = $values;
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 		}
145 145
 
146 146
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
147
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
147
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
148 148
 		} elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
149 149
 			self::maybe_add_item_name( $value, $posted_field );
150 150
 		}
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 			$pattern = self::phone_format( $field );
227 227
 
228 228
 			if ( ! preg_match( $pattern, $value ) ) {
229
-				$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
229
+				$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
230 230
 			}
231 231
 		}
232 232
 	}
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
 	 */
337 337
 	private static function form_is_in_progress( $values ) {
338 338
 		return FrmAppHelper::pro_is_installed() &&
339
-			( isset( $values[ 'frm_page_order_' . $values['form_id'] ] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
339
+			( isset( $values['frm_page_order_' . $values['form_id']] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
340 340
 			FrmField::get_all_types_in_form( $values['form_id'], 'break' );
341 341
 	}
342 342
 
@@ -581,9 +581,9 @@  discard block
 block discarded – undo
581 581
 			foreach ( $datas['missing_keys'] as $key_index => $key ) {
582 582
 				$found = self::is_akismet_guest_info_value( $key, $value, $field_id, $datas['name_field_ids'] );
583 583
 				if ( $found ) {
584
-					$datas[ $key ]             = $value;
584
+					$datas[$key]             = $value;
585 585
 					$datas['frm_duplicated'][] = $field_id;
586
-					unset( $datas['missing_keys'][ $key_index ] );
586
+					unset( $datas['missing_keys'][$key_index] );
587 587
 				}
588 588
 			}
589 589
 		}//end foreach
@@ -629,7 +629,7 @@  discard block
 block discarded – undo
629 629
 
630 630
 			// Send any potentially useful $_SERVER vars, but avoid sending junk we don't need.
631 631
 			if ( $include_value ) {
632
-				$datas[ $key ] = $value;
632
+				$datas[$key] = $value;
633 633
 			}
634 634
 			unset( $key, $value );
635 635
 		}
@@ -646,10 +646,10 @@  discard block
 block discarded – undo
646 646
 	private static function add_comment_content_to_akismet( &$datas, $values ) {
647 647
 		if ( isset( $datas['frm_duplicated'] ) ) {
648 648
 			foreach ( $datas['frm_duplicated'] as $index ) {
649
-				if ( isset( $values['item_meta'][ $index ] ) ) {
650
-					unset( $values['item_meta'][ $index ] );
649
+				if ( isset( $values['item_meta'][$index] ) ) {
650
+					unset( $values['item_meta'][$index] );
651 651
 				} else {
652
-					unset( $values[ $index ] );
652
+					unset( $values[$index] );
653 653
 				}
654 654
 			}
655 655
 			unset( $datas['frm_duplicated'] );
@@ -670,14 +670,14 @@  discard block
 block discarded – undo
670 670
 	private static function skip_adding_values_to_akismet( &$values ) {
671 671
 		$skipped_fields = self::get_akismet_skipped_field_ids( $values );
672 672
 		foreach ( $skipped_fields as $skipped_field ) {
673
-			if ( ! isset( $values['item_meta'][ $skipped_field->id ] ) ) {
673
+			if ( ! isset( $values['item_meta'][$skipped_field->id] ) ) {
674 674
 				continue;
675 675
 			}
676 676
 
677 677
 			if ( self::should_really_skip_field( $skipped_field, $values ) ) {
678
-				unset( $values['item_meta'][ $skipped_field->id ] );
679
-				if ( isset( $values['item_meta']['other'][ $skipped_field->id ] ) ) {
680
-					unset( $values['item_meta']['other'][ $skipped_field->id ] );
678
+				unset( $values['item_meta'][$skipped_field->id] );
679
+				if ( isset( $values['item_meta']['other'][$skipped_field->id] ) ) {
680
+					unset( $values['item_meta']['other'][$skipped_field->id] );
681 681
 				}
682 682
 			}
683 683
 		}
@@ -713,14 +713,14 @@  discard block
 block discarded – undo
713 713
 		}
714 714
 
715 715
 		// If a choice field has Other option, but Other is not selected.
716
-		if ( empty( $values['item_meta']['other'][ $field_data->id ] ) ) {
716
+		if ( empty( $values['item_meta']['other'][$field_data->id] ) ) {
717 717
 			return true;
718 718
 		}
719 719
 
720 720
 		// Check if submitted value is same as one of field option.
721 721
 		foreach ( $field_data->options as $option ) {
722 722
 			$option_value = ! is_array( $option ) ? $option : ( isset( $option['value'] ) ? $option['value'] : '' );
723
-			if ( $values['item_meta']['other'][ $field_data->id ] === $option_value ) {
723
+			if ( $values['item_meta']['other'][$field_data->id] === $option_value ) {
724 724
 				return true;
725 725
 			}
726 726
 		}
@@ -791,7 +791,7 @@  discard block
 block discarded – undo
791 791
 
792 792
 			// Convert name array to string.
793 793
 			if ( isset( $value['first'] ) && isset( $value['last'] ) ) {
794
-				$values['item_meta'][ $field_id ] = trim( implode( ' ', $value ) );
794
+				$values['item_meta'][$field_id] = trim( implode( ' ', $value ) );
795 795
 				$values['name_field_ids'][]       = $field_id;
796 796
 				continue;
797 797
 			}
@@ -812,8 +812,8 @@  discard block
 block discarded – undo
812 812
 						continue;
813 813
 					}
814 814
 
815
-					if ( ! isset( $values['item_meta'][ $subsubindex ] ) ) {
816
-						$values['item_meta'][ $subsubindex ] = array();
815
+					if ( ! isset( $values['item_meta'][$subsubindex] ) ) {
816
+						$values['item_meta'][$subsubindex] = array();
817 817
 					}
818 818
 
819 819
 					// Convert name array to string.
@@ -823,11 +823,11 @@  discard block
 block discarded – undo
823 823
 						$values['name_field_ids'][] = $subsubindex;
824 824
 					}
825 825
 
826
-					$values['item_meta'][ $subsubindex ][] = $subsubvalue;
826
+					$values['item_meta'][$subsubindex][] = $subsubvalue;
827 827
 				}
828 828
 			}//end foreach
829 829
 
830
-			unset( $values['item_meta'][ $field_id ] );
830
+			unset( $values['item_meta'][$field_id] );
831 831
 		}//end foreach
832 832
 
833 833
 		return $form_ids;
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldNumber.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
 		// Validate the number format.
72 72
 		if ( ! is_numeric( $args['value'] ) && '' !== $args['value'] ) {
73
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
73
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
74 74
 		}
75 75
 
76 76
 		// validate number settings
@@ -82,9 +82,9 @@  discard block
 block discarded – undo
82 82
 			if ( $frm_settings->use_html && $maxnum !== '' && $minnum !== '' ) {
83 83
 				$value = (float) $args['value'];
84 84
 				if ( $value < $minnum ) {
85
-					$errors[ 'field' . $args['id'] ] = __( 'Please select a higher number', 'formidable' );
85
+					$errors['field' . $args['id']] = __( 'Please select a higher number', 'formidable' );
86 86
 				} elseif ( $value > $maxnum ) {
87
-					$errors[ 'field' . $args['id'] ] = __( 'Please select a lower number', 'formidable' );
87
+					$errors['field' . $args['id']] = __( 'Please select a lower number', 'formidable' );
88 88
 				}
89 89
 			}
90 90
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 	 * @return void
106 106
 	 */
107 107
 	private function validate_step( &$errors, $args ) {
108
-		if ( isset( $errors[ 'field' . $args['id'] ] ) ) {
108
+		if ( isset( $errors['field' . $args['id']] ) ) {
109 109
 			// Don't need to check if value is invalid before.
110 110
 			return;
111 111
 		}
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 			return;
121 121
 		}
122 122
 
123
-		$errors[ 'field' . $args['id'] ] = sprintf(
123
+		$errors['field' . $args['id']] = sprintf(
124 124
 			// Translators: %1$s: the first nearest value; %2$s: the second nearest value.
125 125
 			__( 'Please enter a valid value. Two nearest valid values are %1$s and %2$s', 'formidable' ),
126 126
 			floatval( $result[0] ),
Please login to merge, or discard this patch.
classes/models/FrmAddon.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -465,7 +465,8 @@
 block discarded – undo
465 465
 	}
466 466
 
467 467
 	private function is_license_revoked() {
468
-		if ( empty( $this->license ) || empty( $this->plugin_slug ) || isset( $_POST['license'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
468
+		if ( empty( $this->license ) || empty( $this->plugin_slug ) || isset( $_POST['license'] ) ) {
469
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
469 470
 			return;
470 471
 		}
471 472
 
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 	}
71 71
 
72 72
 	public function insert_installed_addon( $plugins ) {
73
-		$plugins[ $this->plugin_slug ] = $this;
73
+		$plugins[$this->plugin_slug] = $this;
74 74
 
75 75
 		return $plugins;
76 76
 	}
@@ -78,8 +78,8 @@  discard block
 block discarded – undo
78 78
 	public static function get_addon( $plugin_slug ) {
79 79
 		$plugins = apply_filters( 'frm_installed_addons', array() );
80 80
 		$plugin  = false;
81
-		if ( isset( $plugins[ $plugin_slug ] ) ) {
82
-			$plugin = $plugins[ $plugin_slug ];
81
+		if ( isset( $plugins[$plugin_slug] ) ) {
82
+			$plugin = $plugins[$plugin_slug];
83 83
 		}
84 84
 
85 85
 		return $plugin;
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 		} else {
140 140
 			$api     = new FrmFormApi( $this->license );
141 141
 			$plugins = $api->get_api_info();
142
-			$_data   = $plugins[ $item_id ];
142
+			$_data   = $plugins[$item_id];
143 143
 		}
144 144
 
145 145
 		$_data['sections'] = array(
@@ -380,19 +380,19 @@  discard block
 block discarded – undo
380 380
 
381 381
 		if ( $this->is_current_version( $transient ) ) {
382 382
 			// Make sure it doesn't show there is an update if plugin is up-to-date.
383
-			if ( isset( $transient->response[ $this->plugin_folder ] ) ) {
384
-				unset( $transient->response[ $this->plugin_folder ] );
383
+			if ( isset( $transient->response[$this->plugin_folder] ) ) {
384
+				unset( $transient->response[$this->plugin_folder] );
385 385
 			}
386
-		} elseif ( isset( $transient->response ) && isset( $transient->response[ $this->plugin_folder ] ) ) {
387
-			$this->prepare_update_details( $transient->response[ $this->plugin_folder ] );
386
+		} elseif ( isset( $transient->response ) && isset( $transient->response[$this->plugin_folder] ) ) {
387
+			$this->prepare_update_details( $transient->response[$this->plugin_folder] );
388 388
 
389 389
 			// if the transient has expired, clear the update and trigger it again
390
-			if ( $transient->response[ $this->plugin_folder ] === false ) {
390
+			if ( $transient->response[$this->plugin_folder] === false ) {
391 391
 				if ( ! $this->has_been_cleared() ) {
392 392
 					$this->cleared_plugins();
393 393
 					$this->manually_queue_update();
394 394
 				}
395
-				unset( $transient->response[ $this->plugin_folder ] );
395
+				unset( $transient->response[$this->plugin_folder] );
396 396
 			}
397 397
 		}
398 398
 
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
 	}
483 483
 
484 484
 	private function is_current_version( $transient ) {
485
-		if ( empty( $transient->checked ) || ! isset( $transient->checked[ $this->plugin_folder ] ) ) {
485
+		if ( empty( $transient->checked ) || ! isset( $transient->checked[$this->plugin_folder] ) ) {
486 486
 			return false;
487 487
 		}
488 488
 
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
 			return true;
492 492
 		}
493 493
 
494
-		return isset( $transient->response ) && isset( $transient->response[ $this->plugin_folder ] ) && $transient->checked[ $this->plugin_folder ] === $transient->response[ $this->plugin_folder ]->new_version;
494
+		return isset( $transient->response ) && isset( $transient->response[$this->plugin_folder] ) && $transient->checked[$this->plugin_folder] === $transient->response[$this->plugin_folder]->new_version;
495 495
 	}
496 496
 
497 497
 	private function has_been_cleared() {
@@ -631,8 +631,8 @@  discard block
 block discarded – undo
631 631
 			$response['message'] = $response['status'];
632 632
 		} else {
633 633
 			$messages = $this->get_messages();
634
-			if ( is_string( $response['status'] ) && isset( $messages[ $response['status'] ] ) ) {
635
-				$response['message'] = $messages[ $response['status'] ];
634
+			if ( is_string( $response['status'] ) && isset( $messages[$response['status']] ) ) {
635
+				$response['message'] = $messages[$response['status']];
636 636
 			} else {
637 637
 				$response['message'] = FrmAppHelper::kses( $response['status'], array( 'a' ) );
638 638
 			}
@@ -794,7 +794,7 @@  discard block
 block discarded – undo
794 794
 			'user-agent' => $this->plugin_slug . '/' . $this->version . '; ' . get_bloginfo( 'url' ),
795 795
 		);
796 796
 
797
-		$resp              = wp_remote_post(
797
+		$resp = wp_remote_post(
798 798
 			$this->store_url . '?l=' . urlencode( base64_encode( $this->license ) ),
799 799
 			$arg_array
800 800
 		);
Please login to merge, or discard this patch.
stripe/controllers/FrmStrpLiteActionsController.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 			$gateway   = $payment_action->post_content['gateway'];
48 48
 			$is_stripe = $gateway === 'stripe' || ( is_array( $gateway ) && in_array( 'stripe', $gateway, true ) );
49 49
 			if ( ! $is_stripe || empty( $payment_action->post_content['amount'] ) ) {
50
-				unset( $payment_actions[ $k ] );
50
+				unset( $payment_actions[$k] );
51 51
 			}
52 52
 		}
53 53
 		return $payment_actions;
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 			'run_triggers' => false,
85 85
 			'show_errors'  => true,
86 86
 		);
87
-		$atts     = compact( 'action', 'entry', 'form' );
87
+		$atts = compact( 'action', 'entry', 'form' );
88 88
 
89 89
 		$amount = self::prepare_amount( $action->post_content['amount'], $atts );
90 90
 		if ( empty( $amount ) || $amount == 000 ) {
@@ -502,7 +502,7 @@  discard block
 block discarded – undo
502 502
 		$disallowed = array( ';', ':', '!important' );
503 503
 		foreach ( $settings as $k => $s ) {
504 504
 			if ( is_string( $s ) ) {
505
-				$settings[ $k ] = str_replace( $disallowed, '', $s );
505
+				$settings[$k] = str_replace( $disallowed, '', $s );
506 506
 			}
507 507
 		}
508 508
 
@@ -574,18 +574,18 @@  discard block
 block discarded – undo
574 574
 	 * @return array
575 575
 	 */
576 576
 	public static function remove_cc_validation( $errors, $field, $values ) {
577
-		$has_processed = isset( $_POST[ 'frmintent' . $field->form_id ] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
577
+		$has_processed = isset( $_POST['frmintent' . $field->form_id] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
578 578
 		if ( ! $has_processed ) {
579 579
 			return $errors;
580 580
 		}
581 581
 
582 582
 		$field_id = isset( $field->temp_id ) ? $field->temp_id : $field->id;
583 583
 
584
-		if ( isset( $errors[ 'field' . $field_id . '-cc' ] ) ) {
585
-			unset( $errors[ 'field' . $field_id . '-cc' ] );
584
+		if ( isset( $errors['field' . $field_id . '-cc'] ) ) {
585
+			unset( $errors['field' . $field_id . '-cc'] );
586 586
 		}
587
-		if ( isset( $errors[ 'field' . $field_id ] ) ) {
588
-			unset( $errors[ 'field' . $field_id ] );
587
+		if ( isset( $errors['field' . $field_id] ) ) {
588
+			unset( $errors['field' . $field_id] );
589 589
 		}
590 590
 
591 591
 		return $errors;
Please login to merge, or discard this patch.
classes/models/FrmEntryFormatter.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -164,8 +164,8 @@  discard block
 block discarded – undo
164 164
 
165 165
 		$conditionally_add = array( 'include_fields', 'fields', 'exclude_fields', 'entry' );
166 166
 		foreach ( $conditionally_add as $index ) {
167
-			if ( isset( $atts[ $index ] ) ) {
168
-				$entry_atts[ $index ] = $atts[ $index ];
167
+			if ( isset( $atts[$index] ) ) {
168
+				$entry_atts[$index] = $atts[$index];
169 169
 			}
170 170
 		}
171 171
 
@@ -351,8 +351,8 @@  discard block
 block discarded – undo
351 351
 
352 352
 		$unset = array( 'id', 'form_id', 'format' );
353 353
 		foreach ( $unset as $param ) {
354
-			if ( isset( $atts[ $param ] ) ) {
355
-				unset( $atts[ $param ] );
354
+			if ( isset( $atts[$param] ) ) {
355
+				unset( $atts[$param] );
356 356
 			}
357 357
 		}
358 358
 
@@ -523,11 +523,11 @@  discard block
 block discarded – undo
523 523
 
524 524
 			$displayed_value = $this->prepare_display_value_for_array( $field_value->get_displayed_value() );
525 525
 
526
-			$output[ $this->get_key_or_id( $field_value ) ] = $displayed_value;
526
+			$output[$this->get_key_or_id( $field_value )] = $displayed_value;
527 527
 
528 528
 			$has_separate_value = (bool) $field_value->get_field_option( 'separate_value' );
529 529
 			if ( $has_separate_value || $displayed_value !== $field_value->get_saved_value() ) {
530
-				$output[ $this->get_key_or_id( $field_value ) . '-value' ] = $field_value->get_saved_value();
530
+				$output[$this->get_key_or_id( $field_value ) . '-value'] = $field_value->get_saved_value();
531 531
 			}
532 532
 		}
533 533
 	}
@@ -917,7 +917,7 @@  discard block
 block discarded – undo
917 917
 
918 918
 			if ( is_array( $value ) ) {
919 919
 				foreach ( $value as $key => $single_value ) {
920
-					$value[ $key ] = $this->strip_html( $single_value );
920
+					$value[$key] = $this->strip_html( $single_value );
921 921
 				}
922 922
 			} elseif ( $this->is_plain_text && ! is_array( $value ) ) {
923 923
 				if ( strpos( $value, '<img' ) !== false ) {
Please login to merge, or discard this patch.
classes/views/frm-fields/back-end/html-content.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
 		<?php esc_html_e( 'Content', 'formidable' ); ?>
10 10
 	</label>
11 11
 	<?php
12
-	$e_args  = array(
12
+	$e_args = array(
13 13
 		'textarea_name' => 'field_options[description_' . absint( $field['id'] ) . ']',
14 14
 		'textarea_rows' => 8,
15 15
 	);
Please login to merge, or discard this patch.