Completed
Pull Request — master (#1182)
by Stephanie
23s
created
classes/controllers/FrmWelcomeController.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,8 @@
 block discarded – undo
42 42
 		}
43 43
 
44 44
 		// Only do this for single site installs.
45
-		if ( isset( $_GET['activate-multi'] ) || is_network_admin() ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
45
+		if ( isset( $_GET['activate-multi'] ) || is_network_admin() ) {
46
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
46 47
 			return;
47 48
 		}
48 49
 
Please login to merge, or discard this patch.
classes/controllers/FrmEntriesController.php 2 patches
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -75,19 +75,19 @@  discard block
 block discarded – undo
75 75
 		global $frm_vars;
76 76
 		$form_id = FrmForm::get_current_form_id();
77 77
 
78
-		$columns[ $form_id . '_id' ]       = 'ID';
79
-		$columns[ $form_id . '_item_key' ] = esc_html__( 'Entry Key', 'formidable' );
78
+		$columns[$form_id . '_id']       = 'ID';
79
+		$columns[$form_id . '_item_key'] = esc_html__( 'Entry Key', 'formidable' );
80 80
 
81 81
 		if ( $form_id ) {
82 82
 			self::get_columns_for_form( $form_id, $columns );
83 83
 		} else {
84
-			$columns[ $form_id . '_form_id' ] = __( 'Form', 'formidable' );
85
-			$columns[ $form_id . '_name' ]    = __( 'Entry Name', 'formidable' );
86
-			$columns[ $form_id . '_user_id' ] = __( 'Created By', 'formidable' );
84
+			$columns[$form_id . '_form_id'] = __( 'Form', 'formidable' );
85
+			$columns[$form_id . '_name']    = __( 'Entry Name', 'formidable' );
86
+			$columns[$form_id . '_user_id'] = __( 'Created By', 'formidable' );
87 87
 		}
88 88
 
89
-		$columns[ $form_id . '_created_at' ] = __( 'Entry creation date', 'formidable' );
90
-		$columns[ $form_id . '_updated_at' ] = __( 'Entry update date', 'formidable' );
89
+		$columns[$form_id . '_created_at'] = __( 'Entry creation date', 'formidable' );
90
+		$columns[$form_id . '_updated_at'] = __( 'Entry update date', 'formidable' );
91 91
 		self::maybe_add_ip_col( $form_id, $columns );
92 92
 
93 93
 		$frm_vars['cols'] = $columns;
@@ -145,10 +145,10 @@  discard block
 block discarded – undo
145 145
 
146 146
 		foreach ( $sub_form_cols as $k => $sub_form_col ) {
147 147
 			if ( FrmField::is_no_save_field( $sub_form_col->type ) ) {
148
-				unset( $sub_form_cols[ $k ] );
148
+				unset( $sub_form_cols[$k] );
149 149
 				continue;
150 150
 			}
151
-			$columns[ $form_id . '_' . $sub_form_col->field_key . '-_-' . $field->id ] = FrmAppHelper::truncate( $sub_form_col->name, 35 );
151
+			$columns[$form_id . '_' . $sub_form_col->field_key . '-_-' . $field->id] = FrmAppHelper::truncate( $sub_form_col->name, 35 );
152 152
 			unset( $sub_form_col );
153 153
 		}
154 154
 	}
@@ -165,15 +165,15 @@  discard block
 block discarded – undo
165 165
 		$has_separate_value = ! FrmField::is_option_empty( $field, 'separate_value' );
166 166
 		$is_post_status     = FrmField::is_option_true( $field, 'post_field' ) && $field->field_options['post_field'] == 'post_status';
167 167
 		if ( $has_separate_value && ! $is_post_status ) {
168
-			$columns[ $form_id . '_frmsep_' . $col_id ] = FrmAppHelper::truncate( $field->name, 35 );
168
+			$columns[$form_id . '_frmsep_' . $col_id] = FrmAppHelper::truncate( $field->name, 35 );
169 169
 		}
170 170
 
171
-		$columns[ $form_id . '_' . $col_id ] = FrmAppHelper::truncate( $field->name, 35 );
171
+		$columns[$form_id . '_' . $col_id] = FrmAppHelper::truncate( $field->name, 35 );
172 172
 	}
173 173
 
174 174
 	private static function maybe_add_ip_col( $form_id, &$columns ) {
175 175
 		if ( FrmAppHelper::ips_saved() ) {
176
-			$columns[ $form_id . '_ip' ] = 'IP';
176
+			$columns[$form_id . '_ip'] = 'IP';
177 177
 		}
178 178
 	}
179 179
 
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
 		foreach ( $meta_value as $mk => $mv ) {
212 212
 			// Remove blank values.
213 213
 			if ( empty( $mv ) ) {
214
-				unset( $meta_value[ $mk ] );
214
+				unset( $meta_value[$mk] );
215 215
 			}
216 216
 		}
217 217
 
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
 
288 288
 		foreach ( $fields as $field ) {
289 289
 			if ( self::field_supports_sorting( $field ) ) {
290
-				$columns[ $form_id . '_' . $field->field_key ] = 'meta_' . $field->id;
290
+				$columns[$form_id . '_' . $field->field_key] = 'meta_' . $field->id;
291 291
 			}
292 292
 		}
293 293
 
@@ -363,7 +363,7 @@  discard block
 block discarded – undo
363 363
 			$atts['form_id'] . '_item_key' => '',
364 364
 			$atts['form_id'] . '_id'       => '',
365 365
 		);
366
-		$cols         = $remove_first + array_reverse( $frm_vars['cols'], true );
366
+		$cols = $remove_first + array_reverse( $frm_vars['cols'], true );
367 367
 
368 368
 		$i = $atts['i'];
369 369
 
@@ -374,7 +374,7 @@  discard block
 block discarded – undo
374 374
 
375 375
 			if ( empty( $result ) || ! in_array( $col_key, $result, true ) ) {
376 376
 				$result[] = $col_key;
377
-				$i--;
377
+				$i --;
378 378
 			}
379 379
 
380 380
 			unset( $col_key, $col );
@@ -507,9 +507,9 @@  discard block
 block discarded – undo
507 507
 		if ( ! isset( $frm_vars['form_params'] ) ) {
508 508
 			$frm_vars['form_params'] = array();
509 509
 		}
510
-		$frm_vars['form_params'][ $form->id ] = $params;
510
+		$frm_vars['form_params'][$form->id] = $params;
511 511
 
512
-		if ( isset( $frm_vars['created_entries'][ $form_id ] ) ) {
512
+		if ( isset( $frm_vars['created_entries'][$form_id] ) ) {
513 513
 			return;
514 514
 		}
515 515
 
@@ -525,16 +525,16 @@  discard block
 block discarded – undo
525 525
 		 */
526 526
 		$errors = apply_filters( 'frm_entries_before_create', $errors, $form );
527 527
 
528
-		$frm_vars['created_entries'][ $form_id ] = array( 'errors' => $errors );
528
+		$frm_vars['created_entries'][$form_id] = array( 'errors' => $errors );
529 529
 
530 530
 		if ( empty( $errors ) ) {
531 531
 			$_POST['frm_skip_cookie'] = 1;
532 532
 			$do_success               = false;
533 533
 			if ( $params['action'] === 'create' ) {
534
-				if ( apply_filters( 'frm_continue_to_create', true, $form_id ) && ! isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ) {
535
-					$frm_vars['created_entries'][ $form_id ]['entry_id'] = FrmEntry::create( $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
534
+				if ( apply_filters( 'frm_continue_to_create', true, $form_id ) && ! isset( $frm_vars['created_entries'][$form_id]['entry_id'] ) ) {
535
+					$frm_vars['created_entries'][$form_id]['entry_id'] = FrmEntry::create( $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
536 536
 
537
-					$params['id'] = $frm_vars['created_entries'][ $form_id ]['entry_id'];
537
+					$params['id'] = $frm_vars['created_entries'][$form_id]['entry_id'];
538 538
 					$do_success   = true;
539 539
 				}
540 540
 			}
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -491,7 +491,8 @@
 block discarded – undo
491 491
 
492 492
 	public static function process_entry( $errors = '', $ajax = false ) {
493 493
 		$form_id = FrmAppHelper::get_post_param( 'form_id', '', 'absint' );
494
-		if ( FrmAppHelper::is_admin() || empty( $_POST ) || empty( $form_id ) || ! isset( $_POST['item_key'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
494
+		if ( FrmAppHelper::is_admin() || empty( $_POST ) || empty( $form_id ) || ! isset( $_POST['item_key'] ) ) {
495
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
495 496
 			return;
496 497
 		}
497 498
 
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldUserID.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 	protected function get_field_value( $args ) {
53 53
 		$user_ID      = get_current_user_id();
54 54
 		$user_ID      = ( $user_ID ? $user_ID : '' );
55
-		$posted_value = ( FrmAppHelper::is_admin() && $_POST && isset( $_POST['item_meta'][ $this->field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
55
+		$posted_value = ( FrmAppHelper::is_admin() && $_POST && isset( $_POST['item_meta'][$this->field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
56 56
 		$action       = ( isset( $args['action'] ) ? $args['action'] : ( isset( $args['form_action'] ) ? $args['form_action'] : '' ) );
57 57
 		$updating     = $action == 'update';
58 58
 		return ( is_numeric( $this->field['value'] ) || $posted_value || $updating ) ? $this->field['value'] : $user_ID;
Please login to merge, or discard this patch.
classes/helpers/FrmFieldsHelper.php 2 patches
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -180,7 +180,8 @@  discard block
 block discarded – undo
180 180
 	 * @param mixed $value
181 181
 	 */
182 182
 	private static function get_posted_field_setting( $setting, &$value ) {
183
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
183
+		if ( ! isset( $_POST['field_options'][ $setting ] ) ) {
184
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
184 185
 			return;
185 186
 		}
186 187
 
@@ -1084,7 +1085,8 @@  discard block
 block discarded – undo
1084 1085
 
1085 1086
 		// Check posted vals before checking saved values
1086 1087
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
1087
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1088
+		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) {
1089
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1088 1090
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1089 1091
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1090 1092
 				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
@@ -1094,7 +1096,8 @@  discard block
 block discarded – undo
1094 1096
 
1095 1097
 			return $other_val;
1096 1098
 
1097
-		} elseif ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1099
+		} elseif ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) {
1100
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1098 1101
 			// For normal fields
1099 1102
 
1100 1103
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
Please login to merge, or discard this patch.
Spacing   +45 added lines, -45 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 			if ( in_array( $type, array( 'data', 'lookup' ) ) ) {
27 27
 				$values['field_options']['data_type'] = $setting;
28 28
 			} else {
29
-				$values['field_options'][ $setting ] = 1;
29
+				$values['field_options'][$setting] = 1;
30 30
 			}
31 31
 		}
32 32
 
@@ -133,10 +133,10 @@  discard block
 block discarded – undo
133 133
 		}
134 134
 
135 135
 		foreach ( $defaults as $opt => $default ) {
136
-			$values[ $opt ] = isset( $field->field_options[ $opt ] ) ? $field->field_options[ $opt ] : $default;
136
+			$values[$opt] = isset( $field->field_options[$opt] ) ? $field->field_options[$opt] : $default;
137 137
 
138 138
 			if ( $check_post ) {
139
-				self::get_posted_field_setting( $opt . '_' . $field->id, $values[ $opt ] );
139
+				self::get_posted_field_setting( $opt . '_' . $field->id, $values[$opt] );
140 140
 			}
141 141
 
142 142
 			unset( $opt, $default );
@@ -180,18 +180,18 @@  discard block
 block discarded – undo
180 180
 	 * @param mixed $value
181 181
 	 */
182 182
 	private static function get_posted_field_setting( $setting, &$value ) {
183
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
183
+		if ( ! isset( $_POST['field_options'][$setting] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
184 184
 			return;
185 185
 		}
186 186
 
187 187
 		if ( strpos( $setting, 'html' ) !== false ) {
188 188
 			// Strip slashes from HTML but not regex or script tags.
189
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
189
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
190 190
 		} elseif ( strpos( $setting, 'format_' ) === 0 ) {
191 191
 			// TODO: Remove stripslashes on output, and use on input only.
192
-			$value = sanitize_text_field( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
192
+			$value = sanitize_text_field( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
193 193
 		} else {
194
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
194
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
195 195
 			FrmAppHelper::sanitize_value( 'wp_kses_post', $value );
196 196
 		}
197 197
 	}
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
 		$values['default_value'] = FrmAppHelper::maybe_json_encode( $field->default_value );
265 265
 
266 266
 		foreach ( array( 'name', 'description', 'type', 'field_order', 'field_options', 'required' ) as $col ) {
267
-			$values[ $col ] = $field->{$col};
267
+			$values[$col] = $field->{$col};
268 268
 		}
269 269
 	}
270 270
 
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
 		);
305 305
 
306 306
 		$msg = FrmField::get_option( $field, $error );
307
-		$msg = empty( $msg ) ? $defaults[ $error ]['part'] : $msg;
307
+		$msg = empty( $msg ) ? $defaults[$error]['part'] : $msg;
308 308
 		$msg = do_shortcode( $msg );
309 309
 
310 310
 		return $msg;
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
 		}
415 415
 
416 416
 		$base_name = 'default_value_' . $field['id'];
417
-		$html_id    = isset( $field['html_id'] ) ? $field['html_id'] : self::get_html_id( $field );
417
+		$html_id = isset( $field['html_id'] ) ? $field['html_id'] : self::get_html_id( $field );
418 418
 
419 419
 		$default_type = self::get_default_value_type( $field );
420 420
 
@@ -738,7 +738,7 @@  discard block
 block discarded – undo
738 738
 				continue;
739 739
 			}
740 740
 
741
-			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][ $short_key ] );
741
+			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][$short_key] );
742 742
 			$tag  = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
743 743
 
744 744
 			$atts['entry'] = $entry;
@@ -748,7 +748,7 @@  discard block
 block discarded – undo
748 748
 			if ( $replace_with !== null ) {
749 749
 				$replace_with = self::trigger_shortcode_atts( $replace_with, $atts );
750 750
 				self::sanitize_embedded_shortcodes( compact( 'entry' ), $replace_with );
751
-				$content = str_replace( $shortcodes[0][ $short_key ], $replace_with, $content );
751
+				$content = str_replace( $shortcodes[0][$short_key], $replace_with, $content );
752 752
 			}
753 753
 
754 754
 			unset( $atts, $replace_with );
@@ -766,7 +766,7 @@  discard block
 block discarded – undo
766 766
 		$supported_atts = array( 'sanitize', 'sanitize_url' );
767 767
 		$included_atts  = array_intersect( $supported_atts, array_keys( $atts ) );
768 768
 		foreach ( $included_atts as $included_att ) {
769
-			if ( '0' === $atts[ $included_att ] ) {
769
+			if ( '0' === $atts[$included_att] ) {
770 770
 				// Skip any option that uses 0 so sanitize_url=0 does not encode.
771 771
 				continue;
772 772
 			}
@@ -826,8 +826,8 @@  discard block
 block discarded – undo
826 826
 
827 827
 		$dynamic_default = array( 'admin_email', 'siteurl', 'frmurl', 'sitename', 'get' );
828 828
 
829
-		if ( isset( $shortcode_values[ $atts['tag'] ] ) ) {
830
-			$replace_with = $shortcode_values[ $atts['tag'] ];
829
+		if ( isset( $shortcode_values[$atts['tag']] ) ) {
830
+			$replace_with = $shortcode_values[$atts['tag']];
831 831
 		} elseif ( in_array( $atts['tag'], $dynamic_default ) ) {
832 832
 			$replace_with = self::dynamic_default_values( $atts['tag'], $atts );
833 833
 		} elseif ( $clean_tag == 'user_agent' ) {
@@ -1038,8 +1038,8 @@  discard block
 block discarded – undo
1038 1038
 			self::field_types_for_input( $single_input, $field_selection, $field_types );
1039 1039
 		} elseif ( in_array( $type, $multiple_input ) ) {
1040 1040
 			self::field_types_for_input( $multiple_input, $field_selection, $field_types );
1041
-		} elseif ( isset( $field_selection[ $type ] ) ) {
1042
-			$field_types[ $type ] = $field_selection[ $type ];
1041
+		} elseif ( isset( $field_selection[$type] ) ) {
1042
+			$field_types[$type] = $field_selection[$type];
1043 1043
 		}
1044 1044
 
1045 1045
 		$field_types = apply_filters( 'frm_switch_field_types', $field_types, compact( 'type', 'field_selection' ) );
@@ -1072,7 +1072,7 @@  discard block
 block discarded – undo
1072 1072
 
1073 1073
 	private static function field_types_for_input( $inputs, $fields, &$field_types ) {
1074 1074
 		foreach ( $inputs as $input ) {
1075
-			$field_types[ $input ] = $fields[ $input ];
1075
+			$field_types[$input] = $fields[$input];
1076 1076
 			unset( $input );
1077 1077
 		}
1078 1078
 	}
@@ -1104,7 +1104,7 @@  discard block
 block discarded – undo
1104 1104
 			'parent'  => false,
1105 1105
 			'pointer' => false,
1106 1106
 		);
1107
-		$args     = wp_parse_args( $args, $defaults );
1107
+		$args = wp_parse_args( $args, $defaults );
1108 1108
 
1109 1109
 		$opt_key   = $args['opt_key'];
1110 1110
 		$field     = $args['field'];
@@ -1120,24 +1120,24 @@  discard block
 block discarded – undo
1120 1120
 
1121 1121
 		// Check posted vals before checking saved values
1122 1122
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
1123
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1123
+		if ( $parent && isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1124 1124
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1125 1125
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1126
-				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
1126
+				$other_val = isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ) : '';
1127 1127
 			} else {
1128
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1128
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1129 1129
 			}
1130 1130
 
1131 1131
 			return $other_val;
1132 1132
 
1133
-		} elseif ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1133
+		} elseif ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1134 1134
 			// For normal fields
1135 1135
 
1136 1136
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
1137 1137
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
1138
-				$other_val = isset( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ) : '';
1138
+				$other_val = isset( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ) : '';
1139 1139
 			} else {
1140
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1140
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
1141 1141
 			}
1142 1142
 
1143 1143
 			return $other_val;
@@ -1147,8 +1147,8 @@  discard block
 block discarded – undo
1147 1147
 		if ( $field['type'] === 'checkbox' && is_array( $field['value'] ) ) {
1148 1148
 			// Check if there is an "other" val in saved value and make sure the
1149 1149
 			// "other" val is not equal to the Other checkbox option
1150
-			if ( isset( $field['value'][ $opt_key ] ) && $field['options'][ $opt_key ] != $field['value'][ $opt_key ] ) {
1151
-				$other_val = $field['value'][ $opt_key ];
1150
+			if ( isset( $field['value'][$opt_key] ) && $field['options'][$opt_key] != $field['value'][$opt_key] ) {
1151
+				$other_val = $field['value'][$opt_key];
1152 1152
 			}
1153 1153
 		} else {
1154 1154
 			/**
@@ -1160,8 +1160,8 @@  discard block
 block discarded – undo
1160 1160
 				// Multi-select dropdowns - key is not preserved
1161 1161
 				if ( is_array( $field['value'] ) ) {
1162 1162
 					$o_key = array_search( $temp_val, $field['value'] );
1163
-					if ( isset( $field['value'][ $o_key ] ) ) {
1164
-						unset( $field['value'][ $o_key ], $o_key );
1163
+					if ( isset( $field['value'][$o_key] ) ) {
1164
+						unset( $field['value'][$o_key], $o_key );
1165 1165
 					}
1166 1166
 				} elseif ( $temp_val == $field['value'] ) {
1167 1167
 					// For radio and regular dropdowns
@@ -1203,7 +1203,7 @@  discard block
 block discarded – undo
1203 1203
 			return $other_args;
1204 1204
 		}
1205 1205
 
1206
-		$other_opt  = true;
1206
+		$other_opt = true;
1207 1207
 
1208 1208
 		self::set_other_name( $args, $other_args );
1209 1209
 		self::set_other_value( $args, $other_args );
@@ -1361,7 +1361,7 @@  discard block
 block discarded – undo
1361 1361
 		if ( is_array( $val ) ) {
1362 1362
 			foreach ( $val as $k => $v ) {
1363 1363
 				if ( is_string( $v ) ) {
1364
-					$val[ $k ] = str_replace( $replace, $replace_with, $v );
1364
+					$val[$k] = str_replace( $replace, $replace_with, $v );
1365 1365
 					unset( $k, $v );
1366 1366
 				}
1367 1367
 			}
@@ -1714,7 +1714,7 @@  discard block
 block discarded – undo
1714 1714
 			$countries['class'] = 'frm-countries-opts';
1715 1715
 		}
1716 1716
 
1717
-		$prepop[ __( 'Countries', 'formidable' ) ] = $countries;
1717
+		$prepop[__( 'Countries', 'formidable' )] = $countries;
1718 1718
 
1719 1719
 		// State abv.
1720 1720
 		$states    = self::get_us_states();
@@ -1724,7 +1724,7 @@  discard block
 block discarded – undo
1724 1724
 			$state_abv['class'] = 'frm-state-abv-opts';
1725 1725
 		}
1726 1726
 
1727
-		$prepop[ __( 'U.S. State Abbreviations', 'formidable' ) ] = $state_abv;
1727
+		$prepop[__( 'U.S. State Abbreviations', 'formidable' )] = $state_abv;
1728 1728
 
1729 1729
 		// States.
1730 1730
 		$states = array_values( $states );
@@ -1733,7 +1733,7 @@  discard block
 block discarded – undo
1733 1733
 			$states['class'] = 'frm-states-opts';
1734 1734
 		}
1735 1735
 
1736
-		$prepop[ __( 'U.S. States', 'formidable' ) ] = $states;
1736
+		$prepop[__( 'U.S. States', 'formidable' )] = $states;
1737 1737
 		unset( $state_abv, $states );
1738 1738
 
1739 1739
 		// Age.
@@ -1751,7 +1751,7 @@  discard block
 block discarded – undo
1751 1751
 			$ages['class'] = 'frm-age-opts';
1752 1752
 		}
1753 1753
 
1754
-		$prepop[ __( 'Age', 'formidable' ) ] = $ages;
1754
+		$prepop[__( 'Age', 'formidable' )] = $ages;
1755 1755
 
1756 1756
 		// Satisfaction.
1757 1757
 		$satisfaction = array(
@@ -1766,7 +1766,7 @@  discard block
 block discarded – undo
1766 1766
 			$satisfaction['class'] = 'frm-satisfaction-opts';
1767 1767
 		}
1768 1768
 
1769
-		$prepop[ __( 'Satisfaction', 'formidable' ) ] = $satisfaction;
1769
+		$prepop[__( 'Satisfaction', 'formidable' )] = $satisfaction;
1770 1770
 
1771 1771
 		// Importance.
1772 1772
 		$importance = array(
@@ -1781,7 +1781,7 @@  discard block
 block discarded – undo
1781 1781
 			$importance['class'] = 'frm-importance-opts';
1782 1782
 		}
1783 1783
 
1784
-		$prepop[ __( 'Importance', 'formidable' ) ] = $importance;
1784
+		$prepop[__( 'Importance', 'formidable' )] = $importance;
1785 1785
 
1786 1786
 		// Agreement.
1787 1787
 		$agreement = array(
@@ -1796,7 +1796,7 @@  discard block
 block discarded – undo
1796 1796
 			$agreement['class'] = 'frm-agreement-opts';
1797 1797
 		}
1798 1798
 
1799
-		$prepop[ __( 'Agreement', 'formidable' ) ] = $agreement;
1799
+		$prepop[__( 'Agreement', 'formidable' )] = $agreement;
1800 1800
 
1801 1801
 		// Likely.
1802 1802
 		$likely = array(
@@ -1811,7 +1811,7 @@  discard block
 block discarded – undo
1811 1811
 			$likely['class'] = 'frm-likely-opts';
1812 1812
 		}
1813 1813
 
1814
-		$prepop[ __( 'Likely', 'formidable' ) ] = $likely;
1814
+		$prepop[__( 'Likely', 'formidable' )] = $likely;
1815 1815
 
1816 1816
 		$prepop = apply_filters( 'frm_bulk_field_choices', $prepop );
1817 1817
 	}
@@ -2002,16 +2002,16 @@  discard block
 block discarded – undo
2002 2002
 	 */
2003 2003
 	private static function fill_image_setting_options( $options, &$args ) {
2004 2004
 		foreach ( $options as $key => $option ) {
2005
-			$args['options'][ $key ] = $option;
2005
+			$args['options'][$key] = $option;
2006 2006
 
2007 2007
 			if ( ! empty( $option['addon'] ) ) {
2008
-				$args['options'][ $key ]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
2008
+				$args['options'][$key]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
2009 2009
 			}
2010 2010
 
2011
-			unset( $args['options'][ $key ]['addon'] );
2011
+			unset( $args['options'][$key]['addon'] );
2012 2012
 			$fill = array( 'upgrade', 'message', 'content' );
2013 2013
 			foreach ( $fill as $f ) {
2014
-				unset( $args['options'][ $key ][ $f ], $f );
2014
+				unset( $args['options'][$key][$f], $f );
2015 2015
 			}
2016 2016
 		}
2017 2017
 	}
@@ -2032,8 +2032,8 @@  discard block
 block discarded – undo
2032 2032
 
2033 2033
 		$fill = array( 'upgrade', 'message', 'content' );
2034 2034
 		foreach ( $fill as $f ) {
2035
-			if ( isset( $option[ $f ] ) ) {
2036
-				$custom_attrs[ 'data-' . $f ] = $option[ $f ];
2035
+			if ( isset( $option[$f] ) ) {
2036
+				$custom_attrs['data-' . $f] = $option[$f];
2037 2037
 			}
2038 2038
 		}
2039 2039
 
Please login to merge, or discard this patch.
classes/helpers/FrmListHelper.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -235,8 +235,8 @@  discard block
 block discarded – undo
235 235
 			return $this->get_pagenum();
236 236
 		}
237 237
 
238
-		if ( isset( $this->_pagination_args[ $key ] ) ) {
239
-			return $this->_pagination_args[ $key ];
238
+		if ( isset( $this->_pagination_args[$key] ) ) {
239
+			return $this->_pagination_args[$key];
240 240
 		}
241 241
 	}
242 242
 
@@ -284,8 +284,8 @@  discard block
 block discarded – undo
284 284
 	}
285 285
 
286 286
 	private function hidden_search_inputs( $param_name ) {
287
-		if ( ! empty( $_REQUEST[ $param_name ] ) ) {
288
-			$value = sanitize_text_field( wp_unslash( $_REQUEST[ $param_name ] ) );
287
+		if ( ! empty( $_REQUEST[$param_name] ) ) {
288
+			$value = sanitize_text_field( wp_unslash( $_REQUEST[$param_name] ) );
289 289
 			echo '<input type="hidden" name="' . esc_attr( $param_name ) . '" value="' . esc_attr( $value ) . '" />';
290 290
 		}
291 291
 	}
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 
330 330
 		echo "<ul class='subsubsub'>\n";
331 331
 		foreach ( $views as $class => $view ) {
332
-			$views[ $class ] = "\t" . '<li class="' . esc_attr( $class ) . '">' . $view;
332
+			$views[$class] = "\t" . '<li class="' . esc_attr( $class ) . '">' . $view;
333 333
 		}
334 334
 		echo implode( " |</li>\n", $views ) . "</li>\n"; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
335 335
 		echo '</ul>';
@@ -702,7 +702,7 @@  discard block
 block discarded – undo
702 702
 			'next'  => __( 'Next page', 'formidable' ),
703 703
 		);
704 704
 
705
-		return $labels[ $link ];
705
+		return $labels[$link];
706 706
 	}
707 707
 
708 708
 	private function current_url() {
@@ -795,7 +795,7 @@  discard block
 block discarded – undo
795 795
 
796 796
 		// If the primary column doesn't exist fall back to the
797 797
 		// first non-checkbox column.
798
-		if ( ! isset( $columns[ $default ] ) ) {
798
+		if ( ! isset( $columns[$default] ) ) {
799 799
 			$default = self::get_default_primary_column_name();
800 800
 		}
801 801
 
@@ -809,7 +809,7 @@  discard block
 block discarded – undo
809 809
 		 */
810 810
 		$column = apply_filters( 'list_table_primary_column', $default, $this->screen->id );
811 811
 
812
-		if ( empty( $column ) || ! isset( $columns[ $column ] ) ) {
812
+		if ( empty( $column ) || ! isset( $columns[$column] ) ) {
813 813
 			$column = $default;
814 814
 		}
815 815
 
@@ -831,7 +831,7 @@  discard block
 block discarded – undo
831 831
 			// In 4.3, we added a fourth argument for primary column.
832 832
 			$column_headers = array( array(), array(), array(), $this->get_primary_column_name() );
833 833
 			foreach ( $this->_column_headers as $key => $value ) {
834
-				$column_headers[ $key ] = $value;
834
+				$column_headers[$key] = $value;
835 835
 			}
836 836
 
837 837
 			return $column_headers;
@@ -864,7 +864,7 @@  discard block
 block discarded – undo
864 864
 				$data[1] = false;
865 865
 			}
866 866
 
867
-			$sortable[ $id ] = $data;
867
+			$sortable[$id] = $data;
868 868
 		}
869 869
 
870 870
 		$primary = $this->get_primary_column_name();
@@ -941,8 +941,8 @@  discard block
 block discarded – undo
941 941
 				$class[] = 'column-primary';
942 942
 			}
943 943
 
944
-			if ( isset( $sortable[ $column_key ] ) ) {
945
-				list( $orderby, $desc_first ) = $sortable[ $column_key ];
944
+			if ( isset( $sortable[$column_key] ) ) {
945
+				list( $orderby, $desc_first ) = $sortable[$column_key];
946 946
 
947 947
 				if ( $current_orderby == $orderby ) {
948 948
 					$order   = 'asc' == $current_order ? 'desc' : 'asc';
Please login to merge, or discard this patch.
classes/helpers/FrmEntriesHelper.php 2 patches
Braces   +14 added lines, -7 removed lines patch added patch discarded remove patch
@@ -114,13 +114,16 @@  discard block
 block discarded – undo
114 114
 	 */
115 115
 	public static function value_is_posted( $field, $args ) {
116 116
 		$value_is_posted = false;
117
-		if ( $_POST ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
117
+		if ( $_POST ) {
118
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
118 119
 			$repeating = isset( $args['repeating'] ) && $args['repeating'];
119 120
 			if ( $repeating ) {
120
-				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
121
+				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) {
122
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
121 123
 					$value_is_posted = true;
122 124
 				}
123
-			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
125
+			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) {
126
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
124 127
 				$value_is_posted = true;
125 128
 			}
126 129
 		}
@@ -322,8 +325,10 @@  discard block
 block discarded – undo
322 325
 	 * @since 4.01
323 326
 	 */
324 327
 	private static function set_parent_field_posted_value( $field, $value, $args ) {
325
-		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) && is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
326
-			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) || ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
328
+		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) && is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) {
329
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
330
+			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) || ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) {
331
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
327 332
 				$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
328 333
 			}
329 334
 		} else {
@@ -395,7 +400,8 @@  discard block
 block discarded – undo
395 400
 		self::set_other_repeating_vals( $field, $value, $args );
396 401
 
397 402
 		// Check if there are any posted "Other" values.
398
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
403
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) {
404
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
399 405
 
400 406
 			// Save original value.
401 407
 			$args['temp_value'] = $value;
@@ -425,7 +431,8 @@  discard block
 block discarded – undo
425 431
 		}
426 432
 
427 433
 		// Check if there are any other posted "other" values for this field.
428
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
434
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) {
435
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
429 436
 			// Save original value
430 437
 			$args['temp_value'] = $value;
431 438
 			$args['other']      = true;
Please login to merge, or discard this patch.
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -121,10 +121,10 @@  discard block
 block discarded – undo
121 121
 		if ( $_POST ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
122 122
 			$repeating = isset( $args['repeating'] ) && $args['repeating'];
123 123
 			if ( $repeating ) {
124
-				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
124
+				if ( isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
125 125
 					$value_is_posted = true;
126 126
 				}
127
-			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
127
+			} elseif ( isset( $_POST['item_meta'][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
128 128
 				$value_is_posted = true;
129 129
 			}
130 130
 		}
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 		preg_match_all( "/\[(default-message|default_message)\b(.*?)(?:(\/))?\]/s", $message, $shortcodes, PREG_PATTERN_ORDER );
157 157
 
158 158
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
159
-			$add_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
159
+			$add_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
160 160
 			if ( ! empty( $add_atts ) ) {
161 161
 				$this_atts = array_merge( $atts, $add_atts );
162 162
 			} else {
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 			$default = FrmEntriesController::show_entry_shortcode( $this_atts );
167 167
 
168 168
 			// Add the default message.
169
-			$message = str_replace( $shortcodes[0][ $short_key ], $default, $message );
169
+			$message = str_replace( $shortcodes[0][$short_key], $default, $message );
170 170
 		}
171 171
 
172 172
 		return $message;
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 	 * @return string
180 180
 	 */
181 181
 	public static function prepare_display_value( $entry, $field, $atts ) {
182
-		$field_value = isset( $entry->metas[ $field->id ] ) ? $entry->metas[ $field->id ] : false;
182
+		$field_value = isset( $entry->metas[$field->id] ) ? $entry->metas[$field->id] : false;
183 183
 
184 184
 		if ( FrmAppHelper::pro_is_installed() ) {
185 185
 			$empty = empty( $field_value );
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 			$child_entries = FrmEntry::getAll( array( 'it.parent_item_id' => $entry->id ), '', '', true );
205 205
 		} else {
206 206
 			// Get all values for this field.
207
-			$child_values = isset( $entry->metas[ $atts['embedded_field_id'] ] ) ? $entry->metas[ $atts['embedded_field_id'] ] : false;
207
+			$child_values = isset( $entry->metas[$atts['embedded_field_id']] ) ? $entry->metas[$atts['embedded_field_id']] : false;
208 208
 
209 209
 			if ( $child_values ) {
210 210
 				$child_entries = FrmEntry::getAll( array( 'it.id' => (array) $child_values ) );
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
 			$value = $args['temp_value'];
323 323
 		}
324 324
 		if ( empty( $args['parent_field_id'] ) ) {
325
-			$_POST['item_meta'][ $field->id ] = $value;
325
+			$_POST['item_meta'][$field->id] = $value;
326 326
 		} else {
327 327
 			self::set_parent_field_posted_value( $field, $value, $args );
328 328
 		}
@@ -334,17 +334,17 @@  discard block
 block discarded – undo
334 334
 	 * @since 4.01
335 335
 	 */
336 336
 	private static function set_parent_field_posted_value( $field, $value, $args ) {
337
-		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) && is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
338
-			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) || ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
339
-				$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
337
+		if ( isset( $_POST['item_meta'][$args['parent_field_id']] ) && is_array( $_POST['item_meta'][$args['parent_field_id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
338
+			if ( ! isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] ) || ! is_array( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
339
+				$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
340 340
 			}
341 341
 		} else {
342 342
 			// All of the section was probably removed.
343
-			$_POST['item_meta'][ $args['parent_field_id'] ]                         = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
344
-			$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
343
+			$_POST['item_meta'][$args['parent_field_id']]                         = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
344
+			$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
345 345
 		}
346 346
 
347
-		$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] = $value; // phpcs:ignore WordPress.Security.NonceVerification.Missing
347
+		$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field->id] = $value; // phpcs:ignore WordPress.Security.NonceVerification.Missing
348 348
 	}
349 349
 
350 350
 	public static function get_posted_value( $field, &$value, $args ) {
@@ -374,9 +374,9 @@  discard block
 block discarded – undo
374 374
 	private static function get_posted_meta( $field_id, $args ) {
375 375
 		if ( empty( $args['parent_field_id'] ) ) {
376 376
 			// Sanitizing is done next.
377
-			$value = isset( $_POST['item_meta'][ $field_id ] ) ? wp_unslash( $_POST['item_meta'][ $field_id ] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
377
+			$value = isset( $_POST['item_meta'][$field_id] ) ? wp_unslash( $_POST['item_meta'][$field_id] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
378 378
 		} else {
379
-			$value = isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field_id ] ) ? wp_unslash( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field_id ] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
379
+			$value = isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field_id] ) ? wp_unslash( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field_id] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
380 380
 		}
381 381
 		return $value;
382 382
 	}
@@ -407,14 +407,14 @@  discard block
 block discarded – undo
407 407
 		self::set_other_repeating_vals( $field, $value, $args );
408 408
 
409 409
 		// Check if there are any posted "Other" values.
410
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
410
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
411 411
 
412 412
 			// Save original value.
413 413
 			$args['temp_value'] = $value;
414 414
 			$args['other']      = true;
415 415
 
416 416
 			// Sanitizing is done next.
417
-			$other_vals = wp_unslash( $_POST['item_meta']['other'][ $field->id ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
417
+			$other_vals = wp_unslash( $_POST['item_meta']['other'][$field->id] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
418 418
 			FrmAppHelper::sanitize_value( 'sanitize_text_field', $other_vals );
419 419
 
420 420
 			// Set the validation value now
@@ -437,12 +437,12 @@  discard block
 block discarded – undo
437 437
 		}
438 438
 
439 439
 		// Check if there are any other posted "other" values for this field.
440
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
440
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']]['other'][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
441 441
 			// Save original value
442 442
 			$args['temp_value'] = $value;
443 443
 			$args['other']      = true;
444 444
 
445
-			$other_vals = wp_unslash( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
445
+			$other_vals = wp_unslash( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']]['other'][$field->id] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
446 446
 			FrmAppHelper::sanitize_value( 'sanitize_text_field', $other_vals );
447 447
 
448 448
 			// Set the validation value now.
@@ -469,7 +469,7 @@  discard block
 block discarded – undo
469 469
 		if ( is_array( $value ) && $field->type === 'checkbox' ) {
470 470
 			// Combine "Other" values with checked values. "Other" values will override checked box values.
471 471
 			foreach ( $other_vals as $k => $v ) {
472
-				if ( isset( $value[ $k ] ) && trim( $v ) === '' ) {
472
+				if ( isset( $value[$k] ) && trim( $v ) === '' ) {
473 473
 					// If the other box is checked, but doesn't have a value.
474 474
 					$value = '';
475 475
 					break;
@@ -486,25 +486,25 @@  discard block
 block discarded – undo
486 486
 
487 487
 			// Multi-select dropdown.
488 488
 			if ( is_array( $value ) ) {
489
-				$o_key = array_search( $field->options[ $other_key ], $value );
489
+				$o_key = array_search( $field->options[$other_key], $value );
490 490
 
491 491
 				if ( $o_key !== false ) {
492 492
 					// Modify the original value so other key will be preserved.
493
-					$value[ $other_key ] = $value[ $o_key ];
493
+					$value[$other_key] = $value[$o_key];
494 494
 
495 495
 					// By default, the array keys will be numeric for multi-select dropdowns.
496 496
 					// If going backwards and forwards between pages, the array key will match the other key.
497 497
 					if ( $o_key !== $other_key ) {
498
-						unset( $value[ $o_key ] );
498
+						unset( $value[$o_key] );
499 499
 					}
500 500
 
501 501
 					$args['temp_value']  = $value;
502
-					$value[ $other_key ] = reset( $other_vals );
503
-					if ( FrmAppHelper::is_empty_value( $value[ $other_key ] ) ) {
504
-						unset( $value[ $other_key ] );
502
+					$value[$other_key] = reset( $other_vals );
503
+					if ( FrmAppHelper::is_empty_value( $value[$other_key] ) ) {
504
+						unset( $value[$other_key] );
505 505
 					}
506 506
 				}
507
-			} elseif ( $field->options[ $other_key ] == $value ) {
507
+			} elseif ( $field->options[$other_key] == $value ) {
508 508
 				$value = $other_vals;
509 509
 			}
510 510
 		}
@@ -715,7 +715,7 @@  discard block
 block discarded – undo
715 715
 	 * @return void
716 716
 	 */
717 717
 	public static function maybe_render_captcha_score( $entry_id ) {
718
-		$query                 = array(
718
+		$query = array(
719 719
 			'item_id'  => (int) $entry_id,
720 720
 			'field_id' => 0,
721 721
 		);
Please login to merge, or discard this patch.
classes/helpers/FrmAppHelper.php 2 patches
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -412,7 +412,8 @@  discard block
 block discarded – undo
412 412
 
413 413
 		if ( $src === 'get' ) {
414 414
 			$value = isset( $_POST[ $param ] ) ? wp_unslash( $_POST[ $param ] ) : ( isset( $_GET[ $param ] ) ? wp_unslash( $_GET[ $param ] ) : $default ); // phpcs:ignore WordPress.Security.NonceVerification.Missing, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
415
-			if ( ! isset( $_POST[ $param ] ) && isset( $_GET[ $param ] ) && ! is_array( $value ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
415
+			if ( ! isset( $_POST[ $param ] ) && isset( $_GET[ $param ] ) && ! is_array( $value ) ) {
416
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
416 417
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
417 418
 				$value = htmlspecialchars_decode( wp_unslash( $_GET[ $param ] ) );
418 419
 			}
@@ -500,7 +501,8 @@  discard block
 block discarded – undo
500 501
 				$value = wp_unslash( $_GET[ $args['param'] ] );
501 502
 			}
502 503
 		} elseif ( $args['type'] == 'post' ) {
503
-			if ( isset( $_POST[ $args['param'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
504
+			if ( isset( $_POST[ $args['param'] ] ) ) {
505
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
504 506
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
505 507
 				$value = wp_unslash( $_POST[ $args['param'] ] );
506 508
 				if ( $args['serialized'] === true && is_serialized_string( $value ) && is_serialized( $value ) ) {
@@ -508,7 +510,8 @@  discard block
 block discarded – undo
508 510
 				}
509 511
 			}
510 512
 		} else {
511
-			if ( isset( $_REQUEST[ $args['param'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
513
+			if ( isset( $_REQUEST[ $args['param'] ] ) ) {
514
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
512 515
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
513 516
 				$value = wp_unslash( $_REQUEST[ $args['param'] ] );
514 517
 			}
Please login to merge, or discard this patch.
Spacing   +77 added lines, -77 removed lines patch added patch discarded remove patch
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 			'fill'   => '#4d4d4d',
163 163
 			'orange' => '#f05a24',
164 164
 		);
165
-		$atts     = array_merge( $defaults, $atts );
165
+		$atts = array_merge( $defaults, $atts );
166 166
 
167 167
 		return '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 599.68 601.37" width="' . esc_attr( $atts['width'] ) . '" height="' . esc_attr( $atts['height'] ) . '">
168 168
 			<path fill="' . esc_attr( $atts['orange'] ) . '" d="M289.6 384h140v76h-140z"/>
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
 	 * @return string
374 374
 	 */
375 375
 	public static function get_server_value( $value ) {
376
-		return isset( $_SERVER[ $value ] ) ? wp_strip_all_tags( wp_unslash( $_SERVER[ $value ] ) ) : '';
376
+		return isset( $_SERVER[$value] ) ? wp_strip_all_tags( wp_unslash( $_SERVER[$value] ) ) : '';
377 377
 	}
378 378
 
379 379
 	/**
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
 		$ip         = '';
388 388
 
389 389
 		foreach ( $ip_options as $key ) {
390
-			if ( ! isset( $_SERVER[ $key ] ) ) {
390
+			if ( ! isset( $_SERVER[$key] ) ) {
391 391
 				continue;
392 392
 			}
393 393
 
@@ -455,10 +455,10 @@  discard block
 block discarded – undo
455 455
 		}
456 456
 
457 457
 		if ( $src === 'get' ) {
458
-			$value = isset( $_POST[ $param ] ) ? wp_unslash( $_POST[ $param ] ) : ( isset( $_GET[ $param ] ) ? wp_unslash( $_GET[ $param ] ) : $default ); // phpcs:ignore WordPress.Security.NonceVerification.Missing, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
459
-			if ( ! isset( $_POST[ $param ] ) && isset( $_GET[ $param ] ) && ! is_array( $value ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
458
+			$value = isset( $_POST[$param] ) ? wp_unslash( $_POST[$param] ) : ( isset( $_GET[$param] ) ? wp_unslash( $_GET[$param] ) : $default ); // phpcs:ignore WordPress.Security.NonceVerification.Missing, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
459
+			if ( ! isset( $_POST[$param] ) && isset( $_GET[$param] ) && ! is_array( $value ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
460 460
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
461
-				$value = htmlspecialchars_decode( wp_unslash( $_GET[ $param ] ) );
461
+				$value = htmlspecialchars_decode( wp_unslash( $_GET[$param] ) );
462 462
 			}
463 463
 			self::sanitize_value( $sanitize, $value );
464 464
 		} else {
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
 				}
480 480
 
481 481
 				$p     = trim( $p, ']' );
482
-				$value = isset( $value[ $p ] ) ? $value[ $p ] : $default;
482
+				$value = isset( $value[$p] ) ? $value[$p] : $default;
483 483
 			}
484 484
 		}
485 485
 
@@ -535,26 +535,26 @@  discard block
 block discarded – undo
535 535
 			'sanitize' => 'sanitize_text_field',
536 536
 			'serialized' => false,
537 537
 		);
538
-		$args     = wp_parse_args( $args, $defaults );
538
+		$args = wp_parse_args( $args, $defaults );
539 539
 
540 540
 		$value = $args['default'];
541 541
 		if ( $args['type'] == 'get' ) {
542
-			if ( $_GET && isset( $_GET[ $args['param'] ] ) ) {
542
+			if ( $_GET && isset( $_GET[$args['param']] ) ) {
543 543
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
544
-				$value = wp_unslash( $_GET[ $args['param'] ] );
544
+				$value = wp_unslash( $_GET[$args['param']] );
545 545
 			}
546 546
 		} elseif ( $args['type'] == 'post' ) {
547
-			if ( isset( $_POST[ $args['param'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
547
+			if ( isset( $_POST[$args['param']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
548 548
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
549
-				$value = wp_unslash( $_POST[ $args['param'] ] );
549
+				$value = wp_unslash( $_POST[$args['param']] );
550 550
 				if ( $args['serialized'] === true && is_serialized_string( $value ) && is_serialized( $value ) ) {
551 551
 					self::unserialize_or_decode( $value );
552 552
 				}
553 553
 			}
554 554
 		} else {
555
-			if ( isset( $_REQUEST[ $args['param'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
555
+			if ( isset( $_REQUEST[$args['param']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
556 556
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
557
-				$value = wp_unslash( $_REQUEST[ $args['param'] ] );
557
+				$value = wp_unslash( $_REQUEST[$args['param']] );
558 558
 			}
559 559
 		}
560 560
 
@@ -586,7 +586,7 @@  discard block
 block discarded – undo
586 586
 			if ( is_array( $value ) ) {
587 587
 				$temp_values = $value;
588 588
 				foreach ( $temp_values as $k => $v ) {
589
-					self::sanitize_value( $sanitize, $value[ $k ] );
589
+					self::sanitize_value( $sanitize, $value[$k] );
590 590
 				}
591 591
 			} else {
592 592
 				$value = call_user_func( $sanitize, $value );
@@ -597,8 +597,8 @@  discard block
 block discarded – undo
597 597
 	public static function sanitize_request( $sanitize_method, &$values ) {
598 598
 		$temp_values = $values;
599 599
 		foreach ( $temp_values as $k => $val ) {
600
-			if ( isset( $sanitize_method[ $k ] ) ) {
601
-				$values[ $k ] = call_user_func( $sanitize_method[ $k ], $val );
600
+			if ( isset( $sanitize_method[$k] ) ) {
601
+				$values[$k] = call_user_func( $sanitize_method[$k], $val );
602 602
 			}
603 603
 		}
604 604
 	}
@@ -621,7 +621,7 @@  discard block
 block discarded – undo
621 621
 		if ( is_array( $value ) ) {
622 622
 			$temp_values = $value;
623 623
 			foreach ( $temp_values as $k => $v ) {
624
-				self::decode_specialchars( $value[ $k ] );
624
+				self::decode_specialchars( $value[$k] );
625 625
 			}
626 626
 		} else {
627 627
 			self::decode_amp( $value );
@@ -741,7 +741,7 @@  discard block
 block discarded – undo
741 741
 	 * @return array
742 742
 	 */
743 743
 	public static function add_allowed_submit_button_tags( $allowed_html ) {
744
-		$allowed_html['input']                    = array(
744
+		$allowed_html['input'] = array(
745 745
 			'type'           => true,
746 746
 			'value'          => true,
747 747
 			'formnovalidate' => true,
@@ -764,7 +764,7 @@  discard block
 block discarded – undo
764 764
 			$allowed_html = $html;
765 765
 		} elseif ( ! empty( $allowed ) ) {
766 766
 			foreach ( (array) $allowed as $a ) {
767
-				$allowed_html[ $a ] = isset( $html[ $a ] ) ? $html[ $a ] : array();
767
+				$allowed_html[$a] = isset( $html[$a] ) ? $html[$a] : array();
768 768
 			}
769 769
 		}
770 770
 
@@ -943,8 +943,8 @@  discard block
 block discarded – undo
943 943
 		}
944 944
 
945 945
 		global $wp_query;
946
-		if ( isset( $wp_query->query_vars[ $param ] ) ) {
947
-			$value = $wp_query->query_vars[ $param ];
946
+		if ( isset( $wp_query->query_vars[$param] ) ) {
947
+			$value = $wp_query->query_vars[$param];
948 948
 		}
949 949
 
950 950
 		return $value;
@@ -971,9 +971,9 @@  discard block
 block discarded – undo
971 971
 		$deprecated = array(
972 972
 			'frm_clone_solid_icon' => 'frm_clone_icon',
973 973
 		);
974
-		if ( isset( $deprecated[ $icon ] ) ) {
975
-			$icon = $deprecated[ $icon ];
976
-			$class = str_replace( $icon, $deprecated[ $icon ], $class );
974
+		if ( isset( $deprecated[$icon] ) ) {
975
+			$icon = $deprecated[$icon];
976
+			$class = str_replace( $icon, $deprecated[$icon], $class );
977 977
 		}
978 978
 
979 979
 		if ( $icon === $class ) {
@@ -1296,7 +1296,7 @@  discard block
 block discarded – undo
1296 1296
 				'new_file_path' => self::plugin_path() . '/js',
1297 1297
 			)
1298 1298
 		);
1299
-		$new_file  = new FrmCreateFile( $file_atts );
1299
+		$new_file = new FrmCreateFile( $file_atts );
1300 1300
 
1301 1301
 		$files = array(
1302 1302
 			self::plugin_path() . '/js/formidable.min.js',
@@ -1777,8 +1777,8 @@  discard block
 block discarded – undo
1777 1777
 			return $error;
1778 1778
 		}
1779 1779
 
1780
-		$nonce_value = ( $_REQUEST && isset( $_REQUEST[ $nonce_name ] ) ) ? sanitize_text_field( wp_unslash( $_REQUEST[ $nonce_name ] ) ) : '';
1781
-		if ( $_REQUEST && ( ! isset( $_REQUEST[ $nonce_name ] ) || ! wp_verify_nonce( $nonce_value, $nonce ) ) ) {
1780
+		$nonce_value = ( $_REQUEST && isset( $_REQUEST[$nonce_name] ) ) ? sanitize_text_field( wp_unslash( $_REQUEST[$nonce_name] ) ) : '';
1781
+		if ( $_REQUEST && ( ! isset( $_REQUEST[$nonce_name] ) || ! wp_verify_nonce( $nonce_value, $nonce ) ) ) {
1782 1782
 			$frm_settings = self::get_settings();
1783 1783
 			$error        = $frm_settings->admin_permission;
1784 1784
 		}
@@ -1813,7 +1813,7 @@  discard block
 block discarded – undo
1813 1813
 			} else {
1814 1814
 				foreach ( $value as $k => $v ) {
1815 1815
 					if ( ! is_array( $v ) ) {
1816
-						$value[ $k ] = call_user_func( $original_function, $v );
1816
+						$value[$k] = call_user_func( $original_function, $v );
1817 1817
 					}
1818 1818
 				}
1819 1819
 			}
@@ -1838,7 +1838,7 @@  discard block
 block discarded – undo
1838 1838
 				$return = array_merge( $return, self::array_flatten( $value, $keys ) );
1839 1839
 			} else {
1840 1840
 				if ( $keys == 'keep' ) {
1841
-					$return[ $key ] = $value;
1841
+					$return[$key] = $value;
1842 1842
 				} else {
1843 1843
 					$return[] = $value;
1844 1844
 				}
@@ -1891,11 +1891,11 @@  discard block
 block discarded – undo
1891 1891
 		}
1892 1892
 
1893 1893
 		$ver = $default;
1894
-		if ( ! isset( $wp_scripts->registered[ $handle ] ) ) {
1894
+		if ( ! isset( $wp_scripts->registered[$handle] ) ) {
1895 1895
 			return $ver;
1896 1896
 		}
1897 1897
 
1898
-		$query = $wp_scripts->registered[ $handle ];
1898
+		$query = $wp_scripts->registered[$handle];
1899 1899
 		if ( is_object( $query ) && ! empty( $query->ver ) ) {
1900 1900
 			$ver = $query->ver;
1901 1901
 		}
@@ -2001,7 +2001,7 @@  discard block
 block discarded – undo
2001 2001
 			$suffix = 2;
2002 2002
 			do {
2003 2003
 				$key_check = $key . $separator . $suffix;
2004
-				++$suffix;
2004
+				++ $suffix;
2005 2005
 			} while ( in_array( $key_check, $similar_keys, true ) );
2006 2006
 
2007 2007
 			$key = $key_check;
@@ -2102,7 +2102,7 @@  discard block
 block discarded – undo
2102 2102
 
2103 2103
 		foreach ( array( 'name', 'description' ) as $var ) {
2104 2104
 			$default_val    = isset( $record->{$var} ) ? $record->{$var} : '';
2105
-			$values[ $var ] = self::get_param( $var, $default_val, 'get', 'wp_kses_post' );
2105
+			$values[$var] = self::get_param( $var, $default_val, 'get', 'wp_kses_post' );
2106 2106
 			unset( $var, $default_val );
2107 2107
 		}
2108 2108
 
@@ -2160,9 +2160,9 @@  discard block
 block discarded – undo
2160 2160
 			}
2161 2161
 		}
2162 2162
 
2163
-		$field_type = isset( $post_values['field_options'][ 'type_' . $field->id ] ) ? $post_values['field_options'][ 'type_' . $field->id ] : $field->type;
2164
-		if ( isset( $post_values['item_meta'][ $field->id ] ) ) {
2165
-			$new_value = $post_values['item_meta'][ $field->id ];
2163
+		$field_type = isset( $post_values['field_options']['type_' . $field->id] ) ? $post_values['field_options']['type_' . $field->id] : $field->type;
2164
+		if ( isset( $post_values['item_meta'][$field->id] ) ) {
2165
+			$new_value = $post_values['item_meta'][$field->id];
2166 2166
 			self::unserialize_or_decode( $new_value );
2167 2167
 		} else {
2168 2168
 			$new_value = $meta_value;
@@ -2183,7 +2183,7 @@  discard block
 block discarded – undo
2183 2183
 
2184 2184
 		$field_array = array_merge( (array) $field->field_options, $field_array );
2185 2185
 
2186
-		$values['fields'][ $field->id ] = $field_array;
2186
+		$values['fields'][$field->id] = $field_array;
2187 2187
 	}
2188 2188
 
2189 2189
 	/**
@@ -2230,11 +2230,11 @@  discard block
 block discarded – undo
2230 2230
 		}
2231 2231
 
2232 2232
 		foreach ( $form->options as $opt => $value ) {
2233
-			if ( isset( $post_values[ $opt ] ) ) {
2234
-				$values[ $opt ] = $post_values[ $opt ];
2235
-				self::unserialize_or_decode( $values[ $opt ] );
2233
+			if ( isset( $post_values[$opt] ) ) {
2234
+				$values[$opt] = $post_values[$opt];
2235
+				self::unserialize_or_decode( $values[$opt] );
2236 2236
 			} else {
2237
-				$values[ $opt ] = $value;
2237
+				$values[$opt] = $value;
2238 2238
 			}
2239 2239
 		}
2240 2240
 
@@ -2248,8 +2248,8 @@  discard block
 block discarded – undo
2248 2248
 		$form_defaults = FrmFormsHelper::get_default_opts();
2249 2249
 
2250 2250
 		foreach ( $form_defaults as $opt => $default ) {
2251
-			if ( ! isset( $values[ $opt ] ) || $values[ $opt ] == '' ) {
2252
-				$values[ $opt ] = ( $post_values && isset( $post_values['options'][ $opt ] ) ) ? $post_values['options'][ $opt ] : $default;
2251
+			if ( ! isset( $values[$opt] ) || $values[$opt] == '' ) {
2252
+				$values[$opt] = ( $post_values && isset( $post_values['options'][$opt] ) ) ? $post_values['options'][$opt] : $default;
2253 2253
 			}
2254 2254
 
2255 2255
 			unset( $opt, $default );
@@ -2260,8 +2260,8 @@  discard block
 block discarded – undo
2260 2260
 		}
2261 2261
 
2262 2262
 		foreach ( array( 'before', 'after', 'submit' ) as $h ) {
2263
-			if ( ! isset( $values[ $h . '_html' ] ) ) {
2264
-				$values[ $h . '_html' ] = ( isset( $post_values['options'][ $h . '_html' ] ) ? $post_values['options'][ $h . '_html' ] : FrmFormsHelper::get_default_html( $h ) );
2263
+			if ( ! isset( $values[$h . '_html'] ) ) {
2264
+				$values[$h . '_html'] = ( isset( $post_values['options'][$h . '_html'] ) ? $post_values['options'][$h . '_html'] : FrmFormsHelper::get_default_html( $h ) );
2265 2265
 			}
2266 2266
 			unset( $h );
2267 2267
 		}
@@ -2413,25 +2413,25 @@  discard block
 block discarded – undo
2413 2413
 		if ( ! is_numeric( $levels ) ) {
2414 2414
 			// Show time in specified unit.
2415 2415
 			$levels = self::get_unit( $levels );
2416
-			if ( isset( $time_strings[ $levels ] ) ) {
2416
+			if ( isset( $time_strings[$levels] ) ) {
2417 2417
 				$diff = array(
2418 2418
 					$levels => self::time_format( $levels, $diff ),
2419 2419
 				);
2420 2420
 				$time_strings = array(
2421
-					$levels => $time_strings[ $levels ],
2421
+					$levels => $time_strings[$levels],
2422 2422
 				);
2423 2423
 			}
2424 2424
 			$levels = 1;
2425 2425
 		}
2426 2426
 
2427 2427
 		foreach ( $time_strings as $k => $v ) {
2428
-			if ( isset( $diff[ $k ] ) && $diff[ $k ] ) {
2429
-				$time_strings[ $k ] = $diff[ $k ] . ' ' . ( $diff[ $k ] > 1 ? $v[1] : $v[0] );
2430
-			} elseif ( isset( $diff[ $k ] ) && count( $time_strings ) === 1 ) {
2428
+			if ( isset( $diff[$k] ) && $diff[$k] ) {
2429
+				$time_strings[$k] = $diff[$k] . ' ' . ( $diff[$k] > 1 ? $v[1] : $v[0] );
2430
+			} elseif ( isset( $diff[$k] ) && count( $time_strings ) === 1 ) {
2431 2431
 				// Account for 0.
2432
-				$time_strings[ $k ] = $diff[ $k ] . ' ' . $v[1];
2432
+				$time_strings[$k] = $diff[$k] . ' ' . $v[1];
2433 2433
 			} else {
2434
-				unset( $time_strings[ $k ] );
2434
+				unset( $time_strings[$k] );
2435 2435
 			}
2436 2436
 		}
2437 2437
 
@@ -2450,8 +2450,8 @@  discard block
 block discarded – undo
2450 2450
 			'y' => 'y',
2451 2451
 			'd' => 'days',
2452 2452
 		);
2453
-		if ( isset( $return[ $unit ] ) ) {
2454
-			return $diff[ $return[ $unit ] ];
2453
+		if ( isset( $return[$unit] ) ) {
2454
+			return $diff[$return[$unit]];
2455 2455
 		}
2456 2456
 
2457 2457
 		$total = $diff['days'] * self::convert_time( 'd', $unit );
@@ -2459,11 +2459,11 @@  discard block
 block discarded – undo
2459 2459
 		$times = array( 'h', 'i', 's' );
2460 2460
 
2461 2461
 		foreach ( $times as $time ) {
2462
-			if ( ! isset( $diff[ $time ] ) ) {
2462
+			if ( ! isset( $diff[$time] ) ) {
2463 2463
 				continue;
2464 2464
 			}
2465 2465
 
2466
-			$total += $diff[ $time ] * self::convert_time( $time, $unit );
2466
+			$total += $diff[$time] * self::convert_time( $time, $unit );
2467 2467
 		}
2468 2468
 
2469 2469
 		return floor( $total );
@@ -2483,7 +2483,7 @@  discard block
 block discarded – undo
2483 2483
 			'y' => DAY_IN_SECONDS * 365.25,
2484 2484
 		);
2485 2485
 
2486
-		return $convert[ $from ] / $convert[ $to ];
2486
+		return $convert[$from] / $convert[$to];
2487 2487
 	}
2488 2488
 
2489 2489
 	/**
@@ -2491,7 +2491,7 @@  discard block
 block discarded – undo
2491 2491
 	 */
2492 2492
 	private static function get_unit( $unit ) {
2493 2493
 		$units = self::get_time_strings();
2494
-		if ( isset( $units[ $unit ] ) || is_numeric( $unit ) ) {
2494
+		if ( isset( $units[$unit] ) || is_numeric( $unit ) ) {
2495 2495
 			return $unit;
2496 2496
 		}
2497 2497
 
@@ -2602,17 +2602,17 @@  discard block
 block discarded – undo
2602 2602
 
2603 2603
 					case 1:
2604 2604
 						$l2 = $name;
2605
-						self::add_value_to_array( $name, $l2, $this_val, $vars[ $l1 ] );
2605
+						self::add_value_to_array( $name, $l2, $this_val, $vars[$l1] );
2606 2606
 						break;
2607 2607
 
2608 2608
 					case 2:
2609 2609
 						$l3 = $name;
2610
-						self::add_value_to_array( $name, $l3, $this_val, $vars[ $l1 ][ $l2 ] );
2610
+						self::add_value_to_array( $name, $l3, $this_val, $vars[$l1][$l2] );
2611 2611
 						break;
2612 2612
 
2613 2613
 					case 3:
2614 2614
 						$l4 = $name;
2615
-						self::add_value_to_array( $name, $l4, $this_val, $vars[ $l1 ][ $l2 ][ $l3 ] );
2615
+						self::add_value_to_array( $name, $l4, $this_val, $vars[$l1][$l2][$l3] );
2616 2616
 				}
2617 2617
 
2618 2618
 				unset( $this_val, $n );
@@ -2631,8 +2631,8 @@  discard block
 block discarded – undo
2631 2631
 	public static function add_value_to_array( $name, $l1, $val, &$vars ) {
2632 2632
 		if ( $name == '' ) {
2633 2633
 			$vars[] = $val;
2634
-		} elseif ( ! isset( $vars[ $l1 ] ) ) {
2635
-			$vars[ $l1 ] = $val;
2634
+		} elseif ( ! isset( $vars[$l1] ) ) {
2635
+			$vars[$l1] = $val;
2636 2636
 		}
2637 2637
 	}
2638 2638
 
@@ -2648,7 +2648,7 @@  discard block
 block discarded – undo
2648 2648
 			'email_subject' => esc_attr( sprintf( __( 'If you leave the subject blank, the default will be used: %1$s Form submitted on %2$s', 'formidable' ), $form_name, self::site_name() ) ),
2649 2649
 		);
2650 2650
 
2651
-		if ( ! isset( $tooltips[ $name ] ) ) {
2651
+		if ( ! isset( $tooltips[$name] ) ) {
2652 2652
 			return;
2653 2653
 		}
2654 2654
 
@@ -2658,7 +2658,7 @@  discard block
 block discarded – undo
2658 2658
 			echo ' class="frm_help"';
2659 2659
 		}
2660 2660
 
2661
-		echo ' title="' . esc_attr( $tooltips[ $name ] );
2661
+		echo ' title="' . esc_attr( $tooltips[$name] );
2662 2662
 
2663 2663
 		if ( 'open' != $class ) {
2664 2664
 			echo '"';
@@ -2717,13 +2717,13 @@  discard block
 block discarded – undo
2717 2717
 	}
2718 2718
 
2719 2719
 	private static function prepare_action_slashes( $val, $key, &$post_content ) {
2720
-		if ( ! isset( $post_content[ $key ] ) || is_numeric( $val ) ) {
2720
+		if ( ! isset( $post_content[$key] ) || is_numeric( $val ) ) {
2721 2721
 			return;
2722 2722
 		}
2723 2723
 
2724 2724
 		if ( is_array( $val ) ) {
2725 2725
 			foreach ( $val as $k1 => $v1 ) {
2726
-				self::prepare_action_slashes( $v1, $k1, $post_content[ $key ] );
2726
+				self::prepare_action_slashes( $v1, $k1, $post_content[$key] );
2727 2727
 				unset( $k1, $v1 );
2728 2728
 			}
2729 2729
 		} else {
@@ -2731,7 +2731,7 @@  discard block
 block discarded – undo
2731 2731
 			$val = stripslashes( $val );
2732 2732
 
2733 2733
 			// Add backslashes before double quotes and forward slashes only
2734
-			$post_content[ $key ] = addcslashes( $val, '"\\/' );
2734
+			$post_content[$key] = addcslashes( $val, '"\\/' );
2735 2735
 		}
2736 2736
 	}
2737 2737
 
@@ -2794,14 +2794,14 @@  discard block
 block discarded – undo
2794 2794
 				continue;
2795 2795
 			}
2796 2796
 			$key = $input['name'];
2797
-			if ( isset( $formatted[ $key ] ) ) {
2798
-				if ( is_array( $formatted[ $key ] ) ) {
2799
-					$formatted[ $key ][] = $input['value'];
2797
+			if ( isset( $formatted[$key] ) ) {
2798
+				if ( is_array( $formatted[$key] ) ) {
2799
+					$formatted[$key][] = $input['value'];
2800 2800
 				} else {
2801
-					$formatted[ $key ] = array( $formatted[ $key ], $input['value'] );
2801
+					$formatted[$key] = array( $formatted[$key], $input['value'] );
2802 2802
 				}
2803 2803
 			} else {
2804
-				$formatted[ $key ] = $input['value'];
2804
+				$formatted[$key] = $input['value'];
2805 2805
 			}
2806 2806
 		}
2807 2807
 
@@ -3463,8 +3463,8 @@  discard block
 block discarded – undo
3463 3463
 		}
3464 3464
 
3465 3465
 		foreach ( $keys as $key ) {
3466
-			if ( isset( $values[ $key ] ) ) {
3467
-				$values[ $key ] = self::kses( $values[ $key ], 'all' );
3466
+			if ( isset( $values[$key] ) ) {
3467
+				$values[$key] = self::kses( $values[$key], 'all' );
3468 3468
 			}
3469 3469
 		}
3470 3470
 
@@ -3623,7 +3623,7 @@  discard block
 block discarded – undo
3623 3623
 			return 0;
3624 3624
 		}
3625 3625
 
3626
-		return strlen( $parts[ count( $parts ) - 1 ] );
3626
+		return strlen( $parts[count( $parts ) - 1] );
3627 3627
 	}
3628 3628
 
3629 3629
 	/**
Please login to merge, or discard this patch.
deprecated/FrmEDD_SL_Plugin_Updater.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 		$this->beta        = ! empty( $this->api_data['beta'] ) ? true : false;
45 45
 		$this->cache_key   = md5( serialize( $this->slug . $this->version . $this->api_data['license'] . $this->beta ) );
46 46
 
47
-		$frm_edd_plugin_data[ $this->slug ] = $this->api_data;
47
+		$frm_edd_plugin_data[$this->slug] = $this->api_data;
48 48
 
49 49
 		/**
50 50
 		 * Fires after the $frm_edd_plugin_data is setup.
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 			$_transient_data = new stdClass();
94 94
 		}
95 95
 
96
-		if ( ! empty( $_transient_data->response ) && ! empty( $_transient_data->response[ $this->name ] ) && false === $this->wp_override ) {
96
+		if ( ! empty( $_transient_data->response ) && ! empty( $_transient_data->response[$this->name] ) && false === $this->wp_override ) {
97 97
 			return $_transient_data;
98 98
 		}
99 99
 
@@ -120,12 +120,12 @@  discard block
 block discarded – undo
120 120
 					$version_info->plugin = $this->name;
121 121
 				}
122 122
 
123
-				$_transient_data->response[ $this->name ] = $version_info;
123
+				$_transient_data->response[$this->name] = $version_info;
124 124
 
125 125
 			}
126 126
 
127 127
 			$_transient_data->last_checked           = time();
128
-			$_transient_data->checked[ $this->name ] = $this->version;
128
+			$_transient_data->checked[$this->name] = $this->version;
129 129
 
130 130
 		}
131 131
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 		if ( isset( $_data->sections ) && ! is_array( $_data->sections ) ) {
190 190
 			$new_sections = array();
191 191
 			foreach ( $_data->sections as $key => $value ) {
192
-				$new_sections[ $key ] = $value;
192
+				$new_sections[$key] = $value;
193 193
 			}
194 194
 
195 195
 			$_data->sections = $new_sections;
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 		if ( isset( $_data->banners ) && ! is_array( $_data->banners ) ) {
200 200
 			$new_banners = array();
201 201
 			foreach ( $_data->banners as $key => $value ) {
202
-				$new_banners[ $key ] = $value;
202
+				$new_banners[$key] = $value;
203 203
 			}
204 204
 
205 205
 			$_data->banners = $new_banners;
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 		}
317 317
 
318 318
 		$slug         = sanitize_text_field( $_REQUEST['slug'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
319
-		$data         = $frm_edd_plugin_data[ $slug ];
319
+		$data         = $frm_edd_plugin_data[$slug];
320 320
 		$beta         = ! empty( $data['beta'] ) ? true : false;
321 321
 		$cache_key    = md5( 'edd_plugin_' . sanitize_key( $_REQUEST['plugin'] ) . '_' . $beta . '_version_info' ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
322 322
 		$version_info = $this->get_cached_version_info( $cache_key );
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -303,11 +303,13 @@
 block discarded – undo
303 303
 
304 304
 		global $frm_edd_plugin_data;
305 305
 
306
-		if ( empty( $_REQUEST['edd_sl_action'] ) || 'view_plugin_changelog' !== $_REQUEST['edd_sl_action'] ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
306
+		if ( empty( $_REQUEST['edd_sl_action'] ) || 'view_plugin_changelog' !== $_REQUEST['edd_sl_action'] ) {
307
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
307 308
 			return;
308 309
 		}
309 310
 
310
-		if ( empty( $_REQUEST['plugin'] ) || empty( $_REQUEST['slug'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
311
+		if ( empty( $_REQUEST['plugin'] ) || empty( $_REQUEST['slug'] ) ) {
312
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
311 313
 			return;
312 314
 		}
313 315
 
Please login to merge, or discard this patch.
classes/views/solutions/_import.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 				$info['url'] = $xml;
12 12
 			}
13 13
 
14
-			$disabled = isset( $imported[ $info['form'] ] ) ? ' disabled' : '';
14
+			$disabled = isset( $imported[$info['form']] ) ? ' disabled' : '';
15 15
 			$url   = isset( $info['url'] ) ? $info['url'] : '';
16 16
 			$value = $importing === 'form' ? $info['form'] : $info['key'];
17 17
 			if ( ! isset( $info['img'] ) ) {
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 				continue;
22 22
 			}
23 23
 
24
-			$hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[ $info['form'] ] ) );
24
+			$hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[$info['form']] ) );
25 25
 			?>
26 26
 			<div class="frm_radio radio-inline radio frm_image_option<?php echo esc_attr( $importing === 'view' ? ' show_sub_opt show_' . $info['form'] : '' ); ?>" style="<?php echo esc_attr( $hide_views ? 'display:none' : '' ); ?>">
27 27
 				<?php if ( $importing === 'form' ) { ?>
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 					<?php } ?>
42 42
 					/>
43 43
 					<div class="frm_image_option_container frm_label_with_image">
44
-						<?php echo FrmAppHelper::kses( $info['img'], array( 'svg', 'rect', 'path' ) );  // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
44
+						<?php echo FrmAppHelper::kses( $info['img'], array( 'svg', 'rect', 'path' ) ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
45 45
 						<span class="frm_text_label_for_image">
46 46
 							<?php
47 47
 							if ( ! empty( $disabled ) ) {
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 							}
55 55
 
56 56
 							if ( $importing === 'form' && $disabled ) {
57
-								echo FrmAppHelper::kses( FrmFormsHelper::edit_form_link( $imported[ $info['form'] ] ), array( 'a' ) ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
57
+								echo FrmAppHelper::kses( FrmFormsHelper::edit_form_link( $imported[$info['form']] ), array( 'a' ) ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
58 58
 							} else {
59 59
 								echo esc_html( $info['name'] );
60 60
 							}
Please login to merge, or discard this patch.