Completed
Pull Request — master (#2341)
by
unknown
01:13
created
classes/models/fields/FrmFieldText.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 		$max_length = intval( FrmField::get_option( $this->field, 'max' ) );
43 43
 
44 44
 		if ( $max_length && FrmAppHelper::mb_function( array( 'mb_strlen', 'strlen' ), array( $args['value'] ) ) > $max_length ) {
45
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
45
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
46 46
 		}
47 47
 
48 48
 		return $errors;
Please login to merge, or discard this patch.
classes/models/FrmEntryMeta.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 
59 59
 		global $wpdb;
60 60
 
61
-		$values               = array(
61
+		$values = array(
62 62
 			'item_id'  => $entry_id,
63 63
 			'field_id' => $field_id,
64 64
 		);
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 				}
139 139
 			}
140 140
 
141
-			$values_indexed_by_field_id[ $field_id ] = $meta_value;
141
+			$values_indexed_by_field_id[$field_id] = $meta_value;
142 142
 
143 143
 			self::get_value_to_save( compact( 'field', 'field_id', 'entry_id' ), $meta_value );
144 144
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 
147 147
 				if ( ( is_array( $meta_value ) && empty( $meta_value ) ) || ( ! is_array( $meta_value ) && trim( $meta_value ) == '' ) ) {
148 148
 					// Remove blank fields.
149
-					unset( $values_indexed_by_field_id[ $field_id ] );
149
+					unset( $values_indexed_by_field_id[$field_id] );
150 150
 				} else {
151 151
 					// if value exists, then update it
152 152
 					self::update_entry_meta( $entry_id, $field_id, '', $meta_value );
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 	 */
225 225
 	public static function get_meta_value( $entry, $field_id ) {
226 226
 		if ( isset( $entry->metas ) ) {
227
-			return isset( $entry->metas[ $field_id ] ) ? $entry->metas[ $field_id ] : false;
227
+			return isset( $entry->metas[$field_id] ) ? $entry->metas[$field_id] : false;
228 228
 		}
229 229
 		return self::get_entry_meta_by_field( $entry->id, $field_id );
230 230
 	}
@@ -241,8 +241,8 @@  discard block
 block discarded – undo
241 241
 			$cached   = FrmDb::check_cache( $entry_id, 'frm_entry' );
242 242
 		}
243 243
 
244
-		if ( $cached && isset( $cached->metas ) && isset( $cached->metas[ $field_id ] ) ) {
245
-			$result = $cached->metas[ $field_id ];
244
+		if ( $cached && isset( $cached->metas ) && isset( $cached->metas[$field_id] ) ) {
245
+			$result = $cached->metas[$field_id];
246 246
 
247 247
 			return wp_unslash( $result );
248 248
 		}
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
 			'stripslashes' => true,
274 274
 			'is_draft'     => false,
275 275
 		);
276
-		$args     = wp_parse_args( $args, $defaults );
276
+		$args = wp_parse_args( $args, $defaults );
277 277
 
278 278
 		$query = array();
279 279
 		self::meta_field_query( $field_id, $order, $limit, $args, $query );
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
 
289 289
 		foreach ( $values as $k => $v ) {
290 290
 			FrmAppHelper::unserialize_or_decode( $v );
291
-			$values[ $k ] = $v;
291
+			$values[$k] = $v;
292 292
 			unset( $k, $v );
293 293
 		}
294 294
 
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
 
356 356
 		foreach ( $results as $k => $result ) {
357 357
 			FrmAppHelper::unserialize_or_decode( $result->meta_value );
358
-			$results[ $k ]->meta_value = wp_unslash( $result->meta_value );
358
+			$results[$k]->meta_value = wp_unslash( $result->meta_value );
359 359
 			unset( $k, $result );
360 360
 		}
361 361
 
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
368 368
 			'user_id'  => '',
369 369
 			'group_by' => '',
370 370
 		);
371
-		$args     = wp_parse_args( $args, $defaults );
371
+		$args = wp_parse_args( $args, $defaults );
372 372
 
373 373
 		$query = array();
374 374
 		self::get_ids_query( $where, $order_by, $limit, $unique, $args, $query );
@@ -435,7 +435,7 @@  discard block
 block discarded – undo
435 435
 			} elseif ( false !== strpos( $args['is_draft'], ',' ) ) {
436 436
 				$is_draft = array_reduce(
437 437
 					explode( ',', $args['is_draft'] ),
438
-					function ( $total, $current ) {
438
+					function( $total, $current ) {
439 439
 						if ( is_numeric( $current ) ) {
440 440
 							$total[] = absint( $current );
441 441
 						}
Please login to merge, or discard this patch.
classes/views/styles/components/templates/slider.php 1 patch
Braces   +10 added lines, -4 removed lines patch added patch discarded remove patch
@@ -137,10 +137,13 @@  discard block
 block discarded – undo
137 137
 		</div>
138 138
 		<input type="hidden" <?php echo esc_attr( $field_name ); ?> value="<?php echo esc_attr( $field_value ); ?>" id="<?php echo esc_attr( $component['id'] ); ?>" />
139 139
 	</div>
140
-<?php else : ?>
140
+<?php else {
141
+	: ?>
141 142
 	<div>
142 143
 		<?php if ( empty( $component['independent_fields'] ) ) : ?>
143
-			<div class="frm-slider-component <?php echo esc_attr( $component_class ); ?>" <?php echo esc_attr( $component_attr ); ?> data-display-sliders="top,bottom" data-type="vertical" data-max-value="<?php echo (int) $component['max_value']; ?>">
144
+			<div class="frm-slider-component <?php echo esc_attr( $component_class );
145
+}
146
+?>" <?php echo esc_attr( $component_attr ); ?> data-display-sliders="top,bottom" data-type="vertical" data-max-value="<?php echo (int) $component['max_value']; ?>">
144 147
 				<div class="frm-flex-justify">
145 148
 					<div class="frm-slider-container">
146 149
 						<?php if ( ! empty( $component['icon'] ) ) : ?>
@@ -165,8 +168,11 @@  discard block
 block discarded – undo
165 168
 					</div>
166 169
 				</div>
167 170
 			</div>
168
-		<?php else : ?>
169
-			<div class="<?php echo esc_attr( $component_class ); ?>" <?php echo esc_attr( $component_attr ); ?> >
171
+		<?php else {
172
+	: ?>
173
+			<div class="<?php echo esc_attr( $component_class );
174
+}
175
+?>" <?php echo esc_attr( $component_attr ); ?> >
170 176
 				<div class="frm-slider-component frm-group-sliders frm-has-independent-fields" data-display-sliders="top,bottom" data-max-value="<?php echo (int) $component['max_value']; ?>">
171 177
 					<div class="frm-flex-justify">
172 178
 						<div class="frm-slider-container">
Please login to merge, or discard this patch.
stripe/models/FrmTransLiteAction.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -181,7 +181,7 @@
 block discarded – undo
181 181
 				$has_field  = true;
182 182
 				$key_exists = array_key_exists( $field_atts['name'], $form_atts['form_action']->post_content );
183 183
 				?>
184
-				<option value="<?php echo esc_attr( $field->id ); ?>" <?php selected( $key_exists ? $form_atts['form_action']->post_content[ $field_atts['name'] ] : 0, $field->id ); ?>>
184
+				<option value="<?php echo esc_attr( $field->id ); ?>" <?php selected( $key_exists ? $form_atts['form_action']->post_content[$field_atts['name']] : 0, $field->id ); ?>>
185 185
 					<?php
186 186
 					echo esc_attr( FrmAppHelper::truncate( $field->name, 50, 1 ) );
187 187
 
Please login to merge, or discard this patch.
stripe/helpers/FrmTransLiteListHelper.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 			'payments'      => $frm_payment->get_count(),
124 124
 			'subscriptions' => $frm_sub->get_count(),
125 125
 		);
126
-		$type        = FrmAppHelper::get_simple_request(
126
+		$type = FrmAppHelper::get_simple_request(
127 127
 			array(
128 128
 				'param'   => 'trans_type',
129 129
 				'type'    => 'request',
@@ -138,10 +138,10 @@  discard block
 block discarded – undo
138 138
 				$class = '';
139 139
 			}
140 140
 
141
-			if ( $counts[ $status ] || 'published' === $status ) {
142
-				$links[ $status ] = '<a href="' . esc_url( '?page=formidable-payments&trans_type=' . $status ) . '" ' . $class . '>'
141
+			if ( $counts[$status] || 'published' === $status ) {
142
+				$links[$status] = '<a href="' . esc_url( '?page=formidable-payments&trans_type=' . $status ) . '" ' . $class . '>'
143 143
 					// translators: %1$s: Transaction type (Payments or Subscriptions), %2$s: Span start tag, %3$s: Count, %4$s: Span close tag.
144
-					. sprintf( esc_html__( '%1$s %2$s(%3$s)%4$s', 'formidable' ), esc_html( $name ), '<span class="count">', number_format_i18n( $counts[ $status ] ), '</span>' )
144
+					. sprintf( esc_html__( '%1$s %2$s(%3$s)%4$s', 'formidable' ), esc_html( $name ), '<span class="count">', number_format_i18n( $counts[$status] ), '</span>' )
145 145
 					. '</a>';
146 146
 			}
147 147
 
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
 			echo '<tr id="payment-' . esc_attr( $item->id ) . '" ';
219 219
 
220 220
 			$is_alternate = 0 === $alt % 2;
221
-			++$alt;
221
+			++ $alt;
222 222
 
223 223
 			if ( $is_alternate ) {
224 224
 				echo 'class="alternate"';
@@ -309,7 +309,7 @@  discard block
 block discarded – undo
309 309
 
310 310
 		$form_ids = array();
311 311
 		foreach ( $forms as $form ) {
312
-			$form_ids[ $form->id ] = $form;
312
+			$form_ids[$form->id] = $form;
313 313
 			unset( $form );
314 314
 		}
315 315
 
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
 			'href'  => esc_url( $link ),
361 361
 			'title' => __( 'View', 'formidable' ),
362 362
 		);
363
-		$link        = '<a ' . FrmAppHelper::array_to_html_params( $link_params ) . '>'
363
+		$link = '<a ' . FrmAppHelper::array_to_html_params( $link_params ) . '>'
364 364
 			. $item->{$field}
365 365
 			. '</a>';
366 366
 
@@ -415,8 +415,8 @@  discard block
 block discarded – undo
415 415
 	 * @return mixed
416 416
 	 */
417 417
 	private function get_form_id_column( $item, $atts ) {
418
-		if ( isset( $atts['form_ids'][ $item->item_id ] ) ) {
419
-			$form_link = FrmFormsHelper::edit_form_link( $atts['form_ids'][ $item->item_id ]->form_id );
418
+		if ( isset( $atts['form_ids'][$item->item_id] ) ) {
419
+			$form_link = FrmFormsHelper::edit_form_link( $atts['form_ids'][$item->item_id]->form_id );
420 420
 			return $form_link;
421 421
 		}
422 422
 
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
 	 */
492 492
 	private function get_processing_tooltip() {
493 493
 		return FrmAppHelper::clip(
494
-			function () {
494
+			function() {
495 495
 				FrmAppHelper::tooltip_icon( __( 'This payment method may take between 4-5 business days to process.', 'formidable' ) );
496 496
 			}
497 497
 		);
Please login to merge, or discard this patch.
classes/controllers/FrmStylesController.php 2 patches
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
 			/**
155 155
 			 * Update the form data on the "Manage Styles" tab after global settings are saved.
156 156
 			 */
157
-			function () {
157
+			function() {
158 158
 				self::manage_styles();
159 159
 			}
160 160
 		);
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 
326 326
 		$style_id = self::get_style_id_for_styler();
327 327
 		if ( ! $style_id ) {
328
-			$error_args   = array(
328
+			$error_args = array(
329 329
 				'title'      => __( 'No styles', 'formidable' ),
330 330
 				'body'       => __( 'You must have a style to use the Visual Styler.', 'formidable' ),
331 331
 				'cancel_url' => admin_url( 'admin.php?page=formidable' ),
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
 		$form = FrmForm::getOne( $form_id );
343 343
 
344 344
 		if ( ! is_object( $form ) ) {
345
-			$error_args   = array(
345
+			$error_args = array(
346 346
 				'title'      => __( 'No forms', 'formidable' ),
347 347
 				'body'       => __( 'You must have a form to use the Visual Styler.', 'formidable' ),
348 348
 				'cancel_url' => admin_url( 'admin.php?page=formidable' ),
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
 		if ( ! $form_id ) {
416 416
 			// TODO: Show a message why a random form is being shown (because no form is assigned to the style).
417 417
 			// Fallback to any form.
418
-			$where   = array(
418
+			$where = array(
419 419
 				'status'         => 'published',
420 420
 				// Make sure it's not a repeater.
421 421
 				'parent_form_id' => array( null, 0 ),
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
 	private static function disable_admin_page_styling_on_submit_buttons() {
435 435
 		add_filter(
436 436
 			'frm_submit_button_class',
437
-			function ( $classes ) {
437
+			function( $classes ) {
438 438
 				$classes[] = 'frm_no_style_button';
439 439
 				return $classes;
440 440
 			}
@@ -643,13 +643,13 @@  discard block
 block discarded – undo
643 643
 	private static function force_form_style( $style ) {
644 644
 		add_filter(
645 645
 			'frm_add_form_style_class',
646
-			function ( $class ) use ( $style ) {
647
-				$split   = array_filter(
646
+			function( $class ) use ( $style ) {
647
+				$split = array_filter(
648 648
 					explode( ' ', $class ),
649 649
 					/**
650 650
 					 * @param string $class
651 651
 					 */
652
-					function ( $class ) {
652
+					function( $class ) {
653 653
 						return $class && 0 !== strpos( $class, 'frm_style_' );
654 654
 					}
655 655
 				);
@@ -765,11 +765,11 @@  discard block
 block discarded – undo
765 765
 
766 766
 		$forms = FrmForm::get_published_forms();
767 767
 		foreach ( $forms as $form ) {
768
-			if ( ! isset( $_POST['style'] ) || ! isset( $_POST['style'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
768
+			if ( ! isset( $_POST['style'] ) || ! isset( $_POST['style'][$form->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
769 769
 				continue;
770 770
 			}
771 771
 
772
-			$new_style = sanitize_text_field( wp_unslash( $_POST['style'][ $form->id ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
772
+			$new_style = sanitize_text_field( wp_unslash( $_POST['style'][$form->id] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
773 773
 
774 774
 			$form->options['custom_style'] = $new_style;
775 775
 			$wpdb->update( $wpdb->prefix . 'frm_forms', array( 'options' => maybe_serialize( $form->options ) ), array( 'id' => $form->id ) );
@@ -1178,8 +1178,8 @@  discard block
 block discarded – undo
1178 1178
 	 */
1179 1179
 	public static function get_style_val( $val, $form = 'default' ) {
1180 1180
 		$style = self::get_form_style( $form );
1181
-		if ( $style && isset( $style->post_content[ $val ] ) ) {
1182
-			return $style->post_content[ $val ];
1181
+		if ( $style && isset( $style->post_content[$val] ) ) {
1182
+			return $style->post_content[$val];
1183 1183
 		}
1184 1184
 	}
1185 1185
 
@@ -1198,7 +1198,7 @@  discard block
 block discarded – undo
1198 1198
 			} elseif ( 'alt_bg_color' == $name ) {
1199 1199
 				$setting = 'bg_color_active';
1200 1200
 			}
1201
-			$default_styles[ $name ] = $style->post_content[ $setting ];
1201
+			$default_styles[$name] = $style->post_content[$setting];
1202 1202
 			unset( $name, $val );
1203 1203
 		}
1204 1204
 
@@ -1244,16 +1244,16 @@  discard block
 block discarded – undo
1244 1244
 		$i          = 0;
1245 1245
 		$first_open = false;
1246 1246
 
1247
-		if ( isset( $wp_meta_boxes[ $page ][ $context ] ) ) {
1247
+		if ( isset( $wp_meta_boxes[$page][$context] ) ) {
1248 1248
 			foreach ( array( 'high', 'core', 'default', 'low' ) as $priority ) {
1249
-				if ( isset( $wp_meta_boxes[ $page ][ $context ][ $priority ] ) ) {
1250
-					foreach ( $wp_meta_boxes[ $page ][ $context ][ $priority ] as $box ) {
1249
+				if ( isset( $wp_meta_boxes[$page][$context][$priority] ) ) {
1250
+					foreach ( $wp_meta_boxes[$page][$context][$priority] as $box ) {
1251 1251
 						if ( false === $box || ! $box['title'] ) {
1252 1252
 							continue;
1253 1253
 						}
1254 1254
 
1255
-						++$i;
1256
-						$icon_id = array_key_exists( $box['id'], $icon_ids ) ? $icon_ids[ $box['id'] ] : 'frm-' . $box['id'];
1255
+						++ $i;
1256
+						$icon_id = array_key_exists( $box['id'], $icon_ids ) ? $icon_ids[$box['id']] : 'frm-' . $box['id'];
1257 1257
 
1258 1258
 						$open_class = '';
1259 1259
 						if ( ! $first_open ) {
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -144,7 +144,8 @@  discard block
 block discarded – undo
144 144
 	 * @return void
145 145
 	 */
146 146
 	private static function maybe_hook_into_global_settings_save() {
147
-		if ( empty( $_POST ) || ! isset( $_POST['style'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
147
+		if ( empty( $_POST ) || ! isset( $_POST['style'] ) ) {
148
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
148 149
 			// Avoid changing any style data if the style array is not sent in the request.
149 150
 			return;
150 151
 		}
@@ -765,7 +766,8 @@  discard block
 block discarded – undo
765 766
 
766 767
 		$forms = FrmForm::get_published_forms();
767 768
 		foreach ( $forms as $form ) {
768
-			if ( ! isset( $_POST['style'] ) || ! isset( $_POST['style'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
769
+			if ( ! isset( $_POST['style'] ) || ! isset( $_POST['style'][ $form->id ] ) ) {
770
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
769 771
 				continue;
770 772
 			}
771 773
 
Please login to merge, or discard this patch.
classes/models/FrmInstallPlugin.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 		// Get posted data.
83 83
 		$plugin_slug = FrmAppHelper::get_post_param( 'plugin', '', 'sanitize_text_field' );
84 84
 
85
-		if ( ! empty( get_plugins()[ $plugin_slug ] ) ) {
85
+		if ( ! empty( get_plugins()[$plugin_slug] ) ) {
86 86
 			$activate = activate_plugin( $plugin_slug );
87 87
 		} else {
88 88
 			// Include necessary files for plugin installation.
@@ -163,6 +163,6 @@  discard block
 block discarded – undo
163 163
 	 * @return bool
164 164
 	 */
165 165
 	private static function is_plugin_installed( $plugin_file ) {
166
-		return isset( get_plugins()[ $plugin_file ] );
166
+		return isset( get_plugins()[$plugin_file] );
167 167
 	}
168 168
 }
Please login to merge, or discard this patch.
classes/views/frm-entries/direct.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
 
6 6
 add_filter(
7 7
 	'document_title',
8
-	function ( $title ) use ( $form ) {
8
+	function( $title ) use ( $form ) {
9 9
 		$form_name = '' === $form->name ? FrmFormsHelper::get_no_title_text() : $form->name;
10 10
 		return get_bloginfo( 'name', 'display' ) . ' | ' . wp_strip_all_tags( $form_name );
11 11
 	}
Please login to merge, or discard this patch.
classes/widgets/FrmElementorWidget.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
 
76 76
 			foreach ( $forms as $form ) {
77 77
 				$form_title           = '' === $form->name ? FrmFormsHelper::get_no_title_text() : FrmAppHelper::truncate( $form->name, 50 );
78
-				$options[ $form->id ] = esc_html( $form_title );
78
+				$options[$form->id] = esc_html( $form_title );
79 79
 			}
80 80
 
81 81
 			return $options;
Please login to merge, or discard this patch.