Strategy11 / formidable-forms

classes/views/inbox/list.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 			</h3>
 			<span class="frm_inbox_date">
 				<?php
-				if ( ! isset( $message['read'] ) || ! isset( $message['read'][ $user->ID ] ) ) {
+				if ( ! isset( $message['read'] ) || ! isset( $message['read'][$user->ID] ) ) {
 					$inbox->mark_read( $key );
 					?>
 					<span class="frm_inbox_unread"></span>

classes/models/FrmSolution.php

Spacing +10 added lines, -10 removed lines

@@ -159,7 +159,7 @@ 
 	 */
 	public function add_settings( $sections ) {
 		wp_enqueue_style( 'formidable-pro-fields' );
-		$sections[ $this->plugin_slug ] = array(
+		$sections[$this->plugin_slug] = array(
 			'class'    => $this,
 			'function' => 'settings_page',
 			'name'     => $this->plugin_name(),
@@ -316,9 +316,9 @@ 
 			// Set the current step.
 			if ( ! isset( $step['current'] ) ) {
 				if ( $step['complete'] ) {
-					$steps[ $k ]['current'] = false;
+					$steps[$k]['current'] = false;
 				} else {
-					$steps[ $k ]['current'] = ! $has_current;
+					$steps[$k]['current'] = ! $has_current;
 					$has_current = true;
 				}
 			} elseif ( $step['current'] ) {
@@ -328,10 +328,10 @@ 
 			// Set disabled buttons.
 			$class = isset( $step['button_class'] ) ? $step['button_class'] : '';
 			$class .= ' button-primary frm-button-primary';
-			if ( ! $steps[ $k ]['current'] ) {
+			if ( ! $steps[$k]['current'] ) {
 				$class .= ' frm_grey disabled';
 			}
-			$steps[ $k ]['button_class'] = $class;
+			$steps[$k]['button_class'] = $class;
 		}
 
 		return $steps;
@@ -353,7 +353,7 @@ 
 			if ( $plugin['status'] === 'active' ) {
 				continue;
 			}
-			$links[ $plugin_key ] = $plugin;
+			$links[$plugin_key] = $plugin;
 			if ( isset( $plugin['url'] ) ) {
 				$rel[] = $plugin['url'];
 			} else {
@@ -468,7 +468,7 @@ 
 		$addons = $api->get_api_info();
 
 		$id = $this->download_id();
-		$has_file = isset( $addons[ $id ] ) && isset( $addons[ $id ]['beta'] );
+		$has_file = isset( $addons[$id] ) && isset( $addons[$id]['beta'] );
 
 		if ( ! $step['current'] ) {
 			?>
@@ -483,10 +483,10 @@ 
 
 		if ( ! $has_file ) {
 			echo '<p class="frm_error_style">' . esc_html__( 'We didn\'t find anything to import. Please contact our team.', 'formidable' ) . '</p>';
-		} elseif ( ! isset( $addons[ $id ]['beta']['package'] ) ) {
+		} elseif ( ! isset( $addons[$id]['beta']['package'] ) ) {
 			echo '<p class="frm_error_style">' . esc_html__( 'Looks like you may not have a current subscription for this solution. Please check your account.', 'formidable' ) . '</p>';
 		} else {
-			$xml = $addons[ $id ]['beta']['package'];
+			$xml = $addons[$id]['beta']['package'];
 			if ( is_array( $xml ) ) {
 				$xml = reset( $xml );
 			}
@@ -624,7 +624,7 @@ 
 		foreach ( $forms as $form ) {
 			$was_imported = isset( $form['form'] ) ? FrmForm::get_id_by_key( $form['form'] ) : false;
 			if ( $was_imported ) {
-				$imported[ $form['form'] ] = $was_imported;
+				$imported[$form['form']] = $was_imported;
 			}
 		}
 

Braces +2 added lines, -1 removed lines

@@ -42,7 +42,8 @@
 		}
 
 		// Only do this for single site installs.
-		if ( isset( $_GET['activate-multi'] ) || is_network_admin() ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $_GET['activate-multi'] ) || is_network_admin() ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return;
 		}
 

classes/controllers/FrmXMLController.php

Spacing +11 added lines, -11 removed lines

@@ -121,7 +121,7 @@ 
 			return;
 		}
 
-		$selected_xml  = isset( $form['xml'] ) && isset( $form['xml'][ $selected_form ] ) ? $form['xml'][ $selected_form ] : '';
+		$selected_xml = isset( $form['xml'] ) && isset( $form['xml'][$selected_form] ) ? $form['xml'][$selected_form] : '';
 		if ( empty( $selected_xml ) || strpos( $selected_xml, 'http' ) !== 0 ) {
 			return;
 		}
@@ -133,8 +133,8 @@ 
 	 * @since 4.06.02
 	 */
 	private static function get_selected_in_form( $form, $value = 'form' ) {
-		if ( ! empty( $form ) && isset( $form[ $value ] ) && ! empty( $form[ $value ] ) ) {
-			return $form[ $value ];
+		if ( ! empty( $form ) && isset( $form[$value] ) && ! empty( $form[$value] ) ) {
+			return $form[$value];
 		}
 
 		return '';
@@ -163,7 +163,7 @@ 
 			}
 
 			if ( $for === 'view' ) {
-				$item_key  = is_array( $view_keys ) ? $view_keys[ $form_key ] : $view_keys;
+				$item_key  = is_array( $view_keys ) ? $view_keys[$form_key] : $view_keys;
 				$shortcode = '[display-frm-data id=%1$s filter=limited]';
 			} elseif ( $for === 'form' ) {
 				$item_key = $form_key;
@@ -178,7 +178,7 @@ 
 				continue;
 			}
 
-			$page_ids[ $for ] = wp_insert_post(
+			$page_ids[$for] = wp_insert_post(
 				array(
 					'post_title'   => $name,
 					'post_type'    => 'page',
@@ -319,7 +319,7 @@ 
 		// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash
 		$file_type = sanitize_option( 'upload_path', $_FILES['frm_import_file']['name'] );
 		$file_type = strtolower( pathinfo( $file_type, PATHINFO_EXTENSION ) );
-		if ( 'xml' !== $file_type && isset( $export_format[ $file_type ] ) ) {
+		if ( 'xml' !== $file_type && isset( $export_format[$file_type] ) ) {
 			// allow other file types to be imported
 			do_action( 'frm_before_import_' . $file_type );
 
@@ -402,7 +402,7 @@ 
 		foreach ( $type as $tb_type ) {
 			$where = array();
 			$join  = '';
-			$table = $tables[ $tb_type ];
+			$table = $tables[$tb_type];
 
 			$select     = $table . '.id';
 			$query_vars = array();
@@ -417,7 +417,7 @@ 
 							$table . '.parent_form_id' => $args['ids'],
 						);
 					} else {
-						$where[ $table . '.status !' ] = 'draft';
+						$where[$table . '.status !'] = 'draft';
 					}
 					break;
 				case 'actions':
@@ -430,7 +430,7 @@ 
 				case 'items':
 					// $join = "INNER JOIN {$wpdb->prefix}frm_item_metas im ON ($table.id = im.item_id)";
 					if ( $args['ids'] ) {
-						$where[ $table . '.form_id' ] = $args['ids'];
+						$where[$table . '.form_id'] = $args['ids'];
 					}
 					break;
 				case 'styles':
@@ -471,7 +471,7 @@ 
 					}
 			}
 
-			$records[ $tb_type ] = FrmDb::get_col( $table . $join, $where, $select );
+			$records[$tb_type] = FrmDb::get_col( $table . $join, $where, $select );
 			unset( $tb_type );
 		}
 
@@ -616,7 +616,7 @@ 
 		$no_export_fields = FrmField::no_save_fields();
 		foreach ( $csv_fields as $k => $f ) {
 			if ( in_array( $f->type, $no_export_fields, true ) ) {
-				unset( $csv_fields[ $k ] );
+				unset( $csv_fields[$k] );
 			}
 		}
 

classes/views/frm-fields/back-end/field-multiple.php

Spacing +1 added lines, -1 removed lines

@@ -9,6 +9,6 @@
 	$type = $field['type'];
 	do_action( 'frm_after_checkbox', compact( 'field', 'field_name', 'type' ) );
 } else {
-	$read_only  = $field['read_only'];
+	$read_only = $field['read_only'];
 	include dirname( __FILE__ ) . '/' . $field['type'] . '-field.php';
 }

classes/controllers/FrmAppController.php

Spacing +1 added lines, -1 removed lines

@@ -283,7 +283,7 @@
 				'content' => 'upgrade',
 			)
 		);
-		$renew_link       = FrmAppHelper::admin_upgrade_link(
+		$renew_link = FrmAppHelper::admin_upgrade_link(
 			array(
 				'medium'  => 'new-template',
 				'content' => 'renew',

classes/models/fields/FrmFieldType.php

Spacing +20 added lines, -20 removed lines

@@ -132,8 +132,8 @@ 
 		$field_val = '';
 		if ( is_object( $this->field ) ) {
 			$field_val = $this->field->{$column};
-		} elseif ( is_array( $this->field ) && isset( $this->field[ $column ] ) ) {
-			$field_val = $this->field[ $column ];
+		} elseif ( is_array( $this->field ) && isset( $this->field[$column] ) ) {
+			$field_val = $this->field[$column];
 		}
 
 		return $field_val;
@@ -147,7 +147,7 @@ 
 		if ( is_object( $this->field ) ) {
 			$this->field->{$column} = $value;
 		} elseif ( is_array( $this->field ) ) {
-			$this->field[ $column ] = $value;
+			$this->field[$column] = $value;
 		}
 	}
 
@@ -469,7 +469,7 @@ 
 			printf(
 				/* translators: %s: Field type */
 				esc_html__( '%s Options', 'formidable' ),
-				esc_html( $all_field_types[ $args['display']['type'] ]['name'] )
+				esc_html( $all_field_types[$args['display']['type']]['name'] )
 			);
 			?>
 			<i class="frm_icon_font frm_arrowdown6_icon"></i>
@@ -592,8 +592,8 @@ 
 		$fields = FrmField::field_selection();
 		$fields = array_merge( $fields, FrmField::pro_field_selection() );
 
-		if ( isset( $fields[ $this->type ] ) ) {
-			$name = is_array( $fields[ $this->type ] ) ? $fields[ $this->type ]['name'] : $fields[ $this->type ];
+		if ( isset( $fields[$this->type] ) ) {
+			$name = is_array( $fields[$this->type] ) ? $fields[$this->type]['name'] : $fields[$this->type];
 		}
 
 		return $name;
@@ -604,7 +604,7 @@ 
 	}
 
 	public function get_default_field_options() {
-		$opts       = array(
+		$opts = array(
 			'size'               => '',
 			'max'                => '',
 			'label'              => '',
@@ -942,7 +942,7 @@ 
 			}
 		} else {
 			$args['save_array'] = $this->is_readonly_array();
-			$hidden             .= $this->show_single_hidden( $selected_value, $args );
+			$hidden .= $this->show_single_hidden( $selected_value, $args );
 		}
 
 		return $hidden;
@@ -951,7 +951,7 @@ 
 	protected function show_single_hidden( $selected, $args ) {
 		if ( $args['save_array'] ) {
 			$args['field_name'] .= '[]';
-			$id                 = '';
+			$id = '';
 		} else {
 			$id = ' id="' . esc_attr( $args['html_id'] ) . '"';
 		}
@@ -967,8 +967,8 @@ 
 		$selected = $values['field_value'];
 
 		if ( isset( $values['combo_name'] ) ) {
-			$options  = $options[ $values['combo_name'] ];
-			$selected = ( is_array( $selected ) && isset( $selected[ $values['combo_name'] ] ) ) ? $selected[ $values['combo_name'] ] : '';
+			$options  = $options[$values['combo_name']];
+			$selected = ( is_array( $selected ) && isset( $selected[$values['combo_name']] ) ) ? $selected[$values['combo_name']] : '';
 		}
 
 		$input = $this->select_tag( $values );
@@ -1019,7 +1019,7 @@ 
 	}
 
 	protected function fill_display_field_values( $args = array() ) {
-		$defaults        = array(
+		$defaults = array(
 			'field_name'    => 'item_meta[' . $this->get_field_column( 'id' ) . ']',
 			'field_id'      => $this->get_field_column( 'id' ),
 			'field_plus_id' => '',
@@ -1057,7 +1057,7 @@ 
 			$describedby = 'frm_desc_' . $args['html_id'];
 		}
 
-		if ( isset( $args['errors'][ 'field' . $args['field_id'] ] ) ) {
+		if ( isset( $args['errors']['field' . $args['field_id']] ) ) {
 			$describedby .= ' frm_error_' . $args['html_id'];
 		}
 
@@ -1116,11 +1116,11 @@ 
 
 		$field_id = $this->get_field_column( 'id' );
 		if ( ! array_key_exists( $field_id, $frm_validated_unique_values ) ) {
-			$frm_validated_unique_values[ $field_id ] = array();
+			$frm_validated_unique_values[$field_id] = array();
 			return false;
 		}
 
-		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[ $field_id ], true );
+		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[$field_id], true );
 		return $already_validated_this_value;
 	}
 
@@ -1145,7 +1145,7 @@ 
 	private function value_validated_as_unique( $value ) {
 		global $frm_validated_unique_values;
 		$field_id                                   = $this->get_field_column( 'id' );
-		$frm_validated_unique_values[ $field_id ][] = $value;
+		$frm_validated_unique_values[$field_id][] = $value;
 	}
 
 	public function get_value_to_save( $value, $atts ) {
@@ -1177,8 +1177,8 @@ 
 		$value = $this->prepare_display_value( $value, $atts );
 
 		if ( is_array( $value ) ) {
-			if ( isset( $atts['show'] ) && $atts['show'] && isset( $value[ $atts['show'] ] ) ) {
-				$value = $value[ $atts['show'] ];
+			if ( isset( $atts['show'] ) && $atts['show'] && isset( $value[$atts['show']] ) ) {
+				$value = $value[$atts['show']];
 			} elseif ( ! isset( $atts['return_array'] ) || ! $atts['return_array'] ) {
 				$sep   = isset( $atts['sep'] ) ? $atts['sep'] : ', ';
 				$value = implode( $sep, $value );
@@ -1247,8 +1247,8 @@ 
 		$saved_entries = $atts['ids'];
 		$new_value     = array();
 		foreach ( (array) $value as $old_child_id ) {
-			if ( isset( $saved_entries[ $old_child_id ] ) ) {
-				$new_value[] = $saved_entries[ $old_child_id ];
+			if ( isset( $saved_entries[$old_child_id] ) ) {
+				$new_value[] = $saved_entries[$old_child_id];
 			}
 		}
 

classes/controllers/FrmAddonsController.php

Spacing +13 added lines, -13 removed lines

@@ -74,7 +74,7 @@ 
 		} else {
 			foreach ( $addons as $k => $addon ) {
 				if ( empty( $addon['excerpt'] ) && $k !== 'error' ) {
-					unset( $addons[ $k ] );
+					unset( $addons[$k] );
 				}
 			}
 		}
@@ -170,7 +170,7 @@ 
 
 		foreach ( $list as $k => $info ) {
 			$info['slug'] = $k;
-			$list[ $k ]   = array_merge( $defaults, $info );
+			$list[$k]   = array_merge( $defaults, $info );
 		}
 		return $list;
 	}
@@ -349,16 +349,16 @@ 
 				continue;
 			}
 
-			$wp_plugin  = isset( $wp_plugins[ $folder ] ) ? $wp_plugins[ $folder ] : array();
+			$wp_plugin  = isset( $wp_plugins[$folder] ) ? $wp_plugins[$folder] : array();
 			$wp_version = isset( $wp_plugin['Version'] ) ? $wp_plugin['Version'] : '1.0';
 
 			if ( version_compare( $wp_version, $plugin->new_version, '<' ) ) {
 				$slug                           = explode( '/', $folder );
 				$plugin->slug                   = $slug[0];
-				$transient->response[ $folder ] = $plugin;
+				$transient->response[$folder] = $plugin;
 			}
 
-			$transient->checked[ $folder ] = $wp_version;
+			$transient->checked[$folder] = $wp_version;
 
 		}
 
@@ -381,7 +381,7 @@ 
 
 		$all_plugins = get_plugins();
 
-		return isset( $all_plugins[ $plugin ] );
+		return isset( $all_plugins[$plugin] );
 	}
 
 	/**
@@ -420,13 +420,13 @@ 
 			}
 
 			$download_id = isset( $plugin['id'] ) ? $plugin['id'] : 0;
-			if ( ! empty( $download_id ) && ! isset( $version_info[ $download_id ]['package'] ) ) {
+			if ( ! empty( $download_id ) && ! isset( $version_info[$download_id]['package'] ) ) {
 				// if this addon is using its own license, get the update url
 				$addon_info = $api->get_api_info();
 
-				$version_info[ $download_id ] = $addon_info[ $download_id ];
+				$version_info[$download_id] = $addon_info[$download_id];
 				if ( isset( $addon_info['error'] ) ) {
-					$version_info[ $download_id ]['error'] = array(
+					$version_info[$download_id]['error'] = array(
 						'message' => $addon_info['error']['message'],
 						'code'    => $addon_info['error']['code'],
 					);
@@ -520,8 +520,8 @@ 
 					return $addon;
 				}
 			}
-		} elseif ( isset( $addons[ $download_id ] ) ) {
-			$plugin = $addons[ $download_id ];
+		} elseif ( isset( $addons[$download_id] ) ) {
+			$plugin = $addons[$download_id];
 		}
 
 		return $plugin;
@@ -575,7 +575,7 @@ 
 			self::prepare_addon_link( $addon['link'] );
 
 			self::set_addon_status( $addon );
-			$addons[ $id ] = $addon;
+			$addons[$id] = $addon;
 		}
 	}
 
@@ -593,7 +593,7 @@ 
 			'utm_medium'   => 'addons',
 			'utm_campaign' => 'liteplugin',
 		);
-		$link       = add_query_arg( $query_args, $link );
+		$link = add_query_arg( $query_args, $link );
 	}
 
 	/**

classes/helpers/FrmEntriesListHelper.php

Spacing +3 added lines, -3 removed lines

@@ -25,7 +25,7 @@ 
 			$s_query['it.form_id'] = $form_id;
 			$join_form_in_query    = false;
 		} else {
-			$s_query[]          = array(
+			$s_query[] = array(
 				'or'               => 1,
 				'parent_form_id'   => null,
 				'parent_form_id <' => 1,
@@ -56,7 +56,7 @@ 
 
 		if ( strpos( $orderby, 'meta' ) !== false ) {
 			$order_field_type = FrmField::get_type( str_replace( 'meta_', '', $orderby ) );
-			$orderby          .= in_array( $order_field_type, array( 'number', 'scale', 'star' ) ) ? '+0' : '';
+			$orderby .= in_array( $order_field_type, array( 'number', 'scale', 'star' ) ) ? '+0' : '';
 		}
 
 		$order = self::get_param(
@@ -189,7 +189,7 @@ 
 
 		$r = "<tr id='item-action-{$item->id}'$style>";
 
-		list( $columns, $hidden, , $primary ) = $this->get_column_info();
+		list( $columns, $hidden,, $primary ) = $this->get_column_info();
 		$action_col                           = false;
 		$action_columns                       = $this->get_action_columns();
 

classes/models/FrmFormTemplateApi.php

Spacing +5 added lines, -5 removed lines

@@ -5,7 +5,7 @@ 
 
 class FrmFormTemplateApi extends FrmFormApi {
 
-	protected static $code_option_name  = 'frm_free_license_code';
+	protected static $code_option_name = 'frm_free_license_code';
 
 	private static $base_api_url = 'https://formidableforms.com/wp-json/form-templates/v1/';
 
@@ -76,7 +76,7 @@ 
 
 		$templates    = $this->get_api_info();
 		$contact_form = 20872734;
-		return isset( $templates[ $contact_form ] ) && ! empty( $templates[ $contact_form ]['url'] );
+		return isset( $templates[$contact_form] ) && ! empty( $templates[$contact_form]['url'] );
 	}
 
 	/**
@@ -137,15 +137,15 @@ 
 					continue;
 				}
 
-				$data['urlByKey'][ $template['key'] ] = $template['url'];
+				$data['urlByKey'][$template['key']] = $template['url'];
 			}
 
-			if ( ! isset( $data['urlByKey'][ $key ] ) ) {
+			if ( ! isset( $data['urlByKey'][$key] ) ) {
 				$error = new WP_Error( 400, 'We were unable to retrieve the template' );
 				wp_send_json_error( $error );
 			}
 
-			$data['url'] = $data['urlByKey'][ $key ];
+			$data['url'] = $data['urlByKey'][$key];
 		}
 
 		wp_send_json_success( $data );