Strategy11 /
formidable-forms
| Total Complexity | 56 |
| Total Lines | 218 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like FrmCreateFile often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use FrmCreateFile, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 7 | class FrmCreateFile { |
||
| 8 | |||
| 9 | public $folder_name; |
||
| 10 | public $file_name; |
||
| 11 | public $error_message; |
||
| 12 | public $uploads; |
||
| 13 | private $new_file_path; |
||
| 14 | public $chmod_dir = 0755; |
||
| 15 | public $chmod_file = 0644; |
||
| 16 | private $has_permission = false; |
||
| 17 | |||
| 18 | public function __construct( $atts ) { |
||
| 19 | $this->folder_name = isset( $atts['folder_name'] ) ? $atts['folder_name'] : ''; |
||
| 20 | $this->file_name = $atts['file_name']; |
||
| 21 | $this->error_message = isset( $atts['error_message'] ) ? $atts['error_message'] : ''; |
||
| 22 | $this->uploads = wp_upload_dir(); |
||
|
Bug
introduced
by
|
|||
| 23 | $this->set_new_file_path( $atts ); |
||
| 24 | $this->chmod_dir = defined('FS_CHMOD_DIR') ? FS_CHMOD_DIR : ( fileperms( ABSPATH ) & 0777 | 0755 ); |
||
| 25 | $this->chmod_file = defined('FS_CHMOD_FILE') ? FS_CHMOD_FILE : ( fileperms( ABSPATH . 'index.php' ) & 0777 | 0644 ); |
||
| 26 | |||
| 27 | $this->check_permission(); |
||
| 28 | } |
||
| 29 | |||
| 30 | /** |
||
| 31 | * @since 3.0 |
||
| 32 | */ |
||
| 33 | private function set_new_file_path( $atts ) { |
||
| 34 | if ( isset( $atts['new_file_path'] ) ) { |
||
| 35 | $this->new_file_path = $atts['new_file_path'] . '/' . $this->file_name; |
||
| 36 | } else { |
||
| 37 | $this->new_file_path = $this->uploads['basedir'] . '/' . $this->folder_name . '/' . $this->file_name; |
||
| 38 | } |
||
| 39 | } |
||
| 40 | |||
| 41 | public function create_file( $file_content ) { |
||
| 42 | if ( $this->has_permission ) { |
||
| 43 | $dirs_exist = true; |
||
| 44 | |||
| 45 | // Create the directories if need be |
||
| 46 | $this->create_directories( $dirs_exist ); |
||
| 47 | |||
| 48 | // only write the file if the folders exist |
||
| 49 | if ( $dirs_exist ) { |
||
| 50 | global $wp_filesystem; |
||
| 51 | $wp_filesystem->put_contents( $this->new_file_path, $file_content, $this->chmod_file ); |
||
| 52 | } |
||
| 53 | } |
||
| 54 | } |
||
| 55 | |||
| 56 | /** |
||
| 57 | * @since 3.0 |
||
| 58 | */ |
||
| 59 | public function append_file( $file_content ) { |
||
| 60 | if ( $this->has_permission ) { |
||
| 61 | |||
| 62 | if ( file_exists( $this->new_file_path ) ) { |
||
| 63 | |||
| 64 | $existing_content = $this->get_contents(); |
||
| 65 | $file_content = $existing_content . $file_content; |
||
| 66 | } |
||
| 67 | |||
| 68 | $this->create_file( $file_content ); |
||
| 69 | } |
||
| 70 | } |
||
| 71 | |||
| 72 | /** |
||
| 73 | * Combine an array of files into one |
||
| 74 | * |
||
| 75 | * @since 3.0 |
||
| 76 | * |
||
| 77 | * @param array $file_names And array of file paths |
||
| 78 | */ |
||
| 79 | public function combine_files( $file_names ) { |
||
| 80 | if ( $this->has_permission ) { |
||
| 81 | $content = ''; |
||
| 82 | foreach ( $file_names as $file_name ) { |
||
| 83 | $content .= $this->get_contents( $file_name ) . "\n"; |
||
| 84 | } |
||
| 85 | $this->create_file( $content ); |
||
| 86 | } |
||
| 87 | } |
||
| 88 | |||
| 89 | /** |
||
| 90 | * @since 3.0 |
||
| 91 | */ |
||
| 92 | public function get_file_contents() { |
||
| 93 | $content = ''; |
||
| 94 | |||
| 95 | if ( $this->has_permission ) { |
||
| 96 | $content = $this->get_contents(); |
||
| 97 | } |
||
| 98 | |||
| 99 | return $content; |
||
| 100 | } |
||
| 101 | |||
| 102 | /** |
||
| 103 | * @since 3.0 |
||
| 104 | */ |
||
| 105 | private function get_contents( $file = '' ) { |
||
| 106 | global $wp_filesystem; |
||
| 107 | if ( empty( $file ) ) { |
||
| 108 | $file = $this->new_file_path; |
||
| 109 | } |
||
| 110 | return $wp_filesystem->get_contents( $file ); |
||
| 111 | } |
||
| 112 | |||
| 113 | /** |
||
| 114 | * @since 3.0 |
||
| 115 | */ |
||
| 116 | private function check_permission() { |
||
| 117 | $creds = $this->get_creds(); |
||
| 118 | |||
| 119 | $this->has_permission = true; |
||
| 120 | if ( empty( $creds ) || ! WP_Filesystem( $creds ) ) { |
||
| 121 | // initialize the API - any problems and we exit |
||
| 122 | $this->show_error_message(); |
||
| 123 | $this->has_permission = false; |
||
| 124 | } |
||
| 125 | } |
||
| 126 | |||
| 127 | private function create_directories( &$dirs_exist ) { |
||
| 128 | global $wp_filesystem; |
||
| 129 | |||
| 130 | $needed_dirs = $this->get_needed_dirs(); |
||
| 131 | foreach ( $needed_dirs as $_dir ) { |
||
| 132 | // Only check to see if the Dir exists upon creation failure. Less I/O this way. |
||
| 133 | if ( $wp_filesystem->mkdir( $_dir, $this->chmod_dir ) ) { |
||
| 134 | $index_path = $_dir . '/index.php'; |
||
| 135 | $wp_filesystem->put_contents( $index_path, "<?php\n// Silence is golden.\n?>", $this->chmod_file ); |
||
| 136 | } else { |
||
| 137 | $dirs_exist = $wp_filesystem->is_dir( $_dir ); |
||
| 138 | } |
||
| 139 | } |
||
| 140 | } |
||
| 141 | |||
| 142 | private function get_needed_dirs() { |
||
| 143 | $dir_names = explode( '/', $this->folder_name ); |
||
| 144 | $needed_dirs = array(); |
||
| 145 | |||
| 146 | $next_dir = ''; |
||
| 147 | foreach ( $dir_names as $dir ) { |
||
| 148 | $next_dir .= '/' . $dir; |
||
| 149 | $needed_dirs[] = $this->uploads['basedir'] . $next_dir; |
||
| 150 | } |
||
| 151 | |||
| 152 | return $needed_dirs; |
||
| 153 | } |
||
| 154 | |||
| 155 | private function get_creds() { |
||
| 156 | if ( ! function_exists('get_filesystem_method') ) { |
||
| 157 | include_once( ABSPATH . 'wp-admin/includes/file.php' ); |
||
| 158 | } |
||
| 159 | |||
| 160 | $access_type = get_filesystem_method(); |
||
| 161 | if ( $access_type === 'direct' ) { |
||
| 162 | $creds = request_filesystem_credentials( site_url() . '/wp-admin/', '', false, false, array() ); |
||
| 163 | } else { |
||
| 164 | $creds = $this->get_ftp_creds( $access_type ); |
||
| 165 | } |
||
| 166 | return $creds; |
||
| 167 | } |
||
| 168 | |||
| 169 | private function get_ftp_creds( $type ) { |
||
| 220 | } |
||
| 221 | |||
| 222 | private function show_error_message() { |
||
| 223 | if ( ! empty( $this->error_message ) ) { |
||
| 224 | echo '<div class="message">' . $this->error_message . '</div>'; |
||
| 225 | } |
||
| 226 | } |
||
| 227 | } |
||
| 228 |
Loading history...