Strategy11 / formidable-forms

classes/models/FrmEntry.php

Spacing +23 added lines, -23 removed lines

@@ -56,8 +56,8 @@ 
 	 * @return void
 	 */
 	private static function flag_new_unique_key( $unique_id ) {
-		if ( ! isset( self::$unique_id_match_checks[ $unique_id ] ) ) {
-			self::$unique_id_match_checks[ $unique_id ] = false;
+		if ( ! isset( self::$unique_id_match_checks[$unique_id] ) ) {
+			self::$unique_id_match_checks[$unique_id] = false;
 		}
 	}
 
@@ -109,7 +109,7 @@ 
 				if ( 0 === (int) $meta->field_id ) {
 					continue;
 				}
-				$field_metas[ $meta->field_id ] = $meta->meta_value;
+				$field_metas[$meta->field_id] = $meta->meta_value;
 			}
 
 			$filtered_vals = array_filter( $values['item_meta'] );
@@ -174,8 +174,8 @@ 
 			return false;
 		}
 
-		if ( isset( self::$unique_id_match_checks[ $unique_id ] ) ) {
-			return self::$unique_id_match_checks[ $unique_id ];
+		if ( isset( self::$unique_id_match_checks[$unique_id] ) ) {
+			return self::$unique_id_match_checks[$unique_id];
 		}
 
 		$timestamp = strtotime( $created_at );
@@ -183,7 +183,7 @@ 
 			$timestamp = time();
 		}
 
-		self::$unique_id_match_checks[ $unique_id ] = (bool) FrmDb::get_var(
+		self::$unique_id_match_checks[$unique_id] = (bool) FrmDb::get_var(
 			'frm_item_metas',
 			array(
 				'field_id'     => 0,
@@ -193,7 +193,7 @@ 
 			'id'
 		);
 
-		return self::$unique_id_match_checks[ $unique_id ];
+		return self::$unique_id_match_checks[$unique_id];
 	}
 
 	/**
@@ -223,10 +223,10 @@ 
 		$reduced = array();
 		foreach ( $filter_vals as $field_id => $value ) {
 			$field                = FrmFieldFactory::get_field_object( $field_id );
-			$reduced[ $field_id ] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
-			$reduced[ $field_id ] = $field->set_value_before_save( $reduced[ $field_id ] );
-			if ( '' === $reduced[ $field_id ] || ( is_array( $reduced[ $field_id ] ) && 0 === count( $reduced[ $field_id ] ) ) ) {
-				unset( $reduced[ $field_id ] );
+			$reduced[$field_id] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
+			$reduced[$field_id] = $field->set_value_before_save( $reduced[$field_id] );
+			if ( '' === $reduced[$field_id] || ( is_array( $reduced[$field_id] ) && 0 === count( $reduced[$field_id] ) ) ) {
+				unset( $reduced[$field_id] );
 			}
 		}
 		return $reduced;
@@ -489,7 +489,7 @@ 
 	private static function prepare_entries( &$entries ) {
 		foreach ( $entries as $k => $entry ) {
 			self::prepare_entry( $entry );
-			$entries[ $k ] = $entry;
+			$entries[$k] = $entry;
 		}
 	}
 
@@ -515,19 +515,19 @@ 
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
 
 			if ( $meta_val->item_id == $entry->id ) {
-				$entry->metas[ $meta_val->field_id ] = $meta_val->meta_value;
+				$entry->metas[$meta_val->field_id] = $meta_val->meta_value;
 				if ( $include_key ) {
-					$entry->metas[ $meta_val->field_key ] = $entry->metas[ $meta_val->field_id ];
+					$entry->metas[$meta_val->field_key] = $entry->metas[$meta_val->field_id];
 				}
 				continue;
 			}
 
 			// include sub entries in an array
-			if ( ! isset( $entry->metas[ $meta_val->field_id ] ) ) {
-				$entry->metas[ $meta_val->field_id ] = array();
+			if ( ! isset( $entry->metas[$meta_val->field_id] ) ) {
+				$entry->metas[$meta_val->field_id] = array();
 			}
 
-			$entry->metas[ $meta_val->field_id ][] = $meta_val->meta_value;
+			$entry->metas[$meta_val->field_id][] = $meta_val->meta_value;
 
 			unset( $meta_val );
 		}
@@ -622,16 +622,16 @@ 
 		}
 
 		foreach ( $metas as $m_key => $meta_val ) {
-			if ( ! isset( $entries[ $meta_val->item_id ] ) ) {
+			if ( ! isset( $entries[$meta_val->item_id] ) ) {
 				continue;
 			}
 
-			if ( ! isset( $entries[ $meta_val->item_id ]->metas ) ) {
-				$entries[ $meta_val->item_id ]->metas = array();
+			if ( ! isset( $entries[$meta_val->item_id]->metas ) ) {
+				$entries[$meta_val->item_id]->metas = array();
 			}
 
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
-			$entries[ $meta_val->item_id ]->metas[ $meta_val->field_id ] = $meta_val->meta_value;
+			$entries[$meta_val->item_id]->metas[$meta_val->field_id] = $meta_val->meta_value;
 			unset( $m_key, $meta_val );
 		}
 
@@ -814,7 +814,7 @@ 
 	}
 
 	private static function get_entry_value( $values, $name, $default ) {
-		return $values[ $name ] ?? $default;
+		return $values[$name] ?? $default;
 	}
 
 	/**
@@ -1021,7 +1021,7 @@ 
 	private static function maybe_add_captcha_meta( $form_id, $entry_id ) {
 		global $frm_vars;
 		if ( array_key_exists( 'captcha_scores', $frm_vars ) && array_key_exists( $form_id, $frm_vars['captcha_scores'] ) ) {
-			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][ $form_id ] );
+			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][$form_id] );
 			FrmEntryMeta::add_entry_meta( $entry_id, 0, '', maybe_serialize( $captcha_score_meta ) );
 		}
 	}

classes/models/FrmForm.php

Spacing +32 added lines, -32 removed lines

@@ -209,7 +209,7 @@ 
 			}
 
 			if ( $new_val !== $value ) {
-				$new_values[ $key ] = $new_val;
+				$new_values[$key] = $new_val;
 			}
 		}//end foreach
 
@@ -240,7 +240,7 @@ 
 
 		foreach ( $values as $value_key => $value ) {
 			if ( $value_key && in_array( $value_key, $form_fields ) ) {
-				$new_values[ $value_key ] = $value;
+				$new_values[$value_key] = $value;
 			}
 		}
 
@@ -323,15 +323,15 @@ 
 		$existing_keys = array_keys( $values['item_meta'] );
 		foreach ( $all_fields as $fid ) {
 			if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
-				$values['item_meta'][ $fid->id ] = '';
+				$values['item_meta'][$fid->id] = '';
 			}
-			$field_array[ $fid->id ] = $fid;
+			$field_array[$fid->id] = $fid;
 		}
 		unset( $all_fields );
 
 		foreach ( $values['item_meta'] as $field_id => $default_value ) {
-			if ( isset( $field_array[ $field_id ] ) ) {
-				$field = $field_array[ $field_id ];
+			if ( isset( $field_array[$field_id] ) ) {
+				$field = $field_array[$field_id];
 			} else {
 				$field = FrmField::getOne( $field_id );
 			}
@@ -340,7 +340,7 @@ 
 				continue;
 			}
 
-			$is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
+			$is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options']['custom_html_' . $field_id] ) );
 			if ( $is_settings_page ) {
 				self::get_settings_page_html( $values, $field );
 
@@ -356,22 +356,22 @@ 
 			$update_options = apply_filters( 'frm_field_options_to_update', $update_options );
 
 			foreach ( $update_options as $opt => $default ) {
-				$field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default;
-				self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
+				$field->field_options[$opt] = $values['field_options'][$opt . '_' . $field_id] ?? $default;
+				self::sanitize_field_opt( $opt, $field->field_options[$opt] );
 			}
 
 			$field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
 
 			$new_field = array(
 				'field_options' => $field->field_options,
-				'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
+				'default_value' => isset( $values['default_value_' . $field_id] ) ? FrmAppHelper::maybe_json_encode( $values['default_value_' . $field_id] ) : '',
 			);
 
-			if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) {
-				foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
+			if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options']['options_' . $field_id] ) && is_array( $values['field_options']['options_' . $field_id] ) ) {
+				foreach ( $values['field_options']['options_' . $field_id] as $option_key => $option ) {
 					if ( is_array( $option ) ) {
 						foreach ( $option as $key => $item ) {
-							$values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
+							$values['field_options']['options_' . $field_id][$option_key][$key] = FrmAppHelper::kses( $item, 'all' );
 						}
 					}
 				}
@@ -401,8 +401,8 @@ 
 	 */
 	private static function maybe_update_max_option( $field, $values, &$new_field ) {
 		if ( $field->type === 'textarea' &&
-			! empty( $values['field_options'][ 'type_' . $field->id ] ) &&
-			in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
+			! empty( $values['field_options']['type_' . $field->id] ) &&
+			in_array( $values['field_options']['type_' . $field->id], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
 
 			$new_field['field_options']['max'] = '';
 
@@ -410,7 +410,7 @@ 
 			 * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
 			 * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
 			 */
-			$_POST['field_options'][ 'max_' . $field->id ] = '';
+			$_POST['field_options']['max_' . $field->id] = '';
 		}
 	}
 
@@ -488,11 +488,11 @@ 
 	 * Updating the settings page
 	 */
 	private static function get_settings_page_html( $values, &$field ) {
-		if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
+		if ( isset( $values['field_options']['custom_html_' . $field->id] ) ) {
 			$prev_opts     = array();
 			$fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type );
 
-			$field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html;
+			$field->field_options['custom_html'] = $values['field_options']['custom_html_' . $field->id] ?? $fallback_html;
 		} elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
 			$prev_opts = $field->field_options;
 		}
@@ -517,7 +517,7 @@ 
 		);
 		foreach ( $field_cols as $col => $default ) {
 			$default           = $default === '' ? $field->{$col} : $default;
-			$new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default;
+			$new_field[$col] = $values['field_options'][$col . '_' . $field->id] ?? $default;
 		}
 
 		if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
@@ -708,7 +708,7 @@ 
 			if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) {
 				self::destroy( $form->id );
 				if ( empty( $form->parent_form_id ) ) {
-					++$count;
+					++ $count;
 				}
 			}
 
@@ -931,16 +931,16 @@ 
 		foreach ( $results as $row ) {
 			if ( 'trash' != $row->status ) {
 				if ( $row->is_template ) {
-					++$counts['template'];
+					++ $counts['template'];
 				} else {
-					++$counts['published'];
+					++ $counts['published'];
 				}
 			} else {
-				++$counts['trash'];
+				++ $counts['trash'];
 			}
 
 			if ( 'draft' == $row->status ) {
-				++$counts['draft'];
+				++ $counts['draft'];
 			}
 
 			unset( $row );
@@ -981,8 +981,8 @@ 
 			self::maybe_get_form( $form );
 		}
 
-		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
-			return $frm_vars['form_params'][ $form->id ];
+		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][$form->id] ) ) {
+			return $frm_vars['form_params'][$form->id];
 		}
 
 		$action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -1011,15 +1011,15 @@ 
 			// If there are two forms on the same page, make sure not to submit both.
 			foreach ( $default_values as $var => $default ) {
 				if ( $var === 'action' ) {
-					$values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
+					$values[$var] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
 				} else {
-					$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+					$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 				}
 				unset( $var, $default );
 			}
 		} else {
 			foreach ( $default_values as $var => $default ) {
-				$values[ $var ] = $default;
+				$values[$var] = $default;
 				unset( $var, $default );
 			}
 		}
@@ -1045,7 +1045,7 @@ 
 			'sdir'     => '',
 		);
 		foreach ( $defaults as $var => $default ) {
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 		}
 
 		return $values;
@@ -1073,7 +1073,7 @@ 
 			'keep_post' => '',
 		);
 		foreach ( $defaults as $var => $default ) {
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 		}
 
 		return $values;
@@ -1176,7 +1176,7 @@ 
 		$form    = $atts['form'];
 		$default = $atts['default'] ?? '';
 
-		return $form->options[ $atts['option'] ] ?? $default;
+		return $form->options[$atts['option']] ?? $default;
 	}
 
 	/**

classes/models/FrmFormState.php

Spacing +3 added lines, -3 removed lines

@@ -59,7 +59,7 @@ 
 	 * @return void
 	 */
 	public function set( $key, $value ) {
-		$this->state[ $key ] = $value;
+		$this->state[$key] = $value;
 	}
 
 	/**
@@ -75,7 +75,7 @@ 
 	}
 
 	public function get( $key, $default ) {
-		return $this->state[ $key ] ?? $default;
+		return $this->state[$key] ?? $default;
 	}
 
 	/**
@@ -186,7 +186,7 @@ 
 	private function compressed_state() {
 		$compressed = array();
 		foreach ( $this->state as $key => $value ) {
-			$compressed[ self::compressed_key( $key ) ] = $value;
+			$compressed[self::compressed_key( $key )] = $value;
 		}
 		return $compressed;
 	}

classes/models/FrmSettings.php

Spacing +4 added lines, -4 removed lines

@@ -239,8 +239,8 @@ 
 		}
 
 		foreach ( $settings as $setting => $default ) {
-			if ( isset( $params[ 'frm_' . $setting ] ) ) {
-				$this->{$setting} = $params[ 'frm_' . $setting ];
+			if ( isset( $params['frm_' . $setting] ) ) {
+				$this->{$setting} = $params['frm_' . $setting];
 			} elseif ( ! isset( $this->{$setting} ) ) {
 				$this->{$setting} = $default;
 			}
@@ -432,7 +432,7 @@ 
 			'denylist_check',
 		);
 		foreach ( $checkboxes as $set ) {
-			$this->$set = isset( $params[ 'frm_' . $set ] ) ? absint( $params[ 'frm_' . $set ] ) : 0;
+			$this->$set = isset( $params['frm_' . $set] ) ? absint( $params['frm_' . $set] ) : 0;
 		}
 	}
 
@@ -445,7 +445,7 @@ 
 		$frm_roles = FrmAppHelper::frm_capabilities();
 		$roles     = get_editable_roles();
 		foreach ( $frm_roles as $frm_role => $frm_role_description ) {
-			$this->$frm_role = (array) ( $params[ $frm_role ] ?? 'administrator' );
+			$this->$frm_role = (array) ( $params[$frm_role] ?? 'administrator' );
 
 			// Make sure administrators always have permissions
 			if ( ! in_array( 'administrator', $this->$frm_role, true ) ) {

classes/models/FrmFormAction.php

Spacing +38 added lines, -38 removed lines

@@ -208,9 +208,9 @@ 
 		$groups = FrmFormActionsController::form_action_groups();
 		$group  = 'misc';
 
-		if ( isset( $action_options['group'] ) && isset( $groups[ $action_options['group'] ] ) ) {
+		if ( isset( $action_options['group'] ) && isset( $groups[$action_options['group']] ) ) {
 			$group = $action_options['group'];
-		} elseif ( isset( $groups[ $this->id_base ] ) ) {
+		} elseif ( isset( $groups[$this->id_base] ) ) {
 			$group = $this->id_base;
 		} else {
 			foreach ( $groups as $name => $check_group ) {
@@ -221,8 +221,8 @@ 
 			}
 		}
 
-		$groups[ $group ]['id'] = $group;
-		return $groups[ $group ];
+		$groups[$group]['id'] = $group;
+		return $groups[$group];
 	}
 
 	/**
@@ -333,7 +333,7 @@ 
 	 * @return int $post_id
 	 */
 	public function maybe_create_action( $action, $forms ) {
-		if ( isset( $action['ID'] ) && is_numeric( $action['ID'] ) && isset( $forms[ $action['menu_order'] ] ) && $forms[ $action['menu_order'] ] === 'updated' ) {
+		if ( isset( $action['ID'] ) && is_numeric( $action['ID'] ) && isset( $forms[$action['menu_order']] ) && $forms[$action['menu_order']] === 'updated' ) {
 			// Update action only
 			$action['post_content'] = FrmAppHelper::maybe_json_decode( $action['post_content'] );
 			$post_id                = $this->save_settings( $action );
@@ -356,18 +356,18 @@ 
 		$switch             = $this->get_global_switch_fields();
 
 		foreach ( (array) $action->post_content as $key => $val ) {
-			if ( is_numeric( $val ) && isset( $frm_duplicate_ids[ $val ] ) ) {
-				$action->post_content[ $key ] = $frm_duplicate_ids[ $val ];
+			if ( is_numeric( $val ) && isset( $frm_duplicate_ids[$val] ) ) {
+				$action->post_content[$key] = $frm_duplicate_ids[$val];
 			} elseif ( ! is_array( $val ) ) {
-				$action->post_content[ $key ] = FrmFieldsHelper::switch_field_ids( $val );
-			} elseif ( isset( $switch[ $key ] ) && is_array( $switch[ $key ] ) ) {
+				$action->post_content[$key] = FrmFieldsHelper::switch_field_ids( $val );
+			} elseif ( isset( $switch[$key] ) && is_array( $switch[$key] ) ) {
 				// loop through each value if empty
-				if ( empty( $switch[ $key ] ) ) {
-					$switch[ $key ] = array_keys( $val );
+				if ( empty( $switch[$key] ) ) {
+					$switch[$key] = array_keys( $val );
 				}
 
-				foreach ( $switch[ $key ] as $subkey ) {
-					$action->post_content[ $key ] = $this->duplicate_array_walk( $action->post_content[ $key ], $subkey, $val );
+				foreach ( $switch[$key] as $subkey ) {
+					$action->post_content[$key] = $this->duplicate_array_walk( $action->post_content[$key], $subkey, $val );
 				}
 			}
 
@@ -385,20 +385,20 @@ 
 			foreach ( $subkey as $subkey2 ) {
 				foreach ( (array) $val as $ck => $cv ) {
 					if ( is_array( $cv ) ) {
-						$action[ $ck ] = $this->duplicate_array_walk( $action[ $ck ], $subkey2, $cv );
-					} elseif ( isset( $cv[ $subkey ] ) && is_numeric( $cv[ $subkey ] ) && isset( $frm_duplicate_ids[ $cv[ $subkey ] ] ) ) {
-						$action[ $ck ][ $subkey ] = $frm_duplicate_ids[ $cv[ $subkey ] ];
+						$action[$ck] = $this->duplicate_array_walk( $action[$ck], $subkey2, $cv );
+					} elseif ( isset( $cv[$subkey] ) && is_numeric( $cv[$subkey] ) && isset( $frm_duplicate_ids[$cv[$subkey]] ) ) {
+						$action[$ck][$subkey] = $frm_duplicate_ids[$cv[$subkey]];
 					}
 				}
 			}
 		} else {
 			foreach ( (array) $val as $ck => $cv ) {
 				if ( is_array( $cv ) ) {
-					$action[ $ck ] = $this->duplicate_array_walk( $action[ $ck ], $subkey, $cv );
-				} elseif ( $ck == $subkey && isset( $frm_duplicate_ids[ $cv ] ) ) {
-					$action[ $ck ] = $frm_duplicate_ids[ $cv ];
+					$action[$ck] = $this->duplicate_array_walk( $action[$ck], $subkey, $cv );
+				} elseif ( $ck == $subkey && isset( $frm_duplicate_ids[$cv] ) ) {
+					$action[$ck] = $frm_duplicate_ids[$cv];
 				} elseif ( $ck == $subkey ) {
-					$action[ $ck ] = $this->maybe_switch_field_ids( $action[ $ck ] );
+					$action[$ck] = $this->maybe_switch_field_ids( $action[$ck] );
 				}
 			}
 		}//end if
@@ -422,10 +422,10 @@ 
 		}
 
 		// phpcs:ignore WordPress.Security.NonceVerification.Missing
-		if ( isset( $_POST[ $this->option_name ] ) && is_array( $_POST[ $this->option_name ] ) ) {
+		if ( isset( $_POST[$this->option_name] ) && is_array( $_POST[$this->option_name] ) ) {
 			// Sanitizing removes scripts and <email> type of values.
 			// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
-			$settings = wp_unslash( $_POST[ $this->option_name ] );
+			$settings = wp_unslash( $_POST[$this->option_name] );
 		} else {
 			return;
 		}
@@ -435,7 +435,7 @@ 
 		foreach ( $settings as $number => $new_instance ) {
 			$this->_set( $number );
 
-			$old_instance = $all_instances[ $number ] ?? array();
+			$old_instance = $all_instances[$number] ?? array();
 
 			if ( ! isset( $new_instance['post_status'] ) ) {
 				$new_instance['post_status'] = 'draft';
@@ -474,7 +474,7 @@ 
 			$instance['post_content'] = apply_filters( 'frm_before_save_' . $this->id_base . '_action', $instance['post_content'], $instance, $new_instance, $old_instance, $this );
 
 			if ( false !== $instance ) {
-				$all_instances[ $number ] = $instance;
+				$all_instances[$number] = $instance;
 			}
 
 			$action_ids[] = $this->save_settings( $instance );
@@ -563,12 +563,12 @@ 
 			// some plugins/themes are formatting the post_excerpt
 			$action->post_excerpt = sanitize_title( $action->post_excerpt );
 
-			if ( ! isset( $action_controls[ $action->post_excerpt ] ) ) {
+			if ( ! isset( $action_controls[$action->post_excerpt] ) ) {
 				continue;
 			}
 
-			$action                  = $action_controls[ $action->post_excerpt ]->prepare_action( $action );
-			$settings[ $action->ID ] = $action;
+			$action                  = $action_controls[$action->post_excerpt]->prepare_action( $action );
+			$settings[$action->ID] = $action;
 
 			if ( count( $settings ) >= $limit ) {
 				break;
@@ -594,7 +594,7 @@ 
 	 * @return int The filtered limit value.
 	 */
 	public static function get_action_limit( $form_id, $limit = 99 ) {
-		$type  = 'all';
+		$type = 'all';
 		return (int) apply_filters( 'frm_form_action_limit', (int) $limit, compact( 'type', 'form_id' ) );
 	}
 
@@ -617,7 +617,7 @@ 
 			'limit'       => 99,
 			'post_status' => $default_status,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 	}
 
 	/**
@@ -687,7 +687,7 @@ 
 
 			$action = $this->prepare_action( $action );
 
-			$settings[ $action->ID ] = $action;
+			$settings[$action->ID] = $action;
 		}
 
 		if ( 1 === $limit ) {
@@ -730,10 +730,10 @@ 
 
 		foreach ( $default_values as $k => $vals ) {
 			if ( is_array( $vals ) && ! empty( $vals ) ) {
-				if ( 'event' === $k && ! $this->action_options['force_event'] && ! empty( $action->post_content[ $k ] ) ) {
+				if ( 'event' === $k && ! $this->action_options['force_event'] && ! empty( $action->post_content[$k] ) ) {
 					continue;
 				}
-				$action->post_content[ $k ] = wp_parse_args( $action->post_content[ $k ], $vals );
+				$action->post_content[$k] = wp_parse_args( $action->post_content[$k], $vals );
 			}
 		}
 
@@ -821,9 +821,9 @@ 
 
 		// fill with existing options
 		foreach ( $action->post_content as $name => $val ) {
-			if ( isset( $form->options[ $name ] ) ) {
-				$action->post_content[ $name ] = $form->options[ $name ];
-				unset( $form->options[ $name ] );
+			if ( isset( $form->options[$name] ) ) {
+				$action->post_content[$name] = $form->options[$name];
+				unset( $form->options[$name] );
 			}
 		}
 
@@ -883,8 +883,8 @@ 
 	private static function get_value_from_entry( $entry, $field_id ) {
 		$observed_value = '';
 
-		if ( isset( $entry->metas[ $field_id ] ) ) {
-			$observed_value = $entry->metas[ $field_id ];
+		if ( isset( $entry->metas[$field_id] ) ) {
+			$observed_value = $entry->metas[$field_id];
 		} elseif ( $entry->post_id && FrmAppHelper::pro_is_installed() ) {
 			$field          = FrmField::getOne( $field_id );
 			$observed_value = FrmProEntryMetaHelper::get_post_or_meta_value(
@@ -958,7 +958,7 @@ 
 		$form_fields = FrmField::get_all_for_form( $form_id, '', 'include' );
 		return array_filter(
 			$form_fields,
-			function ( $form_field ) {
+			function( $form_field ) {
 				return ! FrmField::is_no_save_field( $form_field->type );
 			}
 		);

classes/models/FrmFieldFormHtml.php

Spacing +13 added lines, -13 removed lines

@@ -44,8 +44,8 @@ 
 	 * @param array  $atts
 	 */
 	private function _set( $param, $atts ) {
-		if ( isset( $atts[ $param ] ) ) {
-			$this->{$param} = $atts[ $param ];
+		if ( isset( $atts[$param] ) ) {
+			$this->{$param} = $atts[$param];
 		}
 	}
 
@@ -89,8 +89,8 @@ 
 
 		$exclude = array( 'field_obj', 'html' );
 		foreach ( $exclude as $ex ) {
-			if ( isset( $atts[ $ex ] ) ) {
-				unset( $this->pass_args[ $ex ] );
+			if ( isset( $atts[$ex] ) ) {
+				unset( $this->pass_args[$ex] );
 			}
 		}
 	}
@@ -102,8 +102,8 @@ 
 	 * @param array $set
 	 */
 	private function set_from_field( $atts, $set ) {
-		if ( isset( $atts[ $set['param'] ] ) ) {
-			$this->{$set['param']} = $atts[ $set['param'] ];
+		if ( isset( $atts[$set['param']] ) ) {
+			$this->{$set['param']} = $atts[$set['param']];
 		} else {
 			$this->{$set['param']} = $this->field_obj->get_field_column( $set['default'] );
 		}
@@ -230,7 +230,7 @@ 
 	 */
 	private function replace_error_shortcode() {
 		$this->maybe_add_error_id();
-		$error = $this->pass_args['errors'][ 'field' . $this->field_id ] ?? false;
+		$error = $this->pass_args['errors']['field' . $this->field_id] ?? false;
 
 		if ( ! empty( $error ) && false === strpos( $this->html, 'role="alert"' ) && FrmAppHelper::should_include_alert_role_on_field_errors() ) {
 			$error_body = self::get_error_body( $this->html );
@@ -271,7 +271,7 @@ 
 	 * @since 3.06.02
 	 */
 	private function maybe_add_error_id() {
-		if ( ! isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ) {
+		if ( ! isset( $this->pass_args['errors']['field' . $this->field_id] ) ) {
 			return;
 		}
 
@@ -351,7 +351,7 @@ 
 		preg_match_all( "/\[(input|deletelink)\b(.*?)(?:(\/))?\]/s", $this->html, $shortcodes, PREG_PATTERN_ORDER );
 
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
-			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
+			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
 			$tag            = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
 
 			$replace_with = '';
@@ -362,7 +362,7 @@ 
 				$replace_with = $this->replace_input_shortcode( $shortcode_atts );
 			}
 
-			$this->html = str_replace( $shortcodes[0][ $short_key ], $replace_with, $this->html );
+			$this->html = str_replace( $shortcodes[0][$short_key], $replace_with, $this->html );
 		}
 	}
 
@@ -384,7 +384,7 @@ 
 	 */
 	private function prepare_input_shortcode_atts( $shortcode_atts ) {
 		if ( isset( $shortcode_atts['opt'] ) ) {
-			--$shortcode_atts['opt'];
+			-- $shortcode_atts['opt'];
 		}
 
 		$field_class = $shortcode_atts['class'] ?? '';
@@ -448,7 +448,7 @@ 
 	 */
 	private function get_field_div_classes() {
 		// Add error class
-		$classes = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? ' frm_blank_field' : '';
+		$classes = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? ' frm_blank_field' : '';
 
 		// Add label position class
 		$settings = $this->field_obj->display_field_settings();
@@ -527,7 +527,7 @@ 
 		}
 
 		// Add 'aria-invalid' attribute to the group if there are errors.
-		if ( isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ) {
+		if ( isset( $this->pass_args['errors']['field' . $this->field_id] ) ) {
 			$attributes['aria-invalid'] = 'true';
 		}
 

classes/models/FrmEntryValidate.php

Spacing +32 added lines, -32 removed lines

@@ -27,7 +27,7 @@ 
 			return $errors;
 		}
 
-		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values[ 'frm_submit_entry_' . $values['form_id'] ] ) || ! wp_verify_nonce( $values[ 'frm_submit_entry_' . $values['form_id'] ], 'frm_submit_entry_nonce' ) ) ) {
+		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values['frm_submit_entry_' . $values['form_id']] ) || ! wp_verify_nonce( $values['frm_submit_entry_' . $values['form_id']], 'frm_submit_entry_nonce' ) ) ) {
 			$frm_settings   = FrmAppHelper::get_settings();
 			$errors['form'] = $frm_settings->admin_permission;
 		}
@@ -130,7 +130,7 @@ 
 		$args = wp_parse_args( $args, $defaults );
 
 		if ( empty( $args['parent_field_id'] ) ) {
-			$value = $values['item_meta'][ $args['id'] ] ?? '';
+			$value = $values['item_meta'][$args['id']] ?? '';
 		} else {
 			// value is from a nested form
 			$value = $values;
@@ -151,7 +151,7 @@ 
 		}
 
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
 		} elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			self::maybe_add_item_name( $value, $posted_field );
 		}
@@ -204,7 +204,7 @@ 
 		$option_is_valid = (bool) apply_filters( 'frm_option_is_valid', $option_is_valid, $value, $posted_field );
 
 		if ( ! $option_is_valid ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'invalid' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $posted_field, 'invalid' );
 		}
 	}
 
@@ -328,7 +328,7 @@ 
 		FrmFieldsHelper::prepare_new_front_field( $values, $field_object );
 
 		$separate_value = FrmField::get_option( $field_object, 'separate_value' );
-		$map_callback   = function ( $option ) use ( $separate_value ) {
+		$map_callback   = function( $option ) use ( $separate_value ) {
 			if ( is_array( $option ) ) {
 				$option_value = $separate_value ? $option['value'] : $option['label'];
 			} else {
@@ -402,7 +402,7 @@ 
 			$pattern = self::phone_format( $field );
 
 			if ( ! preg_match( $pattern, $value ) ) {
-				$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
+				$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
 			}
 		}
 	}
@@ -524,7 +524,7 @@ 
 	 */
 	private static function form_is_in_progress( $values ) {
 		return FrmAppHelper::pro_is_installed() &&
-			( isset( $values[ 'frm_page_order_' . $values['form_id'] ] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
+			( isset( $values['frm_page_order_' . $values['form_id']] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
 			FrmField::get_all_types_in_form( $values['form_id'], 'break' );
 	}
 
@@ -734,9 +734,9 @@ 
 			foreach ( $datas['missing_keys'] as $key_index => $key ) {
 				$found = self::is_akismet_guest_info_value( $key, $value, $field_id, $datas['name_field_ids'], $values );
 				if ( $found ) {
-					$datas[ $key ]             = $value;
+					$datas[$key]             = $value;
 					$datas['frm_duplicated'][] = $field_id;
-					unset( $datas['missing_keys'][ $key_index ] );
+					unset( $datas['missing_keys'][$key_index] );
 				}
 			}
 		}//end foreach
@@ -779,11 +779,11 @@ 
 					if ( 'Name' !== $field->name ) {
 						continue;
 					}
-					if ( isset( $fields[ $index + 1 ] ) && 'Last' === $fields[ $index + 1 ]->name ) {
-						if ( empty( $values[ absint( $fields[ $index + 1 ]->id ) ] ) ) {
+					if ( isset( $fields[$index + 1] ) && 'Last' === $fields[$index + 1]->name ) {
+						if ( empty( $values[absint( $fields[$index + 1]->id )] ) ) {
 							continue;
 						}
-						$value .= ' ' . $values[ $fields[ $index + 1 ]->id ];
+						$value .= ' ' . $values[$fields[$index + 1]->id];
 						return true;
 					}
 				}
@@ -802,13 +802,13 @@ 
 	 */
 	private static function get_name_text_fields( $form_id ) {
 		$name_text_fields_is_initialized = is_array( self::$name_text_fields );
-		if ( $name_text_fields_is_initialized && isset( self::$name_text_fields[ $form_id ] ) ) {
-			return self::$name_text_fields[ $form_id ];
+		if ( $name_text_fields_is_initialized && isset( self::$name_text_fields[$form_id] ) ) {
+			return self::$name_text_fields[$form_id];
 		}
 		if ( ! $name_text_fields_is_initialized ) {
 			self::$name_text_fields = array();
 		}
-		self::$name_text_fields[ $form_id ] = FrmDb::get_results(
+		self::$name_text_fields[$form_id] = FrmDb::get_results(
 			'frm_fields',
 			array(
 				'form_id' => $form_id,
@@ -819,7 +819,7 @@ 
 			array( 'order_by' => 'field_order ASC' )
 		);
 
-		return self::$name_text_fields[ $form_id ];
+		return self::$name_text_fields[$form_id];
 	}
 
 	private static function add_server_values_to_akismet( &$datas ) {
@@ -828,7 +828,7 @@ 
 
 			// Send any potentially useful $_SERVER vars, but avoid sending junk we don't need.
 			if ( $include_value ) {
-				$datas[ $key ] = $value;
+				$datas[$key] = $value;
 			}
 			unset( $key, $value );
 		}
@@ -845,10 +845,10 @@ 
 	private static function add_comment_content_to_akismet( &$datas, $values ) {
 		if ( isset( $datas['frm_duplicated'] ) ) {
 			foreach ( $datas['frm_duplicated'] as $index ) {
-				if ( isset( $values['item_meta'][ $index ] ) ) {
-					unset( $values['item_meta'][ $index ] );
+				if ( isset( $values['item_meta'][$index] ) ) {
+					unset( $values['item_meta'][$index] );
 				} else {
-					unset( $values[ $index ] );
+					unset( $values[$index] );
 				}
 			}
 			unset( $datas['frm_duplicated'] );
@@ -867,14 +867,14 @@ 
 	private static function skip_adding_values_to_akismet( &$values ) {
 		$skipped_fields = self::get_akismet_skipped_field_ids( $values );
 		foreach ( $skipped_fields as $skipped_field ) {
-			if ( ! isset( $values['item_meta'][ $skipped_field->id ] ) ) {
+			if ( ! isset( $values['item_meta'][$skipped_field->id] ) ) {
 				continue;
 			}
 
 			if ( self::should_really_skip_field( $skipped_field, $values ) ) {
-				unset( $values['item_meta'][ $skipped_field->id ] );
-				if ( isset( $values['item_meta']['other'][ $skipped_field->id ] ) ) {
-					unset( $values['item_meta']['other'][ $skipped_field->id ] );
+				unset( $values['item_meta'][$skipped_field->id] );
+				if ( isset( $values['item_meta']['other'][$skipped_field->id] ) ) {
+					unset( $values['item_meta']['other'][$skipped_field->id] );
 				}
 			}
 		}
@@ -910,14 +910,14 @@ 
 		}
 
 		// If a choice field has Other option, but Other is not selected.
-		if ( empty( $values['item_meta']['other'][ $field_data->id ] ) ) {
+		if ( empty( $values['item_meta']['other'][$field_data->id] ) ) {
 			return true;
 		}
 
 		// Check if submitted value is same as one of field option.
 		foreach ( $field_data->options as $option ) {
 			$option_value = ! is_array( $option ) ? $option : ( $option['value'] ?? '' );
-			if ( $values['item_meta']['other'][ $field_data->id ] === $option_value ) {
+			if ( $values['item_meta']['other'][$field_data->id] === $option_value ) {
 				return true;
 			}
 		}
@@ -989,7 +989,7 @@ 
 
 			// Convert name array to string.
 			if ( isset( $value['first'] ) && isset( $value['last'] ) ) {
-				$values['item_meta'][ $field_id ] = trim( implode( ' ', $value ) );
+				$values['item_meta'][$field_id] = trim( implode( ' ', $value ) );
 				$values['name_field_ids'][]       = $field_id;
 				continue;
 			}
@@ -1010,8 +1010,8 @@ 
 						continue;
 					}
 
-					if ( ! isset( $values['item_meta'][ $subsubindex ] ) ) {
-						$values['item_meta'][ $subsubindex ] = array();
+					if ( ! isset( $values['item_meta'][$subsubindex] ) ) {
+						$values['item_meta'][$subsubindex] = array();
 					}
 
 					// Convert name array to string.
@@ -1021,13 +1021,13 @@ 
 						$values['name_field_ids'][] = $subsubindex;
 					}
 
-					if ( is_array( $values['item_meta'][ $subsubindex ] ) ) {
-						$values['item_meta'][ $subsubindex ][] = $subsubvalue;
+					if ( is_array( $values['item_meta'][$subsubindex] ) ) {
+						$values['item_meta'][$subsubindex][] = $subsubvalue;
 					}
 				}
 			}//end foreach
 
-			unset( $values['item_meta'][ $field_id ] );
+			unset( $values['item_meta'][$field_id] );
 		}//end foreach
 
 		return $form_ids;

classes/models/FrmField.php

Spacing +36 added lines, -36 removed lines

@@ -309,8 +309,8 @@ 
 			require_once ABSPATH . 'wp-admin/includes/plugin.php';
 		}
 		$plugins = get_plugins();
-		if ( isset( $plugins[ $plugin ] ) && ! empty( $plugins[ $plugin ]['Version'] ) ) {
-			return $plugins[ $plugin ]['Version'];
+		if ( isset( $plugins[$plugin] ) && ! empty( $plugins[$plugin]['Version'] ) ) {
+			return $plugins[$plugin]['Version'];
 		}
 		return false;
 	}
@@ -383,8 +383,8 @@ 
 		$values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
 
 		foreach ( array( 'name', 'description', 'type', 'default_value' ) as $col ) {
-			if ( isset( $values[ $col ] ) ) {
-				$new_values[ $col ] = $values[ $col ];
+			if ( isset( $values[$col] ) ) {
+				$new_values[$col] = $values[$col];
 			}
 		}
 
@@ -396,7 +396,7 @@ 
 		$new_values['created_at']    = current_time( 'mysql', 1 );
 
 		if ( isset( $values['id'] ) ) {
-			$frm_duplicate_ids[ $values['field_key'] ] = $new_values['field_key'];
+			$frm_duplicate_ids[$values['field_key']] = $new_values['field_key'];
 			$new_values                                = apply_filters( 'frm_duplicated_field', $new_values );
 		}
 
@@ -405,9 +405,9 @@ 
 		foreach ( $new_values as $k => $v ) {
 			if ( is_array( $v ) ) {
 				if ( $k === 'default_value' ) {
-					$new_values[ $k ] = FrmAppHelper::maybe_json_encode( $v );
+					$new_values[$k] = FrmAppHelper::maybe_json_encode( $v );
 				} else {
-					$new_values[ $k ] = serialize( $v );
+					$new_values[$k] = serialize( $v );
 				}
 			}
 			unset( $k, $v );
@@ -427,7 +427,7 @@ 
 		}
 
 		if ( isset( $values['id'] ) ) {
-			$frm_duplicate_ids[ $values['id'] ] = $new_id;
+			$frm_duplicate_ids[$values['id']] = $new_id;
 		}
 
 		return $new_id;
@@ -478,7 +478,7 @@ 
 			 * @param array $match Shortcode data.
 			 * @return string
 			 */
-			function ( $match ) {
+			function( $match ) {
 				$attr = shortcode_parse_atts( $match[3] );
 
 				if ( ! is_array( $attr ) ) {
@@ -503,7 +503,7 @@ 
 					}
 
 					if ( FrmAppHelper::input_key_is_safe( $key, 'update' ) ) {
-						$safe_atts[ $key ] = $value;
+						$safe_atts[$key] = $value;
 					}
 				}
 
@@ -561,7 +561,7 @@ 
 	public static function duplicate( $old_form_id, $form_id, $copy_keys = false, $blog_id = false ) {
 		global $frm_duplicate_ids;
 
-		$where  = array(
+		$where = array(
 			array(
 				'or'                => 1,
 				'fi.form_id'        => $old_form_id,
@@ -607,8 +607,8 @@ 
 
 			$values                                 = apply_filters( 'frm_duplicated_field', $values );
 			$new_id                                 = self::create( $values );
-			$frm_duplicate_ids[ $field->id ]        = $new_id;
-			$frm_duplicate_ids[ $field->field_key ] = $new_id;
+			$frm_duplicate_ids[$field->id]        = $new_id;
+			$frm_duplicate_ids[$field->field_key] = $new_id;
 			unset( $field );
 		}//end foreach
 	}
@@ -657,11 +657,11 @@ 
 
 		// serialize array values
 		foreach ( array( 'field_options', 'options' ) as $opt ) {
-			if ( isset( $values[ $opt ] ) && is_array( $values[ $opt ] ) ) {
+			if ( isset( $values[$opt] ) && is_array( $values[$opt] ) ) {
 				if ( 'field_options' === $opt ) {
-					$values[ $opt ] = self::maybe_filter_options( $values[ $opt ] );
+					$values[$opt] = self::maybe_filter_options( $values[$opt] );
 				}
-				$values[ $opt ] = serialize( $values[ $opt ] );
+				$values[$opt] = serialize( $values[$opt] );
 			}
 		}
 		if ( isset( $values['default_value'] ) && is_array( $values['default_value'] ) ) {
@@ -848,8 +848,8 @@ 
 					continue;
 				}
 
-				$fields[ $result->id ] = $result;
-				++$count;
+				$fields[$result->id] = $result;
+				++ $count;
 				if ( $limit == 1 ) {
 					$fields = $result;
 					break;
@@ -900,8 +900,8 @@ 
 			$fields = array();
 			$count  = 0;
 			foreach ( $results as $result ) {
-				++$count;
-				$fields[ $result->id ] = $result;
+				++ $count;
+				$fields[$result->id] = $result;
 				if ( ! empty( $limit ) && $count >= $limit ) {
 					break;
 				}
@@ -1015,7 +1015,7 @@ 
 		$query_type = $limit === ' LIMIT 1' || $limit == 1 ? 'row' : 'results';
 
 		if ( is_array( $where ) ) {
-			$args    = array(
+			$args = array(
 				'order_by' => $order_by,
 				'limit'    => $limit,
 			);
@@ -1048,9 +1048,9 @@ 
 				FrmDb::set_cache( $result->field_key, $result, 'frm_field' );
 
 				self::prepare_options( $result );
-				$results[ $r_key ]->field_options = $result->field_options;
-				$results[ $r_key ]->options       = $result->options;
-				$results[ $r_key ]->default_value = $result->default_value;
+				$results[$r_key]->field_options = $result->field_options;
+				$results[$r_key]->options       = $result->options;
+				$results[$r_key]->default_value = $result->default_value;
 
 				unset( $r_key, $result );
 			}
@@ -1129,7 +1129,7 @@ 
 
 			if ( count( $next_fields ) >= self::$transient_size ) {
 				// if this transient is full, check for another
-				++$next;
+				++ $next;
 				self::get_next_transient( $fields, $base_name, $next );
 			}
 		}
@@ -1157,7 +1157,7 @@ 
 				return;
 			}
 
-			++$next;
+			++ $next;
 		}
 	}
 
@@ -1305,7 +1305,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_true_in_array( $field, $option ) {
-		return ! empty( $field[ $option ] );
+		return ! empty( $field[$option] );
 	}
 
 	/**
@@ -1314,7 +1314,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_true_in_object( $field, $option ) {
-		return isset( $field->field_options[ $option ] ) && $field->field_options[ $option ];
+		return isset( $field->field_options[$option] ) && $field->field_options[$option];
 	}
 
 	/**
@@ -1323,7 +1323,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_empty_in_array( $field, $option ) {
-		return empty( $field[ $option ] );
+		return empty( $field[$option] );
 	}
 
 	/**
@@ -1332,7 +1332,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_empty_in_object( $field, $option ) {
-		return empty( $field->field_options[ $option ] );
+		return empty( $field->field_options[$option] );
 	}
 
 	/**
@@ -1341,7 +1341,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_value_in_object( $field, $option ) {
-		return isset( $field->field_options[ $option ] ) && $field->field_options[ $option ] != '';
+		return isset( $field->field_options[$option] ) && $field->field_options[$option] != '';
 	}
 
 	/**
@@ -1367,10 +1367,10 @@ 
 	 * @return mixed
 	 */
 	public static function get_option_in_array( $field, $option ) {
-		if ( isset( $field[ $option ] ) ) {
-			$this_option = $field[ $option ];
-		} elseif ( isset( $field['field_options'] ) && is_array( $field['field_options'] ) && isset( $field['field_options'][ $option ] ) ) {
-			$this_option = $field['field_options'][ $option ];
+		if ( isset( $field[$option] ) ) {
+			$this_option = $field[$option];
+		} elseif ( isset( $field['field_options'] ) && is_array( $field['field_options'] ) && isset( $field['field_options'][$option] ) ) {
+			$this_option = $field['field_options'][$option];
 		} else {
 			$this_option = '';
 		}
@@ -1384,7 +1384,7 @@ 
 	 * @return mixed
 	 */
 	public static function get_option_in_object( $field, $option ) {
-		return $field->field_options[ $option ] ?? '';
+		return $field->field_options[$option] ?? '';
 	}
 
 	/**

classes/helpers/FrmFieldsHelper.php

Spacing +50 added lines, -50 removed lines

@@ -38,7 +38,7 @@ 
 			if ( in_array( $type, array( 'data', 'lookup' ), true ) ) {
 				$values['field_options']['data_type'] = $setting;
 			} else {
-				$values['field_options'][ $setting ] = 1;
+				$values['field_options'][$setting] = 1;
 			}
 		}
 
@@ -172,10 +172,10 @@ 
 		}
 
 		foreach ( $defaults as $opt => $default ) {
-			$values[ $opt ] = $field->field_options[ $opt ] ?? $default;
+			$values[$opt] = $field->field_options[$opt] ?? $default;
 
 			if ( $check_post ) {
-				self::get_posted_field_setting( $opt . '_' . $field->id, $values[ $opt ] );
+				self::get_posted_field_setting( $opt . '_' . $field->id, $values[$opt] );
 			}
 		}
 	}
@@ -192,7 +192,7 @@ 
 			return self::$context_is_safe_to_load_field_options_from_request_data;
 		}
 
-		$function = function () {
+		$function = function() {
 			if ( ! FrmAppHelper::is_admin_page() ) {
 				return false;
 			}
@@ -300,12 +300,12 @@ 
 	 * @param mixed  $value
 	 */
 	private static function get_posted_field_setting( $setting, &$value ) {
-		if ( ! isset( $_POST['field_options'][ $setting ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( ! isset( $_POST['field_options'][$setting] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return;
 		}
 
 		if ( strpos( $setting, 'html' ) !== false ) {
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 
 			// Conditionally strip script tags if the user sending $_POST data is not allowed to use unfiltered HTML.
 			if ( ! FrmAppHelper::allow_unfiltered_html() ) {
@@ -313,9 +313,9 @@ 
 			}
 		} elseif ( strpos( $setting, 'format_' ) === 0 ) {
 			// TODO: Remove stripslashes on output, and use on input only.
-			$value = sanitize_text_field( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
+			$value = sanitize_text_field( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
 		} else {
-			$value = wp_unslash( $_POST['field_options'][ $setting ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$value = wp_unslash( $_POST['field_options'][$setting] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 			FrmAppHelper::sanitize_value( 'wp_kses_post', $value );
 		}
 	}
@@ -388,7 +388,7 @@ 
 		$values['default_value'] = FrmAppHelper::maybe_json_encode( $field->default_value );
 
 		foreach ( array( 'name', 'description', 'type', 'field_order', 'field_options', 'required' ) as $col ) {
-			$values[ $col ] = $field->{$col};
+			$values[$col] = $field->{$col};
 		}
 	}
 
@@ -426,7 +426,7 @@ 
 		);
 
 		$msg = FrmField::get_option( $field, $error );
-		$msg = empty( $msg ) ? $defaults[ $error ]['part'] : $msg;
+		$msg = empty( $msg ) ? $defaults[$error]['part'] : $msg;
 		$msg = do_shortcode( $msg );
 
 		$msg = self::maybe_replace_substrings_with_field_name( $msg, $error, $field );
@@ -696,7 +696,7 @@ 
 			'inside_class' => 'inside',
 			'dismiss-icon' => true,
 		);
-		$args     = array_merge( $defaults, $args );
+		$args = array_merge( $defaults, $args );
 
 		include FrmAppHelper::plugin_path() . '/classes/views/frm-fields/back-end/inline-modal.php';
 	}
@@ -934,7 +934,7 @@ 
 				continue;
 			}
 
-			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][ $short_key ] );
+			$atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[3][$short_key] );
 			$tag  = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
 
 			$atts['entry'] = $entry;
@@ -944,7 +944,7 @@ 
 			if ( $replace_with !== null ) {
 				$replace_with = self::trigger_shortcode_atts( $replace_with, $atts );
 				self::sanitize_embedded_shortcodes( compact( 'entry' ), $replace_with );
-				$content = str_replace( $shortcodes[0][ $short_key ], $replace_with, $content );
+				$content = str_replace( $shortcodes[0][$short_key], $replace_with, $content );
 			}
 
 			unset( $atts, $replace_with );
@@ -962,7 +962,7 @@ 
 		$supported_atts = array( 'remove_accents', 'sanitize', 'sanitize_url' );
 		$included_atts  = array_intersect( $supported_atts, array_keys( $atts ) );
 		foreach ( $included_atts as $included_att ) {
-			if ( '0' === $atts[ $included_att ] ) {
+			if ( '0' === $atts[$included_att] ) {
 				// Skip any option that uses 0 so sanitize_url=0 does not encode.
 				continue;
 			}
@@ -1040,8 +1040,8 @@ 
 
 		$dynamic_default = array( 'admin_email', 'siteurl', 'frmurl', 'sitename', 'get', 'default-email', 'default-from-email' );
 
-		if ( isset( $shortcode_values[ $atts['tag'] ] ) ) {
-			$replace_with = $shortcode_values[ $atts['tag'] ];
+		if ( isset( $shortcode_values[$atts['tag']] ) ) {
+			$replace_with = $shortcode_values[$atts['tag']];
 		} elseif ( in_array( $atts['tag'], $dynamic_default, true ) ) {
 			$replace_with = self::dynamic_default_values( $atts['tag'], $atts );
 		} elseif ( $clean_tag === 'user_agent' ) {
@@ -1265,8 +1265,8 @@ 
 			self::field_types_for_input( $single_input, $field_selection, $field_types );
 		} elseif ( in_array( $type, $multiple_input, true ) ) {
 			self::field_types_for_input( $multiple_input, $field_selection, $field_types );
-		} elseif ( isset( $field_selection[ $type ] ) ) {
-			$field_types[ $type ] = $field_selection[ $type ];
+		} elseif ( isset( $field_selection[$type] ) ) {
+			$field_types[$type] = $field_selection[$type];
 		}
 
 		$field_types = apply_filters( 'frm_switch_field_types', $field_types, compact( 'type', 'field_selection' ) );
@@ -1308,7 +1308,7 @@ 
 		foreach ( $inputs as $input ) {
 			// This may not be set if a field type was removed using the frm_available_fields or frm_pro_available_fields filters.
 			if ( array_key_exists( $input, $fields ) ) {
-				$field_types[ $input ] = $fields[ $input ];
+				$field_types[$input] = $fields[$input];
 			}
 			unset( $input );
 		}
@@ -1341,7 +1341,7 @@ 
 			'parent'  => false,
 			'pointer' => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		$opt_key   = $args['opt_key'];
 		$field     = $args['field'];
@@ -1357,25 +1357,25 @@ 
 
 		// Check posted vals before checking saved values
 		// For fields inside repeating sections - note, don't check if $pointer is true because it will often be zero
-		if ( $parent && isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( $parent && isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
-				$other_val = isset( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ][ $opt_key ] ) ) : '';
+				$other_val = isset( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']][$opt_key] ) ) : '';
 			} else {
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][ $parent ][ $pointer ]['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta'][$parent][$pointer]['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			}
 
 			return $other_val;
 		}
 
-		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][ $field['id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $field['id'] ) && isset( $_POST['item_meta']['other'][$field['id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			// For normal fields
 
 			if ( FrmField::is_field_with_multiple_values( $field ) ) {
 				// phpcs:ignore WordPress.Security.NonceVerification.Missing
-				$other_val = isset( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ][ $opt_key ] ) ) : '';
+				$other_val = isset( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ? sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']][$opt_key] ) ) : '';
 			} else {
-				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][ $field['id'] ] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+				$other_val = sanitize_text_field( wp_unslash( $_POST['item_meta']['other'][$field['id']] ) ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			}
 
 			return $other_val;
@@ -1385,8 +1385,8 @@ 
 		if ( $field['type'] === 'checkbox' && is_array( $field['value'] ) ) {
 			// Check if there is an "other" val in saved value and make sure the
 			// "other" val is not equal to the Other checkbox option
-			if ( isset( $field['value'][ $opt_key ] ) && $field['options'][ $opt_key ] != $field['value'][ $opt_key ] ) {
-				$other_val = $field['value'][ $opt_key ];
+			if ( isset( $field['value'][$opt_key] ) && $field['options'][$opt_key] != $field['value'][$opt_key] ) {
+				$other_val = $field['value'][$opt_key];
 			}
 		} else {
 			/**
@@ -1398,8 +1398,8 @@ 
 				// Multi-select dropdowns - key is not preserved
 				if ( is_array( $field['value'] ) ) {
 					$o_key = array_search( $temp_val, $field['value'] );
-					if ( isset( $field['value'][ $o_key ] ) ) {
-						unset( $field['value'][ $o_key ], $o_key );
+					if ( isset( $field['value'][$o_key] ) ) {
+						unset( $field['value'][$o_key], $o_key );
 					}
 				} elseif ( $temp_val == $field['value'] ) {
 					// For radio and regular dropdowns
@@ -1610,11 +1610,11 @@ 
 			foreach ( $val as $k => $v ) {
 				if ( is_string( $v ) ) {
 					if ( 'custom_html' === $k ) {
-						$val[ $k ] = self::switch_ids_except_strings( $replace, $replace_with, array( '[if description]', '[description]', '[/if description]' ), $v );
+						$val[$k] = self::switch_ids_except_strings( $replace, $replace_with, array( '[if description]', '[description]', '[/if description]' ), $v );
 						unset( $k, $v );
 						continue;
 					}
-					$val[ $k ] = str_replace( $replace, $replace_with, $v );
+					$val[$k] = str_replace( $replace, $replace_with, $v );
 					unset( $k, $v );
 				}
 			}
@@ -1643,8 +1643,8 @@ 
 			if ( false === $index ) {
 				continue;
 			}
-			unset( $replace[ $index ] );
-			unset( $replace_with[ $index ] );
+			unset( $replace[$index] );
+			unset( $replace_with[$index] );
 		}
 		$value = str_replace( $replace, $replace_with, $value );
 		return $value;
@@ -1992,7 +1992,7 @@ 
 			$countries['class'] = 'frm-countries-opts';
 		}
 
-		$prepop[ __( 'Countries', 'formidable' ) ] = $countries;
+		$prepop[__( 'Countries', 'formidable' )] = $countries;
 
 		// State abv.
 		$states    = self::get_us_states();
@@ -2002,7 +2002,7 @@ 
 			$state_abv['class'] = 'frm-state-abv-opts';
 		}
 
-		$prepop[ __( 'U.S. State Abbreviations', 'formidable' ) ] = $state_abv;
+		$prepop[__( 'U.S. State Abbreviations', 'formidable' )] = $state_abv;
 
 		// States.
 		$states = array_values( $states );
@@ -2011,7 +2011,7 @@ 
 			$states['class'] = 'frm-states-opts';
 		}
 
-		$prepop[ __( 'U.S. States', 'formidable' ) ] = $states;
+		$prepop[__( 'U.S. States', 'formidable' )] = $states;
 		unset( $state_abv, $states );
 
 		// Age.
@@ -2029,7 +2029,7 @@ 
 			$ages['class'] = 'frm-age-opts';
 		}
 
-		$prepop[ __( 'Age', 'formidable' ) ] = $ages;
+		$prepop[__( 'Age', 'formidable' )] = $ages;
 
 		// Satisfaction.
 		$satisfaction = array(
@@ -2044,7 +2044,7 @@ 
 			$satisfaction['class'] = 'frm-satisfaction-opts';
 		}
 
-		$prepop[ __( 'Satisfaction', 'formidable' ) ] = $satisfaction;
+		$prepop[__( 'Satisfaction', 'formidable' )] = $satisfaction;
 
 		// Importance.
 		$importance = array(
@@ -2059,7 +2059,7 @@ 
 			$importance['class'] = 'frm-importance-opts';
 		}
 
-		$prepop[ __( 'Importance', 'formidable' ) ] = $importance;
+		$prepop[__( 'Importance', 'formidable' )] = $importance;
 
 		// Agreement.
 		$agreement = array(
@@ -2074,7 +2074,7 @@ 
 			$agreement['class'] = 'frm-agreement-opts';
 		}
 
-		$prepop[ __( 'Agreement', 'formidable' ) ] = $agreement;
+		$prepop[__( 'Agreement', 'formidable' )] = $agreement;
 
 		// Likely.
 		$likely = array(
@@ -2089,7 +2089,7 @@ 
 			$likely['class'] = 'frm-likely-opts';
 		}
 
-		$prepop[ __( 'Likely', 'formidable' ) ] = $likely;
+		$prepop[__( 'Likely', 'formidable' )] = $likely;
 
 		$prepop = apply_filters( 'frm_bulk_field_choices', $prepop );
 	}
@@ -2310,16 +2310,16 @@ 
 	 */
 	private static function fill_image_setting_options( $options, &$args ) {
 		foreach ( $options as $key => $option ) {
-			$args['options'][ $key ] = $option;
+			$args['options'][$key] = $option;
 
 			if ( ! empty( $option['addon'] ) ) {
-				$args['options'][ $key ]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
+				$args['options'][$key]['custom_attrs'] = self::fill_image_setting_addon_link( $option );
 			}
 
-			unset( $args['options'][ $key ]['addon'] );
+			unset( $args['options'][$key]['addon'] );
 			$fill = array( 'upgrade', 'message', 'content' );
 			foreach ( $fill as $f ) {
-				unset( $args['options'][ $key ][ $f ], $f );
+				unset( $args['options'][$key][$f], $f );
 			}
 		}
 	}
@@ -2340,8 +2340,8 @@ 
 
 		$fill = array( 'upgrade', 'message', 'content' );
 		foreach ( $fill as $f ) {
-			if ( isset( $option[ $f ] ) ) {
-				$custom_attrs[ 'data-' . $f ] = $option[ $f ];
+			if ( isset( $option[$f] ) ) {
+				$custom_attrs['data-' . $f] = $option[$f];
 			}
 		}
 
@@ -2407,7 +2407,7 @@ 
 
 		return array_filter(
 			$rows,
-			function ( $row ) {
+			function( $row ) {
 				FrmAppHelper::unserialize_or_decode( $row->field_options );
 				return is_array( $row->field_options ) && ! empty( $row->field_options['draft'] );
 			}
@@ -2470,7 +2470,7 @@ 
 		if ( empty( $attributes['data-fid'] ) ) {
 			unset( $data['plugin-status'] );
 			foreach ( $data as $key => $value ) {
-				$attributes[ 'data-' . $key ] = $value;
+				$attributes['data-' . $key] = $value;
 			}
 		}