Completed
Pull Request — master (#2509)
by
unknown
41s
created
classes/models/fields/FrmFieldCombo.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -61,12 +61,12 @@  discard block
 block discarded – undo
61 61
 			if ( is_array( $sub_field ) ) {
62 62
 				$sub_field                 = wp_parse_args( $sub_field, $defaults );
63 63
 				$sub_field['name']         = $name;
64
-				$this->sub_fields[ $name ] = $sub_field;
64
+				$this->sub_fields[$name] = $sub_field;
65 65
 				continue;
66 66
 			}
67 67
 
68 68
 			if ( is_string( $sub_field ) ) {
69
-				$this->sub_fields[ $name ] = wp_parse_args(
69
+				$this->sub_fields[$name] = wp_parse_args(
70 70
 					array(
71 71
 						'name'  => $name,
72 72
 						'label' => $sub_field,
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 	 */
90 90
 	public function set_aria_invalid_error( &$shortcode_atts, $args ) {
91 91
 		foreach ( $this->get_sub_fields() as $sub_field ) {
92
-			$shortcode_atts[ 'aria-invalid-' . $sub_field['name'] ] = isset( $args['errors'][ 'field' . $this->field_id . '-' . $sub_field['name'] ] ) ? 'true' : 'false';
92
+			$shortcode_atts['aria-invalid-' . $sub_field['name']] = isset( $args['errors']['field' . $this->field_id . '-' . $sub_field['name']] ) ? 'true' : 'false';
93 93
 		}
94 94
 	}
95 95
 
@@ -135,9 +135,9 @@  discard block
 block discarded – undo
135 135
 				}
136 136
 
137 137
 				if ( is_string( $option ) ) {
138
-					$extra_options[ $key . '_' . $option ] = '';
138
+					$extra_options[$key . '_' . $option] = '';
139 139
 				} elseif ( ! empty( $option['name'] ) ) {
140
-					$extra_options[ $key . '_' . $option['name'] ] = '';
140
+					$extra_options[$key . '_' . $option['name']] = '';
141 141
 				}
142 142
 			}
143 143
 		}
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 		foreach ( $this->sub_fields as $name => $sub_field ) {
164 164
 			$sub_field['name'] = $name;
165 165
 			$wrapper_classes   = 'frm_grid_container frm_sub_field_options frm_sub_field_options-' . $sub_field['name'];
166
-			if ( ! isset( $processed_sub_fields[ $name ] ) ) {
166
+			if ( ! isset( $processed_sub_fields[$name] ) ) {
167 167
 				// Options for this subfield should be hidden.
168 168
 				$wrapper_classes .= ' frm_hidden';
169 169
 			}
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 			$default_value = array();
194 194
 
195 195
 			foreach ( $this->sub_fields as $name => $sub_field ) {
196
-				$default_value[ $name ] = '';
196
+				$default_value[$name] = '';
197 197
 			}
198 198
 
199 199
 			return $default_value;
@@ -375,8 +375,8 @@  discard block
 block discarded – undo
375 375
 		// Placeholder.
376 376
 		if ( in_array( 'placeholder', $sub_field['options'], true ) ) {
377 377
 			$placeholders = FrmField::get_option( $field, 'placeholder' );
378
-			if ( ! empty( $placeholders[ $sub_field['name'] ] ) ) {
379
-				$field['placeholder'] = $placeholders[ $sub_field['name'] ];
378
+			if ( ! empty( $placeholders[$sub_field['name']] ) ) {
379
+				$field['placeholder'] = $placeholders[$sub_field['name']];
380 380
 			}
381 381
 		}
382 382
 
@@ -437,9 +437,9 @@  discard block
 block discarded – undo
437 437
 
438 438
 		// Validate not empty.
439 439
 		foreach ( $sub_fields as $name => $sub_field ) {
440
-			if ( empty( $sub_field['optional'] ) && empty( $args['value'][ $name ] ) ) {
441
-				$errors[ 'field' . $args['id'] . '-' . $name ] = '';
442
-				$errors[ 'field' . $args['id'] ]               = $blank_msg;
440
+			if ( empty( $sub_field['optional'] ) && empty( $args['value'][$name] ) ) {
441
+				$errors['field' . $args['id'] . '-' . $name] = '';
442
+				$errors['field' . $args['id']]               = $blank_msg;
443 443
 			}
444 444
 		}
445 445
 
@@ -458,7 +458,7 @@  discard block
 block discarded – undo
458 458
 		$field_key  = $this->field->field_key ?? $this->field['field_key'];
459 459
 		$sub_fields = $this->get_processed_sub_fields();
460 460
 		foreach ( $sub_fields as $name => $sub_field ) {
461
-			$headings[ $field_id . '_' . $name ] = $field_name . ' (' . $field_key . ') - ' . $sub_field['label'];
461
+			$headings[$field_id . '_' . $name] = $field_name . ' (' . $field_key . ') - ' . $sub_field['label'];
462 462
 		}
463 463
 
464 464
 		return $headings;
Please login to merge, or discard this patch.
classes/models/fields/FrmFieldName.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -58,19 +58,19 @@  discard block
 block discarded – undo
58 58
 		$result = array();
59 59
 
60 60
 		foreach ( $names as $name ) {
61
-			if ( empty( $this->sub_fields[ $name ] ) ) {
61
+			if ( empty( $this->sub_fields[$name] ) ) {
62 62
 				continue;
63 63
 			}
64 64
 
65
-			if ( ! isset( $this->sub_fields[ $name ]['wrapper_classes'] ) ) {
66
-				$this->sub_fields[ $name ]['wrapper_classes'] = $col_class;
67
-			} elseif ( is_array( $this->sub_fields[ $name ]['wrapper_classes'] ) ) {
68
-				$this->sub_fields[ $name ]['wrapper_classes'] = implode( ' ', $this->sub_fields[ $name ]['wrapper_classes'] ) . ' ' . $col_class;
65
+			if ( ! isset( $this->sub_fields[$name]['wrapper_classes'] ) ) {
66
+				$this->sub_fields[$name]['wrapper_classes'] = $col_class;
67
+			} elseif ( is_array( $this->sub_fields[$name]['wrapper_classes'] ) ) {
68
+				$this->sub_fields[$name]['wrapper_classes'] = implode( ' ', $this->sub_fields[$name]['wrapper_classes'] ) . ' ' . $col_class;
69 69
 			} else {
70
-				$this->sub_fields[ $name ]['wrapper_classes'] .= ' ' . $col_class;
70
+				$this->sub_fields[$name]['wrapper_classes'] .= ' ' . $col_class;
71 71
 			}
72 72
 
73
-			$result[ $name ] = $this->sub_fields[ $name ];
73
+			$result[$name] = $this->sub_fields[$name];
74 74
 		}
75 75
 
76 76
 		return $result;
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 
102 102
 		// Default desc.
103 103
 		foreach ( $this->sub_fields as $name => $sub_field ) {
104
-			$extra_options[ $name . '_desc' ] = $sub_field['label'];
104
+			$extra_options[$name . '_desc'] = $sub_field['label'];
105 105
 		}
106 106
 
107 107
 		return $extra_options;
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 		$name_layout = $this->get_name_layout();
140 140
 
141 141
 		if ( ! empty( $atts['show'] ) ) {
142
-			return $value[ $atts['show'] ] ?? '';
142
+			return $value[$atts['show']] ?? '';
143 143
 		}
144 144
 
145 145
 		$value = wp_parse_args(
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 			$args['sub_fields'] = $this->sub_fields;
217 217
 
218 218
 			foreach ( $hidden_fields as $name => $hidden_field ) {
219
-				$args['sub_fields'][ $name ]['wrapper_classes'] .= ' frm_hidden';
219
+				$args['sub_fields'][$name]['wrapper_classes'] .= ' frm_hidden';
220 220
 			}
221 221
 		}
222 222
 	}
Please login to merge, or discard this patch.
classes/models/FrmHoneypot.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -274,7 +274,7 @@
 block discarded – undo
274 274
 			return '';
275 275
 		}
276 276
 
277
-		return $item_meta[ $field_id ] ?? '';
277
+		return $item_meta[$field_id] ?? '';
278 278
 	}
279 279
 
280 280
 	/**
Please login to merge, or discard this patch.
classes/models/FrmInbox.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 			return;
106 106
 		}
107 107
 
108
-		if ( isset( self::$messages[ $message['key'] ] ) && ! isset( $message['force'] ) ) {
108
+		if ( isset( self::$messages[$message['key']] ) && ! isset( $message['force'] ) ) {
109 109
 			// Don't replace messages unless required.
110 110
 			return;
111 111
 		}
@@ -114,13 +114,13 @@  discard block
 block discarded – undo
114 114
 			return;
115 115
 		}
116 116
 
117
-		if ( isset( self::$messages[ $message['key'] ] ) ) {
117
+		if ( isset( self::$messages[$message['key']] ) ) {
118 118
 			// Move up and mark as new.
119
-			unset( self::$messages[ $message['key'] ] );
119
+			unset( self::$messages[$message['key']] );
120 120
 		}
121 121
 
122 122
 		$this->fill_message( $message );
123
-		self::$messages[ $message['key'] ] = $message;
123
+		self::$messages[$message['key']] = $message;
124 124
 
125 125
 		$this->update_list();
126 126
 
@@ -157,11 +157,11 @@  discard block
 block discarded – undo
157 157
 	private function clean_messages() {
158 158
 		$removed = false;
159 159
 		foreach ( self::$messages as $t => $message ) {
160
-			$read      = ! empty( $message['read'] ) && isset( $message['read'][ get_current_user_id() ] ) && $message['read'][ get_current_user_id() ] < strtotime( '-1 month' );
161
-			$dismissed = ! empty( $message['dismissed'] ) && isset( $message['dismissed'][ get_current_user_id() ] ) && $message['dismissed'][ get_current_user_id() ] < strtotime( '-1 week' );
160
+			$read      = ! empty( $message['read'] ) && isset( $message['read'][get_current_user_id()] ) && $message['read'][get_current_user_id()] < strtotime( '-1 month' );
161
+			$dismissed = ! empty( $message['dismissed'] ) && isset( $message['dismissed'][get_current_user_id()] ) && $message['dismissed'][get_current_user_id()] < strtotime( '-1 week' );
162 162
 			$expired   = $this->is_expired( $message );
163 163
 			if ( $read || $expired || $dismissed ) {
164
-				unset( self::$messages[ $t ] );
164
+				unset( self::$messages[$t] );
165 165
 				$removed = true;
166 166
 			}
167 167
 		}
@@ -179,11 +179,11 @@  discard block
 block discarded – undo
179 179
 	public function filter_messages( &$messages, $type = 'unread' ) {
180 180
 		$user_id = get_current_user_id();
181 181
 		foreach ( $messages as $k => $message ) {
182
-			$dismissed = isset( $message['dismissed'] ) && isset( $message['dismissed'][ $user_id ] );
182
+			$dismissed = isset( $message['dismissed'] ) && isset( $message['dismissed'][$user_id] );
183 183
 			if ( empty( $k ) || $this->is_expired( $message ) || ( $type === 'dismissed' ) !== $dismissed ) {
184
-				unset( $messages[ $k ] );
184
+				unset( $messages[$k] );
185 185
 			} elseif ( ! $this->is_for_user( $message ) ) {
186
-				unset( $messages[ $k ] );
186
+				unset( $messages[$k] );
187 187
 			}
188 188
 		}
189 189
 		$messages = apply_filters( 'frm_filter_inbox', $messages );
@@ -229,14 +229,14 @@  discard block
 block discarded – undo
229 229
 	 * @return void
230 230
 	 */
231 231
 	public function mark_read( $key ) {
232
-		if ( ! $key || ! isset( self::$messages[ $key ] ) ) {
232
+		if ( ! $key || ! isset( self::$messages[$key] ) ) {
233 233
 			return;
234 234
 		}
235 235
 
236
-		if ( ! isset( self::$messages[ $key ]['read'] ) ) {
237
-			self::$messages[ $key ]['read'] = array();
236
+		if ( ! isset( self::$messages[$key]['read'] ) ) {
237
+			self::$messages[$key]['read'] = array();
238 238
 		}
239
-		self::$messages[ $key ]['read'][ get_current_user_id() ] = time();
239
+		self::$messages[$key]['read'][get_current_user_id()] = time();
240 240
 
241 241
 		$this->update_list();
242 242
 	}
@@ -248,9 +248,9 @@  discard block
 block discarded – undo
248 248
 	 * @return void
249 249
 	 */
250 250
 	public function mark_unread( $key ) {
251
-		$is_read = isset( self::$messages[ $key ] ) && isset( self::$messages[ $key ]['read'] ) && isset( self::$messages[ $key ]['read'][ get_current_user_id() ] );
251
+		$is_read = isset( self::$messages[$key] ) && isset( self::$messages[$key]['read'] ) && isset( self::$messages[$key]['read'][get_current_user_id()] );
252 252
 		if ( $is_read ) {
253
-			unset( self::$messages[ $key ]['read'][ get_current_user_id() ] );
253
+			unset( self::$messages[$key]['read'][get_current_user_id()] );
254 254
 			$this->update_list();
255 255
 		}
256 256
 	}
@@ -266,14 +266,14 @@  discard block
 block discarded – undo
266 266
 			return;
267 267
 		}
268 268
 
269
-		if ( ! isset( self::$messages[ $key ] ) ) {
269
+		if ( ! isset( self::$messages[$key] ) ) {
270 270
 			return;
271 271
 		}
272 272
 
273
-		if ( ! isset( self::$messages[ $key ]['dismissed'] ) ) {
274
-			self::$messages[ $key ]['dismissed'] = array();
273
+		if ( ! isset( self::$messages[$key]['dismissed'] ) ) {
274
+			self::$messages[$key]['dismissed'] = array();
275 275
 		}
276
-		self::$messages[ $key ]['dismissed'][ get_current_user_id() ] = time();
276
+		self::$messages[$key]['dismissed'][get_current_user_id()] = time();
277 277
 
278 278
 		$this->update_list();
279 279
 	}
@@ -287,11 +287,11 @@  discard block
 block discarded – undo
287 287
 		$user_id = get_current_user_id();
288 288
 		foreach ( self::$messages as $key => $message ) {
289 289
 			if ( ! isset( $message['dismissed'] ) ) {
290
-				self::$messages[ $key ]['dismissed'] = array();
290
+				self::$messages[$key]['dismissed'] = array();
291 291
 			}
292 292
 
293
-			if ( ! isset( $message['dismissed'][ $user_id ] ) ) {
294
-				self::$messages[ $key ]['dismissed'][ $user_id ] = time();
293
+			if ( ! isset( $message['dismissed'][$user_id] ) ) {
294
+				self::$messages[$key]['dismissed'][$user_id] = time();
295 295
 			}
296 296
 		}
297 297
 		$this->update_list();
@@ -301,8 +301,8 @@  discard block
 block discarded – undo
301 301
 		$messages = $this->get_messages( 'filter' );
302 302
 		$user_id  = get_current_user_id();
303 303
 		foreach ( $messages as $t => $message ) {
304
-			if ( isset( $message['read'] ) && isset( $message['read'][ $user_id ] ) ) {
305
-				unset( $messages[ $t ] );
304
+			if ( isset( $message['read'] ) && isset( $message['read'][$user_id] ) ) {
305
+				unset( $messages[$t] );
306 306
 			}
307 307
 		}
308 308
 		return $messages;
@@ -341,8 +341,8 @@  discard block
 block discarded – undo
341 341
 	 * @return void
342 342
 	 */
343 343
 	public function remove( $key ) {
344
-		if ( isset( self::$messages[ $key ] ) ) {
345
-			unset( self::$messages[ $key ] );
344
+		if ( isset( self::$messages[$key] ) ) {
345
+			unset( self::$messages[$key] );
346 346
 			$this->update_list();
347 347
 		}
348 348
 	}
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
 			 * @param array $matches The regex results for a single match.
389 389
 			 * @return string
390 390
 			 */
391
-			function ( $matches ) {
391
+			function( $matches ) {
392 392
 				$url   = $matches[2];
393 393
 				$parts = parse_url( $url );
394 394
 
@@ -451,8 +451,8 @@  discard block
 block discarded – undo
451 451
 		$inbox = new self();
452 452
 		return array_filter(
453 453
 			$inbox->get_messages( 'filter' ),
454
-			function ( $message ) use ( $key ) {
455
-				return ! empty( $message[ $key ] );
454
+			function( $message ) use ( $key ) {
455
+				return ! empty( $message[$key] );
456 456
 			}
457 457
 		);
458 458
 	}
@@ -498,8 +498,8 @@  discard block
 block discarded – undo
498 498
 
499 499
 		return array_reduce(
500 500
 			$keys_to_return,
501
-			function ( $total, $key ) use ( $message ) {
502
-				$total[ $key ] = $message[ $key ] ?? '';
501
+			function( $total, $key ) use ( $message ) {
502
+				$total[$key] = $message[$key] ?? '';
503 503
 				return $total;
504 504
 			},
505 505
 			array()
Please login to merge, or discard this patch.
classes/models/FrmEntryMeta.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 
59 59
 		global $wpdb;
60 60
 
61
-		$values               = array(
61
+		$values = array(
62 62
 			'item_id'  => $entry_id,
63 63
 			'field_id' => $field_id,
64 64
 		);
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 				}
139 139
 			}
140 140
 
141
-			$values_indexed_by_field_id[ $field_id ] = $meta_value;
141
+			$values_indexed_by_field_id[$field_id] = $meta_value;
142 142
 
143 143
 			self::get_value_to_save( compact( 'field', 'field_id', 'entry_id' ), $meta_value );
144 144
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 
147 147
 				if ( ( is_array( $meta_value ) && empty( $meta_value ) ) || ( ! is_array( $meta_value ) && trim( $meta_value ) == '' ) ) {
148 148
 					// Remove blank fields.
149
-					unset( $values_indexed_by_field_id[ $field_id ] );
149
+					unset( $values_indexed_by_field_id[$field_id] );
150 150
 				} else {
151 151
 					// if value exists, then update it
152 152
 					self::update_entry_meta( $entry_id, $field_id, '', $meta_value );
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 	 */
225 225
 	public static function get_meta_value( $entry, $field_id ) {
226 226
 		if ( isset( $entry->metas ) ) {
227
-			return $entry->metas[ $field_id ] ?? false;
227
+			return $entry->metas[$field_id] ?? false;
228 228
 		}
229 229
 		return self::get_entry_meta_by_field( $entry->id, $field_id );
230 230
 	}
@@ -246,8 +246,8 @@  discard block
 block discarded – undo
246 246
 			$cached   = FrmDb::check_cache( $entry_id, 'frm_entry' );
247 247
 		}
248 248
 
249
-		if ( $cached && isset( $cached->metas ) && isset( $cached->metas[ $field_id ] ) ) {
250
-			$result = $cached->metas[ $field_id ];
249
+		if ( $cached && isset( $cached->metas ) && isset( $cached->metas[$field_id] ) ) {
250
+			$result = $cached->metas[$field_id];
251 251
 
252 252
 			return wp_unslash( $result );
253 253
 		}
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
 			'stripslashes' => true,
281 281
 			'is_draft'     => false,
282 282
 		);
283
-		$args     = wp_parse_args( $args, $defaults );
283
+		$args = wp_parse_args( $args, $defaults );
284 284
 
285 285
 		$query = array();
286 286
 		self::meta_field_query( $field_id, $order, $limit, $args, $query );
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
 
296 296
 		foreach ( $values as $k => $v ) {
297 297
 			FrmAppHelper::unserialize_or_decode( $v );
298
-			$values[ $k ] = $v;
298
+			$values[$k] = $v;
299 299
 			unset( $k, $v );
300 300
 		}
301 301
 
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
 
363 363
 		foreach ( $results as $k => $result ) {
364 364
 			FrmAppHelper::unserialize_or_decode( $result->meta_value );
365
-			$results[ $k ]->meta_value = wp_unslash( $result->meta_value );
365
+			$results[$k]->meta_value = wp_unslash( $result->meta_value );
366 366
 			unset( $k, $result );
367 367
 		}
368 368
 
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 			'user_id'  => '',
376 376
 			'group_by' => '',
377 377
 		);
378
-		$args     = wp_parse_args( $args, $defaults );
378
+		$args = wp_parse_args( $args, $defaults );
379 379
 
380 380
 		$query = array();
381 381
 		self::get_ids_query( $where, $order_by, $limit, $unique, $args, $query );
@@ -478,7 +478,7 @@  discard block
 block discarded – undo
478 478
 			} elseif ( false !== strpos( $args['is_draft'], ',' ) ) {
479 479
 				$is_draft = array_reduce(
480 480
 					explode( ',', $args['is_draft'] ),
481
-					function ( $total, $current ) {
481
+					function( $total, $current ) {
482 482
 						if ( is_numeric( $current ) ) {
483 483
 							$total[] = absint( $current );
484 484
 						}
Please login to merge, or discard this patch.
classes/models/FrmYoutubeFeedApi.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,6 +40,6 @@
 block discarded – undo
40 40
 	 */
41 41
 	public function get_video( $type = 'welcome' ) {
42 42
 		$videos = $this->get_api_info();
43
-		return $videos[ $type ] ?? array();
43
+		return $videos[$type] ?? array();
44 44
 	}
45 45
 }
Please login to merge, or discard this patch.
classes/models/FrmEntry.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -56,8 +56,8 @@  discard block
 block discarded – undo
56 56
 	 * @return void
57 57
 	 */
58 58
 	private static function flag_new_unique_key( $unique_id ) {
59
-		if ( ! isset( self::$unique_id_match_checks[ $unique_id ] ) ) {
60
-			self::$unique_id_match_checks[ $unique_id ] = false;
59
+		if ( ! isset( self::$unique_id_match_checks[$unique_id] ) ) {
60
+			self::$unique_id_match_checks[$unique_id] = false;
61 61
 		}
62 62
 	}
63 63
 
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 				if ( 0 === (int) $meta->field_id ) {
110 110
 					continue;
111 111
 				}
112
-				$field_metas[ $meta->field_id ] = $meta->meta_value;
112
+				$field_metas[$meta->field_id] = $meta->meta_value;
113 113
 			}
114 114
 
115 115
 			$filtered_vals = array_filter( $values['item_meta'] );
@@ -174,8 +174,8 @@  discard block
 block discarded – undo
174 174
 			return false;
175 175
 		}
176 176
 
177
-		if ( isset( self::$unique_id_match_checks[ $unique_id ] ) ) {
178
-			return self::$unique_id_match_checks[ $unique_id ];
177
+		if ( isset( self::$unique_id_match_checks[$unique_id] ) ) {
178
+			return self::$unique_id_match_checks[$unique_id];
179 179
 		}
180 180
 
181 181
 		$timestamp = strtotime( $created_at );
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 			$timestamp = time();
184 184
 		}
185 185
 
186
-		self::$unique_id_match_checks[ $unique_id ] = (bool) FrmDb::get_var(
186
+		self::$unique_id_match_checks[$unique_id] = (bool) FrmDb::get_var(
187 187
 			'frm_item_metas',
188 188
 			array(
189 189
 				'field_id'     => 0,
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 			'id'
194 194
 		);
195 195
 
196
-		return self::$unique_id_match_checks[ $unique_id ];
196
+		return self::$unique_id_match_checks[$unique_id];
197 197
 	}
198 198
 
199 199
 	/**
@@ -223,10 +223,10 @@  discard block
 block discarded – undo
223 223
 		$reduced = array();
224 224
 		foreach ( $filter_vals as $field_id => $value ) {
225 225
 			$field                = FrmFieldFactory::get_field_object( $field_id );
226
-			$reduced[ $field_id ] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
227
-			$reduced[ $field_id ] = $field->set_value_before_save( $reduced[ $field_id ] );
228
-			if ( '' === $reduced[ $field_id ] || ( is_array( $reduced[ $field_id ] ) && 0 === count( $reduced[ $field_id ] ) ) ) {
229
-				unset( $reduced[ $field_id ] );
226
+			$reduced[$field_id] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) );
227
+			$reduced[$field_id] = $field->set_value_before_save( $reduced[$field_id] );
228
+			if ( '' === $reduced[$field_id] || ( is_array( $reduced[$field_id] ) && 0 === count( $reduced[$field_id] ) ) ) {
229
+				unset( $reduced[$field_id] );
230 230
 			}
231 231
 		}
232 232
 		return $reduced;
@@ -489,7 +489,7 @@  discard block
 block discarded – undo
489 489
 	private static function prepare_entries( &$entries ) {
490 490
 		foreach ( $entries as $k => $entry ) {
491 491
 			self::prepare_entry( $entry );
492
-			$entries[ $k ] = $entry;
492
+			$entries[$k] = $entry;
493 493
 		}
494 494
 	}
495 495
 
@@ -515,19 +515,19 @@  discard block
 block discarded – undo
515 515
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
516 516
 
517 517
 			if ( $meta_val->item_id == $entry->id ) {
518
-				$entry->metas[ $meta_val->field_id ] = $meta_val->meta_value;
518
+				$entry->metas[$meta_val->field_id] = $meta_val->meta_value;
519 519
 				if ( $include_key ) {
520
-					$entry->metas[ $meta_val->field_key ] = $entry->metas[ $meta_val->field_id ];
520
+					$entry->metas[$meta_val->field_key] = $entry->metas[$meta_val->field_id];
521 521
 				}
522 522
 				continue;
523 523
 			}
524 524
 
525 525
 			// include sub entries in an array
526
-			if ( ! isset( $entry->metas[ $meta_val->field_id ] ) ) {
527
-				$entry->metas[ $meta_val->field_id ] = array();
526
+			if ( ! isset( $entry->metas[$meta_val->field_id] ) ) {
527
+				$entry->metas[$meta_val->field_id] = array();
528 528
 			}
529 529
 
530
-			$entry->metas[ $meta_val->field_id ][] = $meta_val->meta_value;
530
+			$entry->metas[$meta_val->field_id][] = $meta_val->meta_value;
531 531
 
532 532
 			unset( $meta_val );
533 533
 		}
@@ -622,16 +622,16 @@  discard block
 block discarded – undo
622 622
 		}
623 623
 
624 624
 		foreach ( $metas as $m_key => $meta_val ) {
625
-			if ( ! isset( $entries[ $meta_val->item_id ] ) ) {
625
+			if ( ! isset( $entries[$meta_val->item_id] ) ) {
626 626
 				continue;
627 627
 			}
628 628
 
629
-			if ( ! isset( $entries[ $meta_val->item_id ]->metas ) ) {
630
-				$entries[ $meta_val->item_id ]->metas = array();
629
+			if ( ! isset( $entries[$meta_val->item_id]->metas ) ) {
630
+				$entries[$meta_val->item_id]->metas = array();
631 631
 			}
632 632
 
633 633
 			FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type );
634
-			$entries[ $meta_val->item_id ]->metas[ $meta_val->field_id ] = $meta_val->meta_value;
634
+			$entries[$meta_val->item_id]->metas[$meta_val->field_id] = $meta_val->meta_value;
635 635
 			unset( $m_key, $meta_val );
636 636
 		}
637 637
 
@@ -814,7 +814,7 @@  discard block
 block discarded – undo
814 814
 	}
815 815
 
816 816
 	private static function get_entry_value( $values, $name, $default ) {
817
-		return $values[ $name ] ?? $default;
817
+		return $values[$name] ?? $default;
818 818
 	}
819 819
 
820 820
 	/**
@@ -1021,7 +1021,7 @@  discard block
 block discarded – undo
1021 1021
 	private static function maybe_add_captcha_meta( $form_id, $entry_id ) {
1022 1022
 		global $frm_vars;
1023 1023
 		if ( array_key_exists( 'captcha_scores', $frm_vars ) && array_key_exists( $form_id, $frm_vars['captcha_scores'] ) ) {
1024
-			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][ $form_id ] );
1024
+			$captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][$form_id] );
1025 1025
 			FrmEntryMeta::add_entry_meta( $entry_id, 0, '', maybe_serialize( $captcha_score_meta ) );
1026 1026
 		}
1027 1027
 	}
Please login to merge, or discard this patch.
classes/models/FrmForm.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
 			}
210 210
 
211 211
 			if ( $new_val !== $value ) {
212
-				$new_values[ $key ] = $new_val;
212
+				$new_values[$key] = $new_val;
213 213
 			}
214 214
 		}//end foreach
215 215
 
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
 
241 241
 		foreach ( $values as $value_key => $value ) {
242 242
 			if ( $value_key && in_array( $value_key, $form_fields ) ) {
243
-				$new_values[ $value_key ] = $value;
243
+				$new_values[$value_key] = $value;
244 244
 			}
245 245
 		}
246 246
 
@@ -323,15 +323,15 @@  discard block
 block discarded – undo
323 323
 		$existing_keys = array_keys( $values['item_meta'] );
324 324
 		foreach ( $all_fields as $fid ) {
325 325
 			if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
326
-				$values['item_meta'][ $fid->id ] = '';
326
+				$values['item_meta'][$fid->id] = '';
327 327
 			}
328
-			$field_array[ $fid->id ] = $fid;
328
+			$field_array[$fid->id] = $fid;
329 329
 		}
330 330
 		unset( $all_fields );
331 331
 
332 332
 		foreach ( $values['item_meta'] as $field_id => $default_value ) {
333
-			if ( isset( $field_array[ $field_id ] ) ) {
334
-				$field = $field_array[ $field_id ];
333
+			if ( isset( $field_array[$field_id] ) ) {
334
+				$field = $field_array[$field_id];
335 335
 			} else {
336 336
 				$field = FrmField::getOne( $field_id );
337 337
 			}
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 				continue;
341 341
 			}
342 342
 
343
-			$is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
343
+			$is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options']['custom_html_' . $field_id] ) );
344 344
 			if ( $is_settings_page ) {
345 345
 				self::get_settings_page_html( $values, $field );
346 346
 
@@ -356,22 +356,22 @@  discard block
 block discarded – undo
356 356
 			$update_options = apply_filters( 'frm_field_options_to_update', $update_options );
357 357
 
358 358
 			foreach ( $update_options as $opt => $default ) {
359
-				$field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default;
360
-				self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
359
+				$field->field_options[$opt] = $values['field_options'][$opt . '_' . $field_id] ?? $default;
360
+				self::sanitize_field_opt( $opt, $field->field_options[$opt] );
361 361
 			}
362 362
 
363 363
 			$field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
364 364
 
365 365
 			$new_field = array(
366 366
 				'field_options' => $field->field_options,
367
-				'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
367
+				'default_value' => isset( $values['default_value_' . $field_id] ) ? FrmAppHelper::maybe_json_encode( $values['default_value_' . $field_id] ) : '',
368 368
 			);
369 369
 
370
-			if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) {
371
-				foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
370
+			if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options']['options_' . $field_id] ) && is_array( $values['field_options']['options_' . $field_id] ) ) {
371
+				foreach ( $values['field_options']['options_' . $field_id] as $option_key => $option ) {
372 372
 					if ( is_array( $option ) ) {
373 373
 						foreach ( $option as $key => $item ) {
374
-							$values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
374
+							$values['field_options']['options_' . $field_id][$option_key][$key] = FrmAppHelper::kses( $item, 'all' );
375 375
 						}
376 376
 					}
377 377
 				}
@@ -401,8 +401,8 @@  discard block
 block discarded – undo
401 401
 	 */
402 402
 	private static function maybe_update_max_option( $field, $values, &$new_field ) {
403 403
 		if ( $field->type === 'textarea' &&
404
-			! empty( $values['field_options'][ 'type_' . $field->id ] ) &&
405
-			in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
404
+			! empty( $values['field_options']['type_' . $field->id] ) &&
405
+			in_array( $values['field_options']['type_' . $field->id], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
406 406
 
407 407
 			$new_field['field_options']['max'] = '';
408 408
 
@@ -410,7 +410,7 @@  discard block
 block discarded – undo
410 410
 			 * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
411 411
 			 * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
412 412
 			 */
413
-			$_POST['field_options'][ 'max_' . $field->id ] = '';
413
+			$_POST['field_options']['max_' . $field->id] = '';
414 414
 		}
415 415
 	}
416 416
 
@@ -488,11 +488,11 @@  discard block
 block discarded – undo
488 488
 	 * Updating the settings page
489 489
 	 */
490 490
 	private static function get_settings_page_html( $values, &$field ) {
491
-		if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
491
+		if ( isset( $values['field_options']['custom_html_' . $field->id] ) ) {
492 492
 			$prev_opts     = array();
493 493
 			$fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type );
494 494
 
495
-			$field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html;
495
+			$field->field_options['custom_html'] = $values['field_options']['custom_html_' . $field->id] ?? $fallback_html;
496 496
 		} elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
497 497
 			$prev_opts = $field->field_options;
498 498
 		}
@@ -517,7 +517,7 @@  discard block
 block discarded – undo
517 517
 		);
518 518
 		foreach ( $field_cols as $col => $default ) {
519 519
 			$default           = $default === '' ? $field->{$col} : $default;
520
-			$new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default;
520
+			$new_field[$col] = $values['field_options'][$col . '_' . $field->id] ?? $default;
521 521
 		}
522 522
 
523 523
 		if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
@@ -708,7 +708,7 @@  discard block
 block discarded – undo
708 708
 			if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) {
709 709
 				self::destroy( $form->id );
710 710
 				if ( empty( $form->parent_form_id ) ) {
711
-					++$count;
711
+					++ $count;
712 712
 				}
713 713
 			}
714 714
 
@@ -931,16 +931,16 @@  discard block
 block discarded – undo
931 931
 		foreach ( $results as $row ) {
932 932
 			if ( 'trash' != $row->status ) {
933 933
 				if ( $row->is_template ) {
934
-					++$counts['template'];
934
+					++ $counts['template'];
935 935
 				} else {
936
-					++$counts['published'];
936
+					++ $counts['published'];
937 937
 				}
938 938
 			} else {
939
-				++$counts['trash'];
939
+				++ $counts['trash'];
940 940
 			}
941 941
 
942 942
 			if ( 'draft' == $row->status ) {
943
-				++$counts['draft'];
943
+				++ $counts['draft'];
944 944
 			}
945 945
 
946 946
 			unset( $row );
@@ -981,8 +981,8 @@  discard block
 block discarded – undo
981 981
 			self::maybe_get_form( $form );
982 982
 		}
983 983
 
984
-		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
985
-			return $frm_vars['form_params'][ $form->id ];
984
+		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][$form->id] ) ) {
985
+			return $frm_vars['form_params'][$form->id];
986 986
 		}
987 987
 
988 988
 		$action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -1011,15 +1011,15 @@  discard block
 block discarded – undo
1011 1011
 			// If there are two forms on the same page, make sure not to submit both.
1012 1012
 			foreach ( $default_values as $var => $default ) {
1013 1013
 				if ( $var === 'action' ) {
1014
-					$values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
1014
+					$values[$var] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
1015 1015
 				} else {
1016
-					$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1016
+					$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1017 1017
 				}
1018 1018
 				unset( $var, $default );
1019 1019
 			}
1020 1020
 		} else {
1021 1021
 			foreach ( $default_values as $var => $default ) {
1022
-				$values[ $var ] = $default;
1022
+				$values[$var] = $default;
1023 1023
 				unset( $var, $default );
1024 1024
 			}
1025 1025
 		}
@@ -1045,7 +1045,7 @@  discard block
 block discarded – undo
1045 1045
 			'sdir'     => '',
1046 1046
 		);
1047 1047
 		foreach ( $defaults as $var => $default ) {
1048
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1048
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1049 1049
 		}
1050 1050
 
1051 1051
 		return $values;
@@ -1073,7 +1073,7 @@  discard block
 block discarded – undo
1073 1073
 			'keep_post' => '',
1074 1074
 		);
1075 1075
 		foreach ( $defaults as $var => $default ) {
1076
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1076
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1077 1077
 		}
1078 1078
 
1079 1079
 		return $values;
@@ -1176,7 +1176,7 @@  discard block
 block discarded – undo
1176 1176
 		$form    = $atts['form'];
1177 1177
 		$default = $atts['default'] ?? '';
1178 1178
 
1179
-		return $form->options[ $atts['option'] ] ?? $default;
1179
+		return $form->options[$atts['option']] ?? $default;
1180 1180
 	}
1181 1181
 
1182 1182
 	/**
Please login to merge, or discard this patch.
classes/models/FrmFormState.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 	 * @return void
60 60
 	 */
61 61
 	public function set( $key, $value ) {
62
-		$this->state[ $key ] = $value;
62
+		$this->state[$key] = $value;
63 63
 	}
64 64
 
65 65
 	/**
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	}
76 76
 
77 77
 	public function get( $key, $default ) {
78
-		return $this->state[ $key ] ?? $default;
78
+		return $this->state[$key] ?? $default;
79 79
 	}
80 80
 
81 81
 	/**
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 	private function compressed_state() {
187 187
 		$compressed = array();
188 188
 		foreach ( $this->state as $key => $value ) {
189
-			$compressed[ self::compressed_key( $key ) ] = $value;
189
+			$compressed[self::compressed_key( $key )] = $value;
190 190
 		}
191 191
 		return $compressed;
192 192
 	}
Please login to merge, or discard this patch.