Issues (8)

contracts/Loader/MakesConnections.php (1 issue)

Labels
Severity
1
<?php
2
3
namespace Stratadox\TableLoader\Loader;
4
5
use Stratadox\TableLoader\Loader\ContainsResultingObjects as Result;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Stratadox\TableLoader\Loader\Result. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
6
7
/**
8
 * Loads relationships.
9
 *
10
 * @author Stratadox
11
 */
12
interface MakesConnections
13
{
14
    /**
15
     * Loads a relationship.
16
     *
17
     * @param KnowsWhereToLook $from    Where to map from.
18
     * @param array[]          $data    List of associative rows.
19
     * @param KnowsWhereToLook $to      Where to map to.
20
     * @param Result           $objects List of objects as [label => [id => instance]].
21
     * @return array[]                  Relations as [$property => $relation].
22
     * @throws CannotLoadTable          When the entity could not be identified or hydrated.
23
     */
24
    public function load(
25
        KnowsWhereToLook $from,
26
        array $data,
27
        KnowsWhereToLookTo $to,
28
        Result $objects
29
    ): array;
30
}
31