Stratadox\Specification\Specifying

Complexity

Total Complexity

11

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	orNot()	0	3	1
A	andNot()	0	3	1
A	or()	0	4	1
A	butNot()	0	3	1
A	and()	0	4	1
A	not()	0	4	1
A	nor()	0	3	1
A	oneOfThese()	0	3	1
A	doesNotSatisfy()	0	3	1
A	xor()	0	4	1
A	satisfiesBoth()	0	3	1

<?php

declare(strict_types = 1);

namespace Stratadox\Specification;

use Stratadox\Specification\Binary\AndSpecification;
use Stratadox\Specification\Binary\OrSpecification;
use Stratadox\Specification\Binary\XorSpecification;
use Stratadox\Specification\Contract\Satisfiable;
use Stratadox\Specification\Contract\Specifies;
use Stratadox\Specification\Unary\NotSpecification;

trait Specifying
{
    /** @see Specifies::not() */
    public function not() : Specifies
    {
        /** @var Specifying|Satisfiable $this */
        return $this->doesNotSatisfy($this);

The method doesNotSatisfy() does not exist on Stratadox\Specification\Contract\Satisfiable. It seems like you code against a sub-type of Stratadox\Specification\Contract\Satisfiable such as Stratadox\Specification\Specification or Stratadox\Specification\Binary\BinarySpecification or Stratadox\Specification\Unary\UnarySpecification.

It seems like $this can also be of type Stratadox\Specification\Specifying; however, parameter $condition of Stratadox\Specification\Specifying::doesNotSatisfy() does only seem to accept Stratadox\Specification\Contract\Satisfiable, maybe add an additional type check?

    }

    /** @see Specifies::and() */
    public function and(Satisfiable $other) : Specifies
    {
        /** @var Specifying|Satisfiable $this */
        return $this->satisfiesBoth($this, $other);

The method satisfiesBoth() does not exist on Stratadox\Specification\Contract\Satisfiable. It seems like you code against a sub-type of Stratadox\Specification\Contract\Satisfiable such as Stratadox\Specification\Specification or Stratadox\Specification\Binary\BinarySpecification or Stratadox\Specification\Unary\UnarySpecification.

It seems like $this can also be of type Stratadox\Specification\Specifying; however, parameter $firstCondition of Stratadox\Specification\Specifying::satisfiesBoth() does only seem to accept Stratadox\Specification\Contract\Satisfiable, maybe add an additional type check?

    }

    /** @see Specifies::or() */
    public function or(Satisfiable $other) : Specifies
    {
        /** @var Specifying|Satisfiable $this */
        return $this->oneOfThese($this, $other);

The method oneOfThese() does not exist on Stratadox\Specification\Contract\Satisfiable. It seems like you code against a sub-type of Stratadox\Specification\Contract\Satisfiable such as Stratadox\Specification\Specification or Stratadox\Specification\Binary\BinarySpecification or Stratadox\Specification\Unary\UnarySpecification.

It seems like $this can also be of type Stratadox\Specification\Specifying; however, parameter $firstCondition of Stratadox\Specification\Specifying::oneOfThese() does only seem to accept Stratadox\Specification\Contract\Satisfiable, maybe add an additional type check?

    }

    /** @see Specifies::xor() */
    public function xor(Satisfiable $other) : Specifies
    {
        /** @var Specifying|Satisfiable $this */
        return new XorSpecification($this, $other);

It seems like $this can also be of type Stratadox\Specification\Specifying; however, parameter $leftHandCondition of Stratadox\Specification\Binary\XorSpecification::__construct() does only seem to accept Stratadox\Specification\Contract\Satisfiable, maybe add an additional type check?

    }

    /** @see Specifies::nor() */
    public function nor(Satisfiable $other) : Specifies
    {
        return $this->not()->andNot($other);
    }

    /** @see Specifies::andNot() */
    public function andNot(Satisfiable $other) : Specifies
    {
        return $this->and($this->doesNotSatisfy($other));
    }

    /** @see Specifies::butNot() */
    public function butNot(Satisfiable $other) : Specifies
    {
        return $this->andNot($other);
    }

    /** @see Specifies::orNot() */
    public function orNot(Satisfiable $other) : Specifies
    {
        return $this->or($this->doesNotSatisfy($other));
    }


    // Private


    private function doesNotSatisfy(Satisfiable $condition) : Specifies
    {
        return new NotSpecification($condition);
    }

    private function satisfiesBoth(Satisfiable $firstCondition, Satisfiable $secondCondition) : Specifies
    {
        return new AndSpecification($firstCondition, $secondCondition);
    }

    private function oneOfThese(Satisfiable $firstCondition, Satisfiable $secondCondition) : Specifies
    {
        return new OrSpecification($firstCondition, $secondCondition);
    }
}