Altering::change() - Code Metrics - Stratadox/ImmutableCollection - Measure and Improve Code Quality continuously with Scrutinizer

Altering::change() A
last analyzed 2018-06-29 09:28 UTC

↳ Parent: Altering

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	2
dl	0
loc	5
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Stratadox\ImmutableCollection;

use Stratadox\Collection\Alterable;
use Stratadox\Collection\Collection;

/**
 * Behaviour to allow "altering" the immutable collection.
 *
 * Provides access to update and delete behaviour in the form of methods that
 * return a modified copy of the original (immutable) collection.
 *
 * @package Stratadox\Collection
 * @author  Stratadox
 */
trait Altering
{
    /**
     * @see Alterable::change()
     * @param int   $index
     * @param mixed $newItem
     * @return static
     */
    public function change(int $index, $newItem)
    {
        $items = $this->items();
        $items[$index] = $newItem;
        return $this->newCopy($items);

    }

    /** @see Collection::items() */
    abstract public function items(): array;

    /**
     * @see ImmutableCollection::newCopy()
     * @param array $items
     * @return static
     */
    abstract protected function newCopy(array $items): Collection;
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Stratadox\ImmutableCollection;
6
7			use Stratadox\Collection\Alterable;
8			use Stratadox\Collection\Collection;
9
10			/**
11			* Behaviour to allow "altering" the immutable collection.
12			*
13			* Provides access to update and delete behaviour in the form of methods that
14			* return a modified copy of the original (immutable) collection.
15			*
16			* @package Stratadox\Collection
17			* @author Stratadox
18			*/
19			trait Altering
20			{
21			/**
22			* @see Alterable::change()
23			* @param int $index
24			* @param mixed $newItem
25			* @return static
26			*/
27			public function change(int $index, $newItem)
28			{
29			$items = $this->items();
30			$items[$index] = $newItem;
31			return $this->newCopy($items);
			0 ignored issues – show Bug Best Practice introduced 2018-06-29 09:28 UTC by Report Bug Copy Issue Report The expression `return $this->newCopy($items)` returns the type `Stratadox\Collection\Collection` which is incompatible with the documented return type `Stratadox\ImmutableCollection\Altering`. Loading history...
32			}
33
34			/** @see Collection::items() */
35			abstract public function items(): array;
36
37			/**
38			* @see ImmutableCollection::newCopy()
39			* @param array $items
40			* @return static
41			*/
42			abstract protected function newCopy(array $items): Collection;
43			}
44

Stratadox / ImmutableCollection

Altering::change() A last analyzed 2018-06-29 09:28 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Altering::change() A
last analyzed 2018-06-29 09:28 UTC