Stratadox\ImmutableCollection\Differentiating

Complexity

Total Complexity

3

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	differenceBetween()	0	11	3

<?php

declare(strict_types=1);

namespace Stratadox\ImmutableCollection;

use function in_array;
use Stratadox\Collection\Collection;
use Stratadox\Collection\Differentiable;

/**
 * Behaviour to find the difference between multiple collections.
 *
 * Provides access to differentiating behaviour in the form of a method that
 * returns a modified copy of the original (immutable) collection with all
 * values omitted that also appear in one of the other collections.
 *
 * @package Stratadox\Collection
 * @author  Stratadox
 */
trait Differentiating
{
    /**
     * @see Differentiable::differenceBetween()
     * @param Collection[] ...$others
     * @return static
     */
    public function differenceBetween(Collection ...$others)
    {
        return $this->newCopy(array_filter(

The expression return $this->newCopy(array_filter($this->items(), function(...) { /* ... */ })) returns the type Stratadox\Collection\Collection which is incompatible with the documented return type Stratadox\ImmutableCollection\Differentiating.

            $this->items(),
            function ($item) use ($others) : bool {
                foreach ($others as $otherCollection) {
                    if (in_array($item, $otherCollection->items(), false)) {
                        return false;
                    }
                }
                return true;
            }
        ));
    }

    /** @see Collection::items() */
    abstract public function items(): array;

    /**
     * @see ImmutableCollection::newCopy()
     * @param array $items
     * @return static
     */
    abstract protected function newCopy(array $items): Collection;
}