Stratadox\Hydration\Mapping\Property\Relationship\KeyRequiring

Complexity

Total Complexity

2

Size/Duplication

Total Lines	14
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	mustHaveTheKeyInThe()	0	6	2

<?php
declare(strict_types=1);

namespace Stratadox\Hydration\Mapping\Property\Relationship;

use function assert;
use Stratadox\Hydration\Mapping\Property\MissingTheKey;
use Stratadox\HydrationMapping\ExposesDataKey;
use Stratadox\HydrationMapping\UnmappableInput;

trait KeyRequiring
{
    /**
     * Asserts that our key is present in the input array.
     *
     * @param array $data       Input data that must contain our key.
     * @throws UnmappableInput  When the input data does not contain our key.
     */
    private function mustHaveTheKeyInThe(array $data): void
    {
        $mapping = $this;
        assert($mapping instanceof ExposesDataKey);
        if (!isset($data[$mapping->key()])) {

It seems like key() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            throw MissingTheKey::inTheInput($data, $mapping, $mapping->key());

$mapping of type Stratadox\Hydration\Mapping\Property\Relationship\KeyRequiring is incompatible with the type Stratadox\HydrationMapping\MapsProperty expected by parameter $mapping of Stratadox\Hydration\Mapping\Property\MissingTheKey::inTheInput().

        }
    }
}