Stratadox / CardGame

src/ReadModel/Match/OngoingMatches.php

<?php declare(strict_types=1);

namespace Stratadox\CardGame\ReadModel\Match;

use Countable;
use Stratadox\CardGame\Match\MatchId;
use Stratadox\CardGame\Proposal\ProposalId;
use function count;

class OngoingMatches implements Countable
{
    /** @var OngoingMatch[] */
    private $matches = [];

    public function addFromProposal(ProposalId $proposal, OngoingMatch $match): void
    {
        $this->matches[$proposal->id()] = $match;
    }

    /** @throws NoSuchMatch */
    public function forProposal(ProposalId $proposal): OngoingMatch
    {
        if (!isset($this->matches[$proposal->id()])) {
            throw NoSuchMatch::forProposal($proposal);
        }
        return $this->matches[$proposal->id()];
    }

    public function withId(MatchId $id): OngoingMatch
    {
        foreach ($this->matches as $ongoingMatch) {
            if ($id->is($ongoingMatch->id())) {
                return $ongoingMatch;
            }
        }

In this branch, the function will implicitly return null which is incompatible with the type-hinted return Stratadox\CardGame\ReadModel\Match\OngoingMatch. Consider adding a return statement or allowing null as return value.

        // @todo throw
    }

    public function count(): int
    {
        return count($this->matches);
    }
}