Stratadox\CardGame\ReadModel\Refusals

Complexity

Total Complexity

2

Size/Duplication

Total Lines	14
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	addFor()	0	3	1
A	for()	0	4	1

<?php declare(strict_types=1);

Class found in ".php" file; use ".inc" extension instead

This file is missing a doc comment.

The PHP open tag does not have a corresponding PHP close tag

Filename "Refusals.php" doesn't match the expected filename "refusals.php"

The PHP open tag must be followed by exactly one blank line

Expected 1 space before "="; 0 found

Expected 1 space after "="; 0 found

namespace Stratadox\CardGame\ReadModel;

use Stratadox\CardGame\CorrelationId;

final class Refusals

Missing doc comment for class Refusals

Missing class doc comment

{

Opening brace should be on the same line as the declaration for class Refusals

Opening brace should be on the same line as the declaration

    private $errorMessages = [];

Expected 1 blank line(s) before first member var; 0 found

Private member variable "errorMessages" must contain a leading underscore

Missing member variable doc comment

Private member variable "errorMessages" must be prefixed with an underscore

Short array syntax is not allowed

    /** @return string[] */

The open comment tag must be the only content on the line

Missing short description in doc comment

Parameter $theRequest should have a doc-comment as per coding-style.

Description for the @return value is missing

The close comment tag must be the only content on the line

    public function for(CorrelationId $theRequest): array
    {

Opening brace should be on the same line as the declaration

//        return ['Cannot open account for unknown entity'];

84% of this comment could be valid code. Did you maybe forget this after debugging?

Line indented incorrectly; expected at least 8 spaces, found 0

Expected 1 space before comment text but found 8; use block comment if you need indentation

Inline comments must start with a capital letter

Inline comments must end in full-stops, exclamation marks, or question marks

8 spaces found before inline comment; expected "// return ['Cannot open account for unknown entity'];" but found "// return ['Cannot open account for unknown entity'];"

Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses

        return $this->errorMessages[$theRequest->id()] ?? [];

Operation must be bracketed

Short array syntax is not allowed

    }

Expected 1 blank line before closing function brace; 0 found

    public function addFor(CorrelationId $theRequest, string $message): void

Missing doc comment for function addFor()

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        $this->errorMessages[$theRequest->id()][] = $message;
    }

Expected 1 blank line after function; 0 found

Expected 1 blank line before closing function brace; 0 found

}

As per coding style, files should not end with a newline character.