Stratadox\CardGame\Proposal\ProposeMatch

Complexity

Total Complexity

5

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	proposedTo()	0	3	1
A	proposedBy()	0	3	1
A	between()	0	6	1
A	__construct()	0	8	1
A	correlationId()	0	3	1

<?php declare(strict_types=1);

Class found in ".php" file; use ".inc" extension instead

This file is missing a doc comment.

The PHP open tag does not have a corresponding PHP close tag

Filename "ProposeMatch.php" doesn't match the expected filename "proposematch.php"

The PHP open tag must be followed by exactly one blank line

Expected 1 space before "="; 0 found

Expected 1 space after "="; 0 found

namespace Stratadox\CardGame\Proposal;

use Stratadox\CardGame\Account\AccountId;
use Stratadox\CardGame\CorrelationId;

final class ProposeMatch

Missing doc comment for class ProposeMatch

Missing class doc comment

{

Opening brace should be on the same line as the declaration for class ProposeMatch

Opening brace should be on the same line as the declaration

    private $proposedBy;

Expected 1 blank line(s) before first member var; 0 found

Private member variable "proposedBy" must contain a leading underscore

Missing member variable doc comment

Private member variable "proposedBy" must be prefixed with an underscore

    private $proposedTo;

Expected 1 blank line(s) before member var; 0 found

Private member variable "proposedTo" must contain a leading underscore

Missing member variable doc comment

Private member variable "proposedTo" must be prefixed with an underscore

    private $correlationId;

Expected 1 blank line(s) before member var; 0 found

Private member variable "correlationId" must contain a leading underscore

Missing member variable doc comment

Private member variable "correlationId" must be prefixed with an underscore

    private function __construct(

Missing doc comment for function __construct()

Missing function doc comment

        AccountId $proposedBy,
        AccountId $proposedTo,
        CorrelationId $correlationId
    ) {

Opening brace should be on a new line

        $this->proposedBy = $proposedBy;

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $this->proposedTo = $proposedTo;

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $this->correlationId = $correlationId;
    }

Expected 1 blank line before closing function brace; 0 found

    public static function between(

Missing doc comment for function between()

Missing function doc comment

        AccountId $proposedBy,
        AccountId $proposedTo,
        CorrelationId $correlationId
    ): ProposeMatch {

Opening brace should be on a new line

        return new self($proposedBy, $proposedTo, $correlationId);
    }

Expected 1 blank line before closing function brace; 0 found

    public function proposedBy(): AccountId

Missing doc comment for function proposedBy()

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        return $this->proposedBy;
    }

Expected 1 blank line before closing function brace; 0 found

    public function proposedTo(): AccountId

Missing doc comment for function proposedTo()

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        return $this->proposedTo;
    }

Expected 1 blank line before closing function brace; 0 found

    public function correlationId(): CorrelationId

Missing doc comment for function correlationId()

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        return $this->correlationId;
    }

Expected 1 blank line after function; 0 found

Expected 1 blank line before closing function brace; 0 found

}

As per coding style, files should not end with a newline character.