Battlefield::remove() - Code Metrics - Inspection of "Differentiate between cards of different players:" - Stratadox/CardGame - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c23c95...90e58a )

by Jesse

created 2019-10-19 16:51 UTC

Battlefield::remove() A

↳ Parent: Battlefield

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	3
dl	0
loc	6
rs	10
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace Stratadox\CardGame\ReadModel\Match;

use function array_filter;
use function array_merge;
use Stratadox\CardGame\Match\MatchId;

class Battlefield
{
    private $cards = [];

    public function add(Card $card, MatchId $match, int $owner): void
    {
        $this->cards[$match->id()][$owner][] = $card;
    }

    public function remove(Card $cardToRemove, MatchId $match, int $owner): void
    {
        $this->cards[$match->id()][$owner] = array_filter(
            $this->cards[$match->id()][$owner],
            function (Card $card) use ($cardToRemove): bool {
                return !$card->is($cardToRemove);
            }
        );
    }

    /** @return Card[] */
    public function cardsInPlay(MatchId $match): array
    {
        return array_merge(...$this->cards[$match->id()] ?? [[]]);
    }

    /** @return Card[] */
    public function cardsInPlayFor(int $player, MatchId $match): array
    {
        return $this->cards[$match->id()][$player] ?? [];
    }

    /** @return Card[] */
    public function attackers(MatchId $match): array
    {
        return array_filter(
            $this->cardsInPlay($match),
            function (Card $card): bool {
                return $card->isAttacking();
            }
        );
    }
}


1			<?php declare(strict_types=1);
2
3			namespace Stratadox\CardGame\ReadModel\Match;
4
5			use function array_filter;
6			use function array_merge;
7			use Stratadox\CardGame\Match\MatchId;
8
9			class Battlefield
10			{
11			private $cards = [];
12
13			public function add(Card $card, MatchId $match, int $owner): void
14			{
15			$this->cards[$match->id()][$owner][] = $card;
16			}
17
18			public function remove(Card $cardToRemove, MatchId $match, int $owner): void
19			{
20			$this->cards[$match->id()][$owner] = array_filter(
21			$this->cards[$match->id()][$owner],
22			function (Card $card) use ($cardToRemove): bool {
23			return !$card->is($cardToRemove);
24			}
25			);
26			}
27
28			/** @return Card[] */
29			public function cardsInPlay(MatchId $match): array
30			{
31			return array_merge(...$this->cards[$match->id()] ?? [[]]);
32			}
33
34			/** @return Card[] */
35			public function cardsInPlayFor(int $player, MatchId $match): array
36			{
37			return $this->cards[$match->id()][$player] ?? [];
38			}
39
40			/** @return Card[] */
41			public function attackers(MatchId $match): array
42			{
43			return array_filter(
44			$this->cardsInPlay($match),
45			function (Card $card): bool {
46			return $card->isAttacking();
47			}
48			);
49			}
50			}
51

Stratadox / CardGame

Push — master ( c23c95...90e58a )

Battlefield::remove() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like