FlexibleContentBuilder::endFlexibleContent() - Code Metrics - Inspection of "Refactor transformative function calls into a set..." - StoutLogic/acf-builder - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (b26cb2)

by Steve

created 2016-07-15 12:45 UTC

FlexibleContentBuilder::endFlexibleContent() A

↳ Parent: FlexibleContentBuilder

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace StoutLogic\AcfBuilder;

class FlexibleContentBuilder extends Builder
{
    private $config = [];
    private $layouts = [];

    private $name;

    public function __construct($name, $args = [])
    {
        $this->name = $name;
        $this->config = array_merge(
            [
                'key' => $name,
                'name' => $name,
                'label' => $this->generateLabel($name),
                'type' => 'flexible_content',
            ],
            $args
        );

        if (!isset($this->config['button'])) {
            $this->config['button'] = 'Add '.rtrim($this->config['label'], 's');
        }
    }

    public function build()
    {
        return array_merge($this->config, [
            'layouts' => $this->buildLayouts(),
        ]);
    }

    private function buildLayouts()
    {
        return array_map(function($layout) {
            $layout = ($layout instanceof Builder) ? $layout->build() : $layout;
            return $this->transformLayout($layout);
        }, $this->getLayouts());
    }

    private function transformLayout($layout)
    {
        $layoutTransform = new Transform\FlexibleContentLayout($this);
        $namespaceTransform = new Transform\NamespaceFieldKey($this);

        return
            $namespaceTransform->transform(
                $layoutTransform->transform($layout)
            );
    }

    public function getName()
    {
        return $this->name;
    }

    public function addLayout($layout, $args = [])
    {
        if ($layout instanceof Builder) {
            $layout = clone $layout;
        } else {
            $layout = new FieldsBuilder($layout, $args);
        }

        $layout->setGroupConfig('name', $layout->getName());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $layout->setGroupConfig('display', 'block');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        foreach ($args as $key => $value) {
            $layout->setGroupConfig($key, $value);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }

        $layout->setParentContext($this);
        $this->pushLayout($layout);

        return $layout;
    }

    public function endFlexibleContent()
    {
        return $this->getParentContext();
    }

    protected function pushLayout($layout)
    {
        $this->layouts[] = $layout;
    }

    public function getLayouts()
    {
        return $this->layouts;
    }

    protected function generateLabel($name)
    {
        return ucwords(str_replace("_", " ", $name));
    }
}


1			<?php
2
3			namespace StoutLogic\AcfBuilder;
4
5			class FlexibleContentBuilder extends Builder
6			{
7			private $config = [];
8			private $layouts = [];
9
10			private $name;
11
12			public function __construct($name, $args = [])
13			{
14			$this->name = $name;
15			$this->config = array_merge(
16			[
17			'key' => $name,
18			'name' => $name,
19			'label' => $this->generateLabel($name),
20			'type' => 'flexible_content',
21			],
22			$args
23			);
24
25			if (!isset($this->config['button'])) {
26			$this->config['button'] = 'Add '.rtrim($this->config['label'], 's');
27			}
28			}
29
30			public function build()
31			{
32			return array_merge($this->config, [
33			'layouts' => $this->buildLayouts(),
34			]);
35			}
36
37			private function buildLayouts()
38			{
39			return array_map(function($layout) {
40			$layout = ($layout instanceof Builder) ? $layout->build() : $layout;
41			return $this->transformLayout($layout);
42			}, $this->getLayouts());
43			}
44
45			private function transformLayout($layout)
46			{
47			$layoutTransform = new Transform\FlexibleContentLayout($this);
48			$namespaceTransform = new Transform\NamespaceFieldKey($this);
49
50			return
51			$namespaceTransform->transform(
52			$layoutTransform->transform($layout)
53			);
54			}
55
56			public function getName()
57			{
58			return $this->name;
59			}
60
61			public function addLayout($layout, $args = [])
62			{
63			if ($layout instanceof Builder) {
64			$layout = clone $layout;
65			} else {
66			$layout = new FieldsBuilder($layout, $args);
67			}
68
69			$layout->setGroupConfig('name', $layout->getName());
			0 ignored issues – show Documentation Bug introduced 2016-07-15 12:48 UTC by Report Bug Copy Issue Report The method `getName` does not exist on `object<StoutLogic\AcfBuilder\Builder>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() / class SomeClass extends ParentClass { } Loading history... Documentation Bug introduced 2016-07-15 12:48 UTC by Report Bug Copy Issue Report The method `setGroupConfig` does not exist on `object<StoutLogic\AcfBuilder\Builder>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /* * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
70			$layout->setGroupConfig('display', 'block');
			0 ignored issues – show Documentation Bug introduced 2016-07-15 12:48 UTC by Report Bug Copy Issue Report The method `setGroupConfig` does not exist on `object<StoutLogic\AcfBuilder\Builder>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
71
72			foreach ($args as $key => $value) {
73			$layout->setGroupConfig($key, $value);
			0 ignored issues – show Documentation Bug introduced 2016-07-15 12:48 UTC by Report Bug Copy Issue Report The method `setGroupConfig` does not exist on `object<StoutLogic\AcfBuilder\Builder>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
74			}
75
76			$layout->setParentContext($this);
77			$this->pushLayout($layout);
78
79			return $layout;
80			}
81
82			public function endFlexibleContent()
83			{
84			return $this->getParentContext();
85			}
86
87			protected function pushLayout($layout)
88			{
89			$this->layouts[] = $layout;
90			}
91
92			public function getLayouts()
93			{
94			return $this->layouts;
95			}
96
97			protected function generateLabel($name)
98			{
99			return ucwords(str_replace("_", " ", $name));
100			}
101			}
102

StoutLogic / acf-builder

Branch — develop (b26cb2)

FlexibleContentBuilder::endFlexibleContent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like