Zoho\Subscription\Api\Addon

Complexity

Total Complexity

6

Size/Duplication

Total Lines	60
Duplicated Lines	41.67 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	listAddons()	7	24	4
A	getAddon()	18	18	2

<?php
declare(strict_types=1);

namespace Zoho\Subscription\Api;

use Zoho\Subscription\Client\Client;

/**
 * Addon.
 *
 * @author Tristan Perchec <tristan.perchec@yproximite.com>
 * @author Tristan Bessoussa <tristan.bessoussa@gmail.com>
 *
 * @link https://www.zoho.com/subscriptions/api/v1/#addons
 */
class Addon extends Client
{
    /**
     * @param array $filters associative array of filters
     *
     * @throws \Exception
     *
     * @return array
     */
    public function listAddons(array $filters = []): array
    {
        $cacheKey = 'addons';
        $hit = $this->getFromCache($cacheKey);

        if (false === $hit) {
            $response = $this->sendRequest('GET', $cacheKey);

            $addons = $this->processResponse($response);
            $hit = $addons['addons'];

            $this->saveToCache($cacheKey, $hit);
        }

        foreach ($filters as $key => $filter) {

This code seems to be duplicated across your project.

            if (array_key_exists($key, current($hit))) {
                $hit = array_filter($hit, function ($element) use ($key, $filter) {
                    return $element[$key] == $filter;
                });
            }
        }

        return $hit;
    }

    /**
     * @param string $addonCode
     *
     * @throws \Exception
     *
     * @return array
     */
    public function getAddon(string $addonCode): array

This method seems to be duplicated in your project.

    {
        $cacheKey = sprintf('addon_%s', $addonCode);
        $hit = $this->getFromCache($cacheKey);

        if (false === $hit) {
            $response = $this->sendRequest('GET', sprintf('addons/%s', $addonCode));

            $data = $this->processResponse($response);
            $addon = $data['addon'];

            $this->saveToCache($cacheKey, $addon);

            return $addon;
        }

        return $hit;
    }
}