Issues in RevertQuoteInventoryObserver.php (master) - Issues in master - Stockbase-Connect/magento2-module - Measure and Improve Code Quality continuously with Scrutinizer

Issues (52)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Model/Observer/RevertQuoteInventoryObserver.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


namespace Stockbase\Integration\Model\Observer;

use Magento\CatalogInventory\Observer\ProductQty;
use Magento\CatalogInventory\Api\StockManagementInterface;
use Magento\CatalogInventory\Model\Indexer\Stock\Processor as IndexStockProcessor;
use Magento\Catalog\Model\Indexer\Product\Price\Processor as ProductPriceProcessor;
use Magento\Framework\Event\Observer as EventObserver;
use Stockbase\Integration\Model\Inventory\StockbaseStockManagement;

/**
 * Class RevertQuoteInventoryObserver
 */
class RevertQuoteInventoryObserver extends \Magento\CatalogInventory\Observer\RevertQuoteInventoryObserver
{
    /**
     * @var StockbaseStockManagement
     */
    private $stockbaseStockManagement;

    /**
     * RevertQuoteInventoryObserver constructor.
     * @param ProductQty               $productQty
     * @param StockManagementInterface $stockManagement
     * @param IndexStockProcessor      $stockIndexerProcessor
     * @param ProductPriceProcessor    $priceIndexer
     * @param StockbaseStockManagement $stockbaseStockManagement
     */
    public function __construct(
        ProductQty $productQty,
        StockManagementInterface $stockManagement,
        IndexStockProcessor $stockIndexerProcessor,
        ProductPriceProcessor $priceIndexer,
        StockbaseStockManagement $stockbaseStockManagement
    ) {
        parent::__construct($productQty, $stockManagement, $stockIndexerProcessor, $priceIndexer);
        $this->stockbaseStockManagement = $stockbaseStockManagement;
    }

    /**
     * {@inheritdoc}
     */
    public function execute(EventObserver $observer)
    {
        /** @var \Magento\Quote\Model\Quote $quote */
        $quote = $observer->getEvent()->getQuote();

        $items = [];
        foreach ($quote->getAllItems() as $item) {
            $productId = $item->getProductId();
            if (!$productId) {
                continue;
            }
            $children = $item->getChildrenItems() ?: [$item];
            foreach ($children as $childItem) {
                $productId = $childItem->getProductId();
                if (!$productId) {
                    continue;
                }

                $amount = $childItem->getTotalQty();
                $reserve = $this->stockbaseStockManagement->getReserveForQuoteItem($childItem->getId());
                if (!empty($reserve)) {

                    $reserve = reset($reserve);
                    $amount -= $reserve->getAmount();
                    //if ($amount != $reserve->getMagentoStockAmount()) {
                    //    throw new \Exception('Invalid quote inventory revert.'); //TODO: Enable additional checks
                    //}
                    $this->stockbaseStockManagement->releaseReserve($reserve);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                }
                if (!isset($items[$productId])) {
                    $items[$productId] = 0;
                }
                $items[$productId] += $amount;
            }
        }
        
        $this->stockManagement->revertProductsSale($items, $quote->getStore()->getWebsiteId());
        $productIds = array_keys($items);
        if (!empty($productIds)) {
            $this->stockIndexerProcessor->reindexList($productIds);
            $this->priceIndexer->reindexList($productIds);
        }
        // Clear flag, so if order placement retried again with success - it will be processed
        $quote->setInventoryProcessed(false);
    }
}


1			<?php
2
3
4			namespace Stockbase\Integration\Model\Observer;
5
6			use Magento\CatalogInventory\Observer\ProductQty;
7			use Magento\CatalogInventory\Api\StockManagementInterface;
8			use Magento\CatalogInventory\Model\Indexer\Stock\Processor as IndexStockProcessor;
9			use Magento\Catalog\Model\Indexer\Product\Price\Processor as ProductPriceProcessor;
10			use Magento\Framework\Event\Observer as EventObserver;
11			use Stockbase\Integration\Model\Inventory\StockbaseStockManagement;
12
13			/**
14			* Class RevertQuoteInventoryObserver
15			*/
16			class RevertQuoteInventoryObserver extends \Magento\CatalogInventory\Observer\RevertQuoteInventoryObserver
17			{
18			/**
19			* @var StockbaseStockManagement
20			*/
21			private $stockbaseStockManagement;
22
23			/**
24			* RevertQuoteInventoryObserver constructor.
25			* @param ProductQty $productQty
26			* @param StockManagementInterface $stockManagement
27			* @param IndexStockProcessor $stockIndexerProcessor
28			* @param ProductPriceProcessor $priceIndexer
29			* @param StockbaseStockManagement $stockbaseStockManagement
30			*/
31	3		public function __construct(
32			ProductQty $productQty,
33			StockManagementInterface $stockManagement,
34			IndexStockProcessor $stockIndexerProcessor,
35			ProductPriceProcessor $priceIndexer,
36			StockbaseStockManagement $stockbaseStockManagement
37			) {
38	3		parent::__construct($productQty, $stockManagement, $stockIndexerProcessor, $priceIndexer);
39	3		$this->stockbaseStockManagement = $stockbaseStockManagement;
40	3		}
41
42			/**
43			* {@inheritdoc}
44			*/
45	3		public function execute(EventObserver $observer)
46			{
47			/** @var \Magento\Quote\Model\Quote $quote */
48	3		$quote = $observer->getEvent()->getQuote();
49
50	3		$items = [];
51	3		foreach ($quote->getAllItems() as $item) {
52	2		$productId = $item->getProductId();
53	2		if (!$productId) {
54			continue;
55			}
56	2		$children = $item->getChildrenItems() ?: [$item];
57	2		foreach ($children as $childItem) {
58	2		$productId = $childItem->getProductId();
59	2		if (!$productId) {
60			continue;
61			}
62
63	2		$amount = $childItem->getTotalQty();
64	2		$reserve = $this->stockbaseStockManagement->getReserveForQuoteItem($childItem->getId());
65	2	View Code Duplication	if (!empty($reserve)) {
			0 ignored issues – show Duplication introduced 2017-09-21 19:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66	2		$reserve = reset($reserve);
67	2		$amount -= $reserve->getAmount();
68			//if ($amount != $reserve->getMagentoStockAmount()) {
69			// throw new \Exception('Invalid quote inventory revert.'); //TODO: Enable additional checks
70			//}
71	2		$this->stockbaseStockManagement->releaseReserve($reserve);
			0 ignored issues – show Security Bug introduced 2017-09-21 19:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$reserve` defined by `reset($reserve)` on line `66` can also be of type `false`; however, `Stockbase\Integration\Mo...ement::releaseReserve()` does only seem to accept `object<Stockbase\Integra...Model\StockItemReserve>`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
72			}
73	2		if (!isset($items[$productId])) {
74	2		$items[$productId] = 0;
75			}
76	2		$items[$productId] += $amount;
77			}
78			}
79
80	3		$this->stockManagement->revertProductsSale($items, $quote->getStore()->getWebsiteId());
81	3		$productIds = array_keys($items);
82	3		if (!empty($productIds)) {
83	2		$this->stockIndexerProcessor->reindexList($productIds);
84	2		$this->priceIndexer->reindexList($productIds);
85			}
86			// Clear flag, so if order placement retried again with success - it will be processed
87	3		$quote->setInventoryProcessed(false);
88	3		}
89			}
90

Stockbase-Connect / magento2-module

Issues (52)

Security Analysis no request data

Model/Observer/RevertQuoteInventoryObserver.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like