Stockbase\Integration\Model\Observer\CancelOrderItemObserver

Complexity

Total Complexity

7

Size/Duplication

Total Lines	47
Duplicated Lines	17.02 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
B	execute()	8	21	6

<?php


namespace Stockbase\Integration\Model\Observer;

use Magento\Catalog\Model\Indexer\Product\Price\Processor as ProductPriceProcessor;
use Magento\CatalogInventory\Api\StockManagementInterface;
use Magento\Framework\Event\Observer as EventObserver;
use Stockbase\Integration\Model\Inventory\StockbaseStockManagement;

/**
 * Class CancelOrderItemObserver
 */
class CancelOrderItemObserver extends \Magento\CatalogInventory\Observer\CancelOrderItemObserver
{
    /**
     * @var StockbaseStockManagement
     */
    private $stockbaseStockManagement;

    /**
     * @param StockManagementInterface $stockManagement
     * @param ProductPriceProcessor    $priceIndexer
     * @param StockbaseStockManagement $stockbaseStockManagement
     */
    public function __construct(
        StockManagementInterface $stockManagement,
        ProductPriceProcessor $priceIndexer,
        StockbaseStockManagement $stockbaseStockManagement
    ) {
        parent::__construct($stockManagement, $priceIndexer);

        $this->stockbaseStockManagement = $stockbaseStockManagement;
    }

    /**
     * {@inheritdoc}
     */
    public function execute(EventObserver $observer)
    {
        /** @var \Magento\Sales\Model\Order\Item $item */
        $item = $observer->getEvent()->getItem();
        
        $children = $item->getChildrenItems();
        $qty = $item->getQtyOrdered() - max($item->getQtyShipped(), $item->getQtyInvoiced()) - $item->getQtyCanceled();
        if ($item->getId() && $item->getProductId() && empty($children) && $qty) {
            $reserve = $this->stockbaseStockManagement->getReserveForQuoteItem($item->getQuoteItemId());
            if (!empty($reserve)) {

This code seems to be duplicated across your project.

                $reserve = reset($reserve);
                $qty -= $reserve->getAmount();
                //if ($qty != $reserve->getMagentoStockAmount()) {
                //    throw new \Exception('Invalid quote inventory revert.'); //TODO: Enable additional checks
                //}
                $this->stockbaseStockManagement->releaseReserve($reserve);

It seems like $reserve defined by reset($reserve) on line 49 can also be of type false; however, Stockbase\Integration\Model\Inventory\StockbaseStockManagement::releaseReserve() does only seem to accept object<Stockbase\Integration\Model\StockItemReserve>, did you maybe forget to handle an error condition?

            }
            $this->stockManagement->backItemQty($item->getProductId(), $qty, $item->getStore()->getWebsiteId());
        }
        $this->priceIndexer->reindexRow($item->getProductId());
    }
}