Stinger-Soft / PlatformBundle

Entity/User.php

<?php

/*
 * This file is part of the Stinger Soft Platform package.
 *
 * (c) Oliver Kotte <oliver.kotte@stinger-soft.net>
 * (c) Florian Meyer <florian.meyer@stinger-soft.net>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace StingerSoft\PlatformBundle\Entity;

use FOS\UserBundle\Model\User as BaseUser;
use StingerSoft\PlatformBundle\Model\Identifiable;

/**
 *
 * $LastChangedBy: $
 * $LastChangedDate: $
 *
 * Class User
 *
 * @package StingerSoft\PlatformBundle\Entity
 */
class User extends BaseUser implements Identifiable {

	/**
	 *
	 * @var integer
	 */
	protected $id;

	/**
	 *
	 * @var string
	 */
	protected $firstname;

	/**
	 *
	 * @var string
	 */
	protected $surname;

	/**
	 *
	 * @return string
	 */
	public function getFirstname() {
		return $this->firstname;
	}

	/**
	 *
	 * @param string $firstname        	
	 *
	 * @return $this
	 */
	public function setFirstname($firstname) {
		$this->firstname = $firstname;
		
		return $this;
	}

	/**
	 *
	 * @return string
	 */
	public function getSurname() {
		return $this->surname;
	}

	/**
	 *
	 * @param string $surname        	
	 *
	 * @return $this
	 */
	public function setSurname($surname) {
		$this->surname = $surname;
		
		return $this;
	}

	/**
	 * Get realname "Firstname Surname"
	 *
	 * @return string

Should the return type not be string|null?

	 */
	public function getRealName() {
		if($this->firstname || $this->surname) {
			return trim($this->getFirstname() . ' ' . $this->getSurname());
		}
		return null;
	}

	/**
	 *
	 * @return string - "Username" ("Firstname Surname")
	 */
	public function getUsernameAndRealName() {
		return $this->getUsername() . ' (' . $this->getRealName() . ')';
	}

	/**
	 *
	 * @return string "Surname, Firstname"|"Surname"
	 */
	public function getReversedRealName() {
		if($this->getFirstname()) {
			return $this->getSurname() . ', ' . $this->getFirstname();
		} else {
			return $this->getSurname();
		}
	}

	/**
	 *
	 * @return string "Firstname Surname"|"Username"
	 */
	public function __toString() {
		return $this->getRealName() != null ? $this->getRealName() : $this->getUsername();

It seems like you are loosely comparing $this->getRealName() of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

	}
}