Stinger-Soft / PlatformBundle

DataFixtures/AbstractStingerFixture.php

<?php

/*
 * This file is part of the Stinger Soft Platform package.
 *
 * (c) Oliver Kotte <oliver.kotte@stinger-soft.net>
 * (c) Florian Meyer <florian.meyer@stinger-soft.net>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace StingerSoft\PlatformBundle\DataFixtures;

use Doctrine\Common\DataFixtures\AbstractFixture;
use Doctrine\Common\Persistence\ObjectManager;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;
use Symfony\Component\DependencyInjection\ContainerAwareTrait;

abstract class AbstractStingerFixture extends AbstractFixture {
	
	use ContainerAwareTrait;

	/**
	 *
	 * @var ObjectManager
	 */
	protected $manager;

	/**
	 *
	 * @var LoggerInterface
	 */
	private $logger;

	public final function load(ObjectManager $manager) {

As per PSR2, final should precede the visibility keyword.

		$this->manager = $manager;
		if(!$this->skipMe()) {
			$this->getLogger()->info("Starting import of fixtures ...");
			$this->reportMemoryUsage();
			// $startTime = microtime(true);

50% of this comment could be valid code. Did you maybe forget this after debugging?

			$this->import();
			// $endTime = microtime(true);

50% of this comment could be valid code. Did you maybe forget this after debugging?

			// $this->info("Finished importing fixtures in " . $this->formatTime($startTime, $endTime));

65% of this comment could be valid code. Did you maybe forget this after debugging?

			$this->reportMemoryUsage();
		} else {
			$this->getLogger()->info('Skipping import of fixtures !');
		}
	}

	protected final function reportMemoryUsage() {

As per PSR2, final should precede the visibility keyword.

		// $this->getLogger()->info("Currently using %s of RAM", $this->getMemoryUsage());

74% of this comment could be valid code. Did you maybe forget this after debugging?

	}

	/**
	 * Load data fixtures
	 */
	protected abstract function import();

The abstract declaration must precede the visibility declaration

	/**
	 * Decides whether this fixture should be skipped or not.
	 *
	 * @return bool
	 */
	protected function skipMe() {
		return false;
	}

	/**
	 *
	 * @return LoggerInterface|null

Should the return type not be object?

	 */
	protected function getLogger() {
		if(!$this->logger && $this->container && $this->container->has('logger')) {
			$this->logger = $this->container->get('logger');
		} else {
			$this->logger = new NullLogger();
		}
		return $this->logger;
	}
}