SearchControllerTest::getSearchController() - Code Metrics - Inspection of "Merge branch 'release/1.1.0'" - Stinger-Soft/EntitySearchBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bd1580...0ea8fb )

by Florian

created 2019-04-04 13:54 UTC

SearchControllerTest::getSearchController() A

↳ Parent: SearchControllerTest

Complexity

Conditions	3
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	41
rs	9.264
c	0
b	0
f	0
cc	3
nc	1
nop	1

<?php
/**
 * Created by PhpStorm.
 * User: FlorianMeyer
 * Date: 06.03.2019
 * Time: 09:48
 */

namespace StingerSoft\EntitySearchBundle\Tests\Controller;

use Doctrine\Common\Persistence\AbstractManagerRegistry;
use Psr\Container\ContainerInterface;
use StingerSoft\EntitySearchBundle\Controller\SearchController;
use StingerSoft\EntitySearchBundle\Form\FacetType;
use StingerSoft\EntitySearchBundle\Form\QueryType;
use StingerSoft\EntitySearchBundle\Services\Mapping\DocumentToEntityMapper;
use StingerSoft\EntitySearchBundle\Services\SearchService;
use StingerSoft\EntitySearchBundle\Tests\AbstractORMTestCase;
use StingerSoft\EntitySearchBundle\Tests\Fixtures\ORM\Beer;
use Symfony\Component\Form\Extension\HttpFoundation\Type\FormTypeHttpFoundationExtension;
use Symfony\Component\Form\Forms;
use Symfony\Component\Form\ResolvedFormTypeFactory;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\Session\Session;
use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;

class SearchControllerTest extends AbstractORMTestCase {

	/**
	 * @throws \Doctrine\ORM\ORMException
	 * @throws \Doctrine\ORM\OptimisticLockException
	 */
	public function testAutocomplete(): void {
		$request = new Request(['term' => 'He']);
		$searchService = $this->getDummySearchService();

		$controller = $this->getSearchController($searchService);
		$response = $controller->autocompleteAction($request);
		$objResponse = \json_decode($response->getContent(), true);
		$this->assertEmpty($objResponse);

		$this->indexBeer($searchService);
		$response = $controller->autocompleteAction($request);
		$objResponse = \json_decode($response->getContent(), true);
		$this->assertCount(1, $objResponse);
	}

	public function testNewSearch(): void {
		$request = new Request(['term' => 'He']);
		$session = new Session(new MockArraySessionStorage());
		$request->setSession($session);

		$controller = $this->getSearchController();

		$response = $controller->searchAction($request, $this->getDocumentToEntityMapper());
		$this->assertInstanceOf(RedirectResponse::class, $response);
		$this->assertEquals('He', $session->get('stinger_soft_entity_search_term'));
	}

	public function render(): Response {
		return new Response();
	}

	public function testSearch(): void {
		$request = new Request();
		$session = new Session(new MockArraySessionStorage());
		$session->set('stinger_soft_entity_search_term', 'He');
		$request->setSession($session);

		$controller = $this->getSearchController();

		$response = $controller->searchAction($request, $this->getDocumentToEntityMapper());
		$this->assertInstanceOf(Response::class, $response);
		$this->assertEquals(200, $response->getStatusCode());

	}

	protected function getSearchController(?SearchService $searchService = null): SearchController {
		$searchService = $searchService ?? $this->getDummySearchService();

		$controller = $this->getMockBuilder(SearchController::class)->setMethods(array(
			'redirectToRoute',
			'getParameter'
		))->disableOriginalConstructor()->getMock();

		$controller->method('redirectToRoute')->willReturn(new RedirectResponse('https://www.stinger-soft.net'));
		$controller->method('getParameter')->willReturn([]);

		$that = $this;

		$container = $this->getMockBuilder(ContainerInterface::class)->setMethods([
			'get', 'has'
		])->disableOriginalConstructor()->getMockForAbstractClass();
		$container->method('has')->willReturnCallback(function($id) {
			return \in_array($id, ['twig', 'form.factory'], true);
		});
		$container->method('get')->willReturnCallback(function($id) use ($that) {
			if($id === 'form.factory') {
				$resolvedFormTypeFactory = new ResolvedFormTypeFactory();
				$formTypeFactory = Forms::createFormFactoryBuilder()
					->addType(new FacetType())
					->addType(new QueryType())
					->addTypeExtension(new FormTypeHttpFoundationExtension())
					->setResolvedTypeFactory($resolvedFormTypeFactory)
					->getFormFactory();
				return $formTypeFactory;
			}
			if($id === 'twig') {
				return $that;
			}
		});

		$controller->setSearchService($searchService);
		/** @noinspection PhpInternalEntityUsedInspection */
		$controller->setContainer($container);

		return $controller;
	}

	/**
	 * @param SearchService $service
	 * @param string $title
	 * @throws \Doctrine\ORM\ORMException
	 * @throws \Doctrine\ORM\OptimisticLockException
	 */
	protected function indexBeer(SearchService $service, $title = 'Hemelinger'): void {
		$beer = new Beer();
		$beer->setTitle($title);
		$this->em->persist($beer);
		$this->em->flush();

		$document = $service->createEmptyDocumentFromEntity($beer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$beer->indexEntity($document);
		$service->saveDocument($document);
	}

	/**
	 *
	 * @return \StingerSoft\EntitySearchBundle\Services\Mapping\DocumentToEntityMapper
	 */
	protected function getDocumentToEntityMapper(): DocumentToEntityMapper {
		$managerMock = $this->getMockBuilder(AbstractManagerRegistry::class)->setMethods(array(
			'getManagerForClass'
		))->disableOriginalConstructor()->getMockForAbstractClass();
		$managerMock->method('getManagerForClass')->willReturn($this->em);
		return new DocumentToEntityMapper($managerMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}

	/**
	 *
	 * {@inheritDoc}
	 *
	 * @see \StingerSoft\EntitySearchBundle\Tests\AbstractTestCase::getUsedEntityFixtures()
	 */
	protected function getUsedEntityFixtures(): array {
		return array(
			Beer::class,
		);
	}

}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: FlorianMeyer
5			* Date: 06.03.2019
6			* Time: 09:48
7			*/
8
9			namespace StingerSoft\EntitySearchBundle\Tests\Controller;
10
11			use Doctrine\Common\Persistence\AbstractManagerRegistry;
12			use Psr\Container\ContainerInterface;
13			use StingerSoft\EntitySearchBundle\Controller\SearchController;
14			use StingerSoft\EntitySearchBundle\Form\FacetType;
15			use StingerSoft\EntitySearchBundle\Form\QueryType;
16			use StingerSoft\EntitySearchBundle\Services\Mapping\DocumentToEntityMapper;
17			use StingerSoft\EntitySearchBundle\Services\SearchService;
18			use StingerSoft\EntitySearchBundle\Tests\AbstractORMTestCase;
19			use StingerSoft\EntitySearchBundle\Tests\Fixtures\ORM\Beer;
20			use Symfony\Component\Form\Extension\HttpFoundation\Type\FormTypeHttpFoundationExtension;
21			use Symfony\Component\Form\Forms;
22			use Symfony\Component\Form\ResolvedFormTypeFactory;
23			use Symfony\Component\HttpFoundation\RedirectResponse;
24			use Symfony\Component\HttpFoundation\Request;
25			use Symfony\Component\HttpFoundation\Response;
26			use Symfony\Component\HttpFoundation\Session\Session;
27			use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;
28
29			class SearchControllerTest extends AbstractORMTestCase {
30
31			/**
32			* @throws \Doctrine\ORM\ORMException
33			* @throws \Doctrine\ORM\OptimisticLockException
34			*/
35			public function testAutocomplete(): void {
36			$request = new Request(['term' => 'He']);
37			$searchService = $this->getDummySearchService();
38
39			$controller = $this->getSearchController($searchService);
40			$response = $controller->autocompleteAction($request);
41			$objResponse = \json_decode($response->getContent(), true);
42			$this->assertEmpty($objResponse);
43
44			$this->indexBeer($searchService);
45			$response = $controller->autocompleteAction($request);
46			$objResponse = \json_decode($response->getContent(), true);
47			$this->assertCount(1, $objResponse);
48			}
49
50			public function testNewSearch(): void {
51			$request = new Request(['term' => 'He']);
52			$session = new Session(new MockArraySessionStorage());
53			$request->setSession($session);
54
55			$controller = $this->getSearchController();
56
57			$response = $controller->searchAction($request, $this->getDocumentToEntityMapper());
58			$this->assertInstanceOf(RedirectResponse::class, $response);
59			$this->assertEquals('He', $session->get('stinger_soft_entity_search_term'));
60			}
61
62			public function render(): Response {
63			return new Response();
64			}
65
66			public function testSearch(): void {
67			$request = new Request();
68			$session = new Session(new MockArraySessionStorage());
69			$session->set('stinger_soft_entity_search_term', 'He');
70			$request->setSession($session);
71
72			$controller = $this->getSearchController();
73
74			$response = $controller->searchAction($request, $this->getDocumentToEntityMapper());
75			$this->assertInstanceOf(Response::class, $response);
76			$this->assertEquals(200, $response->getStatusCode());
77
78			}
79
80			protected function getSearchController(?SearchService $searchService = null): SearchController {
81			$searchService = $searchService ?? $this->getDummySearchService();
82
83			$controller = $this->getMockBuilder(SearchController::class)->setMethods(array(
84			'redirectToRoute',
85			'getParameter'
86			))->disableOriginalConstructor()->getMock();
87
88			$controller->method('redirectToRoute')->willReturn(new RedirectResponse('https://www.stinger-soft.net'));
89			$controller->method('getParameter')->willReturn([]);
90
91			$that = $this;
92
93			$container = $this->getMockBuilder(ContainerInterface::class)->setMethods([
94			'get', 'has'
95			])->disableOriginalConstructor()->getMockForAbstractClass();
96			$container->method('has')->willReturnCallback(function($id) {
97			return \in_array($id, ['twig', 'form.factory'], true);
98			});
99			$container->method('get')->willReturnCallback(function($id) use ($that) {
100			if($id === 'form.factory') {
101			$resolvedFormTypeFactory = new ResolvedFormTypeFactory();
102			$formTypeFactory = Forms::createFormFactoryBuilder()
103			->addType(new FacetType())
104			->addType(new QueryType())
105			->addTypeExtension(new FormTypeHttpFoundationExtension())
106			->setResolvedTypeFactory($resolvedFormTypeFactory)
107			->getFormFactory();
108			return $formTypeFactory;
109			}
110			if($id === 'twig') {
111			return $that;
112			}
113			});
114
115			$controller->setSearchService($searchService);
116			/** @noinspection PhpInternalEntityUsedInspection */
117			$controller->setContainer($container);
118
119			return $controller;
120			}
121
122			/**
123			* @param SearchService $service
124			* @param string $title
125			* @throws \Doctrine\ORM\ORMException
126			* @throws \Doctrine\ORM\OptimisticLockException
127			*/
128			protected function indexBeer(SearchService $service, $title = 'Hemelinger'): void {
129			$beer = new Beer();
130			$beer->setTitle($title);
131			$this->em->persist($beer);
132			$this->em->flush();
133
134			$document = $service->createEmptyDocumentFromEntity($beer);
			0 ignored issues – show Documentation introduced 2019-04-04 14:04 UTC by Report Bug Copy Issue Report `$beer` is of type `object<StingerSoft\Entit...ests\Fixtures\ORM\Beer>`, but the function expects a `object<StingerSoft\Entit...Bundle\Services\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
135			$beer->indexEntity($document);
136			$service->saveDocument($document);
137			}
138
139			/**
140			*
141			* @return \StingerSoft\EntitySearchBundle\Services\Mapping\DocumentToEntityMapper
142			*/
143			protected function getDocumentToEntityMapper(): DocumentToEntityMapper {
144			$managerMock = $this->getMockBuilder(AbstractManagerRegistry::class)->setMethods(array(
145			'getManagerForClass'
146			))->disableOriginalConstructor()->getMockForAbstractClass();
147			$managerMock->method('getManagerForClass')->willReturn($this->em);
148			return new DocumentToEntityMapper($managerMock);
			0 ignored issues – show Documentation introduced 2019-04-04 14:04 UTC by Report Bug Copy Issue Report `$managerMock` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Doctrine\Common\P...stence\ManagerRegistry>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
149			}
150
151			/**
152			*
153			* {@inheritDoc}
154			*
155			* @see \StingerSoft\EntitySearchBundle\Tests\AbstractTestCase::getUsedEntityFixtures()
156			*/
157			protected function getUsedEntityFixtures(): array {
158			return array(
159			Beer::class,
160			);
161			}
162
163			}

Stinger-Soft / EntitySearchBundle

GitHub Access Token became invalid

Push — master ( bd1580...0ea8fb )

SearchControllerTest::getSearchController() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like