Stinger-Soft / EntitySearchBundle

Tests/Form/QueryTypeTest.php

Spacing +1 added lines, -1 removed lines

@@ -116,7 +116,7 @@
 		$view = $form->createView();
 		$children = $view->children;
 		
-		foreach(array_keys($formData) as $key) {
+		foreach (array_keys($formData) as $key) {
 			$this->assertArrayHasKey($key, $children);
 		}
 		

Tests/AbstractORMTestCase.php

Spacing +4 added lines, -4 removed lines

@@ -44,7 +44,7 @@ 
 		);
 		$config = null === $config ? $this->getMockAnnotatedConfig() : $config;
 		$em = EntityManager::create($conn, $config, $evm ?: $this->getEventManager());
-		$schema = array_map(function ($class) use ($em) {
+		$schema = array_map(function($class) use ($em) {
 			return $em->getClassMetadata($class);
 		}, (array)$this->getUsedEntityFixtures());
 		$schemaTool = new SchemaTool($em);
@@ -69,13 +69,13 @@ 
 		$refl = new \ReflectionClass($configurationClass);
 		$methods = $refl->getMethods();
 		$mockMethods = array();
-		foreach($methods as $method) {
-			if($method->name !== 'addFilter' && $method->name !== 'getFilterClassName') {
+		foreach ($methods as $method) {
+			if ($method->name !== 'addFilter' && $method->name !== 'getFilterClassName') {
 				$mockMethods[] = $method->name;
 			}
 		}
 		$config = $this->getMockBuilder($configurationClass)->setMethods($mockMethods)->getMock();
-		$config->expects($this->once())->method('getProxyDir')->will($this->returnValue(__DIR__ . '/../../temp'));
+		$config->expects($this->once())->method('getProxyDir')->will($this->returnValue(__DIR__.'/../../temp'));
 		$config->expects($this->once())->method('getProxyNamespace')->will($this->returnValue('Proxy'));
 		$config->expects($this->any())->method('getDefaultQueryHints')->will($this->returnValue(array()));
 		$config->expects($this->once())->method('getAutoGenerateProxyClasses')->will($this->returnValue(true));

Tests/application.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 // application.php
-require __DIR__ . '/../vendor/autoload.php';
+require __DIR__.'/../vendor/autoload.php';
 
 use StingerSoft\EntitySearchBundle\Command\ClearIndexCommand;
 use StingerSoft\EntitySearchBundle\Command\SyncCommand;

Command/SyncCommand.php

Unused Use Statements -2 removed lines

@@ -13,13 +13,11 @@
 
 namespace StingerSoft\EntitySearchBundle\Command;
 
-use Doctrine\Common\Persistence\ObjectManager;
 use Doctrine\DBAL\Platforms\SQLServerPlatform;
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use StingerSoft\EntitySearchBundle\Services\Mapping\EntityToDocumentMapperInterface;
 use StingerSoft\EntitySearchBundle\Services\SearchService;
-use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\ProgressBar;
 use Symfony\Component\Console\Input\InputArgument;

Spacing +16 added lines, -16 removed lines

@@ -60,13 +60,13 @@ 
 		$this->searchService = $searchService;
 		$this->entityToDocumentMapper = $mapper;
 		// Detect upload path
-		if(!self::$defaultUploadPath) {
-			if(Kernel::VERSION_ID < 40200) {
+		if (!self::$defaultUploadPath) {
+			if (Kernel::VERSION_ID < 40200) {
 				$root = $kernel->getRootDir();
 			} else {
 				$root = $kernel->getProjectDir();
 			}
-			self::$defaultUploadPath = $root . '/../web/uploads';
+			self::$defaultUploadPath = $root.'/../web/uploads';
 		}
 	}
 
@@ -102,7 +102,7 @@ 
 		// Get the entity argument
 		$entity = $input->getArgument('entity');
 
-		if($entity === 'all') {
+		if ($entity === 'all') {
 			/**
 			 * @var EntityManager $entityManager
 			 */
@@ -113,12 +113,12 @@ 
 			/**
 			 * @var ClassMetadata $m
 			 */
-			foreach($meta as $m) {
+			foreach ($meta as $m) {
 
-				if($m->getReflectionClass()->isAbstract() || $m->getReflectionClass()->isInterface()) {
+				if ($m->getReflectionClass()->isAbstract() || $m->getReflectionClass()->isInterface()) {
 					continue;
 				}
-				if(!$this->entityToDocumentMapper->isClassIndexable($m->getReflectionClass()->getName())) {
+				if (!$this->entityToDocumentMapper->isClassIndexable($m->getReflectionClass()->getName())) {
 					continue;
 				}
 				$this->indexEntity($input, $output, $m->getReflectionClass()->getName());
@@ -150,7 +150,7 @@ 
 		try {
 			// Get repository for the given entity type
 			$repository = $entityManager->getRepository($entity);
-		} catch(\Exception $e) {
+		} catch (\Exception $e) {
 			$output->writeln(sprintf('<error>No repository found for "%s", check your input</error>', $entity));
 			return;
 		}
@@ -162,7 +162,7 @@ 
 
 		$useBatch = !($entityManager->getConnection()->getDatabasePlatform() instanceof SQLServerPlatform);
 		$iterableResult = $useBatch ? $queryBuilder->getQuery()->iterate() : $queryBuilder->getQuery()->getResult();
-		if($entityCount === 0) {
+		if ($entityCount === 0) {
 			$output->writeln('<comment>No entities found for indexing</comment>');
 			return;
 		}
@@ -172,21 +172,21 @@ 
 		$entitiesIndexed = 0;
 
 		// Index each entity separate
-		foreach($iterableResult as $row) {
+		foreach ($iterableResult as $row) {
 			$entity = $useBatch ? $row[0] : $row;
 			$progressBar->advance();
-			if($this->entityToDocumentMapper->isIndexable($entity)) {
+			if ($this->entityToDocumentMapper->isIndexable($entity)) {
 				$document = $this->entityToDocumentMapper->createDocument($entityManager, $entity);
-				if($document === null) {
+				if ($document === null) {
 					continue;
 				}
 				try {
 					$this->searchService->saveDocument($document);
 					$entitiesIndexed++;
-				} catch(\Exception $e) {
-					$output->writeln('<error>Failed to index entity with ID ' . $document->getEntityId() . '</error>');
+				} catch (\Exception $e) {
+					$output->writeln('<error>Failed to index entity with ID '.$document->getEntityId().'</error>');
 				}
-				if($entitiesIndexed % 50 === 0) {
+				if ($entitiesIndexed % 50 === 0) {
 					$entityManager->flush();
 				}
 			}
@@ -196,7 +196,7 @@ 
 		$entityManager->clear();
 		$progressBar->finish();
 		$output->writeln('');
-		$output->writeln('<comment>Indexed ' . $entitiesIndexed . ' entities</comment>');
+		$output->writeln('<comment>Indexed '.$entitiesIndexed.' entities</comment>');
 	}
 
 }
\ No newline at end of file

Controller/SearchControllerTrait.php

Spacing +14 added lines, -14 removed lines

@@ -32,7 +32,7 @@ 
 	private $facetFormatter;
 
 	public function searchAction(Request $request, DocumentToEntityMapperInterface $mapper) {
-		if($request->query->get('term', false) !== false) {
+		if ($request->query->get('term', false) !== false) {
 			$this->setSearchTerm($request->getSession(), $request->query->get('term'));
 			return $this->redirectToRoute('stinger_soft_entity_search_search');
 		}
@@ -48,8 +48,8 @@ 
 		));
 
 		$facetForm->handleRequest($request);
-		if($facetForm->isSubmitted()) {
-			if($facetForm->get('clear')->isClicked()) {
+		if ($facetForm->isSubmitted()) {
+			if ($facetForm->get('clear')->isClicked()) {
 				$query->setFacets($this->getDefaultFacets());
 			}
 			$this->setSearchTerm($request->getSession(), $query->getSearchTerm());
@@ -67,9 +67,9 @@ 
 
 			$page = (int)$request->query->get('page', 1);
 			$results = null;
-			if($result instanceof PaginatableResultSet) {
+			if ($result instanceof PaginatableResultSet) {
 				$results = $result->paginate($page, $this->getResultsPerPage());
-			} elseif($results !== null) {
+			} elseif ($results !== null) {
 				$results = $result->getResults(($page - 1) * $this->getResultsPerPage(), $this->getResultsPerPage());
 			}
 
@@ -80,7 +80,7 @@ 
 				'mapper'    => $mapper,
 				'facetForm' => $facetForm->createView()
 			));
-		} catch(\Exception $exception) {
+		} catch (\Exception $exception) {
 			$response = $this->render($this->getErrorTemplate(), array(
 				'error' => $exception->getMessage(),
 				'term'  => $query->getSearchTerm()
@@ -124,7 +124,7 @@ 
 	protected function getConfiguredUsedFacets(array $queryUsedFacets) {
 		$availableFacets = $this->getAvailableFacets();
 		$usedFacets = array();
-		foreach($queryUsedFacets as $queryUsedFacet) {
+		foreach ($queryUsedFacets as $queryUsedFacet) {
 			$usedFacets[$queryUsedFacet] = $availableFacets[$queryUsedFacet];
 		}
 		return $usedFacets;
@@ -191,15 +191,15 @@ 
 	}
 
 	protected function initFacets() {
-		if(!$this->availableFacets) {
+		if (!$this->availableFacets) {
 			$this->availableFacets = array();
 			$this->facetFormatter = array();
 
 			$facetServices = $this->getParameter('stinger_soft.entity_search.available_facets');
-			foreach($facetServices as $facetServiceId) {
+			foreach ($facetServices as $facetServiceId) {
 				$facetService = $this->searchService->getFacet($facetServiceId);
 				$this->availableFacets[$facetService->getField()] = $facetService->getFormOptions();
-				if($facetService->getFacetFormatter()) {
+				if ($facetService->getFacetFormatter()) {
 					$this->facetFormatter[$facetService->getField()] = $facetService->getFacetFormatter();
 				}
 			}
@@ -213,7 +213,7 @@ 
 	 * @return string[string][]
 	 */
 	protected function getSearchFacets(SessionInterface $session) {
-		$facets = $session->get($this->getSessionPrefix() . '_facets', false);
+		$facets = $session->get($this->getSessionPrefix().'_facets', false);
 		return $facets ? \json_decode($facets, true) : $this->getDefaultFacets();
 	}
 
@@ -224,7 +224,7 @@ 
 	 * @param string[string][] $facets
 	 */
 	protected function setSearchFacets(SessionInterface $session, $facets) {
-		$session->set($this->getSessionPrefix() . '_facets', \json_encode($facets));
+		$session->set($this->getSessionPrefix().'_facets', \json_encode($facets));
 	}
 
 	/**
@@ -234,7 +234,7 @@ 
 	 * @return mixed
 	 */
 	protected function getSearchTerm(SessionInterface $session) {
-		return $session->get($this->getSessionPrefix() . '_term', false);
+		return $session->get($this->getSessionPrefix().'_term', false);
 	}
 
 	/**
@@ -244,7 +244,7 @@ 
 	 * @param string $term
 	 */
 	protected function setSearchTerm(SessionInterface $session, $term) {
-		$session->set($this->getSessionPrefix() . '_term', $term);
+		$session->set($this->getSessionPrefix().'_term', $term);
 	}
 
 }
\ No newline at end of file

Tests/Controller/SearchControllerTest.php

Spacing +2 added lines, -2 removed lines

@@ -97,7 +97,7 @@ 
 			return \in_array($id, ['twig', 'form.factory'], true);
 		});
 		$container->method('get')->willReturnCallback(function($id) use ($that) {
-			if($id === 'form.factory') {
+			if ($id === 'form.factory') {
 				$resolvedFormTypeFactory = new ResolvedFormTypeFactory();
 				$formTypeFactory = Forms::createFormFactoryBuilder()
 					->addType(new FacetType())
@@ -107,7 +107,7 @@ 
 					->getFormFactory();
 				return $formTypeFactory;
 			}
-			if($id === 'twig') {
+			if ($id === 'twig') {
 				return $that;
 			}
 		});

Tests/Model/Result/FacetSetAdapterTest.php

Spacing +3 added lines, -3 removed lines

@@ -16,7 +16,7 @@ 
 
 class FacetSetAdapterTest extends \PHPUnit\Framework\TestCase {
 
-	public function testAddFacetValue(){
+	public function testAddFacetValue() {
 		$facets = new FacetSetAdapter(array());
 		$this->assertCount(0, $facets);
 		$facets->addFacetValue(Document::FIELD_AUTHOR, 'Oliver Kotte');
@@ -26,13 +26,13 @@ 
 		$this->assertCount(1, $facets);
 		$this->assertCount(2, $facets->getFacet(Document::FIELD_AUTHOR));
 		
-		foreach($facets as $facetKey => $facetValues){
+		foreach ($facets as $facetKey => $facetValues) {
 			$this->assertEquals(Document::FIELD_AUTHOR, $facetKey);
 			$this->assertCount(2, $facetValues);
 		}
 	}
 	
-	public function testGetFacet(){
+	public function testGetFacet() {
 		$facets = new FacetSetAdapter(array());
 		$this->assertCount(0, $facets);
 		$this->assertNull($facets->getFacet('NotExisting'));

DependencyInjection/StingerSoftEntitySearchExtension.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
 
 		$container->setParameter('stinger_soft.entity_search.available_facets', $config['facets']);
 
-		$loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
+		$loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
 		$loader->load('services.yml');
 		
 		$entityToDocumentMapperDefinition = $container->getDefinition(EntityToDocumentMapperInterface::class);

DependencyInjection/Compiler/FacetCompilerPass.php

Spacing +3 added lines, -3 removed lines

@@ -16,13 +16,13 @@ 
 	 * @param ContainerBuilder $container
 	 */
 	public function process(ContainerBuilder $container) {
-		if(!$container->hasAlias(SearchService::class)) {
+		if (!$container->hasAlias(SearchService::class)) {
 			return;
 		}
 
 		$serviceId = (string)$container->getAlias(SearchService::class);
 
-		if(!$container->hasDefinition($serviceId)) {
+		if (!$container->hasDefinition($serviceId)) {
 			return;
 		}
 
@@ -30,7 +30,7 @@ 
 
 		$servicesMap = array();
 		// Builds an array with fully-qualified type class names as keys and service IDs as values
-		foreach($container->findTaggedServiceIds(FacetServiceInterface::TAG_NAME, true) as $serviceId => $tag) {
+		foreach ($container->findTaggedServiceIds(FacetServiceInterface::TAG_NAME, true) as $serviceId => $tag) {
 			// Add form type service to the service locator
 			$serviceDefinition = $container->getDefinition($serviceId);
 			$servicesMap[$serviceDefinition->getClass()] = new Reference($serviceId);