Completed
Pull Request — master (#1)
by
unknown
12:30
created
Tests/Form/QueryTypeTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@
 block discarded – undo
116 116
 		$view = $form->createView();
117 117
 		$children = $view->children;
118 118
 		
119
-		foreach(array_keys($formData) as $key) {
119
+		foreach (array_keys($formData) as $key) {
120 120
 			$this->assertArrayHasKey($key, $children);
121 121
 		}
122 122
 		
Please login to merge, or discard this patch.
Tests/AbstractORMTestCase.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 		);
45 45
 		$config = null === $config ? $this->getMockAnnotatedConfig() : $config;
46 46
 		$em = EntityManager::create($conn, $config, $evm ?: $this->getEventManager());
47
-		$schema = array_map(function ($class) use ($em) {
47
+		$schema = array_map(function($class) use ($em) {
48 48
 			return $em->getClassMetadata($class);
49 49
 		}, (array)$this->getUsedEntityFixtures());
50 50
 		$schemaTool = new SchemaTool($em);
@@ -69,13 +69,13 @@  discard block
 block discarded – undo
69 69
 		$refl = new \ReflectionClass($configurationClass);
70 70
 		$methods = $refl->getMethods();
71 71
 		$mockMethods = array();
72
-		foreach($methods as $method) {
73
-			if($method->name !== 'addFilter' && $method->name !== 'getFilterClassName') {
72
+		foreach ($methods as $method) {
73
+			if ($method->name !== 'addFilter' && $method->name !== 'getFilterClassName') {
74 74
 				$mockMethods[] = $method->name;
75 75
 			}
76 76
 		}
77 77
 		$config = $this->getMockBuilder($configurationClass)->setMethods($mockMethods)->getMock();
78
-		$config->expects($this->once())->method('getProxyDir')->will($this->returnValue(__DIR__ . '/../../temp'));
78
+		$config->expects($this->once())->method('getProxyDir')->will($this->returnValue(__DIR__.'/../../temp'));
79 79
 		$config->expects($this->once())->method('getProxyNamespace')->will($this->returnValue('Proxy'));
80 80
 		$config->expects($this->any())->method('getDefaultQueryHints')->will($this->returnValue(array()));
81 81
 		$config->expects($this->once())->method('getAutoGenerateProxyClasses')->will($this->returnValue(true));
Please login to merge, or discard this patch.
Tests/application.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 // application.php
3
-require __DIR__ . '/../vendor/autoload.php';
3
+require __DIR__.'/../vendor/autoload.php';
4 4
 
5 5
 use StingerSoft\EntitySearchBundle\Command\ClearIndexCommand;
6 6
 use StingerSoft\EntitySearchBundle\Command\SyncCommand;
Please login to merge, or discard this patch.
Tests/Controller/SearchControllerTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 			return \in_array($id, ['twig', 'form.factory'], true);
98 98
 		});
99 99
 		$container->method('get')->willReturnCallback(function($id) use ($that) {
100
-			if($id === 'form.factory') {
100
+			if ($id === 'form.factory') {
101 101
 				$resolvedFormTypeFactory = new ResolvedFormTypeFactory();
102 102
 				$formTypeFactory = Forms::createFormFactoryBuilder()
103 103
 					->addType(new FacetType())
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 					->getFormFactory();
108 108
 				return $formTypeFactory;
109 109
 			}
110
-			if($id === 'twig') {
110
+			if ($id === 'twig') {
111 111
 				return $that;
112 112
 			}
113 113
 		});
Please login to merge, or discard this patch.
Tests/Model/Result/FacetSetAdapterTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 
17 17
 class FacetSetAdapterTest extends \PHPUnit\Framework\TestCase {
18 18
 
19
-	public function testAddFacetValue(){
19
+	public function testAddFacetValue() {
20 20
 		$facets = new FacetSetAdapter(array());
21 21
 		$this->assertCount(0, $facets);
22 22
 		$facets->addFacetValue(Document::FIELD_AUTHOR, 'Oliver Kotte');
@@ -26,13 +26,13 @@  discard block
 block discarded – undo
26 26
 		$this->assertCount(1, $facets);
27 27
 		$this->assertCount(2, $facets->getFacet(Document::FIELD_AUTHOR));
28 28
 		
29
-		foreach($facets as $facetKey => $facetValues){
29
+		foreach ($facets as $facetKey => $facetValues) {
30 30
 			$this->assertEquals(Document::FIELD_AUTHOR, $facetKey);
31 31
 			$this->assertCount(2, $facetValues);
32 32
 		}
33 33
 	}
34 34
 	
35
-	public function testGetFacet(){
35
+	public function testGetFacet() {
36 36
 		$facets = new FacetSetAdapter(array());
37 37
 		$this->assertCount(0, $facets);
38 38
 		$this->assertNull($facets->getFacet('NotExisting'));
Please login to merge, or discard this patch.
DependencyInjection/StingerSoftEntitySearchExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
 
38 38
 		$container->setParameter('stinger_soft.entity_search.available_facets', $config['facets']);
39 39
 
40
-		$loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
40
+		$loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
41 41
 		$loader->load('services.yml');
42 42
 		
43 43
 		$entityToDocumentMapperDefinition = $container->getDefinition(EntityToDocumentMapperInterface::class);
Please login to merge, or discard this patch.
DependencyInjection/Compiler/FacetCompilerPass.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -16,13 +16,13 @@  discard block
 block discarded – undo
16 16
 	 * @param ContainerBuilder $container
17 17
 	 */
18 18
 	public function process(ContainerBuilder $container) {
19
-		if(!$container->hasAlias(SearchService::class)) {
19
+		if (!$container->hasAlias(SearchService::class)) {
20 20
 			return;
21 21
 		}
22 22
 
23 23
 		$serviceId = (string)$container->getAlias(SearchService::class);
24 24
 
25
-		if(!$container->hasDefinition($serviceId)) {
25
+		if (!$container->hasDefinition($serviceId)) {
26 26
 			return;
27 27
 		}
28 28
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 
31 31
 		$servicesMap = array();
32 32
 		// Builds an array with fully-qualified type class names as keys and service IDs as values
33
-		foreach($container->findTaggedServiceIds(FacetServiceInterface::TAG_NAME, true) as $serviceId => $tag) {
33
+		foreach ($container->findTaggedServiceIds(FacetServiceInterface::TAG_NAME, true) as $serviceId => $tag) {
34 34
 			// Add form type service to the service locator
35 35
 			$serviceDefinition = $container->getDefinition($serviceId);
36 36
 			$servicesMap[$serviceDefinition->getClass()] = new Reference($serviceId);
Please login to merge, or discard this patch.
Command/SyncCommand.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -60,13 +60,13 @@  discard block
 block discarded – undo
60 60
 		$this->searchService = $searchService;
61 61
 		$this->entityToDocumentMapper = $mapper;
62 62
 		// Detect upload path
63
-		if(!self::$defaultUploadPath) {
64
-			if(Kernel::VERSION_ID < 40200) {
63
+		if (!self::$defaultUploadPath) {
64
+			if (Kernel::VERSION_ID < 40200) {
65 65
 				$root = $kernel->getRootDir();
66 66
 			} else {
67 67
 				$root = $kernel->getProjectDir();
68 68
 			}
69
-			self::$defaultUploadPath = $root . '/../web/uploads';
69
+			self::$defaultUploadPath = $root.'/../web/uploads';
70 70
 		}
71 71
 	}
72 72
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 		// Get the entity argument
103 103
 		$entity = $input->getArgument('entity');
104 104
 
105
-		if($entity === 'all') {
105
+		if ($entity === 'all') {
106 106
 			/**
107 107
 			 * @var EntityManager $entityManager
108 108
 			 */
@@ -113,12 +113,12 @@  discard block
 block discarded – undo
113 113
 			/**
114 114
 			 * @var ClassMetadata $m
115 115
 			 */
116
-			foreach($meta as $m) {
116
+			foreach ($meta as $m) {
117 117
 
118
-				if($m->getReflectionClass()->isAbstract() || $m->getReflectionClass()->isInterface()) {
118
+				if ($m->getReflectionClass()->isAbstract() || $m->getReflectionClass()->isInterface()) {
119 119
 					continue;
120 120
 				}
121
-				if(!$this->entityToDocumentMapper->isClassIndexable($m->getReflectionClass()->getName())) {
121
+				if (!$this->entityToDocumentMapper->isClassIndexable($m->getReflectionClass()->getName())) {
122 122
 					continue;
123 123
 				}
124 124
 				$this->indexEntity($input, $output, $m->getReflectionClass()->getName());
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 		try {
151 151
 			// Get repository for the given entity type
152 152
 			$repository = $entityManager->getRepository($entity);
153
-		} catch(\Exception $e) {
153
+		} catch (\Exception $e) {
154 154
 			$output->writeln(sprintf('<error>No repository found for "%s", check your input</error>', $entity));
155 155
 			return;
156 156
 		}
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 
163 163
 		$useBatch = !($entityManager->getConnection()->getDatabasePlatform() instanceof SQLServerPlatform);
164 164
 		$iterableResult = $useBatch ? $queryBuilder->getQuery()->iterate() : $queryBuilder->getQuery()->getResult();
165
-		if($entityCount === 0) {
165
+		if ($entityCount === 0) {
166 166
 			$output->writeln('<comment>No entities found for indexing</comment>');
167 167
 			return;
168 168
 		}
@@ -172,21 +172,21 @@  discard block
 block discarded – undo
172 172
 		$entitiesIndexed = 0;
173 173
 
174 174
 		// Index each entity separate
175
-		foreach($iterableResult as $row) {
175
+		foreach ($iterableResult as $row) {
176 176
 			$entity = $useBatch ? $row[0] : $row;
177 177
 			$progressBar->advance();
178
-			if($this->entityToDocumentMapper->isIndexable($entity)) {
178
+			if ($this->entityToDocumentMapper->isIndexable($entity)) {
179 179
 				$document = $this->entityToDocumentMapper->createDocument($entityManager, $entity);
180
-				if($document === null) {
180
+				if ($document === null) {
181 181
 					continue;
182 182
 				}
183 183
 				try {
184 184
 					$this->searchService->saveDocument($document);
185 185
 					$entitiesIndexed++;
186
-				} catch(\Exception $e) {
187
-					$output->writeln('<error>Failed to index entity with ID ' . $document->getEntityId() . '</error>');
186
+				} catch (\Exception $e) {
187
+					$output->writeln('<error>Failed to index entity with ID '.$document->getEntityId().'</error>');
188 188
 				}
189
-				if($entitiesIndexed % 50 === 0) {
189
+				if ($entitiesIndexed % 50 === 0) {
190 190
 					$entityManager->flush();
191 191
 				}
192 192
 			}
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 		$entityManager->clear();
197 197
 		$progressBar->finish();
198 198
 		$output->writeln('');
199
-		$output->writeln('<comment>Indexed ' . $entitiesIndexed . ' entities</comment>');
199
+		$output->writeln('<comment>Indexed '.$entitiesIndexed.' entities</comment>');
200 200
 	}
201 201
 
202 202
 }
203 203
\ No newline at end of file
Please login to merge, or discard this patch.
Form/FacetChoiceLoader.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,9 +41,9 @@  discard block
 block discarded – undo
41 41
 	public function loadValuesForChoices(array $choices, $value = null): array {
42 42
 		// is called on form creat with $choices containing the preset of the bound entity
43 43
 		$values = array();
44
-		foreach($choices as $key => $choice) {
44
+		foreach ($choices as $key => $choice) {
45 45
 			// we use a DataTransformer, thus only plain values arrive as choices which can be used directly as value
46
-			if(is_callable($value)) {
46
+			if (is_callable($value)) {
47 47
 				$values[$key] = (string)call_user_func($value, $choice, $key);
48 48
 			} else {
49 49
 				$values[$key] = $choice;
@@ -87,9 +87,9 @@  discard block
 block discarded – undo
87 87
 	public function loadChoicesForValues(array $values, $value = null): array {
88 88
 		// is called on form submit after loadValuesForChoices of form create and loadChoiceList of form view create
89 89
 		$choices = array();
90
-		foreach($values as $key => $val) {
90
+		foreach ($values as $key => $val) {
91 91
 			// we use a DataTransformer, thus only plain values arrive as choices which can be used directly as value
92
-			if(is_callable($value)) {
92
+			if (is_callable($value)) {
93 93
 				$choices[$key] = (string)call_user_func($value, $val, $key);
94 94
 			} else {
95 95
 				$choices[$key] = $val;
Please login to merge, or discard this patch.