XMLForm::loadXML() - Code Metrics - Inspection of "Check for valid DOMElement instance" - Stefanius67/Formgenerator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 97d8d6...d31f66 )

by Stefan

created 2021-05-19 14:03 UTC

XMLForm::loadXML() B

↳ Parent: XMLForm

Complexity

Conditions	10
Paths	16

Size

Total Lines	38
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	26
nc	16
nop	1
dl	0
loc	38
rs	7.6666
c	1
b	0
f	0

How to fix Complexity

<?php
declare(strict_types=1);

namespace SKien\Formgenerator;


/**
 *
 *
 * @package Formgenerator
 * @author Stefanius <[email protected]>
 * @copyright MIT License - see the LICENSE file for details
 */
class XMLForm extends FormGenerator
{
    const E_OK = 0;
    const E_FILE_NOT_EXIST = 1;
    const E_XML_ERROR = 2;
    const E_XSD_ERROR = 3;
    const E_MISSING_ROOT = 4;
    const E_MISSING_FORM = 5;
    const E_UNKNOWN_FORM_ELEMENT = 5;

    const XML_SCHEMA = 'FormGenerator.xsd';

    /** @var string error message     */
    protected string $strErrorMsg = '';
    /** @var bool error message as plain text (\n instead of &lt;br/&gt;) */
    protected bool $bPlainError = false;
    /** @var bool check xml file against the FormGenerator XSD schema */
    protected bool $bSchemaValidate = true;

    /**
     * no constructor - always use the constructor of the parent!
     */

    /**
     * Load form from the given XML file.
     * @param string $strXMLFile
     * @return int
     */
    public function loadXML(string $strXMLFile) : int
    {
        if (!file_exists($strXMLFile)) {
            // if file not exist, there is nothing more to do...
            $this->strErrorMsg = 'Missing form file: ' . $strXMLFile;
            return self::E_FILE_NOT_EXIST;
        }
        // to get more detailed information about XML errors and XML schema validation
        libxml_use_internal_errors(true);
        $iResult = self::E_XML_ERROR;
        $oXMLForm = new \DOMDocument();
        if ($oXMLForm->load($strXMLFile)) {
            $iResult = self::E_OK;

            // the XML schema is allways expected in the same directory as the XML file itself
            $strXSDFile = pathinfo($strXMLFile, PATHINFO_DIRNAME) . DIRECTORY_SEPARATOR . self::XML_SCHEMA;
            $strXSDFile = /** @scrutinizer ignore-type */ pathinfo($strXMLFile, PATHINFO_DIRNAME) . DIRECTORY_SEPARATOR . self::XML_SCHEMA;
            $oRoot = $oXMLForm->documentElement;
            if ($this->bSchemaValidate && !$oXMLForm->schemaValidate($strXSDFile)) {
                $iResult = self::E_XSD_ERROR;
            } elseif ($oRoot->nodeName != 'FormGenerator') {
                $this->strErrorMsg = 'Missing document root &lt;FormGenerator&gt; in form file: ' . $strXMLFile;
                $iResult = self::E_MISSING_ROOT;
            } elseif (($oForm = $this->getXMLChild($oRoot, 'Form')) === null) {
                $this->strErrorMsg = 'Missing form elemnt &lt;Form&gt; as first child of the root: ' . $strXMLFile;
                $iResult = self::E_MISSING_FORM;
            } else {
                // First we read some general infos for the form
                $this->readAdditionalXML($oForm);

                // and iterate recursive through the child elements
                $iResult = $this->createChildElements($oForm, $this);
            }
        }
        if ($iResult != self::E_OK && strlen($this->strErrorMsg) == 0) {
            $this->strErrorMsg = ($iResult != self::E_XSD_ERROR ? 'XML error: ' : 'XSD Schema validation error: ');
            $this->strErrorMsg .= $this->getFormatedXMLError($this->bPlainError);
        }
        libxml_clear_errors();
        return $iResult;
    }

    /**
     * Iterate through all childs of the given parent node and create the according element.
     * This method cals itself recursive for all collection elements.
     * @param \DOMElement $oXMLParent the DOM Element containing the infos for the formelement to create
     * @param FormCollection $oFormParent the parent element in the form
     * @return int
     */
    protected function createChildElements(\DOMElement $oXMLParent, FormCollection $oFormParent) : int
    {
        $iResult = self::E_OK;
        if (!$oXMLParent->hasChildNodes()) {
            return $iResult;
        }
        foreach ($oXMLParent->childNodes as $oXMLChild) {
            if (strtolower($oXMLChild->nodeName) == '#text') {
                continue;
            }
            $strClassname = __NAMESPACE__ . '\Form' . $oXMLChild->nodeName;
            if (class_exists($strClassname) && is_subclass_of($strClassname, __NAMESPACE__ . '\FormElement')) {
                $oFormElement = $strClassname::fromXML($oXMLChild, $oFormParent);
                // recursive call for collection element (div, fieldset, line)
                if ($oFormElement instanceof FormCollection) {
                    $iResult = $this->createChildElements($oXMLChild, $oFormElement);
                }
            } else {
                $this->strErrorMsg = 'Unknown form element: ' . $oXMLChild->nodeName;
                $iResult = self::E_UNKNOWN_FORM_ELEMENT;
            }
            if ($iResult != self::E_OK) {
                break;
            }
        }
        return $iResult;
    }

    /**
     * Get message to error occured.
     * May contain multiple lines in case of any XML formating errors.
     * @return string
     */
    public function getErrorMsg() : string
    {
        return $this->strErrorMsg;
    }

    /**
     * Format error message as plain text (\n instead of <br/> for multiline errors)
     * @param bool $bPlainError
     */
    public function setPlainError(bool $bPlainError) : void
    {
        $this->bPlainError = $bPlainError;
    }

    /**
     * enable/disable the schema validation (default set to true)
     * @param bool $bSchemaValidate
     */
    public function setSchemaValidation(bool $bSchemaValidate) : void
    {
        $this->bSchemaValidate = $bSchemaValidate;
    }
}


Stefanius67 / Formgenerator

Push — main ( 97d8d6...d31f66 )

XMLForm::loadXML() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like