Passed
Pull Request — master (#57)
by Stone
03:27
created
Core/Model.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
             $table = $reflect->getShortName(); //this is to only get the model name, otherwise we get the full namespace
140 140
             //since our models all end with Model, we should remove it.
141 141
             $table = $this->removeFromEnd($table, 'Model');
142
-            $table = $table . 's'; //adding the s since the table should be plural. Might be some special case where the plural isn't just with an s
142
+            $table = $table.'s'; //adding the s since the table should be plural. Might be some special case where the plural isn't just with an s
143 143
             $table = strtolower($table); //the database names are in lowercase
144 144
         }
145 145
 
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
         }
163 163
 
164 164
         //if we are here, then table doesn't exist, check for view
165
-        $view = 'v_' . $table;
165
+        $view = 'v_'.$table;
166 166
         $stmt->bindValue(':table', $view, PDO::PARAM_STR);
167 167
         $stmt->execute();
168 168
         $exists = $stmt->rowCount() > 0; //will return 1 if table exists or 0 if non existant
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
     protected function getTablePrefix($table)
187 187
     {
188 188
         if (Config::TABLE_PREFIX != '') {
189
-            $table = Config::TABLE_PREFIX . '_' . $table;
189
+            $table = Config::TABLE_PREFIX.'_'.$table;
190 190
         }
191 191
         return $table;
192 192
     }
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     protected function getRowById($rowId, $table = null)
256 256
     {
257 257
         $tableName = $this->getTable($table);
258
-        $idName = 'id' . $tableName;
258
+        $idName = 'id'.$tableName;
259 259
         $sql = "SELECT * FROM $tableName WHERE $idName = :rowId";
260 260
         $this->query($sql);
261 261
         $this->bind(':rowId', $rowId);
Please login to merge, or discard this patch.
App/Controllers/Admin/Post.php 2 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -211,10 +211,12 @@
 block discarded – undo
211 211
             $this->alertBox->setAlert("empty slug not allowed", "error");
212 212
         }
213 213
 
214
-        if ($postSlug != $originalPostSlug) //if the slug has been updated
214
+        if ($postSlug != $originalPostSlug) {
215
+            //if the slug has been updated
215 216
         {
216 217
             if (!$this->postModel->isPostSlugUnique($postSlug)) {
217 218
                 $error = true;
219
+        }
218 220
                 $originalPostSlug = $this->postModel->getPostSlugFromId($postId);
219 221
                 $this->alertBox->setAlert("Slug not unique", "error");
220 222
             }
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -166,10 +166,10 @@  discard block
 block discarded – undo
166 166
 
167 167
         //checking result and redirecting
168 168
         if ($postId != null) {
169
-            $this->alertBox->setAlert("Post " . $title . " Created");
170
-            $this->container->getResponse()->redirect("admin/post/modify/" . $postSlug);
169
+            $this->alertBox->setAlert("Post ".$title." Created");
170
+            $this->container->getResponse()->redirect("admin/post/modify/".$postSlug);
171 171
         }
172
-        $this->alertBox->setAlert("Error creating " . $title, "error");
172
+        $this->alertBox->setAlert("Error creating ".$title, "error");
173 173
         $this->container->getResponse()->redirect("admin/post/new");
174 174
 
175 175
     }
@@ -237,11 +237,11 @@  discard block
 block discarded – undo
237 237
 
238 238
         //checking result and redirecting
239 239
         if ($postUpdate) {
240
-            $this->alertBox->setAlert("Post " . $title . " Updated");
241
-            $this->container->getResponse()->redirect("admin/post/modify/" . $postSlug);
240
+            $this->alertBox->setAlert("Post ".$title." Updated");
241
+            $this->container->getResponse()->redirect("admin/post/modify/".$postSlug);
242 242
         }
243
-        $this->alertBox->setAlert("Error updating " . $title, "error");
244
-        $this->container->getResponse()->redirect("admin/post/modify/" . $originalPostSlug);
243
+        $this->alertBox->setAlert("Error updating ".$title, "error");
244
+        $this->container->getResponse()->redirect("admin/post/modify/".$originalPostSlug);
245 245
     }
246 246
 
247 247
 
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
         $removedPost = $this->postModel->deletePost($postId);
259 259
 
260 260
         if ($removedPost) {
261
-            $this->alertBox->setAlert("Post " . $postTitle . " deleted");
261
+            $this->alertBox->setAlert("Post ".$postTitle." deleted");
262 262
         }
263 263
 
264 264
         $this->response->redirect("admin/post/list/");
Please login to merge, or discard this patch.
App/Controllers/Admin/Category.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -103,10 +103,10 @@  discard block
 block discarded – undo
103 103
 
104 104
         //checking result and redirecting
105 105
         if ($categoryUpdate) {
106
-            $this->alertBox->setAlert("Category " . $categoryName . " updated");
106
+            $this->alertBox->setAlert("Category ".$categoryName." updated");
107 107
             $this->container->getResponse()->redirect("/admin/category/list/");
108 108
         }
109
-        $this->alertBox->setAlert("Error updating " . $categoryName, "error");
109
+        $this->alertBox->setAlert("Error updating ".$categoryName, "error");
110 110
         $this->container->getResponse()->redirect("/admin/category/list/");
111 111
     }
112 112
 
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
         $removedCategory = $this->categoryModel->delete($categoryId);
124 124
 
125 125
         if ($removedCategory) {
126
-            $this->alertBox->setAlert("Category " . $categoryName . " deleted");
126
+            $this->alertBox->setAlert("Category ".$categoryName." deleted");
127 127
         }
128 128
 
129 129
         $this->response->redirect("/admin/category/list/");
@@ -168,10 +168,10 @@  discard block
 block discarded – undo
168 168
 
169 169
         //checking result and redirecting
170 170
         if ($categoryNew) {
171
-            $this->alertBox->setAlert("Category " . $categoryName . " created");
171
+            $this->alertBox->setAlert("Category ".$categoryName." created");
172 172
             $this->container->getResponse()->redirect("/admin/category/list/");
173 173
         }
174
-        $this->alertBox->setAlert("Error creating " . $categoryName, "error");
174
+        $this->alertBox->setAlert("Error creating ".$categoryName, "error");
175 175
         $this->container->getResponse()->redirect("/admin/category/list/");
176 176
     }
177 177
 }
178 178
\ No newline at end of file
Please login to merge, or discard this patch.
App/Controllers/Admin/Tag.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -89,10 +89,10 @@  discard block
 block discarded – undo
89 89
 
90 90
         //checking result and redirecting
91 91
         if ($tagUpdate) {
92
-            $this->alertBox->setAlert("Tag " . $tagName . " updated");
92
+            $this->alertBox->setAlert("Tag ".$tagName." updated");
93 93
             $this->response->redirect("/admin/tag/list/");
94 94
         }
95
-        $this->alertBox->setAlert("Error updating " . $tagName, "error");
95
+        $this->alertBox->setAlert("Error updating ".$tagName, "error");
96 96
         $this->response->redirect("/admin/tag/list/");
97 97
     }
98 98
 
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
         $removedTag = $this->tagModel->delete($tagId);
110 110
 
111 111
         if ($removedTag) {
112
-            $this->alertBox->setAlert("Tag " . $tagName . " deleted");
112
+            $this->alertBox->setAlert("Tag ".$tagName." deleted");
113 113
         }
114 114
 
115 115
         $this->response->redirect("/admin/tag/list/");
@@ -145,10 +145,10 @@  discard block
 block discarded – undo
145 145
 
146 146
         //checking result and redirecting
147 147
         if ($tagNew) {
148
-            $this->alertBox->setAlert("Tag " . $tagName . " created");
148
+            $this->alertBox->setAlert("Tag ".$tagName." created");
149 149
             $this->response->redirect("/admin/tag/list/");
150 150
         }
151
-        $this->alertBox->setAlert("Error creating " . $tagName, "error");
151
+        $this->alertBox->setAlert("Error creating ".$tagName, "error");
152 152
         $this->response->redirect("/admin/tag/list/");
153 153
     }
154 154
 }
155 155
\ No newline at end of file
Please login to merge, or discard this patch.
App/Controllers/Ajax/PostVerification.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,9 +36,11 @@
 block discarded – undo
36 36
 
37 37
         $data = $postModel->isPostSlugUnique($postSlug);
38 38
 
39
-        if ($data === false) //slug is not unique, but could be from the same post
39
+        if ($data === false) {
40
+            //slug is not unique, but could be from the same post
40 41
         {
41 42
             $slugOfId = $postModel->getPostSlugFromId($postId);
43
+        }
42 44
             if ($slugOfId === $postSlug) {
43 45
                 //it's the same post, return true
44 46
                 $data = true;
Please login to merge, or discard this patch.
Core/Modules/AlertBox.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
         //make sure we have the right type or throw an error
30 30
 
31 31
         if (!in_array($type, $this->allowedTypes)) {
32
-            throw new \Exception("Invalid toastr alert type " . $type);
32
+            throw new \Exception("Invalid toastr alert type ".$type);
33 33
         }
34 34
 
35 35
         $message = htmlspecialchars($message); //avoid any injection
Please login to merge, or discard this patch.
App/Controllers/Ajax/ImageUpload.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -44,24 +44,24 @@  discard block
 block discarded – undo
44 44
     private function getFilename(string $folder, string $file): string
45 45
     {
46 46
         //slugify the file name to avoid security errors or bugs with special characters.
47
-        $fileName = pathinfo($file, PATHINFO_FILENAME );
48
-        $fileExtension = pathinfo($file, PATHINFO_EXTENSION );
47
+        $fileName = pathinfo($file, PATHINFO_FILENAME);
48
+        $fileExtension = pathinfo($file, PATHINFO_EXTENSION);
49 49
         $slugify = new Slugify();
50 50
         $fileName = $slugify->slugify($fileName);
51 51
         //if the filename has only special chars, the slugify will be empty, create a unique ID
52
-        if($fileName ==="")
52
+        if ($fileName === "")
53 53
         {
54 54
             $fileName = uniqid();
55 55
         }
56 56
         $file = $fileName.".".$fileExtension;
57
-        $fileUrl = $folder . $file;
57
+        $fileUrl = $folder.$file;
58 58
         $docRoot = $this->request->getDocumentRoot();
59
-        $filePath = $docRoot . "/public/" . $fileUrl;
59
+        $filePath = $docRoot."/public/".$fileUrl;
60 60
         if (file_exists($filePath) !== 1) {
61 61
             $fileNum = 0;
62 62
             while (file_exists($filePath)) {
63
-                $fileUrl = $folder . $fileNum . "_" . $file;
64
-                $filePath = $docRoot . "/public/" . $fileUrl;
63
+                $fileUrl = $folder.$fileNum."_".$file;
64
+                $filePath = $docRoot."/public/".$fileUrl;
65 65
                 $fileNum += 1;
66 66
             }
67 67
         }
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
             // Respond to the successful upload with JSON.
87 87
             echo json_encode(array('location' => $filetowrite));
88
-        } else {
88
+        }else {
89 89
             // Notify editor that the upload failed
90 90
             echo json_encode(array('error' => 'Upload failed, file might be too big'));
91 91
 
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 
120 120
             // Respond to the successful upload with JSON.
121 121
             echo json_encode(array('location' => $filetowrite));
122
-        } else {
122
+        }else {
123 123
             // Notify editor that the upload failed
124 124
             header("HTTP/1.1 500 Server Error");
125 125
         }
Please login to merge, or discard this patch.
App/Models/UserModel.php 2 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -204,9 +204,11 @@
 block discarded – undo
204 204
 
205 205
         $user = $this->getUserDetailsByEmail($email);
206 206
 
207
-        if ($user === false) //no user exists
207
+        if ($user === false) {
208
+            //no user exists
208 209
         {
209 210
             $response->message = "email doesn't exist, register a new account?";
211
+        }
210 212
             return $response;
211 213
         }
212 214
 
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
         //check if email is valid for sanity
172 172
         if (!filter_var($email, FILTER_VALIDATE_EMAIL)) {
173 173
             $email = htmlspecialchars($email);
174
-            throw new BlogocException("invalid email " . $email);
174
+            throw new BlogocException("invalid email ".$email);
175 175
         }
176 176
         $sql = $this->baseSqlSelect();
177 177
         $sql .= "
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
         $this->bind(':roles_idroles', 1); //we set to one, should probably get from database and config
215 215
         $this->execute();
216 216
 
217
-        return (int)$this->dbh->lastInsertId();
217
+        return (int) $this->dbh->lastInsertId();
218 218
     }
219 219
 
220 220
     /**
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
      */
225 225
     public function updateUser(\stdClass $user)
226 226
     {
227
-        $sql="
227
+        $sql = "
228 228
             UPDATE $this->userTbl
229 229
             SET
230 230
               name=:name,
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
         }
275 275
 
276 276
         if ($this->isAccountPasswordBlocked($user)) {
277
-            $response->message = "too many bad passwords, account is blocked for " . Constant::LOCKOUT_MINUTES . " minutes";
277
+            $response->message = "too many bad passwords, account is blocked for ".Constant::LOCKOUT_MINUTES." minutes";
278 278
             return $response;
279 279
         }
280 280
 
Please login to merge, or discard this patch.
Core/Container.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -50,10 +50,10 @@  discard block
 block discarded – undo
50 50
         $twigOptions = [];
51 51
         if (!Config::DEV_ENVIRONMENT) {
52 52
             $twigOptions = [
53
-                'cache' => dirname(__DIR__) . '/Cache'
53
+                'cache' => dirname(__DIR__).'/Cache'
54 54
             ];
55 55
         }
56
-        $loader = new \Twig_Loader_Filesystem(dirname(__DIR__) . '/App/Views');
56
+        $loader = new \Twig_Loader_Filesystem(dirname(__DIR__).'/App/Views');
57 57
         $twig = new \Twig_Environment($loader, $twigOptions);
58 58
 
59 59
         return $twig;
@@ -68,13 +68,13 @@  discard block
 block discarded – undo
68 68
         if ($this->dbh) {
69 69
             return $this->dbh;
70 70
         }
71
-        $dsn = "mysql:host=" . Config::DB_HOST . ";dbname=" . Config::DB_NAME . ";charset=utf8"; //Creating the Data Source name
71
+        $dsn = "mysql:host=".Config::DB_HOST.";dbname=".Config::DB_NAME.";charset=utf8"; //Creating the Data Source name
72 72
         $opt = [
73 73
             PDO::ATTR_PERSISTENT => true,
74 74
             PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION,
75 75
             PDO::ATTR_DEFAULT_FETCH_MODE => PDO::FETCH_OBJ
76 76
         ];
77
-        $this->dbh = new PDO($dsn, Config::DB_USER, Config::DB_PASSWORD, $opt);;
77
+        $this->dbh = new PDO($dsn, Config::DB_USER, Config::DB_PASSWORD, $opt); ;
78 78
         return $this->dbh;
79 79
     }
80 80
 
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
      */
121 121
     public function getCookie(): Dependency\Cookie
122 122
     {
123
-        if(!$this->cookie){
123
+        if (!$this->cookie) {
124 124
             $this->cookie = new Cookie();
125 125
         }
126 126
         return $this->cookie;
Please login to merge, or discard this patch.