App\Controllers\Ajax\PostVerification

Complexity

Total Complexity

6

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	isSlugUnique()	0	27	5
A	__construct()	0	4	1

<?php

namespace App\Controllers\Ajax;

use App\Models\PostModel;
use Core\AjaxController;
use Core\Traits\StringFunctions;
use Core\Container;

class PostVerification extends AjaxController
{
    use StringFunctions;

The trait Core\Traits\StringFunctions requires the property $childNodes which is not provided by App\Controllers\Ajax\PostVerification.

    protected $slug;

    public function __construct(Container $container)
    {
        $this->loadModules[] = 'Slug';
        parent::__construct($container);
    }

    /**
     * checks if the slug is unique
     * @return bool is unique
     * @throws \Core\JsonException
     * @throws \Exception
     */
    public function isSlugUnique()
    {
        $this->onlyAdmin();
        $this->onlyPost();

        $postSlug = $this->request->getData("postSlug");
        $postId = $this->request->getData("postId");

        $data = false;
        if (!$this->slug->isSlugValid($postSlug) || !$this->isInt($postId)) {
            echo json_encode($data);
            die();

Using exit here is not recommended.

        }

        $postModel = new PostModel($this->container);

        $data = $postModel->isPostSlugUnique($postSlug);

It seems like $postSlug can also be of type null; however, parameter $postSlug of App\Models\PostModel::isPostSlugUnique() does only seem to accept string, maybe add an additional type check?

        if ($data === false) //slug is not unique, but could be from the same post
        {
            $slugOfId = $postModel->getPostSlugFromId($postId);

It seems like $postId can also be of type null; however, parameter $postId of App\Models\PostModel::getPostSlugFromId() does only seem to accept integer, maybe add an additional type check?

            if ($slugOfId === $postSlug) {
                //it's the same post, return true
                $data = true;
            }
        }
        echo json_encode($data);
    }

}