Home::updateUser() - Code Metrics - Inspection of "Admin user modification." - Starbugstone/blogoc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — Auth ( 474bc2...620889 )

by Stone

created 2018-10-17 12:38 UTC

Home::updateUser() D

↳ Parent: Home

Complexity

Conditions	12
Paths	320

Size

Total Lines	67
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	12
eloc	43
nc	320
nop	0
dl	0
loc	67
rs	4.6333
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace App\Controllers\Admin;


use App\Models\RoleModel;
use App\Models\UserModel;
use Core\Container;
use Core\Traits\PasswordFunctions;
use Core\Traits\StringFunctions;

class Home extends \Core\AdminController
{
    use StringFunctions;

    use PasswordFunctions;
    protected $siteConfig;

    private $userModel;
    private $roleModel;

    public function __construct(Container $container)
    {
        $this->loadModules[] = 'SiteConfig';
        parent::__construct($container);
        $this->userModel = new UserModel($this->container);
        $this->roleModel = new RoleModel($this->container);

        $this->data['configs'] = $this->siteConfig->getSiteConfig();
    }

    /**
     * The front page of the admin section. We display the user info
     * @throws \ReflectionException
     * @throws \Twig_Error_Loader
     * @throws \Twig_Error_Runtime
     * @throws \Twig_Error_Syntax
     */
    public function index()
    {
        $this->onlyUser();

        //check if have prefilled form data and error mesages
        $this->data["registrationInfo"] = $this->session->get("registrationInfo");
        $this->data["registrationErrors"] = $this->session->get("registrationErrors");

        //remove the set data as it is now sent to the template
        $this->session->remove("registrationInfo");
        $this->session->remove("registrationErrors");

        $userId = $this->session->get("userId");
        $this->data["user"] = $this->userModel->getUserDetailsById($userId);

        $this->data["roles"] = $this->roleModel->getRoleList();

        $this->renderView('Admin/Home');
    }

    /**
     * Administrate a user as an admin
     * @param int $userId
     * @throws \ReflectionException
     * @throws \Twig_Error_Loader
     * @throws \Twig_Error_Runtime
     * @throws \Twig_Error_Syntax
     */
    public function viewUser(int $userId)
    {
        $this->onlyAdmin();
        if (!$this->isInt($userId)) {
            throw new \Exception("Error in passed ID");
        }

        //check if have prefilled form data and error mesages
        $this->data["registrationInfo"] = $this->session->get("registrationInfo");
        $this->data["registrationErrors"] = $this->session->get("registrationErrors");

        //remove the set data as it is now sent to the template
        $this->session->remove("registrationInfo");
        $this->session->remove("registrationErrors");

        $this->data["user"] = $this->userModel->getUserDetailsById($userId);

        $this->data["roles"] = $this->roleModel->getRoleList();

        $this->renderView('Admin/Home');
    }

    /**
     * Update the user info via post
     */
    public function updateUser()
    {
        $this->onlyUser();
        $this->onlyPost();

        $user = (object)$this->request->getDataFull();
        $redirectUrl = "/admin";

        if ($user->userId !== $this->session->get("userId") || isset($user->userRoleSelector)) {
            //an admin is trying to update a user or form tampered with
            $this->onlyAdmin();
            $redirectUrl = "/admin/home/view-user/" . $user->userId;
        } else {
            //set the role to the original state for update
            $beforeUser = $this->userModel->getUserDetailsById($user->userId);
            $user->userRoleSelector = $beforeUser->roles_idroles;
        }

        $userId = $user->userId;
        $password = $user->forgotPassword ?? "";
        $confirm = $user->forgotConfirm ?? "";
        $resetPassword = false;
        $error = false;
        $registerErrors = new \stdClass();

        if ($password !== "" || $confirm !== "") {
            //we are resetting the password
            $resetPassword = true;
            if ($password !== $confirm) {
                $error = true;
                $registerErrors->forgotPassword = "password and confirmation do not match";
                $registerErrors->forgotConfirm = "password and confirmation do not match";
            }

            $passwordError = $this->isPasswordComplex($password);
            if (!$passwordError["success"]) {
                $error = true;
                $registerErrors->forgotPassword = $passwordError["message"];
            }
        }

        if ($user->userName == "") {
            $error = true;
            $registerErrors->userName = "name must not be empty";
        }
        if ($user->userSurname == "") {
            $error = true;
            $registerErrors->userSurname = "surname must not be empty";
        }
        if ($user->userUsername == "") {
            $error = true;
            $registerErrors->userUsername = "username must not be empty";
        }

        if ($error) {
            $this->session->set("registrationErrors", $registerErrors);
            $this->response->redirect($redirectUrl);
        }

        if ($resetPassword) {
            $this->userModel->resetPassword($userId, $password);
        }

        $this->userModel->updateUser($user);

        $this->alertBox->setAlert('User details updated');
        $this->response->redirect($redirectUrl);
    }
}

1			<?php
2
3			namespace App\Controllers\Admin;
4
5
6			use App\Models\RoleModel;
7			use App\Models\UserModel;
8			use Core\Container;
9			use Core\Traits\PasswordFunctions;
10			use Core\Traits\StringFunctions;
11
12			class Home extends \Core\AdminController
13			{
14			use StringFunctions;
			0 ignored issues – show Bug introduced 2018-10-15 16:47 UTC by Report Bug Copy Issue Report The trait `Core\Traits\StringFunctions` requires the property `$childNodes` which is not provided by `App\Controllers\Admin\Home`. Loading history...
15			use PasswordFunctions;
16			protected $siteConfig;
17
18			private $userModel;
19			private $roleModel;
20
21			public function __construct(Container $container)
22			{
23			$this->loadModules[] = 'SiteConfig';
24			parent::__construct($container);
25			$this->userModel = new UserModel($this->container);
26			$this->roleModel = new RoleModel($this->container);
27
28			$this->data['configs'] = $this->siteConfig->getSiteConfig();
29			}
30
31			/**
32			* The front page of the admin section. We display the user info
33			* @throws \ReflectionException
34			* @throws \Twig_Error_Loader
35			* @throws \Twig_Error_Runtime
36			* @throws \Twig_Error_Syntax
37			*/
38			public function index()
39			{
40			$this->onlyUser();
41
42			//check if have prefilled form data and error mesages
43			$this->data["registrationInfo"] = $this->session->get("registrationInfo");
44			$this->data["registrationErrors"] = $this->session->get("registrationErrors");
45
46			//remove the set data as it is now sent to the template
47			$this->session->remove("registrationInfo");
48			$this->session->remove("registrationErrors");
49
50			$userId = $this->session->get("userId");
51			$this->data["user"] = $this->userModel->getUserDetailsById($userId);
52
53			$this->data["roles"] = $this->roleModel->getRoleList();
54
55			$this->renderView('Admin/Home');
56			}
57
58			/**
59			* Administrate a user as an admin
60			* @param int $userId
61			* @throws \ReflectionException
62			* @throws \Twig_Error_Loader
63			* @throws \Twig_Error_Runtime
64			* @throws \Twig_Error_Syntax
65			*/
66			public function viewUser(int $userId)
67			{
68			$this->onlyAdmin();
69			if (!$this->isInt($userId)) {
70			throw new \Exception("Error in passed ID");
71			}
72
73			//check if have prefilled form data and error mesages
74			$this->data["registrationInfo"] = $this->session->get("registrationInfo");
75			$this->data["registrationErrors"] = $this->session->get("registrationErrors");
76
77			//remove the set data as it is now sent to the template
78			$this->session->remove("registrationInfo");
79			$this->session->remove("registrationErrors");
80
81			$this->data["user"] = $this->userModel->getUserDetailsById($userId);
82
83			$this->data["roles"] = $this->roleModel->getRoleList();
84
85			$this->renderView('Admin/Home');
86			}
87
88			/**
89			* Update the user info via post
90			*/
91			public function updateUser()
92			{
93			$this->onlyUser();
94			$this->onlyPost();
95
96			$user = (object)$this->request->getDataFull();
97			$redirectUrl = "/admin";
98
99			if ($user->userId !== $this->session->get("userId") \|\| isset($user->userRoleSelector)) {
100			//an admin is trying to update a user or form tampered with
101			$this->onlyAdmin();
102			$redirectUrl = "/admin/home/view-user/" . $user->userId;
103			} else {
104			//set the role to the original state for update
105			$beforeUser = $this->userModel->getUserDetailsById($user->userId);
106			$user->userRoleSelector = $beforeUser->roles_idroles;
107			}
108
109			$userId = $user->userId;
110			$password = $user->forgotPassword ?? "";
111			$confirm = $user->forgotConfirm ?? "";
112			$resetPassword = false;
113			$error = false;
114			$registerErrors = new \stdClass();
115
116			if ($password !== "" \|\| $confirm !== "") {
117			//we are resetting the password
118			$resetPassword = true;
119			if ($password !== $confirm) {
120			$error = true;
121			$registerErrors->forgotPassword = "password and confirmation do not match";
122			$registerErrors->forgotConfirm = "password and confirmation do not match";
123			}
124
125			$passwordError = $this->isPasswordComplex($password);
126			if (!$passwordError["success"]) {
127			$error = true;
128			$registerErrors->forgotPassword = $passwordError["message"];
129			}
130			}
131
132			if ($user->userName == "") {
133			$error = true;
134			$registerErrors->userName = "name must not be empty";
135			}
136			if ($user->userSurname == "") {
137			$error = true;
138			$registerErrors->userSurname = "surname must not be empty";
139			}
140			if ($user->userUsername == "") {
141			$error = true;
142			$registerErrors->userUsername = "username must not be empty";
143			}
144
145			if ($error) {
146			$this->session->set("registrationErrors", $registerErrors);
147			$this->response->redirect($redirectUrl);
148			}
149
150			if ($resetPassword) {
151			$this->userModel->resetPassword($userId, $password);
152			}
153
154			$this->userModel->updateUser($user);
155
156			$this->alertBox->setAlert('User details updated');
157			$this->response->redirect($redirectUrl);
158			}
159			}

Starbugstone / blogoc

Push — Auth ( 474bc2...620889 )

Home::updateUser() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like