Comment::__construct() - Code Metrics - Inspection of "Ajax call to load extra comments" - Starbugstone/blogoc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — Comments ( 3ea17b...2fd76b )

by Stone

created 2018-10-22 22:34 UTC

Comment::__construct() A

↳ Parent: Comment

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace App\Controllers\Ajax;

use App\Models\CommentModel;
use Core\AjaxController;
use Core\Container;

class Comment extends AjaxController
{
    private $commentModel;

    public function __construct(Container $container)
    {
        parent::__construct($container);
        $this->commentModel = new CommentModel($this->container);
    }

    /**
     * Update the approved status of a comment
     * @throws \Core\JsonException
     */
    public function modifyApproved()
    {
        $this->onlyAdmin();
        $this->onlyPost();
        $state = (bool)($this->request->getData("state") === 'true');
        $commentId = (int)$this->request->getData("commentId");

        $result = array();
        $result["success"] = $this->commentModel->setApproved(!$state, $commentId);
        $result["state"] = !$state;
        $result["commentId"] = $commentId;
        echo json_encode($result);
    }

    public function loadComments()
    {
        $commentOffset = (int)$this->request->getData("commentOffset");
        $postId = (int)$this->request->getData("postId");

        $result = array();
        $result["success"]=false;

        $data["comments"] = $this->commentModel->getCommentsListOnPost($postId, $commentOffset);

        if($data["comments"])
        {
            $result["success"]=true;
            $twig = $this->container->getTemplate();
            $html = $twig->render('Includes/LoadComments.twig', $data);

            $result["html"] = $html;
            $result["commentOffset"] = $commentOffset + count($data["comments"]);
        }


        echo json_encode($result);
    }

}

1			<?php
2
3			namespace App\Controllers\Ajax;
4
5			use App\Models\CommentModel;
6			use Core\AjaxController;
7			use Core\Container;
8
9			class Comment extends AjaxController
10			{
11			private $commentModel;
12
13			public function __construct(Container $container)
14			{
15			parent::__construct($container);
16			$this->commentModel = new CommentModel($this->container);
17			}
18
19			/**
20			* Update the approved status of a comment
21			* @throws \Core\JsonException
22			*/
23			public function modifyApproved()
24			{
25			$this->onlyAdmin();
26			$this->onlyPost();
27			$state = (bool)($this->request->getData("state") === 'true');
28			$commentId = (int)$this->request->getData("commentId");
29
30			$result = array();
31			$result["success"] = $this->commentModel->setApproved(!$state, $commentId);
32			$result["state"] = !$state;
33			$result["commentId"] = $commentId;
34			echo json_encode($result);
35			}
36
37			public function loadComments()
38			{
39			$commentOffset = (int)$this->request->getData("commentOffset");
40			$postId = (int)$this->request->getData("postId");
41
42			$result = array();
43			$result["success"]=false;
44
45			$data["comments"] = $this->commentModel->getCommentsListOnPost($postId, $commentOffset);
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-10-22 22:36 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Loading history...
46			if($data["comments"])
47			{
48			$result["success"]=true;
49			$twig = $this->container->getTemplate();
50			$html = $twig->render('Includes/LoadComments.twig', $data);
51
52			$result["html"] = $html;
53			$result["commentOffset"] = $commentOffset + count($data["comments"]);
54			}
55
56
57			echo json_encode($result);
58			}
59
60			}

Starbugstone / blogoc

Push — Comments ( 3ea17b...2fd76b )

Comment::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like