Home::sendContactForm() - Code Metrics - Starbugstone/blogoc - Measure and Improve Code Quality continuously with Scrutinizer

Home::sendContactForm() B
last analyzed 2019-01-19 10:15 UTC

↳ Parent: Home

Complexity

Conditions	8
Paths	128

Size

Total Lines	64
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	38
nc	128
nop	0
dl	0
loc	64
rs	7.8808
c	0
b	0
f	0

How to fix Long Method

<?php

namespace App\Controllers;

use App\Models\PostModel;
use App\Models\UserModel;
use Core\Config;
use Core\Container;
use Core\Traits\StringFunctions;

/**
 * Class Home
 *
 * The home page
 *
 * @package App\Controllers
 */
class Home extends \Core\Controller
{

    use StringFunctions;

    protected $siteConfig;
    protected $sendMail;

    private $config;
    private $userModel;
    private $postModel;

    public function __construct(Container $container)
    {
        $this->loadModules[] = 'SiteConfig';
        $this->loadModules[] = 'SendMail';
        parent::__construct($container);

        $this->config = $this->siteConfig->getSiteConfig();
        $this->userModel = new UserModel($this->container);
        $this->postModel = new PostModel($this->container);
        if($this->auth->isuser())
        {
            $this->data["user"] = $this->userModel->getUserDetailsById((int)$this->session->get("userId"));
        }
    }

    /**
     * test the capcha
     * @param string $gCapchaResponse
     * @return bool
     */
    private function testCapcha(string $gCapchaResponse):bool
    {
        $error = false;
        if(Config::GOOGLE_RECAPCHA_PUBLIC_KEY !== "" && Config::GOOGLE_RECAPCHA_SECRET_KEY !== "")

        {
            if(empty($gCapchaResponse))
            {
                $error = true;
                $this->alertBox->setAlert('Capcha not set', 'error');
            }
            //check the capcha
            $grequest = file_get_contents('https://www.google.com/recaptcha/api/siteverify?secret='.Config::GOOGLE_RECAPCHA_SECRET_KEY.'&response='.$gCapchaResponse);
            // The result is in a JSON format. Decoding..
            $gresponse = json_decode($grequest);
            if(!$gresponse->success)
            {
                $error = true;
                $this->alertBox->setAlert('Capcha Error', 'error');
            }
        }
        return $error;
    }

    /**
     * Show the front page
     * @throws \ErrorException
     * @throws \ReflectionException
     * @throws \Twig_Error_Loader
     * @throws \Twig_Error_Runtime
     * @throws \Twig_Error_Syntax
     */
    public function index()
    {
        $frontPosts = $this->postModel->getFrontPosts();

        $this->data['configs'] = $this->config;
        $this->data['navigation'] = $this->siteConfig->getMenu();
        $this->data['jumbotron'] = true;
        $this->data['front_posts'] = $frontPosts;


        //check if have prefilled form data and error messages
        $this->data["contactInfo"] = $this->session->get("contactInfo");
        $this->data["contactErrors"] = $this->session->get("contactErrors");

        //remove the set data as it is now sent to the template
        $this->session->remove("contactInfo");
        $this->session->remove("contactErrors");


        $this->renderView('Home');
    }

    public function contact()
    {

        $this->data['configs'] = $this->config;
        $this->data['navigation'] = $this->siteConfig->getMenu();

        //check if have prefilled form data and error messages
        $this->data["contactInfo"] = $this->session->get("contactInfo");
        $this->data["contactErrors"] = $this->session->get("contactErrors");

        //remove the set data as it is now sent to the template
        $this->session->remove("contactInfo");
        $this->session->remove("contactErrors");

        $this->renderView('Contact');
    }


    /**
     * Send the contact form with error checking
     * @throws \Exception
     */
    public function sendContactForm()
    {
        $this->onlyPost();

        //verify input values (html special chars ?)
        $to = $this->config["admin_email_address"];
        $message = $this->request->getDataFull();

        //Error checking

        //check all the fields
        $error = false;
        $contactErrors = new \stdClass();

        if ($message["contactName"] == "") {
            $error = true;
            $contactErrors->contactName = "Name must not be empty";
        }
        if ($message["contactEmail"] == "") {
            $error = true;
            $contactErrors->contactEmail = "Email must not be empty";
        }
        if ($message["contactSubject"] == "") {
            $error = true;
            $contactErrors->contactSubject = "Subject must not be empty";
        }
        if ($message["contactMessage"] == "") {
            $error = true;
            $contactErrors->contactMessage = "Message must not be empty";
        }
        if (!$this->isEmail($message["contactEmail"])) {
            $error = true;
            $contactErrors->contactEmail = "email is not valid";
        }

        $capchaError = $this->testCapcha($message["g-recaptcha-response"]);

        if($capchaError === true)
        {
            $error = true;
        }

        //If we found an error, return data to the register form and no create
        if ($error) {
            $this->session->set("contactInfo", $message);
            $this->session->set("contactErrors", $contactErrors);
            $this->response->redirect("/home/contact");
        }

        $config = $this->siteConfig->getSiteConfig();

        //from here all is good, send mail
        $userName = htmlspecialchars($message["contactName"]);
        $subject = "Contact from ".$config["site_name"]." : ";
        $subject .= htmlspecialchars($message["contactSubject"]);
        $textMessage = "<h1>message sent by ".$userName."</h1>";
        $textMessage .= "<p>from : <a href='mailto:".$message["contactEmail"]."'>".$message["contactEmail"]."</a></p>";
        $textMessage .= htmlspecialchars($message["contactMessage"]);
        $from = $config["SMTP_from"];

        $this->sendMail->send($to, $subject, $textMessage, $from);

        $this->alertBox->setAlert('Email sent');
        $this->response->redirect();
    }
}

1			<?php
2
3			namespace App\Controllers;
4
5			use App\Models\PostModel;
6			use App\Models\UserModel;
7			use Core\Config;
8			use Core\Container;
9			use Core\Traits\StringFunctions;
10
11			/**
12			* Class Home
13			*
14			* The home page
15			*
16			* @package App\Controllers
17			*/
18			class Home extends \Core\Controller
19			{
20
21			use StringFunctions;
22
23			protected $siteConfig;
24			protected $sendMail;
25
26			private $config;
27			private $userModel;
28			private $postModel;
29
30			public function __construct(Container $container)
31			{
32			$this->loadModules[] = 'SiteConfig';
33			$this->loadModules[] = 'SendMail';
34			parent::__construct($container);
35
36			$this->config = $this->siteConfig->getSiteConfig();
37			$this->userModel = new UserModel($this->container);
38			$this->postModel = new PostModel($this->container);
39			if($this->auth->isuser())
40			{
41			$this->data["user"] = $this->userModel->getUserDetailsById((int)$this->session->get("userId"));
42			}
43			}
44
45			/**
46			* test the capcha
47			* @param string $gCapchaResponse
48			* @return bool
49			*/
50			private function testCapcha(string $gCapchaResponse):bool
51			{
52			$error = false;
53			if(Config::GOOGLE_RECAPCHA_PUBLIC_KEY !== "" && Config::GOOGLE_RECAPCHA_SECRET_KEY !== "")
			0 ignored issues – show introduced 2018-11-03 22:56 UTC by Report Bug Copy Issue Report The condition `Core\Config::GOOGLE_RECAPCHA_PUBLIC_KEY !== ''` is always `false`. Loading history...
54			{
55			if(empty($gCapchaResponse))
56			{
57			$error = true;
58			$this->alertBox->setAlert('Capcha not set', 'error');
59			}
60			//check the capcha
61			$grequest = file_get_contents('https://www.google.com/recaptcha/api/siteverify?secret='.Config::GOOGLE_RECAPCHA_SECRET_KEY.'&response='.$gCapchaResponse);
62			// The result is in a JSON format. Decoding..
63			$gresponse = json_decode($grequest);
64			if(!$gresponse->success)
65			{
66			$error = true;
67			$this->alertBox->setAlert('Capcha Error', 'error');
68			}
69			}
70			return $error;
71			}
72
73			/**
74			* Show the front page
75			* @throws \ErrorException
76			* @throws \ReflectionException
77			* @throws \Twig_Error_Loader
78			* @throws \Twig_Error_Runtime
79			* @throws \Twig_Error_Syntax
80			*/
81			public function index()
82			{
83			$frontPosts = $this->postModel->getFrontPosts();
84
85			$this->data['configs'] = $this->config;
86			$this->data['navigation'] = $this->siteConfig->getMenu();
87			$this->data['jumbotron'] = true;
88			$this->data['front_posts'] = $frontPosts;
89
90
91			//check if have prefilled form data and error messages
92			$this->data["contactInfo"] = $this->session->get("contactInfo");
93			$this->data["contactErrors"] = $this->session->get("contactErrors");
94
95			//remove the set data as it is now sent to the template
96			$this->session->remove("contactInfo");
97			$this->session->remove("contactErrors");
98
99
100			$this->renderView('Home');
101			}
102
103			public function contact()
104			{
105
106			$this->data['configs'] = $this->config;
107			$this->data['navigation'] = $this->siteConfig->getMenu();
108
109			//check if have prefilled form data and error messages
110			$this->data["contactInfo"] = $this->session->get("contactInfo");
111			$this->data["contactErrors"] = $this->session->get("contactErrors");
112
113			//remove the set data as it is now sent to the template
114			$this->session->remove("contactInfo");
115			$this->session->remove("contactErrors");
116
117			$this->renderView('Contact');
118			}
119
120
121			/**
122			* Send the contact form with error checking
123			* @throws \Exception
124			*/
125			public function sendContactForm()
126			{
127			$this->onlyPost();
128
129			//verify input values (html special chars ?)
130			$to = $this->config["admin_email_address"];
131			$message = $this->request->getDataFull();
132
133			//Error checking
134
135			//check all the fields
136			$error = false;
137			$contactErrors = new \stdClass();
138
139			if ($message["contactName"] == "") {
140			$error = true;
141			$contactErrors->contactName = "Name must not be empty";
142			}
143			if ($message["contactEmail"] == "") {
144			$error = true;
145			$contactErrors->contactEmail = "Email must not be empty";
146			}
147			if ($message["contactSubject"] == "") {
148			$error = true;
149			$contactErrors->contactSubject = "Subject must not be empty";
150			}
151			if ($message["contactMessage"] == "") {
152			$error = true;
153			$contactErrors->contactMessage = "Message must not be empty";
154			}
155			if (!$this->isEmail($message["contactEmail"])) {
156			$error = true;
157			$contactErrors->contactEmail = "email is not valid";
158			}
159
160			$capchaError = $this->testCapcha($message["g-recaptcha-response"]);
161
162			if($capchaError === true)
163			{
164			$error = true;
165			}
166
167			//If we found an error, return data to the register form and no create
168			if ($error) {
169			$this->session->set("contactInfo", $message);
170			$this->session->set("contactErrors", $contactErrors);
171			$this->response->redirect("/home/contact");
172			}
173
174			$config = $this->siteConfig->getSiteConfig();
175
176			//from here all is good, send mail
177			$userName = htmlspecialchars($message["contactName"]);
178			$subject = "Contact from ".$config["site_name"]." : ";
179			$subject .= htmlspecialchars($message["contactSubject"]);
180			$textMessage = "<h1>message sent by ".$userName."</h1>";
181			$textMessage .= "<p>from : <a href='mailto:".$message["contactEmail"]."'>".$message["contactEmail"]."</a></p>";
182			$textMessage .= htmlspecialchars($message["contactMessage"]);
183			$from = $config["SMTP_from"];
184
185			$this->sendMail->send($to, $subject, $textMessage, $from);
186
187			$this->alertBox->setAlert('Email sent');
188			$this->response->redirect();
189			}
190			}

Starbugstone / blogoc

Home::sendContactForm() B last analyzed 2019-01-19 10:15 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

Home::sendContactForm() B
last analyzed 2019-01-19 10:15 UTC