App\Controller\Image\DeleteImageController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	deleteTrickImage()	0	8	1
A	__construct()	0	3	1

<?php

namespace App\Controller\Image;

use App\Entity\Image;
use App\Event\Image\ImageDeleteEvent;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\Routing\Annotation\Route;

/**
 * Class DeleteImageController
 * @package App\Controller\Image
 * @IsGranted("ROLE_USER")
 */
class DeleteImageController extends AbstractController
{

    /**
     * @var EventDispatcherInterface
     */
    private $dispatcher;

    public function __construct(EventDispatcherInterface $dispatcher)
    {
        $this->dispatcher = $dispatcher;
    }

    /**
     * @Route("/image/delete/{id}", name="image.deleteFromTrick", methods={"POST"})
     * @param Image $image
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function deleteTrickImage(Image $image)
    {
        $trick = $image->getTrick();
        $event = new ImageDeleteEvent($image, $image->getTrick());

It seems like $image->getTrick() can also be of type null; however, parameter $trick of App\Event\Image\ImageDeleteEvent::__construct() does only seem to accept App\Entity\Trick, maybe add an additional type check?

        $this->dispatcher->dispatch(ImageDeleteEvent::NAME, $event);

        return $this->redirectToRoute('trick.edit', [
            'id' => $trick->getId(),
        ]);
    }
}