Huawei\IAP\StoreSiteSelector::selectSite()

Complexity

Conditions	11
Paths	9

Size

Total Lines	75
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function selectSite(
        string $type,
        ?string $country,
        ?int $accountFlag
    ): StoreSiteSelectorChoice
    {
        $appTouchSite = $accountFlag === self::ACCOUNT_FLAG;

        if ($type === Validator::TYPE_ORDER && $appTouchSite) {
            if (isset($this->appTouchOrderSiteMapping[$country])) {
                return new StoreSiteSelectorChoice(
                    $country,

It seems like $country can also be of type null; however, parameter $country of Huawei\IAP\StoreSiteSelectorChoice::__construct() does only seem to accept string, maybe add an additional type check?

                    $this->subscriptionSiteMapping[$country],
                    $appTouchSite
                );
            }

            return new StoreSiteSelectorChoice(
                self::GERMANY,
                $this->appTouchOrderSiteMapping[self::GERMANY],
                $appTouchSite
            );
        }

        if ($type === Validator::TYPE_ORDER) {
            if (isset($this->orderSiteMapping[$country])) {
                return new StoreSiteSelectorChoice(
                    $country,
                    $this->orderSiteMapping[$country],
                    $appTouchSite
                );
            }

            return new StoreSiteSelectorChoice(
                $this->defaultOrderCountry,
                $this->orderSiteMapping[$this->defaultOrderCountry],
                $appTouchSite
            );
        }

        if ($type === Validator::TYPE_SUBSCRIPTION && $appTouchSite) {
            if (isset($this->appTouchSubscriptionSiteMapping[$country])) {
                return new StoreSiteSelectorChoice(
                    $country,
                    $this->subscriptionSiteMapping[$country],
                    $appTouchSite
                );
            }

            return new StoreSiteSelectorChoice(
                self::GERMANY,
                $this->appTouchSubscriptionSiteMapping[self::GERMANY],
                $appTouchSite
            );
        }

        if ($type === Validator::TYPE_SUBSCRIPTION) {
            if (isset($this->subscriptionSiteMapping[$country])) {
                return new StoreSiteSelectorChoice(
                    $country,
                    $this->subscriptionSiteMapping[$country],
                    $appTouchSite
                );
            }

            return new StoreSiteSelectorChoice(
                $this->defaultSubscriptionCountry,
                $this->subscriptionSiteMapping[$this->defaultSubscriptionCountry],
                $appTouchSite
            );
        }

        throw new \RuntimeException(\sprintf(
            'Can not select site using (%s)',
            \json_encode(['type' => $type, 'country' => $country, 'accountFlag' => $accountFlag])
        ));