Coder::format() - Code Metrics - Inspection of "No memoization for coder" - Stadly/PasswordPolice - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 19a784...76ed2d )

by Magnar Ovedal

created 2019-04-16 10:36 UTC

Coder::format() A

↳ Parent: Coder

Complexity

Conditions	4
Paths	4

Size

Total Lines	17
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	8
nc	4
nop	1
dl	0
loc	17
ccs	9
cts	9
cp	1
crap	4
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Stadly\PasswordPolice\Formatter;

use Stadly\PasswordPolice\CharTree;
use Stadly\PasswordPolice\CodeMap;
use Stadly\PasswordPolice\Formatter;

final class Coder implements Formatter
{
    use Chaining;

    /**
     * @var CodeMap Code map for coding character trees.
     */
    private $codeMap;

    /**
     * @param CodeMap $codeMap Code map for coding character trees.
     */
    public function __construct(CodeMap $codeMap)
    {
        $this->codeMap = $codeMap;
    }

    /**
     * @param CharTree $charTree Character tree to format.
     * @return CharTree Coded variant of the character tree.
     */
    protected function applyCurrent(CharTree $charTree): CharTree
    {
        return $this->format($charTree);
    }

    /**
     * @param CharTree $charTree Character tree to format.
     * @return CharTree Coded variant of the character tree. Memoization is not used.
     */
    private function format(CharTree $charTree): CharTree
    {
        if ($charTree->getRoot() === null) {
            return $charTree;
        }

        $branches = [];

        foreach ($this->codeMap->getMap($charTree) as $char => $codedChars) {
            $branch = $this->applyCurrent($charTree->getBranchesAfterRoot((string)$char));

            foreach ($codedChars as $codedChar) {
                $branches[] = CharTree::fromString($codedChar, [$branch]);
            }
        }

        return CharTree::fromString('', $branches);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Stadly\PasswordPolice\Formatter;
6
7		use Stadly\PasswordPolice\CharTree;
8		use Stadly\PasswordPolice\CodeMap;
9		use Stadly\PasswordPolice\Formatter;
10
11		final class Coder implements Formatter
12		{
13		use Chaining;
14
15		/**
16		* @var CodeMap Code map for coding character trees.
17		*/
18		private $codeMap;
19
20		/**
21		* @param CodeMap $codeMap Code map for coding character trees.
22		*/
23	5	public function __construct(CodeMap $codeMap)
24		{
25	5	$this->codeMap = $codeMap;
26	5	}
27
28		/**
29		* @param CharTree $charTree Character tree to format.
30		* @return CharTree Coded variant of the character tree.
31		*/
32	5	protected function applyCurrent(CharTree $charTree): CharTree
33		{
34	5	return $this->format($charTree);
35		}
36
37		/**
38		* @param CharTree $charTree Character tree to format.
39		* @return CharTree Coded variant of the character tree. Memoization is not used.
40		*/
41	5	private function format(CharTree $charTree): CharTree
42		{
43	5	if ($charTree->getRoot() === null) {
44	1	return $charTree;
45		}
46
47	4	$branches = [];
48
49	4	foreach ($this->codeMap->getMap($charTree) as $char => $codedChars) {
50	3	$branch = $this->applyCurrent($charTree->getBranchesAfterRoot((string)$char));
51
52	3	foreach ($codedChars as $codedChar) {
53	3	$branches[] = CharTree::fromString($codedChar, [$branch]);
54		}
55		}
56
57	4	return CharTree::fromString('', $branches);
58		}
59		}
60

Stadly / PasswordPolice

Push — master ( 19a784...76ed2d )

Coder::format() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like