ICSPBaseActions.check_results() - Code Metrics - Inspection of "hpe-icsp refinement" - StackStorm/st2contrib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#496)

unknown

created 2016-05-25 09:48 UTC

ICSPBaseActions.check_results() A

↳ Parent: ICSPBaseActions

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
dl	0
loc	4
rs	10
c	0
b	0
f	0

# Licensed to the StackStorm, Inc ('StackStorm') under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import requests
import copy
from st2actions.runners.pythonrunner import Action


class ICSPBaseActions(Action):

    def __init__(self, config):
        super(ICSPBaseActions, self).__init__(config)
        self.icsp_host = config['host']
        self.icsp_user = config['user']
        self.icsp_pass = config['pass']
        self.icsp_apiv = config['apiv']
        self.icsp_sslverify = config['sslverify']

    def check_results(self, results):
        # Check for errorCode json element
        if 'errorCode' in results:
            raise Exception("Error: %s" % (results["recommendedActions"]))

    def set_connection(self, connection=None):
        if connection:
            if 'host' in connection:
                self.icsp_host = connection['host']
            if 'user' in connection:
                self.icsp_user = connection['user']
            if 'pass' in connection:
                self.icsp_pass = connection['pass']
            if 'apiv' in connection:
                self.icsp_apiv = connection['apiv']
            if 'sslverify' in connection:
                if connection['sslverify'].lower() == "false":
                    self.icsp_sslverify = False
                else:
                    self.icsp_sslverify = True

    def get_sessionid(self):
        url = 'https://%s/rest/login-sessions' % self.icsp_host
        payload = {'userName': self.icsp_user, 'password': self.icsp_pass}
        headers = {'accept': 'application/json',
                   'accept-language': 'en-us',
                   'Content-Type': 'application/json'}
        p = requests.post(url, headers=headers,
                          json=payload, verify=self.icsp_sslverify)
        results = p.json()
        self.check_results(results)
        self.icsp_sessionid = results["sessionID"]
class Foo:
    def __init__(self, x=None):
        self.x = x

        # added here due to the requirement of the session id
        self.base_headers = {'Auth': self.icsp_sessionid,
class Foo:
    def __init__(self, x=None):
        self.x = x
                             'X-Api-Version': self.icsp_apiv}

        return results["sessionID"]

    def extract_id(self, joburi):
        jobid = str(joburi)
        return int(jobid.split("/")[-1])

    def get_mids(self, ids, idtype):
        endpoint = "/rest/os-deployment-servers"
        getresults = self.icsp_get(endpoint)
        servers = getresults["members"]
        mids = []
        for id in ids:

            for server in servers:
                if idtype == 'serialnumber':
                    if ((server["serialNumber"] == id) and
                            (server["mid"] not in mids)):
                        mids.append(int(server["mid"]))
                if idtype == 'uuid':
                    if ((server["uuid"] == id) and
                            (server["mid"] not in mids)):
                        mids.append(int(server["mid"]))
        return mids

    def validate_mids (self, identifiers):

        for n in identifiers:
            try:
                int(n)
            except:
                raise ValueError("Identifier provided is not a MID")
    

    def icsp_get(self, endpoint):
        url = 'https://%s%s' % (self.icsp_host, endpoint)
        headers = copy.copy(self.base_headers)
        p = requests.get(url, headers=headers, verify=self.icsp_sslverify)
        results = p.json()
        self.check_results(results)
        return results

    def icsp_put(self, endpoint, payload):
        url = 'https://%s%s' % (self.icsp_host, endpoint)
        headers = copy.copy(self.base_headers)
        p = requests.put(url, headers=headers,
                         json=payload, verify=self.icsp_sslverify)
        results = p.json()
        self.check_results(results)
        return

    def icsp_post(self, endpoint, payload):
        url = 'https://%s%s' % (self.icsp_host, endpoint)
        headers = copy.copy(self.base_headers)
        headers['Content-type'] = "application/json"
        p = requests.post(url, headers=headers,
                          data=payload, verify=self.icsp_sslverify)
        results = p.json()
        self.check_results(results)
        return results

    def icsp_delete(self, endpoint):
        url = 'https://%s%s' % (self.icsp_host, endpoint)
        headers = copy.copy(self.base_headers)
        requests.delete(url, headers=headers, verify=self.icsp_sslverify)
        return


1			# Licensed to the StackStorm, Inc ('StackStorm') under one or more
2			# contributor license agreements. See the NOTICE file distributed with
3			# this work for additional information regarding copyright ownership.
4			# The ASF licenses this file to You under the Apache License, Version 2.0
5			# (the "License"); you may not use this file except in compliance with
6			# the License. You may obtain a copy of the License at
7			#
8			# http://www.apache.org/licenses/LICENSE-2.0
9			#
10			# Unless required by applicable law or agreed to in writing, software
11			# distributed under the License is distributed on an "AS IS" BASIS,
12			# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13			# See the License for the specific language governing permissions and
14			# limitations under the License.
15
16			import requests
17			import copy
18			from st2actions.runners.pythonrunner import Action
19
20
21			class ICSPBaseActions(Action):
22
23			def __init__(self, config):
24			super(ICSPBaseActions, self).__init__(config)
25			self.icsp_host = config['host']
26			self.icsp_user = config['user']
27			self.icsp_pass = config['pass']
28			self.icsp_apiv = config['apiv']
29			self.icsp_sslverify = config['sslverify']
30
31			def check_results(self, results):
32			# Check for errorCode json element
33			if 'errorCode' in results:
34			raise Exception("Error: %s" % (results["recommendedActions"]))
35
36			def set_connection(self, connection=None):
37			if connection:
38			if 'host' in connection:
39			self.icsp_host = connection['host']
40			if 'user' in connection:
41			self.icsp_user = connection['user']
42			if 'pass' in connection:
43			self.icsp_pass = connection['pass']
44			if 'apiv' in connection:
45			self.icsp_apiv = connection['apiv']
46			if 'sslverify' in connection:
47			if connection['sslverify'].lower() == "false":
48			self.icsp_sslverify = False
49			else:
50			self.icsp_sslverify = True
51
52			def get_sessionid(self):
53			url = 'https://%s/rest/login-sessions' % self.icsp_host
54			payload = {'userName': self.icsp_user, 'password': self.icsp_pass}
55			headers = {'accept': 'application/json',
56			'accept-language': 'en-us',
57			'Content-Type': 'application/json'}
58			p = requests.post(url, headers=headers,
59			json=payload, verify=self.icsp_sslverify)
60			results = p.json()
61			self.check_results(results)
62			self.icsp_sessionid = results["sessionID"]
			0 ignored issues – show Coding Style introduced 2016-04-12 15:39 UTC by Report Bug Copy Issue Report The attribute `icsp_sessionid` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
63
64			# added here due to the requirement of the session id
65			self.base_headers = {'Auth': self.icsp_sessionid,
			0 ignored issues – show Coding Style introduced 2016-04-26 09:35 UTC by Report Bug Copy Issue Report The attribute `base_headers` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
66			'X-Api-Version': self.icsp_apiv}
67
68			return results["sessionID"]
69
70			def extract_id(self, joburi):
71			jobid = str(joburi)
72			return int(jobid.split("/")[-1])
73
74			def get_mids(self, ids, idtype):
75			endpoint = "/rest/os-deployment-servers"
76			getresults = self.icsp_get(endpoint)
77			servers = getresults["members"]
78			mids = []
79			for id in ids:
			0 ignored issues – show Bug Best Practice introduced 2016-05-17 17:00 UTC by Report Bug Copy Issue Report This seems to re-define the built-in `id`. It is generally discouraged to redefine built-ins as this makes code very hard to read. Loading history...
80			for server in servers:
81			if idtype == 'serialnumber':
82			if ((server["serialNumber"] == id) and
83			(server["mid"] not in mids)):
84			mids.append(int(server["mid"]))
85			if idtype == 'uuid':
86			if ((server["uuid"] == id) and
87			(server["mid"] not in mids)):
88			mids.append(int(server["mid"]))
89			return mids
90
91			def validate_mids (self, identifiers):
			0 ignored issues – show Coding Style introduced 2016-05-25 09:51 UTC by Report Bug Copy Issue Report No space allowed before bracket def validate_mids (self, identifiers): ^ Loading history...
92			for n in identifiers:
93			try:
94			int(n)
95			except:
96			raise ValueError("Identifier provided is not a MID")
97
			0 ignored issues – show Coding Style introduced 2016-05-25 09:51 UTC by Report Bug Copy Issue Report Trailing whitespace Loading history...
98			def icsp_get(self, endpoint):
99			url = 'https://%s%s' % (self.icsp_host, endpoint)
100			headers = copy.copy(self.base_headers)
101			p = requests.get(url, headers=headers, verify=self.icsp_sslverify)
102			results = p.json()
103			self.check_results(results)
104			return results
105
106			def icsp_put(self, endpoint, payload):
107			url = 'https://%s%s' % (self.icsp_host, endpoint)
108			headers = copy.copy(self.base_headers)
109			p = requests.put(url, headers=headers,
110			json=payload, verify=self.icsp_sslverify)
111			results = p.json()
112			self.check_results(results)
113			return
114
115			def icsp_post(self, endpoint, payload):
116			url = 'https://%s%s' % (self.icsp_host, endpoint)
117			headers = copy.copy(self.base_headers)
118			headers['Content-type'] = "application/json"
119			p = requests.post(url, headers=headers,
120			data=payload, verify=self.icsp_sslverify)
121			results = p.json()
122			self.check_results(results)
123			return results
124
125			def icsp_delete(self, endpoint):
126			url = 'https://%s%s' % (self.icsp_host, endpoint)
127			headers = copy.copy(self.base_headers)
128			requests.delete(url, headers=headers, verify=self.icsp_sslverify)
129			return
130

StackStorm / st2contrib

Pull Request — master (#496)

ICSPBaseActions.check_results() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like