Completed
Pull Request — master (#513)
by
unknown
03:15
created

GetVMDetails.run()   F

Complexity

Conditions 11

Size

Total Lines 34

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 11
c 1
b 0
f 0
dl 0
loc 34
rs 3.1764

How to fix   Complexity   

Complexity

Complex classes like GetVMDetails.run() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

1
# Licensed to the StackStorm, Inc ('StackStorm') under one or more
2
# contributor license agreements.  See the NOTICE file distributed with
3
# this work for additional information regarding copyright ownership.
4
# The ASF licenses this file to You under the Apache License, Version 2.0
5
# (the "License"); you may not use this file except in compliance with
6
# the License.  You may obtain a copy of the License at
7
#
8
#     http://www.apache.org/licenses/LICENSE-2.0
9
#
10
# Unless required by applicable law or agreed to in writing, software
11
# distributed under the License is distributed on an "AS IS" BASIS,
12
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13
# See the License for the specific language governing permissions and
14
# limitations under the License.
15
16
from vmwarelib import inventory
17
from vmwarelib.actions import BaseAction
18
19
20
class GetVMDetails(BaseAction):
21
    def run(self, vm_ids, vm_names, vsphere=None):
22
        """
23
        Retrieve details for given Virtual Machines
24
25
        Args:
26
        - vm_ids: Moid of Virtual Machines to retrieve
27
        - vm_names: Name of Virtual Machines to retrieve
28
        - vsphere: Pre-configured vsphere connection details (config.yaml)
29
30
31
        Returns:
32
        - dict: Virtual machine details.
33
        """
34
35
        # TODO review using propertspec for retrieving all VM's at onces.
36
        results = {}
37
        if not vm_ids and not vm_names:
38
            raise ValueError("No IDs nor Names provided.")
39
40
        self.establish_connection(vsphere)
41
42
        if vm_ids:
43
            for vid in vm_ids:
44
                vm = inventory.get_virtualmachine(self.si_content, moid=vid)
45
                if vm:
46
                    if vm.name not in results:
47
                        results[vm.name] = vm.summary
48
        if vm_names:
49
            for vm in vm_names:
50
                vm = inventory.get_virtualmachine(self.si_content, name=vm)
51
                if vm:
52
                    if vm.name not in results:
53
                        results[vm.name] = vm.summary
54
        return results
55