Completed
Pull Request — master (#513)
by
unknown
04:09
created

GetVMUUID.run()   F

Complexity

Conditions 11

Size

Total Lines 30

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 11
c 0
b 0
f 0
dl 0
loc 30
rs 3.1764

How to fix   Complexity   

Complexity

Complex classes like GetVMUUID.run() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

1
# Licensed to the StackStorm, Inc ('StackStorm') under one or more
2
# contributor license agreements.  See the NOTICE file distributed with
3
# this work for additional information regarding copyright ownership.
4
# The ASF licenses this file to You under the Apache License, Version 2.0
5
# (the "License"); you may not use this file except in compliance with
6
# the License.  You may obtain a copy of the License at
7
#
8
#     http://www.apache.org/licenses/LICENSE-2.0
9
#
10
# Unless required by applicable law or agreed to in writing, software
11
# distributed under the License is distributed on an "AS IS" BASIS,
12
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13
# See the License for the specific language governing permissions and
14
# limitations under the License.
15
16
from vmwarelib import inventory
17
from vmwarelib.actions import BaseAction
18
19
20
class GetVMUUID(BaseAction):
21
22
    def run(self, vm_ids, vm_names, vsphere=None):
23
        """
24
        Retrieve UUID for specified virtual machine.
25
26
        Args:
27
        - vm_id: Moid of Virtual Machine to edit
28
        - vm_name: Name of Virtual Machine to edit
29
        - vsphere: Pre-configured vsphere connection details (config.yaml)
30
31
        Returns:
32
        - dict: uuid values.
33
        """
34
        self.establish_connection(vsphere)
35
36
        results = []
37
        if not vm_ids and not vm_names:
38
            raise Exception("No ID nor Names provided")
39
        if vm_ids:
40
            for vm in vm_ids:
41
                vm = inventory.get_virtualmachine(self.si_content, moid=vm)
42
                if vm:
43
                    if vm.summary.config.uuid not in results:
44
                        results.append(vm.summary.config.uuid)
45
        if vm_names:
46
            for vm in vm_names:
47
                vm = inventory.get_virtualmachine(self.si_content, name=vm)
48
                if vm:
49
                    if vm.summary.config.uuid not in results:
50
                        results.append(vm.summary.config.uuid)
51
        return results
52