Completed
Pull Request — master (#474)
by
unknown
03:25
created

GetMid.run()   F

Complexity

Conditions 10

Size

Total Lines 28

Duplication

Lines 0
Ratio 0 %
Metric Value
cc 10
dl 0
loc 28
rs 3.1304

How to fix   Complexity   

Complexity

Complex classes like GetMid.run() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

1
# Licensed to the StackStorm, Inc ('StackStorm') under one or more
2
# contributor license agreements.  See the NOTICE file distributed with
3
# this work for additional information regarding copyright ownership.
4
# The ASF licenses this file to You under the Apache License, Version 2.0
5
# (the "License"); you may not use this file except in compliance with
6
# the License.  You may obtain a copy of the License at
7
#
8
#     http://www.apache.org/licenses/LICENSE-2.0
9
#
10
# Unless required by applicable law or agreed to in writing, software
11
# distributed under the License is distributed on an "AS IS" BASIS,
12
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13
# See the License for the specific language governing permissions and
14
# limitations under the License.
15
16
from lib.icsp import ICSPBaseActions
17
18
19
class GetMid(ICSPBaseActions):
20
    def run(self, uuid, serialnumber, connection_details):
21
22
        if connection_details:
23
            self.setConnection(connection_details)
24
        self.getSessionID()
25
        endpoint = "/rest/os-deployment-servers"
26
        getresults = self.icspGET(endpoint)
27
        servers = getresults["members"]
28
        results = []
29
        # Checking arrays are set otherwise errors occur later
30
        # when called within flows missing arrays cause python errors
31
        if not serialnumber:
32
            serialnumber = []
33
        if not uuid:
34
            uuid = []
35
        for server in servers:
36
            if (server["uuid"] in uuid) or\
37
                    (server["serialNumber"] in serialnumber):
38
                if (len(uuid) + len(serialnumber)) == 1:
39
                    return {'mid': int(server["mid"])}
40
                else:
41
                    if server["mid"] not in results:
42
                        results.append(int(server["mid"]))
43
44
        if results:
45
            return results
46
        else:
47
            raise ValueError("No Servers Found")
48