Client.start() - Code Metrics - Inspection of "Icinga2 Integration pack, v0.2.0, initial commit" - StackStorm/st2contrib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#469)

unknown

created 2016-04-08 13:39 UTC

Client.start() F

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	63
rs	2.8462
cc	14

How to fix Long Method Complexity

import pycurl, json
import urllib
import signal
import sys
import time

POST_PARAMS = {}

class Client:
  def __init__(self, sensor, api_url, api_user, api_password):
    if sensor is not None:
      self._sensor = sensor
    else:
      self._sensor = None
    self.conn = None
    self.buffer = ''
    self.keep_trying = 1
    self.api_url = api_url
    self.api_user = api_user
    self.api_password = api_password
    
    signal.signal(signal.SIGINT, self.handle_ctrl_c)

  def handle_ctrl_c(self, signal, frame):
    if self._sensor is not None:
      sensor.logger.info('SIGINT receivied')
    else:
      print 'You pressed Ctrl+C!'
    self.abort_session()

  def abort_session(self):
    self.keep_trying = 0
    self.conn.close()

  def setup_connection(self):

    if self.conn:
      self.conn.close()
      self.buffer = ''
    self.headers = ['Accept: application/json', 'Expect:']
    self.conn = pycurl.Curl()
    self.conn.setopt(pycurl.SSL_VERIFYHOST, False)
    self.conn.setopt(pycurl.SSL_VERIFYPEER, False)
    self.conn.setopt(pycurl.USERPWD, "%s:%s" % (self.api_user, self.api_password))
    self.conn.setopt(pycurl.URL, self.api_url)
    self.conn.setopt(pycurl.VERBOSE, 1)
    self.conn.setopt(pycurl.WRITEFUNCTION, self.on_receive)
    self.conn.setopt(pycurl.NOSIGNAL, 1)
    self.conn.setopt(pycurl.NOPROGRESS, 0)
    self.conn.setopt(pycurl.PROGRESSFUNCTION, self.on_progress)
    self.conn.setopt(pycurl.HTTPHEADER, self.headers)
    self.conn.setopt(pycurl.POST, 1)
    self.conn.setopt(pycurl.POSTFIELDS, urllib.urlencode(POST_PARAMS))

  def on_receive(self, data):
    self.buffer += data
    if data.endswith('\n') and self.buffer.strip():
    # complete message received
      event = json.loads(self.buffer)
      self.buffer = ''
      if self._sensor is not None:
        self._sensor.process_event(event)
      else:
        print event

  def on_progress(self, d_total, downloaded, u_total, uploaded):
    pass
    #print "on_progress called"

  def __del__(self):
    self.conn.close()

  def start(self):
    if self._sensor is not None:
      self._sensor.logger.info('pyCurl started.')
    backoff_network_error = 0.25
    backoff_http_error = 5
    backoff_rate_limit = 60
    while True and self.keep_trying == 1:
      if self._sensor is not None:
        self._sensor.logger.info('keep trying = %i', self.keep_trying)
      else:
        print "keep trying = %i" % self.keep_trying
      self.setup_connection()
      try:
        self.conn.perform()
      except:
        # Network error, use linear back off up to 16 seconds
        if self.keep_trying == 0:
          continue
        if self._sensor is not None:
          self._sensor.logger.info('Network error: %s', self.conn.errstr())
          self._sensor.logger.info('Waiting %s seconds before trying again', backoff_network_error)
        else:
          print 'Network error: %s' % self.conn.errstr()
          print 'Waiting %s seconds before trying again' % backoff_network_error
        time.sleep(backoff_network_error)
        backoff_network_error = min(backoff_network_error + 1, 16)
        continue
      # HTTP Error
      sc = self.conn.getinfo(pycurl.HTTP_CODE)
      if sc == 420:
        # Rate limit, use exponential back off starting with 1 minute and double each attempt
        if self._sensor is not None:
          self._sensor.logger.info('Rate limit, waiting %s seconds', backoff_rate_limit)
        else:
          print 'Rate limit, waiting %s seconds' % backoff_rate_limit
        time.sleep(backoff_rate_limit)
        backoff_rate_limit *= 2
      elif sc == 401:
        # Authentication error
        if self._sensor is not None:
          self._sensor.logger.info('Authentication error, check user/password, waiting %s seconds', backoff_rate_limit)
        else:
          print 'Authentication error, check user/password, waiting %s seconds' % backoff_rate_limit
        time.sleep(backoff_rate_limit)
        backoff_rate_limit *= 2
      elif sc == 404:
        # Authorization error
        if self._sensor is not None:
          self._sensor.logger.info('Authorization error, check permissions, waiting %s seconds', backoff_rate_limit)
        else:
          print 'Authorization error, check permissions, waiting %s seconds' % backoff_rate_limit
        time.sleep(backoff_rate_limit)
        backoff_rate_limit *= 2
      else:
        # HTTP error, use exponential back off up to 320 seconds
        if self._sensor is not None:
          self._sensor.logger.info('HTTP error %s, %s', sc, self.conn.errstr())
          self._sensor.logger.info('Waiting %s seconds', backoff_http_error)
        else:
          print 'HTTP error %s, %s' % (sc, self.conn.errstr())
          print 'Waiting %s seconds' % backoff_http_error
        time.sleep(backoff_http_error)
        backoff_http_error = min(backoff_http_error * 2, 320)



1			import pycurl, json
2			import urllib
3			import signal
4			import sys
5			import time
6
7			POST_PARAMS = {}
8
9			class Client:
10			def __init__(self, sensor, api_url, api_user, api_password):
11			if sensor is not None:
12			self._sensor = sensor
13			else:
14			self._sensor = None
15			self.conn = None
16			self.buffer = ''
17			self.keep_trying = 1
18			self.api_url = api_url
19			self.api_user = api_user
20			self.api_password = api_password
21
22			signal.signal(signal.SIGINT, self.handle_ctrl_c)
23
24			def handle_ctrl_c(self, signal, frame):
25			if self._sensor is not None:
26			sensor.logger.info('SIGINT receivied')
27			else:
28			print 'You pressed Ctrl+C!'
29			self.abort_session()
30
31			def abort_session(self):
32			self.keep_trying = 0
33			self.conn.close()
34
35			def setup_connection(self):
36
37			if self.conn:
38			self.conn.close()
39			self.buffer = ''
40			self.headers = ['Accept: application/json', 'Expect:']
41			self.conn = pycurl.Curl()
42			self.conn.setopt(pycurl.SSL_VERIFYHOST, False)
43			self.conn.setopt(pycurl.SSL_VERIFYPEER, False)
44			self.conn.setopt(pycurl.USERPWD, "%s:%s" % (self.api_user, self.api_password))
45			self.conn.setopt(pycurl.URL, self.api_url)
46			self.conn.setopt(pycurl.VERBOSE, 1)
47			self.conn.setopt(pycurl.WRITEFUNCTION, self.on_receive)
48			self.conn.setopt(pycurl.NOSIGNAL, 1)
49			self.conn.setopt(pycurl.NOPROGRESS, 0)
50			self.conn.setopt(pycurl.PROGRESSFUNCTION, self.on_progress)
51			self.conn.setopt(pycurl.HTTPHEADER, self.headers)
52			self.conn.setopt(pycurl.POST, 1)
53			self.conn.setopt(pycurl.POSTFIELDS, urllib.urlencode(POST_PARAMS))
54
55			def on_receive(self, data):
56			self.buffer += data
57			if data.endswith('\n') and self.buffer.strip():
58			# complete message received
59			event = json.loads(self.buffer)
60			self.buffer = ''
61			if self._sensor is not None:
62			self._sensor.process_event(event)
63			else:
64			print event
65
66			def on_progress(self, d_total, downloaded, u_total, uploaded):
67			pass
68			#print "on_progress called"
69
70			def __del__(self):
71			self.conn.close()
72
73			def start(self):
74			if self._sensor is not None:
75			self._sensor.logger.info('pyCurl started.')
76			backoff_network_error = 0.25
77			backoff_http_error = 5
78			backoff_rate_limit = 60
79			while True and self.keep_trying == 1:
80			if self._sensor is not None:
81			self._sensor.logger.info('keep trying = %i', self.keep_trying)
82			else:
83			print "keep trying = %i" % self.keep_trying
84			self.setup_connection()
85			try:
86			self.conn.perform()
87			except:
88			# Network error, use linear back off up to 16 seconds
89			if self.keep_trying == 0:
90			continue
91			if self._sensor is not None:
92			self._sensor.logger.info('Network error: %s', self.conn.errstr())
93			self._sensor.logger.info('Waiting %s seconds before trying again', backoff_network_error)
94			else:
95			print 'Network error: %s' % self.conn.errstr()
96			print 'Waiting %s seconds before trying again' % backoff_network_error
97			time.sleep(backoff_network_error)
98			backoff_network_error = min(backoff_network_error + 1, 16)
99			continue
100			# HTTP Error
101			sc = self.conn.getinfo(pycurl.HTTP_CODE)
102			if sc == 420:
103			# Rate limit, use exponential back off starting with 1 minute and double each attempt
104			if self._sensor is not None:
105			self._sensor.logger.info('Rate limit, waiting %s seconds', backoff_rate_limit)
106			else:
107			print 'Rate limit, waiting %s seconds' % backoff_rate_limit
108			time.sleep(backoff_rate_limit)
109			backoff_rate_limit *= 2
110			elif sc == 401:
111			# Authentication error
112			if self._sensor is not None:
113			self._sensor.logger.info('Authentication error, check user/password, waiting %s seconds', backoff_rate_limit)
114			else:
115			print 'Authentication error, check user/password, waiting %s seconds' % backoff_rate_limit
116			time.sleep(backoff_rate_limit)
117			backoff_rate_limit *= 2
118			elif sc == 404:
119			# Authorization error
120			if self._sensor is not None:
121			self._sensor.logger.info('Authorization error, check permissions, waiting %s seconds', backoff_rate_limit)
122			else:
123			print 'Authorization error, check permissions, waiting %s seconds' % backoff_rate_limit
124			time.sleep(backoff_rate_limit)
125			backoff_rate_limit *= 2
126			else:
127			# HTTP error, use exponential back off up to 320 seconds
128			if self._sensor is not None:
129			self._sensor.logger.info('HTTP error %s, %s', sc, self.conn.errstr())
130			self._sensor.logger.info('Waiting %s seconds', backoff_http_error)
131			else:
132			print 'HTTP error %s, %s' % (sc, self.conn.errstr())
133			print 'Waiting %s seconds' % backoff_http_error
134			time.sleep(backoff_http_error)
135			backoff_http_error = min(backoff_http_error * 2, 320)
136
137

StackStorm / st2contrib

Pull Request — master (#469)

Client.start() F

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like