Client.make_call() - Code Metrics - Inspection of "Icinga2 Integration pack, v0.2.0, initial commit" - StackStorm/st2contrib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#469)

unknown

created 2016-04-08 13:39 UTC

Client.make_call() D

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	51
rs	4.2352
cc	10

How to fix Long Method Complexity

import pycurl, json
from StringIO import StringIO
import urllib
import signal
import sys
import time

POST_PARAMS = {}
MAX_ATTEMPTS = 3

class Client:
  def __init__(self, action, api_url, api_user, api_password, method):
    self.conn = None
    self.action = action
    self.keep_trying = 1
    self.api_url = api_url
    self.api_user = api_user
    self.api_password = api_password
    self.method = method
    self.buffer = ''
    signal.signal(signal.SIGINT, self.handle_ctrl_c)

  def handle_ctrl_c(self, signal, frame):
    sys.stderr.write('SIGINT receivied')
    sys.stderr.write('You pressed Ctrl+C?!')
    self.abort_session()

  def abort_session(self):
    self.keep_trying = 0
    self.conn.close()

  def setup_connection(self):

    if self.conn:
      self.conn.close()
    self.headers = ['Accept: application/json', 'Expect:', 'Connection: close']
    self.conn = pycurl.Curl()
    self.conn.setopt(pycurl.SSL_VERIFYHOST, False)
    self.conn.setopt(pycurl.SSL_VERIFYPEER, False)
    self.conn.setopt(pycurl.USERPWD, "%s:%s" % (self.api_user, self.api_password))
    self.conn.setopt(pycurl.URL, self.api_url)
    self.conn.setopt(pycurl.VERBOSE, 0)
    self.conn.setopt(pycurl.WRITEFUNCTION, self.on_receive)
    self.conn.setopt(pycurl.NOSIGNAL, 1)
    self.conn.setopt(pycurl.NOPROGRESS, 1)
    self.conn.setopt(pycurl.HTTPHEADER, self.headers)
    if self.method == 'post':
      self.conn.setopt(pycurl.POST, 1)
      self.conn.setopt(pycurl.POSTFIELDS, urllib.urlencode(POST_PARAMS))
    elif self.method == 'get':
      self.conn.setopt(pycurl.POST, 0)
    
  def on_receive(self, data):
    #self.action.logger.debug('Icinga2GetStatus: client on_receive, data: %s', data)
    # complete message received
    self.buffer += data
    # sys.stderr.write(data)
    try:
      event = json.loads(self.buffer)
      update_body = True
    except:
      # no json found
      update_body = False

    if update_body:
      if self.action is not None:
        #sys.stderr.write('Updating body\n')
        self.action.set_body(event)
      else:
        print event
      

  def __del__(self):
    self.conn.close()

  def make_call(self):
    backoff_network_error = 0.25
    backoff_http_error = 1
    backoff_rate_limit = 60
    attempt = 0
    while True and self.keep_trying == 1 and attempt < MAX_ATTEMPTS:
      attempt += 1
      self.setup_connection()
      try:
        self.conn.perform()
      except:
        # Network error, use linear back off up to 16 seconds
        if self.keep_trying == 0:
          continue
        sys.stderr.write ('Network error: %s' % self.conn.errstr())
        sys.stderr.write ('Waiting %s seconds before trying again' % backoff_network_error)
        time.sleep(backoff_network_error)
        backoff_network_error = min(backoff_network_error + 1, 16)
        continue
      # HTTP Error
      sc = self.conn.getinfo(pycurl.HTTP_CODE)
      if sc == 200:
        #sys.stderr.write('HTTP request successful.')
        self.conn.close()
        break
      elif sc == 420:
        # Rate limit, use exponential back off starting with 1 minute and double each attempt
        sys.stderr.write ('Rate limit, waiting %s seconds' % backoff_rate_limit)
        time.sleep(backoff_rate_limit)
        backoff_rate_limit *= 2
      elif sc == 401:
        # Authentication error
        sys.stderr.write ('Authentication error, check user/password.')
        self.action.error = 1
        break
      elif sc == 404:
        # Authorization error
        sys.stderr.write ('Object not found, or authorization error. Verify request of check permissions.')
        self.action.error = 2
        break
      elif sc == 400:
        # Authorization error
        sys.stderr.write ('Bad request.')
        self.action.error = 3
        break
      else:
        # HTTP error, use exponential back off up to 320 seconds
        sys.stderr.write('HTTP error %s, %s' % (sc, self.conn.errstr()))
        sys.stderr.write('Waiting %s seconds' % backoff_http_error)
        time.sleep(backoff_http_error)
        backoff_http_error = min(backoff_http_error * 2, 10)




1			import pycurl, json
2			from StringIO import StringIO
3			import urllib
4			import signal
5			import sys
6			import time
7
8			POST_PARAMS = {}
9			MAX_ATTEMPTS = 3
10
11			class Client:
12			def __init__(self, action, api_url, api_user, api_password, method):
13			self.conn = None
14			self.action = action
15			self.keep_trying = 1
16			self.api_url = api_url
17			self.api_user = api_user
18			self.api_password = api_password
19			self.method = method
20			self.buffer = ''
21			signal.signal(signal.SIGINT, self.handle_ctrl_c)
22
23			def handle_ctrl_c(self, signal, frame):
24			sys.stderr.write('SIGINT receivied')
25			sys.stderr.write('You pressed Ctrl+C?!')
26			self.abort_session()
27
28			def abort_session(self):
29			self.keep_trying = 0
30			self.conn.close()
31
32			def setup_connection(self):
33
34			if self.conn:
35			self.conn.close()
36			self.headers = ['Accept: application/json', 'Expect:', 'Connection: close']
37			self.conn = pycurl.Curl()
38			self.conn.setopt(pycurl.SSL_VERIFYHOST, False)
39			self.conn.setopt(pycurl.SSL_VERIFYPEER, False)
40			self.conn.setopt(pycurl.USERPWD, "%s:%s" % (self.api_user, self.api_password))
41			self.conn.setopt(pycurl.URL, self.api_url)
42			self.conn.setopt(pycurl.VERBOSE, 0)
43			self.conn.setopt(pycurl.WRITEFUNCTION, self.on_receive)
44			self.conn.setopt(pycurl.NOSIGNAL, 1)
45			self.conn.setopt(pycurl.NOPROGRESS, 1)
46			self.conn.setopt(pycurl.HTTPHEADER, self.headers)
47			if self.method == 'post':
48			self.conn.setopt(pycurl.POST, 1)
49			self.conn.setopt(pycurl.POSTFIELDS, urllib.urlencode(POST_PARAMS))
50			elif self.method == 'get':
51			self.conn.setopt(pycurl.POST, 0)
52
53			def on_receive(self, data):
54			#self.action.logger.debug('Icinga2GetStatus: client on_receive, data: %s', data)
55			# complete message received
56			self.buffer += data
57			# sys.stderr.write(data)
58			try:
59			event = json.loads(self.buffer)
60			update_body = True
61			except:
62			# no json found
63			update_body = False
64
65			if update_body:
66			if self.action is not None:
67			#sys.stderr.write('Updating body\n')
68			self.action.set_body(event)
69			else:
70			print event
71
72
73			def __del__(self):
74			self.conn.close()
75
76			def make_call(self):
77			backoff_network_error = 0.25
78			backoff_http_error = 1
79			backoff_rate_limit = 60
80			attempt = 0
81			while True and self.keep_trying == 1 and attempt < MAX_ATTEMPTS:
82			attempt += 1
83			self.setup_connection()
84			try:
85			self.conn.perform()
86			except:
87			# Network error, use linear back off up to 16 seconds
88			if self.keep_trying == 0:
89			continue
90			sys.stderr.write ('Network error: %s' % self.conn.errstr())
91			sys.stderr.write ('Waiting %s seconds before trying again' % backoff_network_error)
92			time.sleep(backoff_network_error)
93			backoff_network_error = min(backoff_network_error + 1, 16)
94			continue
95			# HTTP Error
96			sc = self.conn.getinfo(pycurl.HTTP_CODE)
97			if sc == 200:
98			#sys.stderr.write('HTTP request successful.')
99			self.conn.close()
100			break
101			elif sc == 420:
102			# Rate limit, use exponential back off starting with 1 minute and double each attempt
103			sys.stderr.write ('Rate limit, waiting %s seconds' % backoff_rate_limit)
104			time.sleep(backoff_rate_limit)
105			backoff_rate_limit *= 2
106			elif sc == 401:
107			# Authentication error
108			sys.stderr.write ('Authentication error, check user/password.')
109			self.action.error = 1
110			break
111			elif sc == 404:
112			# Authorization error
113			sys.stderr.write ('Object not found, or authorization error. Verify request of check permissions.')
114			self.action.error = 2
115			break
116			elif sc == 400:
117			# Authorization error
118			sys.stderr.write ('Bad request.')
119			self.action.error = 3
120			break
121			else:
122			# HTTP error, use exponential back off up to 320 seconds
123			sys.stderr.write('HTTP error %s, %s' % (sc, self.conn.errstr()))
124			sys.stderr.write('Waiting %s seconds' % backoff_http_error)
125			time.sleep(backoff_http_error)
126			backoff_http_error = min(backoff_http_error * 2, 10)
127
128
129

StackStorm / st2contrib

Pull Request — master (#469)

Client.make_call() D

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like