Completed
Pull Request — master (#462)
by
unknown
02:16
created

GetVMUUID.run()   C

Complexity

Conditions 11

Size

Total Lines 17

Duplication

Lines 0
Ratio 0 %
Metric Value
cc 11
dl 0
loc 17
rs 5.5714

How to fix   Complexity   

Complexity

Complex classes like GetVMUUID.run() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

1
#!/usr/bin/env python
2
3
# Licensed to the StackStorm, Inc ('StackStorm') under one or more
4
# contributor license agreements.  See the NOTICE file distributed with
5
# this work for additional information regarding copyright ownership.
6
# The ASF licenses this file to You under the Apache License, Version 2.0
7
# (the "License"); you may not use this file except in compliance with
8
# the License.  You may obtain a copy of the License at
9
#
10
#     http://www.apache.org/licenses/LICENSE-2.0
11
#
12
# Unless required by applicable law or agreed to in writing, software
13
# distributed under the License is distributed on an "AS IS" BASIS,
14
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15
# See the License for the specific language governing permissions and
16
# limitations under the License.
17
18
from vmwarelib import inventory
19
from vmwarelib.actions import BaseAction
20
21
22
class GetVMUUID(BaseAction):
23
24
    def run(self, vm_ids, vm_names):
25
        results = []
26
        if not vm_ids and not vm_names:
27
            raise Exception("No ID nor Names provided")
28
        if vm_ids:
29
            for vm in vm_ids:
30
                vm = inventory.get_virtualmachine(self.si_content, moid=vm)
31
                if vm:
32
                    if vm.summary.config.uuid not in results:
33
                        results.append(vm.summary.config.uuid)
34
        if vm_names:
35
            for vm in vm_names:
36
                vm = inventory.get_virtualmachine(self.si_content, name=vm)
37
                if vm:
38
                    if vm.summary.config.uuid not in results:
39
                        results.append(vm.summary.config.uuid)
40
        return results
41