Auth.run() - Code Metrics - Inspection of "WIP: Add duo pack (2FA)" - StackStorm/st2contrib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#442)

unknown

created 2016-03-14 17:44 UTC

Auth.run() D

↳ Parent: Auth

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	11
dl	0
loc	58
rs	4.2857

How to fix Long Method Complexity

#!/usr/bin/env python

# Licensed to the StackStorm, Inc ('StackStorm') under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import urllib

from st2actions.runners.pythonrunner import Action
from lib.actions import AuthAction


class Auth(AuthAction):
    def run(self, username, factor,
            ipaddr, device, push_type, passcode, pushinfo):
        """
        Auth against the Duo Platorm.

        Returns: An dict with info returned by Duo.

        Raises:
          ValueError: 'Duo config not found in config' or 'Invalid factor'
          RuntimeError: 'Failed auth.'
        """

        auth_kargs = {}

        if factor == "auto" or factor == "push":
            auth_kargs['type'] = push_type
            auth_kargs['device'] = device

            if ipaddr is not None:
                auth_kargs['ipaddr'] = ipaddr

            if pushinfo is not None:
                info = {}
                for value in pushinfo.split('; '):
                    (key, value) = value.split('=')
                    info[key] = value

                encoded = urllib.urlencode(info)
                auth_kargs['pushinfo'] = encoded
        elif factor == "passcode":
            auth_kargs['passcode'] = passcode
        elif factor == "phone":
            auth_kargs['device'] = device
        elif factor == "sms":
            # As 'sms' just denies and then we do not support it
            # requires re-authentication.

            print "Denied, we do not support SMS!"
            raise ValueError("Denied, we do not support SMS!")
        else:
            raise ValueError("Invalid factor!")

        try:
            data = self.duo_auth.auth(factor=factor,
                                      username=username,
                                      **auth_kargs)
        except RuntimeError, e:
            print "Error: %s" % e
            raise RuntimeError("Error: %s" % e)
        else:
            if data['result'] == "allow":
                return data
            elif data['result'] == "deny":
                print data['status_msg']
                raise RuntimeError("{}".format(
                    data['status_msg']))
            else:
                raise RuntimeError("Invalid status")


1			#!/usr/bin/env python
2
3			# Licensed to the StackStorm, Inc ('StackStorm') under one or more
4			# contributor license agreements. See the NOTICE file distributed with
5			# this work for additional information regarding copyright ownership.
6			# The ASF licenses this file to You under the Apache License, Version 2.0
7			# (the "License"); you may not use this file except in compliance with
8			# the License. You may obtain a copy of the License at
9			#
10			# http://www.apache.org/licenses/LICENSE-2.0
11			#
12			# Unless required by applicable law or agreed to in writing, software
13			# distributed under the License is distributed on an "AS IS" BASIS,
14			# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			# See the License for the specific language governing permissions and
16			# limitations under the License.
17
18			import urllib
19
20			from st2actions.runners.pythonrunner import Action
21			from lib.actions import AuthAction
22
23
24			class Auth(AuthAction):
25			def run(self, username, factor,
26			ipaddr, device, push_type, passcode, pushinfo):
27			"""
28			Auth against the Duo Platorm.
29
30			Returns: An dict with info returned by Duo.
31
32			Raises:
33			ValueError: 'Duo config not found in config' or 'Invalid factor'
34			RuntimeError: 'Failed auth.'
35			"""
36
37			auth_kargs = {}
38
39			if factor == "auto" or factor == "push":
40			auth_kargs['type'] = push_type
41			auth_kargs['device'] = device
42
43			if ipaddr is not None:
44			auth_kargs['ipaddr'] = ipaddr
45
46			if pushinfo is not None:
47			info = {}
48			for value in pushinfo.split('; '):
49			(key, value) = value.split('=')
50			info[key] = value
51
52			encoded = urllib.urlencode(info)
53			auth_kargs['pushinfo'] = encoded
54			elif factor == "passcode":
55			auth_kargs['passcode'] = passcode
56			elif factor == "phone":
57			auth_kargs['device'] = device
58			elif factor == "sms":
59			# As 'sms' just denies and then we do not support it
60			# requires re-authentication.
61
62			print "Denied, we do not support SMS!"
63			raise ValueError("Denied, we do not support SMS!")
64			else:
65			raise ValueError("Invalid factor!")
66
67			try:
68			data = self.duo_auth.auth(factor=factor,
69			username=username,
70			**auth_kargs)
71			except RuntimeError, e:
72			print "Error: %s" % e
73			raise RuntimeError("Error: %s" % e)
74			else:
75			if data['result'] == "allow":
76			return data
77			elif data['result'] == "deny":
78			print data['status_msg']
79			raise RuntimeError("{}".format(
80			data['status_msg']))
81			else:
82			raise RuntimeError("Invalid status")
83

StackStorm / st2contrib

Pull Request — master (#442)

Auth.run() D

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like