VMCreateBareBones.run() - Code Metrics - Inspection of "Vsphere barebones atomic actions" - StackStorm/st2contrib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#462)

unknown

created 2016-04-04 14:47 UTC

VMCreateBareBones.run() B

↳ Parent: VMCreateBareBones

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	5
dl	0
loc	82
rs	7.9885

How to fix Long Method

#!/usr/bin/env python

# Licensed to the StackStorm, Inc ('StackStorm') under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from pyVmomi import vim

from vmwarelib import inventory
from vmwarelib import checkinputs
from vmwarelib.actions import BaseAction


class VMCreateBareBones(BaseAction):
    def run(self, vm_name, cluster, datastore_cluster,
            datastore, resourcepool, cpu_size, ram_size,
            guestos, version, description):
        # Setup Identifiers for objects
        si = self.si
        si_content = si.RetrieveContent()
        #checkinputs.vm_storage(datastore_cluster, datastore)
        checkinputs.one_of_two_strings(datastore_cluster,
                                       datastore,
                                       "Datastore Cluster or Datastore")

        data_center = self.si_content.rootFolder.childEntity[0]
        cluster = inventory.get_cluster(self.si_content, name=cluster)
        data_store_cluster = inventory.get_datastore_cluster(
            self.si_content,
            name=datastore_cluster)
        #data_store = inventory.get_datastore(self.si_content, name=datastore)
        target_folder = data_center.vmFolder

        # If No Resource Pool issued the Default one for
        # the Cluster will be selected.
        if resourcepool:
            resource_pool = inventory.get_resource_pool(self.si_content,
                                                        name=resourcepool)
        else:
            resource_pool = cluster.resourcePool

        # Config created that is required for DS selection
        # Config is BareBones, CPU RAM no more.
        config = vim.vm.ConfigSpec(name=vm_name,
                                   memoryMB=(ram_size * 1024),
                                   numCPUs=cpu_size,
                                   guestId=guestos,
                                   version=version,
                                   cpuHotAddEnabled=True,
                                   memoryHotAddEnabled=True,
                                   annotation=description)

        # if Datastore cluster is provided it will find the
        # recommended Datastore to store VM files
        if datastore_cluster:
            podsel = vim.storageDrs.PodSelectionSpec()
            podsel.storagePod = data_store_cluster

            storage_spec = vim.storageDrs.StoragePlacementSpec(
                type='create',
                configSpec=config,
                resourcePool=resource_pool,
                podSelectionSpec=podsel,
                folder=target_folder)

            # Create Instance of Storage Resource Manager -
            # This is used to identify a Recommended Datastore from a Cluster
            srm = si_content.storageResourceManager
            results = srm.RecommendDatastores(storageSpec=storage_spec)
            rec_ds = results.recommendations[0].action[0]\
                .relocateSpec.datastore
            datastore_path = '[' + rec_ds.name + '] ' + vm_name
        else:
            # No Datastore Cluster has been offered so using the D
            if datastore:
                #data_store = inventory.get_datastore(self.si_content,
                                                     #name=datastore)
                datastore_path = '[' + datastore + '] ' + vm_name
            else:
                raise Exception('Error No Storage Data Provided')

        #Now Datastore is known the remaining
        #of VM Config can be setup and added
        vmx_file = vim.vm.FileInfo(logDirectory=None,
                                   snapshotDirectory=None,
                                   suspendDirectory=None,
                                   vmPathName=datastore_path)
        config.files = vmx_file

        #Create task to Build actual Machine
        task = target_folder.CreateVM_Task(config=config, pool=resource_pool)
        self._wait_for_task(task)
        if task.info.state != vim.TaskInfo.State.success:
            raise Exception(task.info.error.msg)

        return {'vm_id': task.info.result._moId}


1			#!/usr/bin/env python
2
3			# Licensed to the StackStorm, Inc ('StackStorm') under one or more
4			# contributor license agreements. See the NOTICE file distributed with
5			# this work for additional information regarding copyright ownership.
6			# The ASF licenses this file to You under the Apache License, Version 2.0
7			# (the "License"); you may not use this file except in compliance with
8			# the License. You may obtain a copy of the License at
9			#
10			# http://www.apache.org/licenses/LICENSE-2.0
11			#
12			# Unless required by applicable law or agreed to in writing, software
13			# distributed under the License is distributed on an "AS IS" BASIS,
14			# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			# See the License for the specific language governing permissions and
16			# limitations under the License.
17
18			from pyVmomi import vim
19
20			from vmwarelib import inventory
21			from vmwarelib import checkinputs
22			from vmwarelib.actions import BaseAction
23
24
25			class VMCreateBareBones(BaseAction):
26			def run(self, vm_name, cluster, datastore_cluster,
27			datastore, resourcepool, cpu_size, ram_size,
28			guestos, version, description):
29			# Setup Identifiers for objects
30			si = self.si
31			si_content = si.RetrieveContent()
32			#checkinputs.vm_storage(datastore_cluster, datastore)
33			checkinputs.one_of_two_strings(datastore_cluster,
34			datastore,
35			"Datastore Cluster or Datastore")
36
37			data_center = self.si_content.rootFolder.childEntity[0]
38			cluster = inventory.get_cluster(self.si_content, name=cluster)
39			data_store_cluster = inventory.get_datastore_cluster(
40			self.si_content,
41			name=datastore_cluster)
42			#data_store = inventory.get_datastore(self.si_content, name=datastore)
43			target_folder = data_center.vmFolder
44
45			# If No Resource Pool issued the Default one for
46			# the Cluster will be selected.
47			if resourcepool:
48			resource_pool = inventory.get_resource_pool(self.si_content,
49			name=resourcepool)
50			else:
51			resource_pool = cluster.resourcePool
52
53			# Config created that is required for DS selection
54			# Config is BareBones, CPU RAM no more.
55			config = vim.vm.ConfigSpec(name=vm_name,
56			memoryMB=(ram_size * 1024),
57			numCPUs=cpu_size,
58			guestId=guestos,
59			version=version,
60			cpuHotAddEnabled=True,
61			memoryHotAddEnabled=True,
62			annotation=description)
63
64			# if Datastore cluster is provided it will find the
65			# recommended Datastore to store VM files
66			if datastore_cluster:
67			podsel = vim.storageDrs.PodSelectionSpec()
68			podsel.storagePod = data_store_cluster
69
70			storage_spec = vim.storageDrs.StoragePlacementSpec(
71			type='create',
72			configSpec=config,
73			resourcePool=resource_pool,
74			podSelectionSpec=podsel,
75			folder=target_folder)
76
77			# Create Instance of Storage Resource Manager -
78			# This is used to identify a Recommended Datastore from a Cluster
79			srm = si_content.storageResourceManager
80			results = srm.RecommendDatastores(storageSpec=storage_spec)
81			rec_ds = results.recommendations[0].action[0]\
82			.relocateSpec.datastore
83			datastore_path = '[' + rec_ds.name + '] ' + vm_name
84			else:
85			# No Datastore Cluster has been offered so using the D
86			if datastore:
87			#data_store = inventory.get_datastore(self.si_content,
88			#name=datastore)
89			datastore_path = '[' + datastore + '] ' + vm_name
90			else:
91			raise Exception('Error No Storage Data Provided')
92
93			#Now Datastore is known the remaining
94			#of VM Config can be setup and added
95			vmx_file = vim.vm.FileInfo(logDirectory=None,
96			snapshotDirectory=None,
97			suspendDirectory=None,
98			vmPathName=datastore_path)
99			config.files = vmx_file
100
101			#Create task to Build actual Machine
102			task = target_folder.CreateVM_Task(config=config, pool=resource_pool)
103			self._wait_for_task(task)
104			if task.info.state != vim.TaskInfo.State.success:
105			raise Exception(task.info.error.msg)
106
107			return {'vm_id': task.info.result._moId}
108

StackStorm / st2contrib

Pull Request — master (#462)

VMCreateBareBones.run() B

Complexity

Size

Duplication

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like