Auth.run() - Code Metrics - Inspection of "Add duo pack (2FA)" - StackStorm/st2contrib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#442)

unknown

created 2016-03-14 18:35 UTC

Auth.run() D

↳ Parent: Auth

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	11
dl	0
loc	56
rs	4.4262

How to fix Long Method Complexity

#!/usr/bin/env python

# Licensed to the StackStorm, Inc ('StackStorm') under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import urllib

from lib.actions import AuthAction


class Auth(AuthAction):
    def run(self, username, factor,
            ipaddr, device, push_type, passcode, pushinfo):
        """
        Auth against the Duo Platorm.

        Returns: An dict with info returned by Duo.

        Raises:
          ValueError: 'Duo config not found in config' or 'Invalid factor'
          RuntimeError: 'Failed auth.'
        """

        auth_kargs = {}

        if factor == "auto" or factor == "push":
            auth_kargs['type'] = push_type
            auth_kargs['device'] = device

            if ipaddr is not None:
                auth_kargs['ipaddr'] = ipaddr

            if pushinfo is not None:
                info = {}
                for value in pushinfo.split('; '):
                    (key, value) = value.split('=')
                    info[key] = value

                encoded = urllib.urlencode(info)
                auth_kargs['pushinfo'] = encoded
        elif factor == "passcode":
            auth_kargs['passcode'] = passcode
        elif factor == "phone":
            auth_kargs['device'] = device
        elif factor == "sms":
            # As 'sms' just denies and then we do not support it
            # requires re-authentication.

            raise ValueError("Denied, we do not support SMS!")
        else:
            raise ValueError("Invalid factor!")

        try:
            data = self.duo_auth.auth(factor=factor,
                                      username=username,
                                      **auth_kargs)
        except RuntimeError, e:
            raise RuntimeError("Error: %s" % e)
        else:
            if data['result'] == "allow":
                return data
            elif data['result'] == "deny":
                self.send_user_error(data['status_msg'])
                raise RuntimeError("{}".format(
                    data['status_msg']))
            else:
                raise RuntimeError("Invalid status")


1			#!/usr/bin/env python
2
3			# Licensed to the StackStorm, Inc ('StackStorm') under one or more
4			# contributor license agreements. See the NOTICE file distributed with
5			# this work for additional information regarding copyright ownership.
6			# The ASF licenses this file to You under the Apache License, Version 2.0
7			# (the "License"); you may not use this file except in compliance with
8			# the License. You may obtain a copy of the License at
9			#
10			# http://www.apache.org/licenses/LICENSE-2.0
11			#
12			# Unless required by applicable law or agreed to in writing, software
13			# distributed under the License is distributed on an "AS IS" BASIS,
14			# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15			# See the License for the specific language governing permissions and
16			# limitations under the License.
17
18			import urllib
19
20			from lib.actions import AuthAction
21
22
23			class Auth(AuthAction):
24			def run(self, username, factor,
25			ipaddr, device, push_type, passcode, pushinfo):
26			"""
27			Auth against the Duo Platorm.
28
29			Returns: An dict with info returned by Duo.
30
31			Raises:
32			ValueError: 'Duo config not found in config' or 'Invalid factor'
33			RuntimeError: 'Failed auth.'
34			"""
35
36			auth_kargs = {}
37
38			if factor == "auto" or factor == "push":
39			auth_kargs['type'] = push_type
40			auth_kargs['device'] = device
41
42			if ipaddr is not None:
43			auth_kargs['ipaddr'] = ipaddr
44
45			if pushinfo is not None:
46			info = {}
47			for value in pushinfo.split('; '):
48			(key, value) = value.split('=')
49			info[key] = value
50
51			encoded = urllib.urlencode(info)
52			auth_kargs['pushinfo'] = encoded
53			elif factor == "passcode":
54			auth_kargs['passcode'] = passcode
55			elif factor == "phone":
56			auth_kargs['device'] = device
57			elif factor == "sms":
58			# As 'sms' just denies and then we do not support it
59			# requires re-authentication.
60
61			raise ValueError("Denied, we do not support SMS!")
62			else:
63			raise ValueError("Invalid factor!")
64
65			try:
66			data = self.duo_auth.auth(factor=factor,
67			username=username,
68			**auth_kargs)
69			except RuntimeError, e:
70			raise RuntimeError("Error: %s" % e)
71			else:
72			if data['result'] == "allow":
73			return data
74			elif data['result'] == "deny":
75			self.send_user_error(data['status_msg'])
76			raise RuntimeError("{}".format(
77			data['status_msg']))
78			else:
79			raise RuntimeError("Invalid status")
80

StackStorm / st2contrib

Pull Request — master (#442)

Auth.run() D

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like